March 2020 - Sound-open-firmware - mailman.alsa-project.org

Re: [Sound-open-firmware] [PATCH 2/5] ASoC: SOF: imx: fix undefined reference issue
by Daniel Baluta 31 Mar '20

31 Mar '20

On Tue, Mar 31, 2020 at 3:25 PM Mark Brown <broonie(a)kernel.org> wrote: > > On Thu, Mar 19, 2020 at 09:49:54PM +0200, Daniel Baluta wrote: > > From: Daniel Baluta <daniel.baluta(a)nxp.com> > > > Fixes: f9ad75468453 ("ASoC: SOF: imx: fix reverse CONFIG_SND_SOC_SOF_OF > > dependency") > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> > > Signed-off-by: Daniel Baluta <daniel.baluta(a)nxp.com> > > This has you as the author but you list a signoff by Pierre before you? Patch was initially designed by Pierre [1] when in the internal SOF tree we already had the I.MX8M patches. Whereas, in the current patch series I firstly fix the i.MX8 then I add support for i.MX8M. Should I go back and put Pierre as original author? [1] https://github.com/thesofproject/linux/commit/0c7dcfee80d96a8e75684178ab738…

1 0

[Sound-open-firmware] [PATCH 0/5] Add support for SOF on i.MX8M
by Daniel Baluta 30 Mar '20

30 Mar '20

From: Daniel Baluta <daniel.baluta(a)nxp.com> This patch series adds support for SOF on i.MX8M family. First board from this family that has a DSP is i.MX8MP. First 2 patches are trying to fix some compilation issues, the next two are adding the imx8m support and the last one adds the devicetree binding. Daniel Baluta (4): ASoC: SOF: imx: fix undefined reference issue ASoC: SOF: imx: Add i.MX8M HW support ASoC: SOF: Add i.MX8MP device descriptor dt-bindings: dsp: fsl: Add fsl,imx8mp-dsp entry YueHaibing (1): ASoC: SOF: imx8: Fix randbuild error .../devicetree/bindings/dsp/fsl,dsp.yaml | 2 + sound/soc/sof/imx/Kconfig | 32 +- sound/soc/sof/imx/Makefile | 2 + sound/soc/sof/imx/imx8m.c | 279 ++++++++++++++++++ sound/soc/sof/sof-of-dev.c | 14 + 5 files changed, 325 insertions(+), 4 deletions(-) create mode 100644 sound/soc/sof/imx/imx8m.c -- 2.17.1

2 6

Re: [Sound-open-firmware] [PATCH 0/2] ASoC: SOF: initialise work immediately
by Guennadi Liakhovetski 25 Mar '20

25 Mar '20

On Tue, Mar 24, 2020 at 02:48:22PM +0000, Mark Brown wrote: > On Tue, Mar 24, 2020 at 02:58:56PM +0100, Guennadi Liakhovetski wrote: > > On Tue, Mar 24, 2020 at 01:30:42PM +0000, Mark Brown wrote: > > > > As documented in submitting-patches.rst please send patches to the > > > maintainers for the code you would like to change. The normal kernel > > > workflow is that people apply patches from their inboxes, if they aren't > > > copied they are likely to not see the patch at all and it is much more > > > difficult to apply patches. > > > I know that different maintainers have different preferences. For example > > in the subsysteem, where I'd worked for about 10 years the maintainer > > preferred not to be CCed on patches, he preferred to pick up patches from > > his mailing list folders, or whatever arrangement his mail filters > > provided for. I learned already that in ALSA / ASoC it's usual to CC > > maintainers. But I wasn't sure whether that also holds for larger patch > > series. E.g. my main patch series now consists of 14 patches, so, I > > thought, that maybe you would rather not receive multiple copies of the > > entire seriees for each new version both directly in your inbox and in > > the mailing list folder. Or is it indeed your preference to always be > > CCed on all patches? I apologise for re-iterating a question, that > > probably had been addressed multiple times before, maybe it's worth > > documenting this somewhere on ALSA web? > > Yes, copy me on patches. This is, as covered in what I wrote above, the > standard and documented approach for the kernel - unless you explicitly > know that there is some unusual approach for a specific subsystem you > should assume that if you want people to see your patches you need to > send the patches to them. Got it, thanks!

1 0

Re: [Sound-open-firmware] [PATCH 0/2] ASoC: SOF: initialise work immediately
by Guennadi Liakhovetski 25 Mar '20

25 Mar '20

Hi Mark, On Tue, Mar 24, 2020 at 01:30:42PM +0000, Mark Brown wrote: > On Tue, Mar 24, 2020 at 01:29:19PM +0100, Guennadi Liakhovetski wrote: > > Fix uninitialised work errors by moving initialisation to directly > > after allocation. > > > > Guennadi Liakhovetski (2): > > ASoC: SOF: (cosmetic) use for_each_pcm_streams() in sof_dai_load() > > ASoC: SOF: fix uninitialised "work" with VirtIO > > As documented in submitting-patches.rst please send patches to the > maintainers for the code you would like to change. The normal kernel > workflow is that people apply patches from their inboxes, if they aren't > copied they are likely to not see the patch at all and it is much more > difficult to apply patches. An update: these patches got merged into the SOF tree, so, no need to merge them to ASoC directly. Thanks Guennadi

1 0

[Sound-open-firmware] [PATCH 0/2] ASoC: SOF: initialise work immediately
by Guennadi Liakhovetski 24 Mar '20

24 Mar '20

Fix uninitialised work errors by moving initialisation to directly after allocation. Guennadi Liakhovetski (2): ASoC: SOF: (cosmetic) use for_each_pcm_streams() in sof_dai_load() ASoC: SOF: fix uninitialised "work" with VirtIO sound/soc/sof/pcm.c | 4 +--- sound/soc/sof/sof-audio.h | 3 +++ sound/soc/sof/topology.c | 17 ++++++++++++----- 3 files changed, 16 insertions(+), 8 deletions(-) -- 1.9.3

2 4

Re: [Sound-open-firmware] [PATCH 0/2] ASoC: SOF: initialise work immediately
by Guennadi Liakhovetski 24 Mar '20

24 Mar '20

Hi Mark, On Tue, Mar 24, 2020 at 01:30:42PM +0000, Mark Brown wrote: > On Tue, Mar 24, 2020 at 01:29:19PM +0100, Guennadi Liakhovetski wrote: > > Fix uninitialised work errors by moving initialisation to directly > > after allocation. > > > > Guennadi Liakhovetski (2): > > ASoC: SOF: (cosmetic) use for_each_pcm_streams() in sof_dai_load() > > ASoC: SOF: fix uninitialised "work" with VirtIO > > As documented in submitting-patches.rst please send patches to the > maintainers for the code you would like to change. The normal kernel > workflow is that people apply patches from their inboxes, if they aren't > copied they are likely to not see the patch at all and it is much more > difficult to apply patches. I know that different maintainers have different preferences. For example in the subsysteem, where I'd worked for about 10 years the maintainer preferred not to be CCed on patches, he preferred to pick up patches from his mailing list folders, or whatever arrangement his mail filters provided for. I learned already that in ALSA / ASoC it's usual to CC maintainers. But I wasn't sure whether that also holds for larger patch series. E.g. my main patch series now consists of 14 patches, so, I thought, that maybe you would rather not receive multiple copies of the entire seriees for each new version both directly in your inbox and in the mailing list folder. Or is it indeed your preference to always be CCed on all patches? I apologise for re-iterating a question, that probably had been addressed multiple times before, maybe it's worth documenting this somewhere on ALSA web? Thanks Guennadi

1 0

[Sound-open-firmware] [PATCH] ASoC: SOF: fix uninitialised "work" with VirtIO
by Guennadi Liakhovetski 23 Mar '20

23 Mar '20

In the VirtIO case the sof_pcm_open() function isn't called on the host during guest streaming, which then leaves "work" structures uninitialised. However it is then used to handle position update messages from the DSP. Move their initialisation to immediately after allocation of the containing structure. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski(a)linux.intel.com> --- This is a re-send of "[PATCH 08/14] ASoC: SOF: fix uninitialised "work" with VirtIO" as suggested by Mark, also taking into account a comment from Ranjani - thanks. Note: I haven't sent patches before from mutt, hope this will work, if not - will have to re-send. sound/soc/sof/pcm.c | 4 +--- sound/soc/sof/sof-audio.h | 3 +++ sound/soc/sof/topology.c | 17 ++++++++++++----- 3 files changed, 16 insertions(+), 8 deletions(-) diff --git a/sound/soc/sof/pcm.c b/sound/soc/sof/pcm.c index f4769e1..47cd741 100644 --- a/sound/soc/sof/pcm.c +++ b/sound/soc/sof/pcm.c @@ -57,7 +57,7 @@ static int sof_pcm_dsp_params(struct snd_sof_pcm *spcm, struct snd_pcm_substream /* * sof pcm period elapse work */ -static void sof_pcm_period_elapsed_work(struct work_struct *work) +void snd_sof_pcm_period_elapsed_work(struct work_struct *work) { struct snd_sof_pcm_stream *sps = container_of(work, struct snd_sof_pcm_stream, @@ -475,8 +475,6 @@ static int sof_pcm_open(struct snd_soc_component *component, dev_dbg(component->dev, "pcm: open stream %d dir %d\n", spcm->pcm.pcm_id, substream->stream); - INIT_WORK(&spcm->stream[substream->stream].period_elapsed_work, - sof_pcm_period_elapsed_work); caps = &spcm->pcm.caps[substream->stream]; diff --git a/sound/soc/sof/sof-audio.h b/sound/soc/sof/sof-audio.h index eacd10e..bf65f31a 100644 --- a/sound/soc/sof/sof-audio.h +++ b/sound/soc/sof/sof-audio.h @@ -11,6 +11,8 @@ #ifndef __SOUND_SOC_SOF_AUDIO_H #define __SOUND_SOC_SOF_AUDIO_H +#include <linux/workqueue.h> + #include <sound/soc.h> #include <sound/control.h> #include <sound/sof/stream.h> /* needs to be included before control.h */ @@ -189,6 +191,7 @@ struct snd_sof_pcm *snd_sof_find_spcm_comp(struct snd_soc_component *scomp, struct snd_sof_pcm *snd_sof_find_spcm_pcm_id(struct snd_soc_component *scomp, unsigned int pcm_id); void snd_sof_pcm_period_elapsed(struct snd_pcm_substream *substream); +void snd_sof_pcm_period_elapsed_work(struct work_struct *work); /* * Mixer IPC diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c index 058de94..fe8ba3e 100644 --- a/sound/soc/sof/topology.c +++ b/sound/soc/sof/topology.c @@ -9,6 +9,7 @@ // #include <linux/firmware.h> +#include <linux/workqueue.h> #include <sound/tlv.h> #include <sound/pcm_params.h> #include <uapi/sound/sof/tokens.h> @@ -2448,7 +2449,7 @@ static int sof_dai_load(struct snd_soc_component *scomp, int index, struct snd_soc_tplg_stream_caps *caps; struct snd_soc_tplg_private *private = &pcm->priv; struct snd_sof_pcm *spcm; - int stream = SNDRV_PCM_STREAM_PLAYBACK; + int stream; int ret = 0; /* nothing to do for BEs atm */ @@ -2460,8 +2461,12 @@ static int sof_dai_load(struct snd_soc_component *scomp, int index, return -ENOMEM; spcm->scomp = scomp; - spcm->stream[SNDRV_PCM_STREAM_PLAYBACK].comp_id = COMP_ID_UNASSIGNED; - spcm->stream[SNDRV_PCM_STREAM_CAPTURE].comp_id = COMP_ID_UNASSIGNED; + + for_each_pcm_streams(stream) { + spcm->stream[stream].comp_id = COMP_ID_UNASSIGNED; + INIT_WORK(&spcm->stream[stream].period_elapsed_work, + snd_sof_pcm_period_elapsed_work); + } spcm->pcm = *pcm; dev_dbg(scomp->dev, "tplg: load pcm %s\n", pcm->dai_name); @@ -2482,8 +2487,10 @@ static int sof_dai_load(struct snd_soc_component *scomp, int index, if (!spcm->pcm.playback) goto capture; + stream = SNDRV_PCM_STREAM_PLAYBACK; + dev_vdbg(scomp->dev, "tplg: pcm %s stream tokens: playback d0i3:%d\n", - spcm->pcm.pcm_name, spcm->stream[0].d0i3_compatible); + spcm->pcm.pcm_name, spcm->stream[stream].d0i3_compatible); caps = &spcm->pcm.caps[stream]; @@ -2513,7 +2520,7 @@ static int sof_dai_load(struct snd_soc_component *scomp, int index, return ret; dev_vdbg(scomp->dev, "tplg: pcm %s stream tokens: capture d0i3:%d\n", - spcm->pcm.pcm_name, spcm->stream[1].d0i3_compatible); + spcm->pcm.pcm_name, spcm->stream[stream].d0i3_compatible); caps = &spcm->pcm.caps[stream]; -- 1.9.3

2 3

[Sound-open-firmware] Static pipeline and dsp only use case
by Daniel Baluta 23 Mar '20

23 Mar '20

Hi Liam, We have now basic support for our i.MX8 boards in Qemu. Do you know if we can continue development/testing having only the DSP side? So far none of the i.MX8 have qemu support. Looking at src/schedule/task.c I noticed that we can create a static pipeline but how do we trigger processing? Our goal for qemu right now is to complete the DSP part and validate some processing algorithms. Thanks for your help!

3 2

Re: [Sound-open-firmware] [PATCH 06/14] ASoC: SOF: add a power status IPC
by Guennadi Liakhovetski 23 Mar '20

23 Mar '20

On Fri, Mar 20, 2020 at 04:39:48PM +0000, Mark Brown wrote: > On Fri, Mar 20, 2020 at 04:07:27PM +0100, Guennadi Liakhovetski wrote: > > On Fri, Mar 20, 2020 at 02:27:32PM +0100, Guennadi Liakhovetski wrote: > > > > No, this isn't a completion - it's a counter. I've used atomic variables > > > before, I cannot remember seeing any difficulties with their correct use > > > described. Do you have a pointer? > > > Actually I'd even say this isn't a problem. I think it's safe to say, you > > won't suspend and resume your audio interface more often than every 10 > > seconds. That makes under 3200000 cycles per year. Even with 31 bits for a > > signed integer that makes more than 600 years. I think we're safe. > > The problem is that atomics are just incredibly error prone - for > example they're just a plain number, they're usually counting something > which is not being locked so you have to be careful any time you do > anything around them. Their lack of structure makes them harder to > reason about than most other locking primitives, often harder than it's > worth. Ok, understand, but do you see any problems with this specific use case? Thinking about possible replacements - it isn't a case for a ref-count, because it isn't a get-put scenario. We really just need to count a specific event - DSP reboots. It can be the case that this counter doesn't need to be atomic at all. When it is read, the DSP is guaranteed to be up and running - I think. So no race would be possible. I can try to think about this more carefully and maybe make it a normal unprotected counter. But I don't think it has to be protected even better than what these patches are doing. Thanks Guennadi

1 0

[Sound-open-firmware] [PATCH 00/12] ASoC: SOF DSP virtualisation
by Guennadi Liakhovetski 20 Mar '20

20 Mar '20

This patch series extends the SOF driver to add support for DSP virtualisation to ASoC. It is built on top of VirtIO, contains a guest driver and a vhost in-kernel guest driver. This version supports a single playback and a single capture interface on the guest. The specific guest audio topology is supplied by the host from a file, specified on the QEMU command line. This solution is designed to use advanced DSP functionality, available on the host. In case no DSP is available on the host, a fall-back should be provided in the future to the pure audio virtualisation standard, currently developed by OASIS. Extensive documentation is available at [1]. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski at linux.intel.com> v2: one patch merged, one patch resubmitted separately, otherwise no changes. [1] https://thesofproject.github.io/latest/developer_guides/virtualization/virt… Guennadi Liakhovetski (12): ASoC: add function parameters to enable forced path pruning ASoC: SOF: extract firmware-related operation into a function ASoC: SOF: VirtIO: make a function global vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl ASoC: SOF: support IPC with immediate response ASoC: SOF: add a power status IPC ASoC: SOF: add two helper lookup functions ASoC: SOF: add a VirtIO DSP driver ASoC: SOF: add a vhost driver: sound part vhost: add an SOF DSP driver ASoC: SOF: VirtIO: free guest pipelines upon termination ASoC: SOF: VirtIO: enable simultaneous playback and capture drivers/vhost/Kconfig | 7 + drivers/vhost/Makefile | 5 + drivers/vhost/dsp.c | 731 ++++++++++++++++++++++ include/sound/soc-dpcm.h | 28 +- include/sound/soc-topology.h | 3 + include/sound/sof.h | 4 + include/sound/sof/header.h | 3 + include/sound/sof/topology.h | 1 + include/sound/sof/virtio.h | 206 +++++++ include/uapi/linux/vhost.h | 9 +- include/uapi/linux/vhost_types.h | 7 + include/uapi/linux/virtio_ids.h | 1 + sound/soc/soc-compress.c | 2 +- sound/soc/soc-dapm.c | 8 +- sound/soc/soc-pcm.c | 98 ++- sound/soc/sof/Kconfig | 8 + sound/soc/sof/Makefile | 8 + sound/soc/sof/core.c | 114 ++-- sound/soc/sof/ipc.c | 39 +- sound/soc/sof/loader.c | 4 + sound/soc/sof/ops.h | 10 +- sound/soc/sof/pcm.c | 15 +- sound/soc/sof/pm.c | 4 + sound/soc/sof/sof-audio.c | 33 + sound/soc/sof/sof-audio.h | 21 + sound/soc/sof/sof-priv.h | 54 ++ sound/soc/sof/topology.c | 71 ++- sound/soc/sof/vhost-be.c | 1248 ++++++++++++++++++++++++++++++++++++++ sound/soc/sof/virtio-fe.c | 922 ++++++++++++++++++++++++++++ 29 files changed, 3555 insertions(+), 109 deletions(-) create mode 100644 drivers/vhost/dsp.c create mode 100644 include/sound/sof/virtio.h create mode 100644 sound/soc/sof/vhost-be.c create mode 100644 sound/soc/sof/virtio-fe.c -- 1.9.3

1 12