September 2017 - Sound-open-firmware - mailman.alsa-project.org

[Sound-open-firmware] [PATCH] SRC: Fix use of int and uint types and remove unused function parameters
by Seppo Ingalsuo 29 Sep '17

29 Sep '17

This patch fixes the warning messages shown with gcc option -Wextra. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo(a)linux.intel.com> --- src/audio/src.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/audio/src.c b/src/audio/src.c index 3fd9614..3723b4e 100644 --- a/src/audio/src.c +++ b/src/audio/src.c @@ -65,8 +65,7 @@ struct comp_data { void (*src_func)(struct comp_dev *dev, struct comp_buffer *source, struct comp_buffer *sink, - uint32_t source_frames, - uint32_t sink_frames); + int source_frames); }; /* Common mute function for 2s and 1s SRC. This preserves the same @@ -113,8 +112,7 @@ static void src_muted_s32(struct comp_buffer *source, struct comp_buffer *sink, static void fallback_s32(struct comp_dev *dev, struct comp_buffer *source, struct comp_buffer *sink, - uint32_t source_frames, - uint32_t sink_frames) + int source_frames) { struct comp_data *cd = comp_get_drvdata(dev); @@ -129,7 +127,7 @@ static void fallback_s32(struct comp_dev *dev, /* Normal 2 stage SRC */ static void src_2s_s32_default(struct comp_dev *dev, struct comp_buffer *source, struct comp_buffer *sink, - uint32_t source_frames, uint32_t sink_frames) + int source_frames) { int i; int j; @@ -203,7 +201,7 @@ static void src_2s_s32_default(struct comp_dev *dev, /* 1 stage SRC for simple conversions */ static void src_1s_s32_default(struct comp_dev *dev, struct comp_buffer *source, struct comp_buffer *sink, - uint32_t source_frames, uint32_t sink_frames) + int source_frames) { int i; int j; @@ -440,7 +438,7 @@ static int src_params(struct comp_dev *dev) * be too long. */ q = need.blk_out / dev->frames; - if (q * dev->frames < need.blk_out) + if (q * (int)dev->frames < need.blk_out) ++q; if (q * dev->frames < need.blk_out + dev->frames) @@ -543,9 +541,9 @@ static int src_copy(struct comp_dev *dev) need_sink = blk_out * dev->frame_bytes; /* Run as many times as buffers allow */ - while ((source->avail >= need_source) && (sink->free >= need_sink)) { + while (((int)source->avail >= need_source) && ((int)sink->free >= need_sink)) { /* Run src */ - cd->src_func(dev, source, sink, blk_in, blk_out); + cd->src_func(dev, source, sink, blk_in); /* calc new free and available */ comp_update_buffer_consume(source, 0); -- 2.11.0

2 5

[Sound-open-firmware] [PATCH] SRC: Fix use of int and uint types and remove unused function parameters
by Seppo Ingalsuo 29 Sep '17

29 Sep '17

This patch fixes the warning messages shown with gcc option -Wextra. The source and sink buffer pointers advance is moved from filter function to higher level copy function as update consume/produce parameter. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo(a)linux.intel.com> --- src/audio/src.c | 32 +++++++++++--------------------- src/audio/src_core.c | 4 ++-- src/audio/src_core.h | 4 ++-- 3 files changed, 15 insertions(+), 25 deletions(-) diff --git a/src/audio/src.c b/src/audio/src.c index 3fd9614..de84149 100644 --- a/src/audio/src.c +++ b/src/audio/src.c @@ -65,8 +65,7 @@ struct comp_data { void (*src_func)(struct comp_dev *dev, struct comp_buffer *source, struct comp_buffer *sink, - uint32_t source_frames, - uint32_t sink_frames); + int source_frames); }; /* Common mute function for 2s and 1s SRC. This preserves the same @@ -77,7 +76,6 @@ static void src_muted_s32(struct comp_buffer *source, struct comp_buffer *sink, { int i; - int32_t *src = (int32_t *) source->r_ptr; int32_t *dest = (int32_t *) sink->w_ptr; int32_t *end = (int32_t *) sink->end_addr; int n_read = 0; @@ -101,8 +99,6 @@ static void src_muted_s32(struct comp_buffer *source, struct comp_buffer *sink, n_read += nch*blk_in; n_written += nch*blk_out; } - source->r_ptr = src + n_read; - sink->w_ptr = dest; } /* Fallback function to just output muted samples and advance @@ -113,8 +109,7 @@ static void src_muted_s32(struct comp_buffer *source, struct comp_buffer *sink, static void fallback_s32(struct comp_dev *dev, struct comp_buffer *source, struct comp_buffer *sink, - uint32_t source_frames, - uint32_t sink_frames) + int source_frames) { struct comp_data *cd = comp_get_drvdata(dev); @@ -129,7 +124,7 @@ static void fallback_s32(struct comp_dev *dev, /* Normal 2 stage SRC */ static void src_2s_s32_default(struct comp_dev *dev, struct comp_buffer *source, struct comp_buffer *sink, - uint32_t source_frames, uint32_t sink_frames) + int source_frames) { int i; int j; @@ -196,14 +191,12 @@ static void src_2s_s32_default(struct comp_dev *dev, n_written += blk_out; } } - source->r_ptr = s1.x_rptr - nch + 1; - sink->w_ptr = s2.y_wptr - nch + 1; } /* 1 stage SRC for simple conversions */ static void src_1s_s32_default(struct comp_dev *dev, struct comp_buffer *source, struct comp_buffer *sink, - uint32_t source_frames, uint32_t sink_frames) + int source_frames) { int i; int j; @@ -254,8 +247,6 @@ static void src_1s_s32_default(struct comp_dev *dev, } } - source->r_ptr = s1.x_rptr - nch + 1; - sink->w_ptr = s1.y_wptr - nch + 1; } static struct comp_dev *src_new(struct sof_ipc_comp *comp) @@ -404,8 +395,7 @@ static int src_params(struct comp_dev *dev) /* Initize SRC for actual sample rate */ nch = MIN(params->channels, PLATFORM_MAX_CHANNELS); for (i = 0; i < nch; i++) { - n = src_polyphase_init(&cd->src[i], source_rate, sink_rate, - &need, buffer_start); + n = src_polyphase_init(&cd->src[i], &need, buffer_start); buffer_start += need.single_src; } @@ -440,10 +430,10 @@ static int src_params(struct comp_dev *dev) * be too long. */ q = need.blk_out / dev->frames; - if (q * dev->frames < need.blk_out) + if (q * (int)dev->frames < need.blk_out) ++q; - if (q * dev->frames < need.blk_out + dev->frames) + if (q * (int)dev->frames < need.blk_out + (int)dev->frames) ++q; /* Configure downstream buffer */ @@ -543,13 +533,13 @@ static int src_copy(struct comp_dev *dev) need_sink = blk_out * dev->frame_bytes; /* Run as many times as buffers allow */ - while ((source->avail >= need_source) && (sink->free >= need_sink)) { + while (((int) source->avail >= need_source) && ((int) sink->free >= need_sink)) { /* Run src */ - cd->src_func(dev, source, sink, blk_in, blk_out); + cd->src_func(dev, source, sink, blk_in); /* calc new free and available */ - comp_update_buffer_consume(source, 0); - comp_update_buffer_produce(sink, 0); + comp_update_buffer_consume(source, need_source); + comp_update_buffer_produce(sink, need_sink); } return 0; diff --git a/src/audio/src_core.c b/src/audio/src_core.c index 5b804d6..8098d87 100644 --- a/src/audio/src_core.c +++ b/src/audio/src_core.c @@ -269,8 +269,8 @@ void src_polyphase_reset(struct polyphase_src *src) src_state_reset(&src->state2); } -int src_polyphase_init(struct polyphase_src *src, int fs1, int fs2, - struct src_alloc *res, int32_t *delay_lines_start) +int src_polyphase_init(struct polyphase_src *src, struct src_alloc *res, + int32_t *delay_lines_start) { int n_stages; int ret; diff --git a/src/audio/src_core.h b/src/audio/src_core.h index 2965c7d..a9f66d4 100644 --- a/src/audio/src_core.h +++ b/src/audio/src_core.h @@ -130,8 +130,8 @@ static inline int src_polyphase_get_blk_out(struct polyphase_src *src) void src_polyphase_reset(struct polyphase_src *src); -int src_polyphase_init(struct polyphase_src *src, int fs1, int fs2, - struct src_alloc *res, int32_t *delay_lines_start); +int src_polyphase_init(struct polyphase_src *src, struct src_alloc *res, + int32_t *delay_lines_start); int src_polyphase(struct polyphase_src *src, int32_t x[], int32_t y[], int n_in); -- 2.11.0

2 1

[Sound-open-firmware] [PATCH v2] sof: check for missing prototypes
by Pierre-Louis Bossart 27 Sep '17

27 Sep '17

using gcc -Wmissing-prototypes helps identify a series of missing include files or static declarations. the -Wmissing-prototypes option is not enforced yet, there are remaining issues with the Tensilica HAL that will need to be fixed separately. To turn it on, modify configure.ac # General compiler flags -CFLAGS="${CFLAGS:+$CFLAGS } -O2 -g -Wall -Werror -Wl,-EL -fno-inline-functions -nostdlib" +CFLAGS="${CFLAGS:+$CFLAGS } -O2 -g -Wall -Werror -Wl,-EL -fno-inline-functions -nostdlib -Wmissing-prototypes" Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- src/arch/xtensa/task.c | 1 + src/audio/src_core.c | 6 +++--- src/include/reef/init.h | 2 ++ src/include/reef/interrupt.h | 2 +- src/ipc/pmc-ipc.c | 1 + src/lib/lib.c | 1 + src/lib/schedule.c | 8 +++++--- src/math/numbers.c | 1 + src/math/trig.c | 1 + src/platform/baytrail/platform.c | 1 + src/platform/baytrail/timer.c | 2 +- 11 files changed, 18 insertions(+), 8 deletions(-) diff --git a/src/arch/xtensa/task.c b/src/arch/xtensa/task.c index 7e74c07..349f8ab 100644 --- a/src/arch/xtensa/task.c +++ b/src/arch/xtensa/task.c @@ -33,6 +33,7 @@ #include <reef/interrupt.h> #include <platform/platform.h> #include <reef/debug.h> +#include <arch/task.h> #include <stdint.h> #include <errno.h> diff --git a/src/audio/src_core.c b/src/audio/src_core.c index bce3586..5b804d6 100644 --- a/src/audio/src_core.c +++ b/src/audio/src_core.c @@ -52,21 +52,21 @@ int sof_rates[SOF_RATES_LENGTH] = {8000, 11025, 12000, 16000, 18900, 192000}; /* Calculates the needed FIR delay line length */ -int src_fir_delay_length(struct src_stage *s) +static int src_fir_delay_length(struct src_stage *s) { return s->subfilter_length + (s->num_of_subfilters - 1) * s->idm + s->blk_in; } /* Calculates the FIR output delay line length */ -int src_out_delay_length(struct src_stage *s) +static int src_out_delay_length(struct src_stage *s) { return (s->num_of_subfilters - 1) * s->odm + 1; } /* Returns index of a matching sample rate */ -int src_find_fs(int fs_list[], int list_length, int fs) +static int src_find_fs(int fs_list[], int list_length, int fs) { int i; diff --git a/src/include/reef/init.h b/src/include/reef/init.h index c2eaf87..9d97b48 100644 --- a/src/include/reef/init.h +++ b/src/include/reef/init.h @@ -38,4 +38,6 @@ int main(int argc, char *argv[]); int arch_init(struct reef *reef); +void __memmap_init(void); + #endif diff --git a/src/include/reef/interrupt.h b/src/include/reef/interrupt.h index 3c78e77..ea7d057 100644 --- a/src/include/reef/interrupt.h +++ b/src/include/reef/interrupt.h @@ -79,7 +79,7 @@ static inline void interrupt_global_enable(uint32_t flags) arch_interrupt_global_enable(flags); } -uint32_t platform_interrupt_get_enabled(); +uint32_t platform_interrupt_get_enabled(void); void platform_interrupt_clear(uint32_t irq, uint32_t mask); void platform_interrupt_mask(uint32_t irq, uint32_t mask); void platform_interrupt_unmask(uint32_t irq, uint32_t mask); diff --git a/src/ipc/pmc-ipc.c b/src/ipc/pmc-ipc.c index b8183c0..fdb8d4b 100644 --- a/src/ipc/pmc-ipc.c +++ b/src/ipc/pmc-ipc.c @@ -37,6 +37,7 @@ #include <reef/wait.h> #include <reef/trace.h> #include <platform/interrupt.h> +#include <platform/pmc.h> #include <platform/shim.h> diff --git a/src/lib/lib.c b/src/lib/lib.c index e1b1d9a..a1c9933 100644 --- a/src/lib/lib.c +++ b/src/lib/lib.c @@ -31,6 +31,7 @@ #include <stdint.h> #include <stdlib.h> #include <reef/reef.h> +#include <reef/alloc.h> #if 0 // TODO: only compile if no arch memcpy is available. diff --git a/src/lib/schedule.c b/src/lib/schedule.c index 142a2fb..427ca2e 100644 --- a/src/lib/schedule.c +++ b/src/lib/schedule.c @@ -159,7 +159,7 @@ static uint32_t sch_work(void *data, uint32_t delay) * Schedule task with the earliest deadline from task list. * Can run in IRQ context. */ -struct task *schedule_edf(void) +static struct task *schedule_edf(void) { struct task *task; struct task *next_plus1_task = NULL; @@ -201,8 +201,9 @@ struct task *schedule_edf(void) return next_plus1_task; } +#if 0 /* FIXME: is this needed ? */ /* delete task from scheduler */ -int schedule_task_del(struct task *task) +static int schedule_task_del(struct task *task) { uint32_t flags; int ret = 0; @@ -225,6 +226,7 @@ out: spin_unlock_irq(&sch->lock, flags); return ret; } +#endif /* * Add a new task to the scheduler to be run and define a scheduling @@ -285,7 +287,7 @@ void schedule_task_complete(struct task *task) spin_unlock_irq(&sch->lock, flags); } -void scheduler_run(void *unused) +static void scheduler_run(void *unused) { struct task *next_task; diff --git a/src/math/numbers.c b/src/math/numbers.c index 579de5d..93d41ea 100644 --- a/src/math/numbers.c +++ b/src/math/numbers.c @@ -34,6 +34,7 @@ * pseudocode in * https://en.wikipedia.org/wiki/Euclidean_algorithm#Implementations */ +#include <reef/math/numbers.h> int gcd(int a, int b) { diff --git a/src/math/trig.c b/src/math/trig.c index 8101980..79eb480 100644 --- a/src/math/trig.c +++ b/src/math/trig.c @@ -32,6 +32,7 @@ #include <stdint.h> #include <reef/audio/format.h> +#include <reef/math/trig.h> #define SINE_C_Q20 341782638 /* 2*SINE_NQUART/pi in Q12.20 */ diff --git a/src/platform/baytrail/platform.c b/src/platform/baytrail/platform.c index e3daf48..b701196 100644 --- a/src/platform/baytrail/platform.c +++ b/src/platform/baytrail/platform.c @@ -40,6 +40,7 @@ #include <reef/mailbox.h> #include <reef/dai.h> #include <reef/dma.h> +#include <reef/interrupt.h> #include <reef/reef.h> #include <reef/work.h> #include <reef/clock.h> diff --git a/src/platform/baytrail/timer.c b/src/platform/baytrail/timer.c index 513ede1..9256dd9 100644 --- a/src/platform/baytrail/timer.c +++ b/src/platform/baytrail/timer.c @@ -44,7 +44,7 @@ struct timer_data { static struct timer_data xtimer[1] = {}; -void platform_timer_64_handler(void *arg) +static void platform_timer_64_handler(void *arg) { struct timer *timer = arg; struct timer_data *tdata = timer->timer_data; -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] Fix compilation errors triggered by -Werror=missing-prototypes
by Seppo Ingalsuo 27 Sep '17

27 Sep '17

This patch adds include statements for modules to introduce the function prototypes for trig.c, numbers.c, and lib.c. In addition three unused functions are disabled with #if 0. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo(a)linux.intel.com> --- src/arch/xtensa/hal/set_region_translate.c | 2 ++ src/arch/xtensa/xtos/exc-syscall-c-handler.c | 3 +++ src/lib/lib.c | 1 + src/math/numbers.c | 2 ++ src/math/trig.c | 1 + 5 files changed, 9 insertions(+) diff --git a/src/arch/xtensa/hal/set_region_translate.c b/src/arch/xtensa/hal/set_region_translate.c index 7e885f6..5d5b21d 100644 --- a/src/arch/xtensa/hal/set_region_translate.c +++ b/src/arch/xtensa/hal/set_region_translate.c @@ -69,6 +69,7 @@ static inline unsigned probe_itlb(unsigned addr) { return tmp; } +#if 0 void invalidate_dtlb_entry(unsigned addr) { __asm__ __volatile__("idtlb %0; dsync \n\t" : : "a" (addr)); @@ -78,6 +79,7 @@ void invalidate_itlb_entry(unsigned addr) { __asm__ __volatile__("iitlb %0 ; isync\n\t" : : "a" (addr)); } +#endif static inline unsigned read_dtlbcfg() { unsigned long tmp; diff --git a/src/arch/xtensa/xtos/exc-syscall-c-handler.c b/src/arch/xtensa/xtos/exc-syscall-c-handler.c index 405f7b6..aa43d27 100644 --- a/src/arch/xtensa/xtos/exc-syscall-c-handler.c +++ b/src/arch/xtensa/xtos/exc-syscall-c-handler.c @@ -42,6 +42,8 @@ * _xtos_set_exception_handler( EXCCAUSE_SYSCALL, * (_xtos_handler)_xtos_p_syscall_handler ); */ + +#if 0 UserFrame* _xtos_p_syscall_handler( UserFrame *uf /*, int cause */ ) { uf->pc += 3; /* skip SYSCALL instruction */ @@ -98,4 +100,5 @@ UserFrame* _xtos_p_syscall_handler( UserFrame *uf /*, int cause */ ) return( uf ); } +#endif diff --git a/src/lib/lib.c b/src/lib/lib.c index e1b1d9a..a1c9933 100644 --- a/src/lib/lib.c +++ b/src/lib/lib.c @@ -31,6 +31,7 @@ #include <stdint.h> #include <stdlib.h> #include <reef/reef.h> +#include <reef/alloc.h> #if 0 // TODO: only compile if no arch memcpy is available. diff --git a/src/math/numbers.c b/src/math/numbers.c index 579de5d..67492a0 100644 --- a/src/math/numbers.c +++ b/src/math/numbers.c @@ -35,6 +35,8 @@ * https://en.wikipedia.org/wiki/Euclidean_algorithm#Implementations */ +#include <reef/math/numbers.h> + int gcd(int a, int b) { int t; diff --git a/src/math/trig.c b/src/math/trig.c index 8101980..79eb480 100644 --- a/src/math/trig.c +++ b/src/math/trig.c @@ -32,6 +32,7 @@ #include <stdint.h> #include <reef/audio/format.h> +#include <reef/math/trig.h> #define SINE_C_Q20 341782638 /* 2*SINE_NQUART/pi in Q12.20 */ -- 2.11.0

3 4

[Sound-open-firmware] [PATCH 00/10] MISRA rules - 1st pass
by Pierre-Louis Bossart 27 Sep '17

27 Sep '17

here are a set of patches that start a cleanup for MISRA compliance required for automotive. In general while the MISRA rules are debatable, they helped point at code that can be optimized or made more readable. Additional information on remaining opens can be seen here: https://sonarcloud.io/project/issues?directories=src%2Farch%2Fxtensa%2Csrc%… Pierre-Louis Bossart (10): sof: define each identifier in a dedicated statement pipeline: add missing default case pipeline: simplify prepare loop SRC: replace switch by if for readability tone: replace switch by if for readability volume: replace switch by if for readability ssp: replace switch by if for readability ssp: remove unnecessary direction parameter in ssp_stop wait: reduce number of nested breaks ipc: remove unnecessary tests src/arch/xtensa/timer.c | 9 ++++-- src/audio/dai.c | 17 ++++++---- src/audio/eq_fir.c | 22 ++++++++++--- src/audio/eq_iir.c | 21 +++++++++--- src/audio/host.c | 17 +++++++--- src/audio/iir.c | 6 ++-- src/audio/mixer.c | 15 ++++++--- src/audio/pipeline.c | 26 +++++++-------- src/audio/pipeline_static.c | 5 ++- src/audio/src.c | 38 ++++++++++++++-------- src/audio/src_core.c | 42 ++++++++++++++++++------ src/audio/tone.c | 24 +++++++------- src/audio/volume.c | 69 +++++++++++++++++++++++----------------- src/drivers/dw-dma.c | 15 ++++++--- src/drivers/ssp.c | 24 ++++++++------ src/include/reef/wait.h | 4 +-- src/ipc/byt-ipc.c | 5 +-- src/ipc/dma-copy.c | 14 +++++--- src/ipc/intel-ipc.c | 9 ++++-- src/ipc/ipc.c | 3 +- src/ipc/pmc-ipc.c | 6 ++-- src/lib/alloc.c | 24 ++++++++++---- src/lib/lib.c | 17 +++++++--- src/lib/schedule.c | 13 +++++--- src/lib/work.c | 18 ++++++++--- src/math/trig.c | 8 +++-- src/platform/baytrail/clk.c | 3 +- src/platform/baytrail/platform.c | 18 ++++++++--- src/platform/baytrail/timer.c | 8 +++-- 29 files changed, 334 insertions(+), 166 deletions(-) -- 2.11.0

2 11

[Sound-open-firmware] [PATCH] sof: check for missing prototypes
by Pierre-Louis Bossart 25 Sep '17

25 Sep '17

gcc -Wall is not enough, add -Wmissing-prototypes to align with kernel warnings. Add relevant includes and move functions without prototype as static Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- configure.ac | 2 +- src/arch/xtensa/task.c | 1 + src/audio/src_core.c | 6 +++--- src/include/reef/init.h | 2 ++ src/include/reef/interrupt.h | 2 +- src/ipc/pmc-ipc.c | 1 + src/lib/schedule.c | 8 +++++--- src/platform/baytrail/platform.c | 1 + src/platform/baytrail/timer.c | 2 +- 9 files changed, 16 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index 1c6fd0a..e8c8edf 100644 --- a/configure.ac +++ b/configure.ac @@ -18,7 +18,7 @@ AC_DEFINE_UNQUOTED([REEF_MINOR], reef_minor, [Reef minor version]) AC_CANONICAL_HOST # General compiler flags -CFLAGS="${CFLAGS:+$CFLAGS } -O2 -g -Wall -Werror -Wl,-EL -fno-inline-functions -nostdlib" +CFLAGS="${CFLAGS:+$CFLAGS } -O2 -g -Wall -Werror -Wl,-EL -fno-inline-functions -nostdlib -Wmissing-prototypes" # Cross compiler tool libgcc and headers AC_ARG_WITH([root-dir], diff --git a/src/arch/xtensa/task.c b/src/arch/xtensa/task.c index 7e74c07..349f8ab 100644 --- a/src/arch/xtensa/task.c +++ b/src/arch/xtensa/task.c @@ -33,6 +33,7 @@ #include <reef/interrupt.h> #include <platform/platform.h> #include <reef/debug.h> +#include <arch/task.h> #include <stdint.h> #include <errno.h> diff --git a/src/audio/src_core.c b/src/audio/src_core.c index bce3586..5b804d6 100644 --- a/src/audio/src_core.c +++ b/src/audio/src_core.c @@ -52,21 +52,21 @@ int sof_rates[SOF_RATES_LENGTH] = {8000, 11025, 12000, 16000, 18900, 192000}; /* Calculates the needed FIR delay line length */ -int src_fir_delay_length(struct src_stage *s) +static int src_fir_delay_length(struct src_stage *s) { return s->subfilter_length + (s->num_of_subfilters - 1) * s->idm + s->blk_in; } /* Calculates the FIR output delay line length */ -int src_out_delay_length(struct src_stage *s) +static int src_out_delay_length(struct src_stage *s) { return (s->num_of_subfilters - 1) * s->odm + 1; } /* Returns index of a matching sample rate */ -int src_find_fs(int fs_list[], int list_length, int fs) +static int src_find_fs(int fs_list[], int list_length, int fs) { int i; diff --git a/src/include/reef/init.h b/src/include/reef/init.h index c2eaf87..9d97b48 100644 --- a/src/include/reef/init.h +++ b/src/include/reef/init.h @@ -38,4 +38,6 @@ int main(int argc, char *argv[]); int arch_init(struct reef *reef); +void __memmap_init(void); + #endif diff --git a/src/include/reef/interrupt.h b/src/include/reef/interrupt.h index 3c78e77..ea7d057 100644 --- a/src/include/reef/interrupt.h +++ b/src/include/reef/interrupt.h @@ -79,7 +79,7 @@ static inline void interrupt_global_enable(uint32_t flags) arch_interrupt_global_enable(flags); } -uint32_t platform_interrupt_get_enabled(); +uint32_t platform_interrupt_get_enabled(void); void platform_interrupt_clear(uint32_t irq, uint32_t mask); void platform_interrupt_mask(uint32_t irq, uint32_t mask); void platform_interrupt_unmask(uint32_t irq, uint32_t mask); diff --git a/src/ipc/pmc-ipc.c b/src/ipc/pmc-ipc.c index b8183c0..fdb8d4b 100644 --- a/src/ipc/pmc-ipc.c +++ b/src/ipc/pmc-ipc.c @@ -37,6 +37,7 @@ #include <reef/wait.h> #include <reef/trace.h> #include <platform/interrupt.h> +#include <platform/pmc.h> #include <platform/shim.h> diff --git a/src/lib/schedule.c b/src/lib/schedule.c index 142a2fb..427ca2e 100644 --- a/src/lib/schedule.c +++ b/src/lib/schedule.c @@ -159,7 +159,7 @@ static uint32_t sch_work(void *data, uint32_t delay) * Schedule task with the earliest deadline from task list. * Can run in IRQ context. */ -struct task *schedule_edf(void) +static struct task *schedule_edf(void) { struct task *task; struct task *next_plus1_task = NULL; @@ -201,8 +201,9 @@ struct task *schedule_edf(void) return next_plus1_task; } +#if 0 /* FIXME: is this needed ? */ /* delete task from scheduler */ -int schedule_task_del(struct task *task) +static int schedule_task_del(struct task *task) { uint32_t flags; int ret = 0; @@ -225,6 +226,7 @@ out: spin_unlock_irq(&sch->lock, flags); return ret; } +#endif /* * Add a new task to the scheduler to be run and define a scheduling @@ -285,7 +287,7 @@ void schedule_task_complete(struct task *task) spin_unlock_irq(&sch->lock, flags); } -void scheduler_run(void *unused) +static void scheduler_run(void *unused) { struct task *next_task; diff --git a/src/platform/baytrail/platform.c b/src/platform/baytrail/platform.c index e3daf48..b701196 100644 --- a/src/platform/baytrail/platform.c +++ b/src/platform/baytrail/platform.c @@ -40,6 +40,7 @@ #include <reef/mailbox.h> #include <reef/dai.h> #include <reef/dma.h> +#include <reef/interrupt.h> #include <reef/reef.h> #include <reef/work.h> #include <reef/clock.h> diff --git a/src/platform/baytrail/timer.c b/src/platform/baytrail/timer.c index 513ede1..9256dd9 100644 --- a/src/platform/baytrail/timer.c +++ b/src/platform/baytrail/timer.c @@ -44,7 +44,7 @@ struct timer_data { static struct timer_data xtimer[1] = {}; -void platform_timer_64_handler(void *arg) +static void platform_timer_64_handler(void *arg) { struct timer *timer = arg; struct timer_data *tdata = timer->timer_data; -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] EQ FIR: Get coefficients and response switch via ABI
by Seppo Ingalsuo 25 Sep '17

25 Sep '17

The FIR equalizer configure and control is updated to use the new component ABI. Checks are added to protect equalizer from invalid setup. Also an unused parameter is removed from fir_init_delay() function. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo(a)linux.intel.com> --- src/audio/eq_fir.c | 86 ++++++++++++++++++++++++++++++------------------------ src/audio/eq_fir.h | 34 --------------------- src/audio/fir.c | 3 +- src/audio/fir.h | 3 +- 4 files changed, 50 insertions(+), 76 deletions(-) diff --git a/src/audio/eq_fir.c b/src/audio/eq_fir.c index eb2d864..fc6ae03 100644 --- a/src/audio/eq_fir.c +++ b/src/audio/eq_fir.c @@ -44,6 +44,7 @@ #include <reef/audio/pipeline.h> #include <reef/audio/format.h> #include <uapi/ipc.h> +#include <uapi/eq.h> #include "fir.h" #include "eq_fir.h" @@ -57,7 +58,7 @@ /* src component private data */ struct comp_data { - struct eq_fir_configuration *config; + struct sof_eq_fir_config *config; uint32_t period_bytes; struct fir_state_32x16 fir[PLATFORM_MAX_CHANNELS]; void (*eq_fir_func)(struct comp_dev *dev, @@ -120,7 +121,7 @@ static void eq_fir_s32_default(struct comp_dev *dev, } } -static void eq_fir_free_parameters(struct eq_fir_configuration **config) +static void eq_fir_free_parameters(struct sof_eq_fir_config **config) { if (*config != NULL) rfree(*config); @@ -148,22 +149,26 @@ static void eq_fir_free_delaylines(struct fir_state_32x16 fir[]) } static int eq_fir_setup(struct fir_state_32x16 fir[], - struct eq_fir_configuration *config, int nch) + struct sof_eq_fir_config *config, int nch) { int i, j, idx, length, resp; int32_t *fir_data; + int16_t *coef_data, *assign_response; int response_index[PLATFORM_MAX_CHANNELS]; int length_sum = 0; - if (nch > PLATFORM_MAX_CHANNELS) + if ((nch > PLATFORM_MAX_CHANNELS) + || (config->channels_in_config > PLATFORM_MAX_CHANNELS)) return -EINVAL; /* Collect index of respose start positions in all_coefficients[] */ j = 0; + assign_response = &config->data[0]; + coef_data = &config->data[config->channels_in_config]; for (i = 0; i < PLATFORM_MAX_CHANNELS; i++) { - if (i < config->number_of_responses_defined) { + if (i < config->number_of_responses) { response_index[i] = j; - j += 3 + config->all_coefficients[j]; + j += 3 + coef_data[j]; } else { response_index[i] = 0; } @@ -174,15 +179,17 @@ static int eq_fir_setup(struct fir_state_32x16 fir[], /* Initialize 1st phase */ for (i = 0; i < nch; i++) { - resp = config->assign_response[i]; + resp = assign_response[i]; + if (resp > config->number_of_responses - 1) + return -EINVAL; + if (resp < 0) { /* Initialize EQ channel to bypass */ fir_reset(&fir[i]); } else { /* Initialize EQ coefficients */ idx = response_index[resp]; - length = fir_init_coef(&fir[i], - &config->all_coefficients[idx]); + length = fir_init_coef(&fir[i], &coef_data[idx]); if (length > 0) length_sum += length; } @@ -199,31 +206,29 @@ static int eq_fir_setup(struct fir_state_32x16 fir[], /* Initialize 2nd phase to set EQ delay lines pointers */ for (i = 0; i < nch; i++) { - resp = config->assign_response[i]; + resp = assign_response[i]; if (resp >= 0) { - idx = response_index[resp]; - fir_init_delay(&fir[i], &config->all_coefficients[idx], - &fir_data); + fir_init_delay(&fir[i], &fir_data); } - } return 0; } static int eq_fir_switch_response(struct fir_state_32x16 fir[], - struct eq_fir_configuration *config, struct eq_fir_update *update, - int nch) + struct sof_eq_fir_config *config, + struct sof_ipc_ctrl_value_comp compv[], uint32_t num_elemens, int nch) { - int i, ret; + int i, j, ret; /* Copy assign response from update and re-initilize EQ */ if (config == NULL) return -EINVAL; - for (i = 0; i < config->stream_max_channels; i++) { - if (i < update->stream_max_channels) - config->assign_response[i] = update->assign_response[i]; + for (i = 0; i < num_elemens; i++) { + j = compv[i].index; + if (j < config->channels_in_config) + config->data[i] = compv[i].svalue; } ret = eq_fir_setup(fir, config, nch); @@ -238,6 +243,9 @@ static int eq_fir_switch_response(struct fir_state_32x16 fir[], static struct comp_dev *eq_fir_new(struct sof_ipc_comp *comp) { struct comp_dev *dev; + struct sof_ipc_comp_eq_fir *eq_fir; + struct sof_ipc_comp_eq_fir *ipc_eq_fir + = (struct sof_ipc_comp_eq_fir *) comp; struct comp_data *cd; int i; @@ -248,7 +256,8 @@ static struct comp_dev *eq_fir_new(struct sof_ipc_comp *comp) if (dev == NULL) return NULL; - memcpy(&dev->comp, comp, sizeof(struct sof_ipc_comp_eq_fir)); + eq_fir = (struct sof_ipc_comp_eq_fir *) &dev->comp; + memcpy(eq_fir, ipc_eq_fir, sizeof(struct sof_ipc_comp_eq_fir)); cd = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, sizeof(*cd)); if (cd == NULL) { @@ -282,14 +291,18 @@ static void eq_fir_free(struct comp_dev *dev) /* set component audio stream parameters */ static int eq_fir_params(struct comp_dev *dev) { - struct comp_data *cd = comp_get_drvdata(dev); struct sof_ipc_comp_config *config = COMP_GET_CONFIG(dev); + struct comp_data *cd = comp_get_drvdata(dev); struct comp_buffer *sink; int err; trace_eq("par"); - /* calculate period size based on config */ + /* Calculate period size based on config. First make sure that + * frame_bytes is set. + */ + dev->frame_bytes = + dev->params.sample_container_bytes * dev->params.channels; cd->period_bytes = dev->frames * dev->frame_bytes; /* configure downstream buffer */ @@ -312,27 +325,30 @@ static int eq_fir_params(struct comp_dev *dev) static int fir_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) { struct comp_data *cd = comp_get_drvdata(dev); - struct eq_fir_update *fir_update; /* TODO: move this to IPC as it's ABI */ + struct sof_ipc_ctrl_value_comp *compv; size_t bs; int i, ret = 0; /* TODO: determine if data is DMAed or appended to cdata */ + /* Check version from ABI header */ + if (cdata->data->comp_abi != SOF_EQ_FIR_ABI_VERSION) + return -EINVAL; + switch (cdata->cmd) { case SOF_CTRL_CMD_EQ_SWITCH: trace_eq("EFx"); - fir_update = (struct eq_fir_update *)cdata->data; + compv = (struct sof_ipc_ctrl_value_comp *) cdata->data->data; ret = eq_fir_switch_response(cd->fir, cd->config, - fir_update, PLATFORM_MAX_CHANNELS); + compv, cdata->num_elems, PLATFORM_MAX_CHANNELS); if (ret < 0) { trace_eq_error("ec1"); return ret; } /* Print trace information */ - tracev_value(fir_update->stream_max_channels); - for (i = 0; i < fir_update->stream_max_channels; i++) - tracev_value(fir_update->assign_response[i]); + for (i = 0; i < cd->config->channels_in_config; i++) + tracev_value(cd->config->data[i]); break; case SOF_CTRL_CMD_EQ_CONFIG: @@ -342,22 +358,16 @@ static int fir_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) eq_fir_free_parameters(&cd->config); /* Copy new config, need to decode data to know the size */ - bs = cdata->num_elems; - if (bs > EQ_FIR_MAX_BLOB_SIZE) + bs = cdata->data->size; + if ((bs > SOF_EQ_FIR_MAX_SIZE) || (bs < 1)) return -EINVAL; cd->config = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, bs); if (cd->config == NULL) return -EINVAL; - memcpy(cd->config, cdata->data, bs); + memcpy(cd->config, cdata->data->data, bs); ret = eq_fir_setup(cd->fir, cd->config, PLATFORM_MAX_CHANNELS); - - /* Print trace information */ - tracev_value(cd->config->stream_max_channels); - tracev_value(cd->config->number_of_responses_defined); - for (i = 0; i < cd->config->stream_max_channels; i++) - tracev_value(cd->config->assign_response[i]); break; case SOF_CTRL_CMD_MUTE: trace_eq("EFm"); diff --git a/src/audio/eq_fir.h b/src/audio/eq_fir.h index 7579ba4..4d2480c 100644 --- a/src/audio/eq_fir.h +++ b/src/audio/eq_fir.h @@ -33,38 +33,4 @@ #ifndef EQ_FIR_H #define EQ_FIR_H - -/* - * eq_fir_configuration data structure contains this information - * stream max channels - * number_of_responses_defined - * 0=no respones, 1=one response defined, 2=two responses defined, etc. - * assign_response[STREAM_MAX_CHANNELS] - * -1 = not defined, 0 = use first response, 1 = use 2nd response, etc. - * E.g. {0, 0, 0, 0, -1, -1, -1, -1} would apply to channels 0-3 the - * same first defined response and leave channels 4-7 unequalized. - * all_coefficients[] - * Repeated data { filter_length, input_shift, output_shift, h[] } - * where vector h has filter_length number of coefficients. - * Coefficients in h[] are in Q1.15 format. 16384 = 0.5. The shifts - * are number of right shifts. - */ - -#define NHEADER_EQ_FIR_BLOB 2 /* Header is two words plus assigns plus coef */ - -#define EQ_FIR_MAX_BLOB_SIZE 4096 /* Max size allowed for blob in bytes */ - -struct eq_fir_configuration { - uint16_t stream_max_channels; - uint16_t number_of_responses_defined; - uint16_t assign_response[PLATFORM_MAX_CHANNELS]; - int16_t all_coefficients[]; -}; - -struct eq_fir_update { - uint16_t stream_max_channels; - uint16_t assign_response[PLATFORM_MAX_CHANNELS]; - -}; - #endif diff --git a/src/audio/fir.c b/src/audio/fir.c index beb7e72..044b35d 100644 --- a/src/audio/fir.c +++ b/src/audio/fir.c @@ -83,8 +83,7 @@ int fir_init_coef(struct fir_state_32x16 *fir, int16_t config[]) return fir->length; } -void fir_init_delay(struct fir_state_32x16 *fir, int16_t config[], - int32_t **data) +void fir_init_delay(struct fir_state_32x16 *fir, int32_t **data) { fir->delay = *data; fir->delay_size = fir->length; diff --git a/src/audio/fir.h b/src/audio/fir.h index a99bcde..e682ef2 100644 --- a/src/audio/fir.h +++ b/src/audio/fir.h @@ -58,8 +58,7 @@ void fir_reset(struct fir_state_32x16 *fir); int fir_init_coef(struct fir_state_32x16 *fir, int16_t config[]); -void fir_init_delay(struct fir_state_32x16 *fir, int16_t config[], - int32_t **data); +void fir_init_delay(struct fir_state_32x16 *fir, int32_t **data); /* The next trivial functions are inlined */ -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] EQ IIR: Get filter config and response switch via ABI
by Seppo Ingalsuo 25 Sep '17

25 Sep '17

The IIR equalizer configure and control is updated to use the new component ABI. In addition there are checks added to protect IIR equalizer from invalid setup. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo(a)linux.intel.com> --- src/audio/eq_iir.c | 76 +++++++++++++++++--------------- src/audio/eq_iir.h | 47 -------------------- src/include/uapi/eq.h | 119 ++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 159 insertions(+), 83 deletions(-) create mode 100644 src/include/uapi/eq.h diff --git a/src/audio/eq_iir.c b/src/audio/eq_iir.c index 58a06a3..86f879a 100644 --- a/src/audio/eq_iir.c +++ b/src/audio/eq_iir.c @@ -44,6 +44,7 @@ #include <reef/audio/pipeline.h> #include <reef/audio/format.h> #include <uapi/ipc.h> +#include <uapi/eq.h> #include "eq_iir.h" #include "iir.h" @@ -57,7 +58,7 @@ /* src component private data */ struct comp_data { - struct eq_iir_configuration *config; + struct sof_eq_iir_config *config; uint32_t period_bytes; struct iir_state_df2t iir[PLATFORM_MAX_CHANNELS]; void (*eq_iir_func)(struct comp_dev *dev, @@ -120,7 +121,7 @@ static void eq_iir_s32_default(struct comp_dev *dev, } } -static void eq_iir_free_parameters(struct eq_iir_configuration **config) +static void eq_iir_free_parameters(struct sof_eq_iir_config **config) { if (*config != NULL) rfree(*config); @@ -150,27 +151,31 @@ static void eq_iir_free_delaylines(struct iir_state_df2t *iir) } static int eq_iir_setup(struct iir_state_df2t iir[], - struct eq_iir_configuration *config, int nch) + struct sof_eq_iir_config *config, int nch) { int i, j, idx, resp; size_t s; size_t size_sum = 0; int64_t *iir_delay; /* TODO should not need to know the type */ + int32_t *coef_data, *assign_response; int response_index[PLATFORM_MAX_CHANNELS]; - if (nch > PLATFORM_MAX_CHANNELS) - return -EINVAL; - /* Free existing IIR channels data if it was allocated */ eq_iir_free_delaylines(iir); + if ((nch > PLATFORM_MAX_CHANNELS) + || (config->channels_in_config > PLATFORM_MAX_CHANNELS)) + return -EINVAL; + /* Collect index of respose start positions in all_coefficients[] */ j = 0; + assign_response = &config->data[0]; + coef_data = &config->data[config->channels_in_config]; for (i = 0; i < PLATFORM_MAX_CHANNELS; i++) { - if (i < config->number_of_responses_defined) { + if (i < config->number_of_responses) { response_index[i] = j; j += NHEADER_DF2T - + NBIQUAD_DF2T * config->all_coefficients[j]; + + NBIQUAD_DF2T * coef_data[j]; } else { response_index[i] = 0; } @@ -178,15 +183,17 @@ static int eq_iir_setup(struct iir_state_df2t iir[], /* Initialize 1st phase */ for (i = 0; i < nch; i++) { - resp = config->assign_response[i]; + resp = assign_response[i]; + if (resp > config->number_of_responses - 1) + return -EINVAL; + if (resp < 0) { /* Initialize EQ channel to bypass */ iir_reset_df2t(&iir[i]); } else { /* Initialize EQ coefficients */ idx = response_index[resp]; - s = iir_init_coef_df2t(&iir[i], - &config->all_coefficients[idx]); + s = iir_init_coef_df2t(&iir[i], &coef_data[idx]); if (s > 0) size_sum += s; else @@ -204,9 +211,8 @@ static int eq_iir_setup(struct iir_state_df2t iir[], /* Initialize 2nd phase to set EQ delay lines pointers */ for (i = 0; i < nch; i++) { - resp = config->assign_response[i]; + resp = assign_response[i]; if (resp >= 0) { - idx = response_index[resp]; iir_init_delay_df2t(&iir[i], &iir_delay); } @@ -216,18 +222,19 @@ static int eq_iir_setup(struct iir_state_df2t iir[], } static int eq_iir_switch_response(struct iir_state_df2t iir[], - struct eq_iir_configuration *config, struct eq_iir_update *update, - int nch) + struct sof_eq_iir_config *config, + struct sof_ipc_ctrl_value_comp compv[], uint32_t num_elemens, int nch) { - int i, ret; + int i, j, ret; /* Copy assign response from update and re-initilize EQ */ if (config == NULL) return -EINVAL; - for (i = 0; i < config->stream_max_channels; i++) { - if (i < update->stream_max_channels) - config->assign_response[i] = update->assign_response[i]; + for (i = 0; i < num_elemens; i++) { + j = compv[i].index; + if (j < config->channels_in_config) + config->data[i] = compv[i].svalue; } ret = eq_iir_setup(iir, config, nch); @@ -293,7 +300,11 @@ static int eq_iir_params(struct comp_dev *dev) trace_eq_iir("par"); - /* calculate period size based on config */ + /* Calculate period size based on config. First make sure that + * frame_bytes is set. + */ + dev->frame_bytes = + dev->params.sample_container_bytes * dev->params.channels; cd->period_bytes = dev->frames * dev->frame_bytes; /* configure downstream buffer */ @@ -316,21 +327,21 @@ static int eq_iir_params(struct comp_dev *dev) static int iir_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) { struct comp_data *cd = comp_get_drvdata(dev); - struct eq_iir_update *iir_update; /* TODO: move to IPC header as part of ABI */ + struct sof_ipc_ctrl_value_comp *compv; int i, ret = 0; size_t bs; switch (cdata->cmd) { case SOF_CTRL_CMD_EQ_SWITCH: trace_eq_iir("EFx"); - iir_update = (struct eq_iir_update *) cdata->data; + compv = (struct sof_ipc_ctrl_value_comp *) cdata->data->data; ret = eq_iir_switch_response(cd->iir, cd->config, - iir_update, PLATFORM_MAX_CHANNELS); + compv, cdata->num_elems, PLATFORM_MAX_CHANNELS); /* Print trace information */ - tracev_value(iir_update->stream_max_channels); - for (i = 0; i < iir_update->stream_max_channels; i++) - tracev_value(iir_update->assign_response[i]); + tracev_value(cd->config->channels_in_config); + for (i = 0; i < cd->config->channels_in_config; i++) + tracev_value(cd->config->data[i]); break; case SOF_CTRL_CMD_EQ_CONFIG: @@ -339,8 +350,8 @@ static int iir_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) eq_iir_free_parameters(&cd->config); /* Copy new config, need to decode data to know the size */ - bs = cdata->num_elems; - if (bs > EQ_IIR_MAX_BLOB_SIZE) + bs = cdata->data->size; + if ((bs > SOF_EQ_IIR_MAX_SIZE) || (bs < 1)) return -EINVAL; /* Allocate and make a copy of the blob and setup IIR */ @@ -348,18 +359,11 @@ static int iir_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) if (cd->config == NULL) return -EINVAL; - memcpy(cd->config, cdata->data, bs); + memcpy(cd->config, cdata->data->data, bs); /* Initialize all channels, the actual number of channels may * not be set yet. */ ret = eq_iir_setup(cd->iir, cd->config, PLATFORM_MAX_CHANNELS); - - /* Print trace information */ - tracev_value(cd->config->stream_max_channels); - tracev_value(cd->config->number_of_responses_defined); - for (i = 0; i < cd->config->stream_max_channels; i++) - tracev_value(cd->config->assign_response[i]); - break; case SOF_CTRL_CMD_MUTE: trace_eq_iir("EFm"); diff --git a/src/audio/eq_iir.h b/src/audio/eq_iir.h index 42d95c1..e28a1a3 100644 --- a/src/audio/eq_iir.h +++ b/src/audio/eq_iir.h @@ -33,51 +33,4 @@ #ifndef EQ_IIR_H #define EQ_IIR_H - - -/* eq_iir_configuration - * uint32_t platform max channels - * uint32_t number_of_responses_defined - * 0=no responses, 1=one response defined, 2=two responses defined, etc. - * uint32_t assign_response[PLATFORM_MAX_CHANNELS] - * -1 = not defined, 0 = use first response, 1 = use 2nd response, etc. - * E.g. {0, 0, 0, 0, -1, -1, -1, -1} would apply to channels 0-3 the - * same first defined response and leave channels 4-7 unequalized. - * all_coefficients[] - * <1st EQ> - * uint32_t num_biquads - * uint32_t num_biquads_in_series - * <1st biquad> - * int32_t coef_a2 Q2.30 format - * int32_t coef_a1 Q2.30 format - * int32_t coef_b2 Q2.30 format - * int32_t coef_b1 Q2.30 format - * int32_t coef_b0 Q2.30 format - * int32_t output_shift number of shifts right, shift left is negative - * int32_t output_gain Q2.14 format - * <2nd biquad> - * ... - * <2nd EQ> - * - * Note: A flat response biquad can be made with a section set to - * b0 = 1.0, gain = 1.0, and other parameters set to 0 - * {0, 0, 0, 0, 1073741824, 0, 16484} - */ - -#define EQ_IIR_MAX_BLOB_SIZE 1024 /* In bytes or size_t */ - -#define NHEADER_EQ_IIR_BLOB 2 /* Blob is two words plus asssigns plus coef */ - -struct eq_iir_configuration { - int32_t stream_max_channels; - int32_t number_of_responses_defined; - int32_t assign_response[PLATFORM_MAX_CHANNELS]; - int32_t all_coefficients[]; -}; - -struct eq_iir_update { - int32_t stream_max_channels; - int32_t assign_response[PLATFORM_MAX_CHANNELS]; -}; - #endif diff --git a/src/include/uapi/eq.h b/src/include/uapi/eq.h new file mode 100644 index 0000000..9c42a51 --- /dev/null +++ b/src/include/uapi/eq.h @@ -0,0 +1,119 @@ +/* + * Copyright (c) 2017, Intel Corporation + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * * Neither the name of the Intel Corporation nor the + * names of its contributors may be used to endorse or promote products + * derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + * Author: Seppo Ingalsuo <seppo.ingalsuo(a)linux.intel.com> + */ + +#ifndef EQ_H +#define EQ_H + +/* FIR EQ type */ + +/* Component will reject non-matching configuration. The version number need + * to be incremented with any ABI changes in function fir_cmd(). + */ +#define SOF_EQ_FIR_ABI_VERSION 1 + +#define SOF_EQ_FIR_MAX_SIZE 4096 /* Max size allowed for coef data in bytes */ + +/* + * eq_fir_configuration data structure contains this information + * uint16_t channels_in_config + * This describes the number of channels in this EQ config data. It + * can be different from PLATFORM_MAX_CHANNELS. + * uint16_t number_of_responses + * 0=no responses, 1=one response defined, 2=two responses defined, etc. + * int16_t data[] + * assign_response[STREAM_MAX_CHANNELS] + * -1 = not defined, 0 = use first response, 1 = use 2nd response, etc. + * E.g. {0, 0, 0, 0, -1, -1, -1, -1} would apply to channels 0-3 the + * same first defined response and leave channels 4-7 unequalized. + * coef_data[] + * Repeated data { filter_length, input_shift, output_shift, h[] } + * for every EQ response defined where vector h has filter_length + * number of coefficients. Coefficients in h[] are in Q1.15 format. + * E.g. 16384 (Q1.15) = 0.5. The shifts are number of right shifts. + */ + +struct sof_eq_fir_config { + uint16_t channels_in_config; + uint16_t number_of_responses; + int16_t data[]; +}; + +/* IIR EQ type */ + +/* Component will reject non-matching configuration. The version number need + * to be incremented with any ABI changes in function fir_cmd(). + */ +#define SOF_EQ_FIR_ABI_VERSION 1 + +#define SOF_EQ_IIR_MAX_SIZE 1024 /* Max size allowed for coef data in bytes */ + +/* eq_iir_configuration + * uint32_t channels_in_config + * This describes the number of channels in this EQ config data. It + * can be different from PLATFORM_MAX_CHANNELS. + * uint32_t number_of_responses_defined + * 0=no responses, 1=one response defined, 2=two responses defined, etc. + * int32_t data[] + * Data consist of two parts. First is the response assign vector that + * has length of channels_in_config. The latter part is coefficient + * data. + * uint32_t assign_response[channels_in_config] + * -1 = not defined, 0 = use first response, 1 = use 2nd, etc. + * E.g. {0, 0, 0, 0, -1, -1, -1, -1} would apply to channels 0-3 the + * same first defined response and leave channels 4-7 unequalized. + * coefficient_data[] + * <1st EQ> + * uint32_t num_biquads + * uint32_t num_biquads_in_series + * <1st biquad> + * int32_t coef_a2 Q2.30 format + * int32_t coef_a1 Q2.30 format + * int32_t coef_b2 Q2.30 format + * int32_t coef_b1 Q2.30 format + * int32_t coef_b0 Q2.30 format + * int32_t output_shift number of shifts right, shift left is negative + * int32_t output_gain Q2.14 format + * <2nd biquad> + * ... + * <2nd EQ> + * + * Note: A flat response biquad can be made with a section set to + * b0 = 1.0, gain = 1.0, and other parameters set to 0 + * {0, 0, 0, 0, 1073741824, 0, 16484} + */ + +struct sof_eq_iir_config { + uint32_t channels_in_config; + uint32_t number_of_responses; + int32_t data[]; +}; + +#endif /* EQ_H */ + -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] Component ABI: Check for valid ABI header for COMP_CMD_SET_DATA command
by Seppo Ingalsuo 25 Sep '17

25 Sep '17

This patch adds the code to check the generic ABI header fields and reject data with invalid header. The individual components those use ABI need to check the component specific fields in addition. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo(a)linux.intel.com> --- src/include/reef/audio/component.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/include/reef/audio/component.h b/src/include/reef/audio/component.h index 5ae8084..436a758 100644 --- a/src/include/reef/audio/component.h +++ b/src/include/reef/audio/component.h @@ -245,6 +245,17 @@ static inline int comp_host_buffer(struct comp_dev *dev, /* send component command - mandatory */ static inline int comp_cmd(struct comp_dev *dev, int cmd, void *data) { + struct sof_ipc_ctrl_data *cdata = data; + + if ((cmd == COMP_CMD_SET_DATA) + && ((cdata->data->magic != SOF_ABI_MAGIC) + || (cdata->data->abi != SOF_ABI_VERSION))) { + trace_comp_error("abi"); + trace_value(cdata->data->magic); + trace_value(cdata->data->abi); + return -EINVAL; + } + return dev->drv->ops.cmd(dev, cmd, data); } -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] Volume: Add 24 to 24 bit samples volume processing
by Seppo Ingalsuo 25 Sep '17

25 Sep '17

This patch adds to component volume S24_4LE to S24_4LE processing. The macro from audio/format.h is used to compute shifts needed for product. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo(a)linux.intel.com> --- src/audio/volume.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/audio/volume.c b/src/audio/volume.c index be6197e..b7e8e39 100644 --- a/src/audio/volume.c +++ b/src/audio/volume.c @@ -41,6 +41,7 @@ #include <reef/clock.h> #include <reef/audio/component.h> #include <reef/audio/pipeline.h> +#include <reef/audio/format.h> #define trace_volume(__e) trace_event(TRACE_CLASS_VOLUME, __e) #define tracev_volume(__e) tracev_event(TRACE_CLASS_VOLUME, __e) @@ -214,6 +215,26 @@ static void vol_s24_to_s32(struct comp_dev *dev, struct comp_buffer *sink, } } +/* Copy and scale volume from 24 bit source buffer to 24 bit on 32 bit boundary + * dest buffer. + */ +static void vol_s24_to_s24(struct comp_dev *dev, struct comp_buffer *sink, + struct comp_buffer *source, uint32_t frames) +{ + struct comp_data *cd = comp_get_drvdata(dev); + int32_t i, *src = (int32_t*) source->r_ptr; + int32_t *dest = (int32_t*) sink->w_ptr; + + /* buffer sizes are always divisible by period frames */ + /* Samples are Q1.23 and volume is Q1.16 */ + for (i = 0; i < frames * 2; i += 2) { + dest[i] = (int32_t)(Q_MULTS_32X32( + (int64_t)src[i], cd->volume[0], 23, 16, 23)); + dest[i + 1] = (int32_t)(Q_MULTS_32X32( + (int64_t)src[i+1], cd->volume[1], 23, 16, 23)); + } +} + /* map of source and sink buffer formats to volume function */ static const struct comp_func_map func_map[] = { {SOF_IPC_FRAME_S16_LE, SOF_IPC_FRAME_S16_LE, 2, vol_s16_to_s16}, @@ -224,6 +245,7 @@ static const struct comp_func_map func_map[] = { {SOF_IPC_FRAME_S24_4LE, SOF_IPC_FRAME_S16_LE, 2, vol_s24_to_s16}, {SOF_IPC_FRAME_S32_LE, SOF_IPC_FRAME_S24_4LE, 2, vol_s32_to_s24}, {SOF_IPC_FRAME_S24_4LE, SOF_IPC_FRAME_S32_LE, 2, vol_s24_to_s32}, + {SOF_IPC_FRAME_S24_4LE, SOF_IPC_FRAME_S24_4LE, 2, vol_s24_to_s24}, }; /* synchronise host mmap() volume with real value */ -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] comp: host: Add trace output for buffer size errors
by Liam Girdwood 25 Sep '17

25 Sep '17

Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/audio/host.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/audio/host.c b/src/audio/host.c index a1d312a..76124fc 100644 --- a/src/audio/host.c +++ b/src/audio/host.c @@ -415,6 +415,7 @@ static int host_params(struct comp_dev *dev) err = buffer_set_size(hd->dma_buffer, buffer_size); if (err < 0) { trace_host_error("eSz"); + trace_value(buffer_size); return err; } -- 2.11.0

1 1

[Sound-open-firmware] [PATCH] topology: fix capture pipeline ID for SSP DAI
by Liam Girdwood 24 Sep '17

24 Sep '17

Capture pipeline for SSP DAI should be 2. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- topology/reef-apl-nocodec.m4 | 2 +- topology/reef-bdw-rt286.m4 | 2 +- topology/reef-bdw-rt5640.m4 | 2 +- topology/reef-bxt-nocodec.m4 | 2 +- topology/reef-byt-nocodec.m4 | 2 +- topology/reef-byt-rt5640.m4 | 2 +- topology/reef-byt-rt5651.m4 | 2 +- topology/reef-cht-nocodec.m4 | 2 +- topology/reef-hsw-rt5640.m4 | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/topology/reef-apl-nocodec.m4 b/topology/reef-apl-nocodec.m4 index f87a4e9..5e497f6 100644 --- a/topology/reef-apl-nocodec.m4 +++ b/topology/reef-apl-nocodec.m4 @@ -93,7 +93,7 @@ DAI_ADD(sof/pipe-dai-playback.m4, # capture DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-capture.m4, - 1, SSP, 2, I2S, + 2, SSP, 2, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) diff --git a/topology/reef-bdw-rt286.m4 b/topology/reef-bdw-rt286.m4 index eae2065..cb11ad6 100644 --- a/topology/reef-bdw-rt286.m4 +++ b/topology/reef-bdw-rt286.m4 @@ -93,7 +93,7 @@ DAI_ADD(sof/pipe-dai-playback.m4, # capture DAI is SSP0 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-capture.m4, - 1, SSP, 0, I2S, + 2, SSP, 0, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) diff --git a/topology/reef-bdw-rt5640.m4 b/topology/reef-bdw-rt5640.m4 index 60feb82..b3c19c2 100644 --- a/topology/reef-bdw-rt5640.m4 +++ b/topology/reef-bdw-rt5640.m4 @@ -93,7 +93,7 @@ DAI_ADD(sof/pipe-dai-playback.m4, # capture DAI is SSP0 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-capture.m4, - 1, SSP, 0, I2S, + 2, SSP, 0, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) diff --git a/topology/reef-bxt-nocodec.m4 b/topology/reef-bxt-nocodec.m4 index 744e9b1..58bc6f6 100644 --- a/topology/reef-bxt-nocodec.m4 +++ b/topology/reef-bxt-nocodec.m4 @@ -93,7 +93,7 @@ DAI_ADD(sof/pipe-dai-playback.m4, # capture DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-capture.m4, - 1, SSP, 2, I2S, + 2, SSP, 2, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) diff --git a/topology/reef-byt-nocodec.m4 b/topology/reef-byt-nocodec.m4 index 05373f9..5f6cd1d 100644 --- a/topology/reef-byt-nocodec.m4 +++ b/topology/reef-byt-nocodec.m4 @@ -82,7 +82,7 @@ DAI_ADD(sof/pipe-dai-playback.m4, # capture DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-capture.m4, - 1, SSP, 2, I2S, + 2, SSP, 2, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) diff --git a/topology/reef-byt-rt5640.m4 b/topology/reef-byt-rt5640.m4 index 911b4d1..c5e8b52 100644 --- a/topology/reef-byt-rt5640.m4 +++ b/topology/reef-byt-rt5640.m4 @@ -82,7 +82,7 @@ DAI_ADD(sof/pipe-dai-playback.m4, # capture DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-capture.m4, - 1, SSP, 2, Audio, + 2, SSP, 2, Audio, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) diff --git a/topology/reef-byt-rt5651.m4 b/topology/reef-byt-rt5651.m4 index c6f20a4..e335d66 100644 --- a/topology/reef-byt-rt5651.m4 +++ b/topology/reef-byt-rt5651.m4 @@ -82,7 +82,7 @@ DAI_ADD(sof/pipe-dai-playback.m4, # capture DAI is SSP2 using "Audio" DAPM stream name and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-capture.m4, - 1, SSP, 2, Audio, + 2, SSP, 2, Audio, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) diff --git a/topology/reef-cht-nocodec.m4 b/topology/reef-cht-nocodec.m4 index 43e0e6e..ddeb71e 100644 --- a/topology/reef-cht-nocodec.m4 +++ b/topology/reef-cht-nocodec.m4 @@ -82,7 +82,7 @@ DAI_ADD(sof/pipe-dai-playback.m4, # capture DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-capture.m4, - 1, SSP, 2, I2S, + 2, SSP, 2, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) diff --git a/topology/reef-hsw-rt5640.m4 b/topology/reef-hsw-rt5640.m4 index 3d26149..efd815b 100644 --- a/topology/reef-hsw-rt5640.m4 +++ b/topology/reef-hsw-rt5640.m4 @@ -93,7 +93,7 @@ DAI_ADD(sof/pipe-dai-playback.m4, # capture DAI is SSP0 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priority 0 DAI_ADD(sof/pipe-dai-capture.m4, - 1, SSP, 0, I2S, + 2, SSP, 0, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] pipeline: fix timestamp for capture streams.
by Liam Girdwood 24 Sep '17

24 Sep '17

Make sure we timestamp upstream in capture streams Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/audio/pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/audio/pipeline.c b/src/audio/pipeline.c index 62c21b7..4e830c6 100644 --- a/src/audio/pipeline.c +++ b/src/audio/pipeline.c @@ -851,7 +851,7 @@ upstream: continue; /* continue downstream */ - res = timestamp_upstream(start, buffer->sink, posn); + res = timestamp_upstream(start, buffer->source, posn); if (res == 1) break; } -- 2.11.0

1 3

[Sound-open-firmware] [PATCH] ssp: add missing break in dai format switch
by Pierre-Louis Bossart 23 Sep '17

23 Sep '17

Support for DSP_A is obviously broken. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- src/drivers/ssp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/drivers/ssp.c b/src/drivers/ssp.c index c97b60e..a472974 100644 --- a/src/drivers/ssp.c +++ b/src/drivers/ssp.c @@ -224,6 +224,7 @@ static inline int ssp_set_config(struct dai *dai, sscr0 |= SSCR0_PSP | SSCR0_MOD | SSCR0_FRDC(config->num_slots); sscr1 |= SSCR1_TRAIL; sspsp |= SSPSP_SFRMWDTH(1) | SSPSP_SFRMDLY(2); + break; case SOF_DAI_FMT_DSP_B: sscr0 |= SSCR0_PSP | SSCR0_MOD | SSCR0_FRDC(config->num_slots); sscr1 |= SSCR1_TRAIL; -- 2.11.0

2 1

[Sound-open-firmware] [PATCH 1/4] SRC: Add checks for number of channels when initializing from params
by Seppo Ingalsuo 22 Sep '17

22 Sep '17

This patch prevents SRCs init to loop past PLATFORM_MAX_CHANNELS. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo(a)linux.intel.com> --- src/audio/src.c | 5 +++-- src/audio/src_core.h | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/audio/src.c b/src/audio/src.c index 1f84a5a..203e802 100644 --- a/src/audio/src.c +++ b/src/audio/src.c @@ -322,7 +322,7 @@ static int src_params(struct comp_dev *dev) size_t delay_lines_size; uint32_t source_rate, sink_rate; int32_t *buffer_start; - int n = 0, i, err, frames_is_for_source, q; + int n = 0, i, err, frames_is_for_source, nch, q; trace_src("par"); @@ -392,7 +392,8 @@ static int src_params(struct comp_dev *dev) buffer_start = cd->delay_lines + need.scratch; /* Initize SRC for actual sample rate */ - for (i = 0; i < params->channels; i++) { + nch = MIN(params->channels, PLATFORM_MAX_CHANNELS); + for (i = 0; i < nch; i++) { n = src_polyphase_init(&cd->src[i], source_rate, sink_rate, &need, buffer_start); buffer_start += need.single_src; diff --git a/src/audio/src_core.h b/src/audio/src_core.h index 5977421..886cc23 100644 --- a/src/audio/src_core.h +++ b/src/audio/src_core.h @@ -33,6 +33,7 @@ #define SRC_CORE_H #define MAX(a, b) (((a) > (b)) ? (a) : (b)) +#define MIN(a, b) (((a) < (b)) ? (a) : (b)) struct src_alloc { int fir_s1; -- 2.11.0

2 4

[Sound-open-firmware] [PATCH 1/3] ipc: add support for timer topology scheduling source.
by Liam Girdwood 22 Sep '17

22 Sep '17

Add an option to schedule based on timer or on DAI/DMA IRQ Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/include/uapi/ipc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/include/uapi/ipc.h b/src/include/uapi/ipc.h index acfa05e..472fb41 100644 --- a/src/include/uapi/ipc.h +++ b/src/include/uapi/ipc.h @@ -678,6 +678,7 @@ struct sof_ipc_pipe_new { uint32_t mips; /* worst case instruction count per period */ uint32_t frames_per_sched; /* output frames of pipeline, 0 is variable */ uint32_t xrun_limit_usecs; /* report xruns greater than limit */ + uint32_t timer; /* non zero if timer scheduled otherwise DAI scheduled */ } __attribute__((packed)); /* pipeline construction complete - SOF_IPC_TPLG_PIPE_COMPLETE */ -- 2.11.0

1 2

[Sound-open-firmware] [PATCH] comp: enforce state transition checking for each component.
by Liam Girdwood 21 Sep '17

21 Sep '17

Make sure each component checks the state transition prior to performing any action for the new state. This ensure that only supported transitions are used and any non supported transition is flagged as an error. This also removes DRAIN state and performs some cleanup on mixer state handling. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/audio/component.c | 7 +++--- src/audio/dai.c | 16 ++++-------- src/audio/eq_fir.c | 10 +++++--- src/audio/eq_iir.c | 28 ++++----------------- src/audio/host.c | 15 +++++------ src/audio/mixer.c | 51 +++++++++++++++++++++----------------- src/audio/src.c | 14 +++++------ src/audio/tone.c | 14 +++++------ src/audio/volume.c | 15 +++++------ src/include/reef/audio/component.h | 1 - src/ipc/intel-ipc.c | 3 --- 11 files changed, 74 insertions(+), 100 deletions(-) diff --git a/src/audio/component.c b/src/audio/component.c index 1cf4799..ec170c6 100644 --- a/src/audio/component.c +++ b/src/audio/component.c @@ -126,6 +126,7 @@ int comp_set_state(struct comp_dev *dev, int cmd) dev->state = COMP_STATE_ACTIVE; } else { trace_comp_error("CES"); + trace_value(dev->state); ret = -EINVAL; } break; @@ -134,6 +135,7 @@ int comp_set_state(struct comp_dev *dev, int cmd) dev->state = COMP_STATE_ACTIVE; } else { trace_comp_error("CEr"); + trace_value(dev->state); ret = -EINVAL; } break; @@ -142,6 +144,7 @@ int comp_set_state(struct comp_dev *dev, int cmd) dev->state = COMP_STATE_READY; } else { trace_comp_error("CEs"); + trace_value(dev->state); ret = -EINVAL; } break; @@ -151,13 +154,11 @@ int comp_set_state(struct comp_dev *dev, int cmd) dev->state = COMP_STATE_PAUSED; else { trace_comp_error("CEp"); + trace_value(dev->state); ret = -EINVAL; } break; default: - trace_comp_error("CEd"); - trace_value(cmd); - ret = -EINVAL; break; } diff --git a/src/audio/dai.c b/src/audio/dai.c index cf8de72..e22d21d 100644 --- a/src/audio/dai.c +++ b/src/audio/dai.c @@ -444,20 +444,18 @@ static int dai_reset(struct comp_dev *dev) static int dai_cmd(struct comp_dev *dev, int cmd, void *data) { struct dai_data *dd = comp_get_drvdata(dev); -// struct sof_ipc_ctrl_values *ctrl = data; int ret; trace_dai("cmd"); tracev_value(cmd); + ret = comp_set_state(dev, cmd); + if (ret < 0) + return ret; + switch (cmd) { - case COMP_CMD_PAUSE: - case COMP_CMD_STOP: - dev->state = COMP_STATE_PAUSED; - break; case COMP_CMD_RELEASE: case COMP_CMD_START: - ret = dma_start(dd->dma, dd->chan); if (ret < 0) return ret; @@ -465,16 +463,12 @@ static int dai_cmd(struct comp_dev *dev, int cmd, void *data) /* update starting wallclock */ platform_dai_wallclock(dev, &dd->wallclock); - dev->state = COMP_STATE_ACTIVE; - break; - case COMP_CMD_SUSPEND: - case COMP_CMD_RESUME: break; default: break; } - return 0; + return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/audio/eq_fir.c b/src/audio/eq_fir.c index ef3b7d2..ba42643 100644 --- a/src/audio/eq_fir.c +++ b/src/audio/eq_fir.c @@ -389,16 +389,18 @@ static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data) trace_src("cmd"); + ret = comp_set_state(dev, cmd); + if (ret < 0) + return ret; + switch (cmd) { case COMP_CMD_SET_DATA: ret = fir_cmd(dev, cdata); break; - case COMP_CMD_START: case COMP_CMD_STOP: - case COMP_CMD_PAUSE: - case COMP_CMD_RELEASE: + comp_buffer_reset(dev); + break; default: - ret = comp_set_state(dev, cmd); break; } diff --git a/src/audio/eq_iir.c b/src/audio/eq_iir.c index 4a4cff1..995721b 100644 --- a/src/audio/eq_iir.c +++ b/src/audio/eq_iir.c @@ -392,36 +392,18 @@ static int eq_iir_cmd(struct comp_dev *dev, int cmd, void *data) trace_eq_iir("cmd"); + ret = comp_set_state(dev, cmd); + if (ret < 0) + return ret; + switch (cmd) { case COMP_CMD_SET_DATA: ret = iir_cmd(dev, cdata); break; - case COMP_CMD_START: - trace_eq_iir("EFs"); - dev->state = COMP_STATE_ACTIVE; - break; case COMP_CMD_STOP: - trace_eq_iir("ESp"); - if (dev->state == COMP_STATE_ACTIVE || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_READY; - } - break; - case COMP_CMD_PAUSE: - trace_eq_iir("EPe"); - /* only support pausing for running */ - if (dev->state == COMP_STATE_ACTIVE) - dev->state = COMP_STATE_PAUSED; - - break; - case COMP_CMD_RELEASE: - trace_eq_iir("ERl"); - dev->state = COMP_STATE_ACTIVE; + comp_buffer_reset(dev); break; default: - trace_eq_iir("EDf"); - ret = -EINVAL; break; } diff --git a/src/audio/host.c b/src/audio/host.c index 8aa29ad..a1d312a 100644 --- a/src/audio/host.c +++ b/src/audio/host.c @@ -278,7 +278,7 @@ static struct comp_dev *host_new(struct sof_ipc_comp *comp) /* init posn data. TODO: other fields */ hd->posn.comp_id = comp->id; - + dev->state = COMP_STATE_READY; return dev; error: @@ -549,19 +549,16 @@ static int host_cmd(struct comp_dev *dev, int cmd, void *data) trace_host("cmd"); + ret = comp_set_state(dev, cmd); + if (ret < 0) + return ret; + switch (cmd) { case COMP_CMD_PAUSE: case COMP_CMD_STOP: - if (dev->state == COMP_STATE_ACTIVE) - ret = host_stop(dev); - break; - case COMP_CMD_SUSPEND: - case COMP_CMD_RESUME: + ret = host_stop(dev); break; - case COMP_CMD_START: - case COMP_CMD_RELEASE: default: - ret = comp_set_state(dev, cmd); break; } diff --git a/src/audio/mixer.c b/src/audio/mixer.c index 85aa601..3861b7c 100644 --- a/src/audio/mixer.c +++ b/src/audio/mixer.c @@ -151,55 +151,60 @@ static int mixer_params(struct comp_dev *dev) return 0; } -static int mixer_status_change(struct comp_dev *dev/* , uint32_t target_state */) +static int mixer_source_status_count(struct comp_dev *mixer, uint32_t status) { - int finish = 0; struct comp_buffer *source; struct list_item * blist; - uint32_t stream_target = COMP_STATE_INIT; + int count = 0; - /* calculate the highest status between input streams */ - list_for_item(blist, &dev->bsource_list) { + /* count source with state == status */ + list_for_item(blist, &mixer->bsource_list) { source = container_of(blist, struct comp_buffer, sink_list); - if (source->source->state > stream_target) - stream_target = source->source->state; + if (source->source->state == status) + count++; } - if (dev->state == stream_target) - finish = 1; - else - dev->state = stream_target; + return count; +} + +static inline int mixer_sink_status(struct comp_dev *mixer) +{ + struct comp_buffer *sink; - return finish; + sink = list_first_item(&mixer->bsink_list, struct comp_buffer, + source_list); + return sink->sink->state; } /* used to pass standard and bespoke commands (with data) to component */ static int mixer_cmd(struct comp_dev *dev, int cmd, void *data) { - int finish = 0; + int ret; trace_mixer("cmd"); + ret = comp_set_state(dev, cmd); + if (ret < 0) + return ret; + switch(cmd) { case COMP_CMD_START: - trace_mixer("MSa"); - case COMP_CMD_PAUSE: case COMP_CMD_RELEASE: - case COMP_CMD_DRAIN: - case COMP_CMD_SUSPEND: - case COMP_CMD_RESUME: - finish = mixer_status_change(dev); + if (mixer_sink_status(dev) == COMP_STATE_ACTIVE) + return 1; /* no need to go downstream */ break; + case COMP_CMD_PAUSE: case COMP_CMD_STOP: - finish = mixer_status_change(dev); - if (finish == 0) - comp_buffer_reset(dev); + if (mixer_source_status_count(dev, COMP_STATE_ACTIVE) > 0) { + dev->state = COMP_STATE_ACTIVE; + return 1; /* no need to go downstream */ + } break; default: break; } - return finish; + return 0; /* send cmd downstream */ } /* diff --git a/src/audio/src.c b/src/audio/src.c index bc32f95..1f84a5a 100644 --- a/src/audio/src.c +++ b/src/audio/src.c @@ -292,6 +292,7 @@ static struct comp_dev *src_new(struct sof_ipc_comp *comp) for (i = 0; i < PLATFORM_MAX_CHANNELS; i++) src_polyphase_reset(&cd->src[i]); + dev->state = COMP_STATE_READY; return dev; } @@ -489,17 +490,16 @@ static int src_cmd(struct comp_dev *dev, int cmd, void *data) struct sof_ipc_ctrl_data *cdata = data; int ret = 0; - trace_src("SCm"); + trace_src("cmd"); + + ret = comp_set_state(dev, cmd); + if (ret < 0) + return ret; switch (cmd) { case COMP_CMD_SET_VALUE: return src_ctrl_cmd(dev, cdata); - case COMP_CMD_START: - case COMP_CMD_STOP: - case COMP_CMD_PAUSE: - case COMP_CMD_RELEASE: default: - ret = comp_set_state(dev, cmd); break; } @@ -564,7 +564,7 @@ static int src_reset(struct comp_dev *dev) for (i = 0; i < PLATFORM_MAX_CHANNELS; i++) src_polyphase_reset(&cd->src[i]); - dev->state = COMP_STATE_INIT; + dev->state = COMP_STATE_READY; return 0; } diff --git a/src/audio/tone.c b/src/audio/tone.c index aec8a72..94d9aa7 100644 --- a/src/audio/tone.c +++ b/src/audio/tone.c @@ -395,6 +395,7 @@ static struct comp_dev *tone_new(struct sof_ipc_comp *comp) /* Reset tone generator and set channels volumes to default */ tonegen_reset(&cd->sg); + dev->state = COMP_STATE_READY; return dev; } @@ -472,17 +473,16 @@ static int tone_cmd(struct comp_dev *dev, int cmd, void *data) struct sof_ipc_ctrl_data *cdata = data; int ret = 0; - trace_tone("tri"); + trace_tone("cmd"); + + ret = comp_set_state(dev, cmd); + if (ret < 0) + return ret; switch (cmd) { case COMP_CMD_SET_VALUE: return tone_ctrl_cmd(dev, cdata); - case COMP_CMD_START: - case COMP_CMD_STOP: - case COMP_CMD_PAUSE: - case COMP_CMD_RELEASE: default: - ret = comp_set_state(dev, cmd); break; } @@ -550,7 +550,7 @@ static int tone_reset(struct comp_dev *dev) /* Initialize with the defaults */ tonegen_reset(&cd->sg); - dev->state = COMP_STATE_INIT; + dev->state = COMP_STATE_READY; return 0; } diff --git a/src/audio/volume.c b/src/audio/volume.c index 45bbe27..960a144 100644 --- a/src/audio/volume.c +++ b/src/audio/volume.c @@ -466,25 +466,22 @@ static int volume_ctrl_get_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *c static int volume_cmd(struct comp_dev *dev, int cmd, void *data) { struct sof_ipc_ctrl_data *cdata = data; - int ret = 0; + int ret; trace_volume("cmd"); + ret = comp_set_state(dev, cmd); + if (ret < 0) + return ret; + switch (cmd) { case COMP_CMD_SET_VALUE: return volume_ctrl_set_cmd(dev, cdata); case COMP_CMD_GET_VALUE: return volume_ctrl_get_cmd(dev, cdata); - case COMP_CMD_START: - case COMP_CMD_STOP: - case COMP_CMD_PAUSE: - case COMP_CMD_RELEASE: default: - ret = comp_set_state(dev, cmd); - break; + return ret; } - - return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/include/reef/audio/component.h b/src/include/reef/audio/component.h index d092210..5ae8084 100644 --- a/src/include/reef/audio/component.h +++ b/src/include/reef/audio/component.h @@ -76,7 +76,6 @@ #define COMP_CMD_START 1 /* start component stream */ #define COMP_CMD_PAUSE 2 /* immediately pause the component stream */ #define COMP_CMD_RELEASE 3 /* release paused component stream */ -#define COMP_CMD_DRAIN 4 /* drain component buffers */ #define COMP_CMD_SUSPEND 5 /* suspend component */ #define COMP_CMD_RESUME 6 /* resume component */ diff --git a/src/ipc/intel-ipc.c b/src/ipc/intel-ipc.c index 752ea0c..92dfd73 100644 --- a/src/ipc/intel-ipc.c +++ b/src/ipc/intel-ipc.c @@ -394,9 +394,6 @@ static int ipc_stream_trigger(uint32_t header) case iCS(SOF_IPC_STREAM_TRIG_RELEASE): cmd = COMP_CMD_RELEASE; break; - case iCS(SOF_IPC_STREAM_TRIG_DRAIN): - cmd = COMP_CMD_DRAIN; - break; /* XRUN is special case- TODO */ case iCS(SOF_IPC_STREAM_TRIG_XRUN): return 0; -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] comps: make sure correct state transitions are used and verified.
by Liam Girdwood 21 Sep '17

21 Sep '17

Use the correct component states and verify this at runtime. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/audio/component.c | 18 ++++++++++++++---- src/audio/host.c | 10 ++++------ src/audio/mixer.c | 6 ++++-- src/audio/volume.c | 3 ++- 4 files changed, 24 insertions(+), 13 deletions(-) diff --git a/src/audio/component.c b/src/audio/component.c index fd0d65e..1cf4799 100644 --- a/src/audio/component.c +++ b/src/audio/component.c @@ -122,13 +122,23 @@ int comp_set_state(struct comp_dev *dev, int cmd) switch (cmd) { case COMP_CMD_START: + if (dev->state == COMP_STATE_PREPARE) { + dev->state = COMP_STATE_ACTIVE; + } else { + trace_comp_error("CES"); + ret = -EINVAL; + } + break; case COMP_CMD_RELEASE: - dev->state = COMP_STATE_ACTIVE; + if (dev->state == COMP_STATE_PAUSED) { + dev->state = COMP_STATE_ACTIVE; + } else { + trace_comp_error("CEr"); + ret = -EINVAL; + } break; case COMP_CMD_STOP: - if (dev->state == COMP_STATE_ACTIVE || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); + if (dev->state == COMP_STATE_ACTIVE) { dev->state = COMP_STATE_READY; } else { trace_comp_error("CEs"); diff --git a/src/audio/host.c b/src/audio/host.c index 36e4c29..8aa29ad 100644 --- a/src/audio/host.c +++ b/src/audio/host.c @@ -527,7 +527,7 @@ static int host_stop(struct comp_dev *dev) /* now reset downstream buffer */ comp_buffer_reset(dev); - dev->state = COMP_STATE_READY; + dev->state = COMP_STATE_PAUSED; return 0; } @@ -549,18 +549,16 @@ static int host_cmd(struct comp_dev *dev, int cmd, void *data) trace_host("cmd"); - // TODO: align cmd macros. switch (cmd) { + case COMP_CMD_PAUSE: case COMP_CMD_STOP: - if (dev->state == COMP_STATE_ACTIVE || - dev->state == COMP_STATE_PAUSED) + if (dev->state == COMP_STATE_ACTIVE) ret = host_stop(dev); break; case COMP_CMD_SUSPEND: case COMP_CMD_RESUME: break; case COMP_CMD_START: - case COMP_CMD_PAUSE: case COMP_CMD_RELEASE: default: ret = comp_set_state(dev, cmd); @@ -616,7 +614,7 @@ static int host_reset(struct comp_dev *dev) hd->host_pos = NULL; hd->source = NULL; hd->sink = NULL; - dev->state = COMP_STATE_INIT; + dev->state = COMP_STATE_READY; return 0; } diff --git a/src/audio/mixer.c b/src/audio/mixer.c index 30ac8cc..85aa601 100644 --- a/src/audio/mixer.c +++ b/src/audio/mixer.c @@ -99,7 +99,7 @@ static struct comp_dev *mixer_new(struct sof_ipc_comp *comp) } comp_set_drvdata(dev, md); - + dev->state = COMP_STATE_READY; return dev; } @@ -274,7 +274,7 @@ static int mixer_reset(struct comp_dev *dev) return 1; /* should not reset the downstream components */ } - dev->state = COMP_STATE_INIT; + dev->state = COMP_STATE_READY; return 0; } @@ -312,6 +312,8 @@ static int mixer_prepare(struct comp_dev *dev) } } + dev->state = COMP_STATE_PREPARE; + /* prepare downstream */ return downstream; } diff --git a/src/audio/volume.c b/src/audio/volume.c index 13cba42..45bbe27 100644 --- a/src/audio/volume.c +++ b/src/audio/volume.c @@ -332,6 +332,7 @@ static struct comp_dev *volume_new(struct sof_ipc_comp *comp) cd->tvolume[i] = VOL_MAX; } + dev->state = COMP_STATE_READY; return dev; } @@ -649,7 +650,7 @@ static int volume_reset(struct comp_dev *dev) { trace_volume("res"); - dev->state = COMP_STATE_INIT; + dev->state = COMP_STATE_READY; return 0; } -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] timer: use 64 bit timestamps
by Liam Girdwood 21 Sep '17

21 Sep '17

Use 64bit timestamps now that 64 bit timers are implemented. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/platform/baytrail/timer.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/platform/baytrail/timer.c b/src/platform/baytrail/timer.c index 17c1f0b..ce58fc5 100644 --- a/src/platform/baytrail/timer.c +++ b/src/platform/baytrail/timer.c @@ -172,7 +172,7 @@ void platform_host_timestamp(struct comp_dev *host, /* get host postion */ err = comp_position(host, posn); if (err == 0) - posn->flags |= SOF_TIME_HOST_VALID; + posn->flags |= SOF_TIME_HOST_VALID | SOF_TIME_HOST_64; } /* get timestamp for DAI stream DMA position */ @@ -187,15 +187,15 @@ void platform_dai_timestamp(struct comp_dev *dai, posn->flags |= SOF_TIME_DAI_VALID; /* get SSP wallclock - DAI sets this to stream start value */ - posn->wallclock = shim_read(SHIM_EXT_TIMER_STAT) - posn->wallclock; - posn->flags |= SOF_TIME_WALL_VALID; + posn->wallclock = platform_timer_get(platform_timer) - posn->wallclock; + posn->flags |= SOF_TIME_WALL_VALID | SOF_TIME_WALL_64; } /* get current wallclock for componnent */ void platform_dai_wallclock(struct comp_dev *dai, uint64_t *wallclock) { /* only 1 wallclock on BYT */ - *wallclock = shim_read(SHIM_EXT_TIMER_STAT); + *wallclock = platform_timer_get(platform_timer); } static int platform_timer_register(struct timer *timer, -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] ssp: irq: fix handler comment and remove FIFO empty loop
by Liam Girdwood 21 Sep '17

21 Sep '17

Comment is wrong and FIFO empty not needed in IRQ handler. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/drivers/ssp.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/drivers/ssp.c b/src/drivers/ssp.c index b87806e..7538edd 100644 --- a/src/drivers/ssp.c +++ b/src/drivers/ssp.c @@ -370,19 +370,14 @@ static int ssp_trigger(struct dai *dai, int cmd, int direction) return 0; } -/* The IRQ handler allows the SSP port to drain the playback FIFO to make sure - * every sample has been played */ +/* clear IRQ sources atm */ static void ssp_irq_handler(void *data) { struct dai *dai = data; - int i; + trace_ssp("irq"); trace_value(ssp_read(dai, SSSR)); - /* empty Rx FIFO */ - for (i = 0; i < 16; i++) - ssp_read(dai, SSDR); - /* clear IRQ */ ssp_write(dai, SSSR, ssp_read(dai, SSSR)); platform_interrupt_clear(ssp_irq(dai), 1); -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] dai: cache: Make sure we only writeback the amount copied
by Liam Girdwood 21 Sep '17

21 Sep '17

The DAI IRQ hanlder was always writing back full period size even when less data was copied. Only writeback the amount of data copied. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/audio/dai.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/audio/dai.c b/src/audio/dai.c index ebec519..cf8de72 100644 --- a/src/audio/dai.c +++ b/src/audio/dai.c @@ -103,7 +103,7 @@ static void dai_dma_cb(void *data, uint32_t type, struct dma_sg_elem *next) comp_update_buffer_consume(dma_buffer, copied_size); /* writeback buffer contents from cache */ - dcache_writeback_region(dma_buffer->r_ptr, dd->period_bytes); + dcache_writeback_region(dma_buffer->r_ptr, copied_size); /* update host position(in bytes offset) for drivers */ dev->position += copied_size; @@ -498,6 +498,7 @@ static int dai_position(struct comp_dev *dev, struct sof_ipc_stream_posn *posn) /* set stream start wallclock */ posn->wallclock = dd->wallclock; + return 0; } -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] platform: byt: Add support for masking all DMACs and SSPs
by Liam Girdwood 20 Sep '17

20 Sep '17

Add the remaining DMACs and SSP to platform IRQ mask/unmask and clear. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/platform/baytrail/platform.c | 99 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 96 insertions(+), 3 deletions(-) diff --git a/src/platform/baytrail/platform.c b/src/platform/baytrail/platform.c index ce8a689..651c3ce 100644 --- a/src/platform/baytrail/platform.c +++ b/src/platform/baytrail/platform.c @@ -105,6 +105,18 @@ int platform_boot_complete(uint32_t boot_message) void platform_interrupt_clear(uint32_t irq, uint32_t mask) { switch (irq) { + case IRQ_NUM_EXT_SSP0: + shim_write(SHIM_PISR, mask << 3); + interrupt_clear(irq); + break; + case IRQ_NUM_EXT_SSP1: + shim_write(SHIM_PISR, mask << 4); + interrupt_clear(irq); + break; + case IRQ_NUM_EXT_SSP2: + shim_write(SHIM_PISR, mask << 5); + interrupt_clear(irq); + break; case IRQ_NUM_EXT_DMAC0: shim_write(SHIM_PISR, mask << 16); interrupt_clear(irq); @@ -118,6 +130,18 @@ void platform_interrupt_clear(uint32_t irq, uint32_t mask) shim_write(SHIM_PISRH, mask << 0); interrupt_clear(irq); break; + case IRQ_NUM_EXT_SSP3: + shim_write(SHIM_PISRH, mask << 8); + interrupt_clear(irq); + break; + case IRQ_NUM_EXT_SSP4: + shim_write(SHIM_PISRH, mask << 9); + interrupt_clear(irq); + break; + case IRQ_NUM_EXT_SSP5: + shim_write(SHIM_PISRH, mask << 10); + interrupt_clear(irq); + break; #endif default: break; @@ -132,12 +156,76 @@ uint32_t platform_interrupt_get_enabled(void) void platform_interrupt_mask(uint32_t irq, uint32_t mask) { - + switch (irq) { + case IRQ_NUM_EXT_SSP0: + shim_write(SHIM_PIMR, mask << 3); + break; + case IRQ_NUM_EXT_SSP1: + shim_write(SHIM_PIMR, mask << 4); + break; + case IRQ_NUM_EXT_SSP2: + shim_write(SHIM_PIMR, mask << 5); + break; + case IRQ_NUM_EXT_DMAC0: + shim_write(SHIM_PIMR, mask << 16); + break; + case IRQ_NUM_EXT_DMAC1: + shim_write(SHIM_PIMR, mask << 24); + break; +#if defined CONFIG_CHERRYTRAIL + case IRQ_NUM_EXT_DMAC2: + shim_write(SHIM_PISMH, mask << 8); + break; + case IRQ_NUM_EXT_SSP3: + shim_write(SHIM_PIMRH, mask << 0); + break; + case IRQ_NUM_EXT_SSP4: + shim_write(SHIM_PIMRH, mask << 1); + break; + case IRQ_NUM_EXT_SSP5: + shim_write(SHIM_PIMRH, mask << 2); + break; +#endif + default: + break; + } } void platform_interrupt_unmask(uint32_t irq, uint32_t mask) { - + switch (irq) { + case IRQ_NUM_EXT_SSP0: + shim_write(SHIM_PIMR, shim_read(SHIM_PIMR) & ~(mask << 3)); + break; + case IRQ_NUM_EXT_SSP1: + shim_write(SHIM_PIMR, shim_read(SHIM_PIMR) & ~(mask << 4)); + break; + case IRQ_NUM_EXT_SSP2: + shim_write(SHIM_PIMR, shim_read(SHIM_PIMR) & ~(mask << 5)); + break; + case IRQ_NUM_EXT_DMAC0: + shim_write(SHIM_PIMR, shim_read(SHIM_PIMR) & ~(mask << 16)); + break; + case IRQ_NUM_EXT_DMAC1: + shim_write(SHIM_PIMR, shim_read(SHIM_PIMR) & ~(mask << 24)); + break; +#if defined CONFIG_CHERRYTRAIL + case IRQ_NUM_EXT_DMAC2: + shim_write(SHIM_PIMRH, shim_read(SHIM_PIMRH) & ~(mask << 8)); + break; + case IRQ_NUM_EXT_SSP3: + shim_write(SHIM_PIMRH, shim_read(SHIM_PIMRH) & ~(mask << 0)); + break; + case IRQ_NUM_EXT_SSP4: + shim_write(SHIM_PIMRH, shim_read(SHIM_PIMRH) & ~(mask << 1)); + break; + case IRQ_NUM_EXT_SSP5: + shim_write(SHIM_PIMRH, shim_read(SHIM_PIMRH) & ~(mask << 2)); + break; +#endif + default: + break; + } } int platform_init(struct reef *reef) @@ -213,9 +301,14 @@ int platform_init(struct reef *reef) dma_probe(dmac2); #endif - /* mask SSP interrupts */ + /* mask SSP 0 - 2 interrupts */ shim_write(SHIM_PIMR, shim_read(SHIM_PIMR) | 0x00000038); +#if defined CONFIG_CHERRYTRAIL + /* mask SSP 3 - 5 interrupts */ + shim_write(SHIM_PIMRH, shim_read(SHIM_PIMRH) | 0x00000700); +#endif + /* init SSP ports */ trace_point(TRACE_BOOT_PLATFORM_SSP); ssp0 = dai_get(SOF_DAI_INTEL_SSP, 0); -- 2.11.0

2 15

[Sound-open-firmware] [PATCH v2 1/3] interrupt-map: add cpu param for REEF_IRQ generation
by Keyon Jie 20 Sep '17

20 Sep '17

This will be needed for multi-core, add it here. Signed-off-by: Keyon Jie <yang.jie(a)linux.intel.com> --- src/include/reef/interrupt-map.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/include/reef/interrupt-map.h b/src/include/reef/interrupt-map.h index a292279..b968258 100644 --- a/src/include/reef/interrupt-map.h +++ b/src/include/reef/interrupt-map.h @@ -31,6 +31,8 @@ #ifndef __INCLUDE_INTERRUPT_MAP__ #define __INCLUDE_INTERRUPT_MAP__ +#include <config.h> + #define REEF_IRQ_BIT_SHIFT 24 #define REEF_IRQ_LEVEL_SHIFT 16 #define REEF_IRQ_CPU_SHIFT 8 @@ -43,6 +45,7 @@ #define REEF_IRQ(_bit, _level, _cpu, _number) \ ((_bit << REEF_IRQ_BIT_SHIFT) \ | (_level << REEF_IRQ_LEVEL_SHIFT)\ + | (_cpu << REEF_IRQ_CPU_SHIFT)\ | (_number << REEF_IRQ_NUM_SHIFT)) #ifdef CONFIG_IRQ_MAP -- 2.11.0

2 3

[Sound-open-firmware] [PATCH 1/4] Add DMA callback for dma_copy_to_host() and dma_copy_from_host().
by yan.wang＠linux.intel.com 20 Sep '17

20 Sep '17

From: Yan Wang <yan.wang(a)linux.intel.com> It is necessary to add dma callback to set completion_t variable to notify DMA copying is finished. Otherwise it will always enter into error handler. Signed-off-by: Yan Wang <yan.wang(a)linux.intel.com> --- src/ipc/dma-copy.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/ipc/dma-copy.c b/src/ipc/dma-copy.c index b8d27be..d295089 100644 --- a/src/ipc/dma-copy.c +++ b/src/ipc/dma-copy.c @@ -64,6 +64,14 @@ static struct dma_sg_elem *sg_get_elem_at(struct dma_sg_config *host_sg, return NULL; } +static void dma_complete(void *data, uint32_t type, struct dma_sg_elem *next) +{ + completion_t *comp = (completion_t *)data; + + if (type == DMA_IRQ_TYPE_LLIST) + wait_completed(comp); +} + int dma_copy_to_host(struct dma_sg_config *host_sg, int32_t host_offset, void *local_ptr, int32_t size) { @@ -102,6 +110,8 @@ int dma_copy_to_host(struct dma_sg_config *host_sg, int32_t host_offset, local_sg_elem.size = HOST_PAGE_SIZE - offset; list_item_prepend(&local_sg_elem.list, &config.elem_list); + dma_set_cb(dma, chan, DMA_IRQ_TYPE_LLIST, dma_complete, &complete); + /* transfer max PAGE size at a time to SG buffer */ while (size > 0) { @@ -179,6 +189,8 @@ int dma_copy_from_host(struct dma_sg_config *host_sg, int32_t host_offset, local_sg_elem.size = HOST_PAGE_SIZE - offset; list_item_prepend(&local_sg_elem.list, &config.elem_list); + dma_set_cb(dma, chan, DMA_IRQ_TYPE_LLIST, dma_complete, &complete); + /* transfer max PAGE size at a time to SG buffer */ while (size > 0) { -- 2.7.4

2 1

[Sound-open-firmware] [PATCH 1/5] SRC: Remove old coefficient set with bug
by Seppo Ingalsuo 20 Sep '17

20 Sep '17

This set prevented passtrough conversions to work, e.g. 48 kHz to 48 kHz due to a bug in table. This set is replaced with coefficients with a profile keyword to help selecting suitable set for a platform. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo(a)linux.intel.com> --- .../coefficients/src/src_int16_1_3_4375_5000.h | 251 ----- .../coefficients/src/src_int16_20_21_4020_5000.h | 1066 -------------------- .../coefficients/src/src_int16_21_20_4020_5000.h | 1056 ------------------- .../coefficients/src/src_int16_3_1_4375_5000.h | 252 ----- .../coefficients/src/src_int16_7_8_4375_5000.h | 657 ------------ .../coefficients/src/src_int16_8_7_4375_5000.h | 662 ------------ .../reef/audio/coefficients/src/src_int16_define.h | 11 - .../reef/audio/coefficients/src/src_int16_table.h | 32 - 8 files changed, 3987 deletions(-) delete mode 100644 src/include/reef/audio/coefficients/src/src_int16_1_3_4375_5000.h delete mode 100644 src/include/reef/audio/coefficients/src/src_int16_20_21_4020_5000.h delete mode 100644 src/include/reef/audio/coefficients/src/src_int16_21_20_4020_5000.h delete mode 100644 src/include/reef/audio/coefficients/src/src_int16_3_1_4375_5000.h delete mode 100644 src/include/reef/audio/coefficients/src/src_int16_7_8_4375_5000.h delete mode 100644 src/include/reef/audio/coefficients/src/src_int16_8_7_4375_5000.h delete mode 100644 src/include/reef/audio/coefficients/src/src_int16_define.h delete mode 100644 src/include/reef/audio/coefficients/src/src_int16_table.h diff --git a/src/include/reef/audio/coefficients/src/src_int16_1_3_4375_5000.h b/src/include/reef/audio/coefficients/src/src_int16_1_3_4375_5000.h deleted file mode 100644 index 34e177c..0000000 --- a/src/include/reef/audio/coefficients/src/src_int16_1_3_4375_5000.h +++ /dev/null @@ -1,251 +0,0 @@ -const int16_t src_int16_1_3_4375_5000_fir[245] = { - 0, - 0, - -1, - 0, - 1, - 1, - 1, - -1, - -2, - -1, - 1, - 3, - 2, - 0, - -4, - -4, - 0, - 4, - 6, - 2, - -5, - -8, - -4, - 5, - 11, - 7, - -4, - -13, - -12, - 1, - 16, - 17, - 2, - -17, - -23, - -8, - 17, - 30, - 16, - -15, - -37, - -26, - 10, - 42, - 39, - -2, - -46, - -52, - -10, - 47, - 67, - 26, - -44, - -82, - -47, - 36, - 95, - 72, - -21, - -104, - -100, - -1, - 109, - 129, - 31, - -106, - -159, - -69, - 94, - 187, - 115, - -71, - -210, - -167, - 35, - 225, - 225, - 16, - -228, - -284, - -82, - 216, - 342, - 163, - -184, - -395, - -259, - 130, - 437, - 368, - -49, - -463, - -489, - -62, - 467, - 616, - 208, - -439, - -748, - -393, - 372, - 880, - 624, - -252, - -1007, - -914, - 60, - 1125, - 1285, - 240, - -1228, - -1791, - -720, - 1313, - 2565, - 1582, - -1377, - -4078, - -3627, - 1416, - 9650, - 17303, - 20414, - 17303, - 9650, - 1416, - -3627, - -4078, - -1377, - 1582, - 2565, - 1313, - -720, - -1791, - -1228, - 240, - 1285, - 1125, - 60, - -914, - -1007, - -252, - 624, - 880, - 372, - -393, - -748, - -439, - 208, - 616, - 467, - -62, - -489, - -463, - -49, - 368, - 437, - 130, - -259, - -395, - -184, - 163, - 342, - 216, - -82, - -284, - -228, - 16, - 225, - 225, - 35, - -167, - -210, - -71, - 115, - 187, - 94, - -69, - -159, - -106, - 31, - 129, - 109, - -1, - -100, - -104, - -21, - 72, - 95, - 36, - -47, - -82, - -44, - 26, - 67, - 47, - -10, - -52, - -46, - -2, - 39, - 42, - 10, - -26, - -37, - -15, - 16, - 30, - 17, - -8, - -23, - -17, - 2, - 17, - 16, - 1, - -12, - -13, - -4, - 7, - 11, - 5, - -4, - -8, - -5, - 2, - 6, - 4, - 0, - -4, - -4, - 0, - 2, - 3, - 1, - -1, - -2, - -1, - 1, - 1, - 1, - 0, - -1, - 0, - 0 - -}; -struct src_stage src_int16_1_3_4375_5000 = { - 1, 0, 1, 245, 245, 3, 1, 0, 1, - src_int16_1_3_4375_5000_fir}; diff --git a/src/include/reef/audio/coefficients/src/src_int16_20_21_4020_5000.h b/src/include/reef/audio/coefficients/src/src_int16_20_21_4020_5000.h deleted file mode 100644 index 51aade7..0000000 --- a/src/include/reef/audio/coefficients/src/src_int16_20_21_4020_5000.h +++ /dev/null @@ -1,1066 +0,0 @@ -const int16_t src_int16_20_21_4020_5000_fir[1060] = { - 1, - -2, - 2, - 1, - -8, - 19, - -34, - 46, - -47, - 28, - 20, - -96, - 188, - -274, - 316, - -277, - 125, - 150, - -525, - 939, - -1288, - 1439, - -1233, - 472, - 1182, - -4843, - 21640, - 18847, - -5651, - 2095, - -277, - -717, - 1157, - -1205, - 997, - -663, - 311, - -18, - -175, - 261, - -260, - 203, - -125, - 51, - 3, - -31, - 38, - -32, - 21, - -10, - 3, - 0, - -1, - 1, - -2, - 2, - 0, - -6, - 18, - -34, - 49, - -54, - 40, - 3, - -78, - 175, - -273, - 336, - -323, - 197, - 61, - -439, - 882, - -1296, - 1547, - -1470, - 856, - 658, - -4253, - 22894, - 17336, - -5873, - 2472, - -629, - -447, - 989, - -1132, - 999, - -713, - 382, - -88, - -120, - 228, - -247, - 205, - -135, - 64, - -9, - -23, - 34, - -31, - 21, - -11, - 4, - 0, - -1, - 1, - -2, - 3, - -2, - -4, - 16, - -33, - 51, - -61, - 52, - -14, - -58, - 159, - -268, - 351, - -364, - 266, - -30, - -343, - 808, - -1280, - 1629, - -1687, - 1237, - 97, - -3539, - 24033, - 15769, - -5978, - 2790, - -960, - -177, - 807, - -1040, - 983, - -749, - 444, - -155, - -64, - 191, - -229, - 203, - -143, - 76, - -21, - -14, - 29, - -29, - 21, - -12, - 5, - -1, - -1, - 1, - -3, - 4, - -3, - -2, - 14, - -32, - 52, - -66, - 63, - -32, - -37, - 139, - -257, - 359, - -400, - 333, - -123, - -238, - 718, - -1241, - 1683, - -1879, - 1608, - -491, - -2701, - 25047, - 14163, - -5972, - 3046, - -1263, - 89, - 616, - -932, - 950, - -771, - 497, - -217, - -9, - 151, - -208, - 198, - -148, - 86, - -32, - -5, - 23, - -26, - 20, - -12, - 5, - -1, - 0, - 1, - -3, - 4, - -4, - 0, - 11, - -29, - 52, - -70, - 74, - -49, - -14, - 115, - -241, - 361, - -428, - 394, - -215, - -127, - 613, - -1178, - 1708, - -2042, - 1962, - -1097, - -1745, - 25925, - 12534, - -5861, - 3238, - -1534, - 347, - 417, - -810, - 900, - -778, - 540, - -274, - 46, - 109, - -183, - 189, - -151, - 95, - -41, - 3, - 18, - -23, - 19, - -12, - 6, - -2, - 0, - 1, - -3, - 5, - -6, - 2, - 8, - -27, - 51, - -74, - 83, - -66, - 10, - 90, - -221, - 356, - -450, - 450, - -306, - -11, - 494, - -1092, - 1703, - -2173, - 2293, - -1713, - -675, - 26656, - 10897, - -5655, - 3365, - -1770, - 591, - 216, - -676, - 836, - -771, - 573, - -326, - 98, - 67, - -156, - 177, - -150, - 101, - -50, - 11, - 12, - -20, - 18, - -12, - 6, - -2, - 0, - 1, - -3, - 5, - -7, - 4, - 5, - -23, - 49, - -76, - 92, - -82, - 33, - 62, - -196, - 344, - -464, - 498, - -393, - 108, - 364, - -984, - 1666, - -2267, - 2593, - -2327, - 502, - 27233, - 9269, - -5360, - 3428, - -1968, - 819, - 16, - -532, - 757, - -751, - 594, - -370, - 148, - 24, - -127, - 162, - -147, - 106, - -58, - 19, - 6, - -16, - 17, - -12, - 6, - -2, - 0, - 1, - -3, - 6, - -8, - 6, - 2, - -20, - 46, - -76, - 98, - -97, - 57, - 32, - -167, - 326, - -469, - 539, - -475, - 228, - 224, - -856, - 1597, - -2323, - 2856, - -2928, - 1779, - 27649, - 7665, - -4988, - 3428, - -2124, - 1027, - -180, - -383, - 667, - -718, - 604, - -406, - 194, - -18, - -96, - 145, - -142, - 108, - -64, - 26, - 0, - -13, - 15, - -12, - 7, - -3, - 1, - 1, - -3, - 6, - -9, - 9, - -2, - -15, - 42, - -75, - 104, - -111, - 81, - 0, - -134, - 302, - -466, - 570, - -550, - 345, - 76, - -709, - 1498, - -2337, - 3076, - -3506, - 3145, - 27901, - 6101, - -4547, - 3367, - -2238, - 1211, - -368, - -230, - 567, - -672, - 604, - -435, - 235, - -59, - -64, - 125, - -134, - 109, - -70, - 32, - -5, - -9, - 13, - -11, - 7, - -3, - 1, - 1, - -3, - 6, - -10, - 11, - -5, - -10, - 38, - -73, - 107, - -123, - 104, - -32, - -98, - 271, - -455, - 592, - -616, - 459, - -76, - -546, - 1368, - -2309, - 3248, - -4050, - 4589, - 27985, - 4589, - -4050, - 3248, - -2309, - 1368, - -546, - -76, - 459, - -616, - 592, - -455, - 271, - -98, - -32, - 104, - -123, - 107, - -73, - 38, - -10, - -5, - 11, - -10, - 6, - -3, - 1, - 1, - -3, - 7, - -11, - 13, - -9, - -5, - 32, - -70, - 109, - -134, - 125, - -64, - -59, - 235, - -435, - 604, - -672, - 567, - -230, - -368, - 1211, - -2238, - 3367, - -4547, - 6101, - 27901, - 3145, - -3506, - 3076, - -2337, - 1498, - -709, - 76, - 345, - -550, - 570, - -466, - 302, - -134, - 0, - 81, - -111, - 104, - -75, - 42, - -15, - -2, - 9, - -9, - 6, - -3, - 1, - 1, - -3, - 7, - -12, - 15, - -13, - 0, - 26, - -64, - 108, - -142, - 145, - -96, - -18, - 194, - -406, - 604, - -718, - 667, - -383, - -180, - 1027, - -2124, - 3428, - -4988, - 7665, - 27649, - 1779, - -2928, - 2856, - -2323, - 1597, - -856, - 224, - 228, - -475, - 539, - -469, - 326, - -167, - 32, - 57, - -97, - 98, - -76, - 46, - -20, - 2, - 6, - -8, - 6, - -3, - 1, - 0, - -2, - 6, - -12, - 17, - -16, - 6, - 19, - -58, - 106, - -147, - 162, - -127, - 24, - 148, - -370, - 594, - -751, - 757, - -532, - 16, - 819, - -1968, - 3428, - -5360, - 9269, - 27233, - 502, - -2327, - 2593, - -2267, - 1666, - -984, - 364, - 108, - -393, - 498, - -464, - 344, - -196, - 62, - 33, - -82, - 92, - -76, - 49, - -23, - 5, - 4, - -7, - 5, - -3, - 1, - 0, - -2, - 6, - -12, - 18, - -20, - 12, - 11, - -50, - 101, - -150, - 177, - -156, - 67, - 98, - -326, - 573, - -771, - 836, - -676, - 216, - 591, - -1770, - 3365, - -5655, - 10897, - 26656, - -675, - -1713, - 2293, - -2173, - 1703, - -1092, - 494, - -11, - -306, - 450, - -450, - 356, - -221, - 90, - 10, - -66, - 83, - -74, - 51, - -27, - 8, - 2, - -6, - 5, - -3, - 1, - 0, - -2, - 6, - -12, - 19, - -23, - 18, - 3, - -41, - 95, - -151, - 189, - -183, - 109, - 46, - -274, - 540, - -778, - 900, - -810, - 417, - 347, - -1534, - 3238, - -5861, - 12534, - 25925, - -1745, - -1097, - 1962, - -2042, - 1708, - -1178, - 613, - -127, - -215, - 394, - -428, - 361, - -241, - 115, - -14, - -49, - 74, - -70, - 52, - -29, - 11, - 0, - -4, - 4, - -3, - 1, - 0, - -1, - 5, - -12, - 20, - -26, - 23, - -5, - -32, - 86, - -148, - 198, - -208, - 151, - -9, - -217, - 497, - -771, - 950, - -932, - 616, - 89, - -1263, - 3046, - -5972, - 14163, - 25047, - -2701, - -491, - 1608, - -1879, - 1683, - -1241, - 718, - -238, - -123, - 333, - -400, - 359, - -257, - 139, - -37, - -32, - 63, - -66, - 52, - -32, - 14, - -2, - -3, - 4, - -3, - 1, - -1, - -1, - 5, - -12, - 21, - -29, - 29, - -14, - -21, - 76, - -143, - 203, - -229, - 191, - -64, - -155, - 444, - -749, - 983, - -1040, - 807, - -177, - -960, - 2790, - -5978, - 15769, - 24033, - -3539, - 97, - 1237, - -1687, - 1629, - -1280, - 808, - -343, - -30, - 266, - -364, - 351, - -268, - 159, - -58, - -14, - 52, - -61, - 51, - -33, - 16, - -4, - -2, - 3, - -2, - 1, - -1, - 0, - 4, - -11, - 21, - -31, - 34, - -23, - -9, - 64, - -135, - 205, - -247, - 228, - -120, - -88, - 382, - -713, - 999, - -1132, - 989, - -447, - -629, - 2472, - -5873, - 17336, - 22894, - -4253, - 658, - 856, - -1470, - 1547, - -1296, - 882, - -439, - 61, - 197, - -323, - 336, - -273, - 175, - -78, - 3, - 40, - -54, - 49, - -34, - 18, - -6, - 0, - 2, - -2, - 1, - -1, - 0, - 3, - -10, - 21, - -32, - 38, - -31, - 3, - 51, - -125, - 203, - -260, - 261, - -175, - -18, - 311, - -663, - 997, - -1205, - 1157, - -717, - -277, - 2095, - -5651, - 18847, - 21640, - -4843, - 1182, - 472, - -1233, - 1439, - -1288, - 939, - -525, - 150, - 125, - -277, - 316, - -274, - 188, - -96, - 20, - 28, - -47, - 46, - -34, - 19, - -8, - 1, - 2, - -2, - 1, - -1, - 1, - 2, - -9, - 20, - -33, - 43, - -39, - 15, - 36, - -111, - 198, - -269, - 291, - -228, - 53, - 233, - -600, - 977, - -1257, - 1308, - -980, - 93, - 1663, - -5309, - 20286, - 20286, - -5309, - 1663, - 93, - -980, - 1308, - -1257, - 977, - -600, - 233, - 53, - -228, - 291, - -269, - 198, - -111, - 36, - 15, - -39, - 43, - -33, - 20, - -9, - 2, - 1, - -1, - 0 - -}; -struct src_stage src_int16_20_21_4020_5000 = { - 1, 1, 20, 53, 1060, 21, 20, 0, 0, - src_int16_20_21_4020_5000_fir}; diff --git a/src/include/reef/audio/coefficients/src/src_int16_21_20_4020_5000.h b/src/include/reef/audio/coefficients/src/src_int16_21_20_4020_5000.h deleted file mode 100644 index 678ed4f..0000000 --- a/src/include/reef/audio/coefficients/src/src_int16_21_20_4020_5000.h +++ /dev/null @@ -1,1056 +0,0 @@ -const int16_t src_int16_21_20_4020_5000_fir[1050] = { - 1, - -3, - 5, - -9, - 11, - -9, - 0, - 19, - -51, - 96, - -151, - 208, - -253, - 270, - -235, - 130, - 64, - -357, - 750, - -1232, - 1783, - -2376, - 2996, - -3680, - 4818, - 29296, - 1867, - -2442, - 2405, - -2140, - 1762, - -1339, - 921, - -547, - 243, - -19, - -124, - 196, - -213, - 193, - -153, - 107, - -65, - 32, - -10, - -2, - 6, - -6, - 5, - -2, - 1, - -3, - 6, - -9, - 13, - -13, - 6, - 11, - -42, - 87, - -146, - 210, - -267, - 300, - -287, - 204, - -31, - -248, - 640, - -1142, - 1744, - -2434, - 3227, - -4251, - 6405, - 29032, - 527, - -1798, - 2058, - -1969, - 1705, - -1355, - 980, - -626, - 324, - -91, - -66, - 155, - -188, - 181, - -150, - 109, - -70, - 38, - -15, - 2, - 4, - -5, - 4, - -2, - 1, - -3, - 6, - -10, - 14, - -16, - 12, - 3, - -32, - 77, - -138, - 208, - -277, - 326, - -335, - 276, - -128, - -132, - 516, - -1030, - 1672, - -2450, - 3408, - -4773, - 8048, - 28594, - -709, - -1152, - 1686, - -1768, - 1619, - -1346, - 1020, - -691, - 397, - -160, - -9, - 113, - -160, - 166, - -144, - 110, - -73, - 42, - -19, - 5, - 2, - -4, - 3, - -2, - 1, - -3, - 6, - -11, - 16, - -20, - 17, - -5, - -21, - 65, - -127, - 202, - -281, - 347, - -377, - 345, - -224, - -11, - 380, - -895, - 1568, - -2421, - 3532, - -5235, - 9732, - 27989, - -1832, - -515, - 1297, - -1541, - 1506, - -1314, - 1041, - -743, - 462, - -225, - 47, - 69, - -130, - 148, - -136, - 108, - -76, - 46, - -23, - 8, - 0, - -3, - 3, - -2, - 1, - -3, - 6, - -11, - 18, - -23, - 23, - -14, - -9, - 51, - -113, - 193, - -281, - 362, - -414, - 409, - -318, - 113, - 233, - -742, - 1433, - -2346, - 3596, - -5626, - 11441, - 27221, - -2836, - 102, - 898, - -1292, - 1369, - -1259, - 1043, - -780, - 517, - -284, - 102, - 25, - -98, - 128, - -125, - 105, - -76, - 49, - -26, - 11, - -2, - -2, - 2, - -2, - 1, - -2, - 6, - -12, - 19, - -26, - 28, - -23, - 3, - 36, - -97, - 179, - -275, - 370, - -443, - 467, - -409, - 237, - 80, - -571, - 1268, - -2227, - 3596, - -5935, - 13160, - 26300, - -3715, - 690, - 495, - -1027, - 1211, - -1183, - 1026, - -802, - 561, - -337, - 153, - -18, - -66, - 106, - -113, - 99, - -76, - 51, - -29, - 13, - -4, - 0, - 2, - -1, - 0, - -2, - 6, - -12, - 20, - -28, - 34, - -31, - 15, - 20, - -79, - 162, - -264, - 372, - -466, - 517, - -494, - 360, - -79, - -385, - 1075, - -2063, - 3531, - -6153, - 14870, - 25235, - -4465, - 1240, - 97, - -751, - 1035, - -1087, - 991, - -810, - 595, - -383, - 200, - -60, - -32, - 83, - -99, - 93, - -74, - 51, - -31, - 16, - -6, - 1, - 1, - -1, - 0, - -2, - 5, - -12, - 20, - -30, - 38, - -39, - 28, - 3, - -59, - 142, - -248, - 367, - -480, - 559, - -572, - 479, - -240, - -189, - 858, - -1856, - 3397, - -6268, - 16557, - 24038, - -5085, - 1745, - -290, - -469, - 845, - -974, - 939, - -803, - 617, - -421, - 243, - -100, - 0, - 59, - -84, - 84, - -71, - 51, - -32, - 17, - -7, - 2, - 0, - -1, - 0, - -2, - 5, - -11, - 20, - -32, - 42, - -47, - 40, - -14, - -37, - 118, - -227, - 355, - -486, - 592, - -641, - 592, - -400, - 16, - 619, - -1609, - 3196, - -6275, - 18202, - 22722, - -5573, - 2198, - -660, - -186, - 644, - -846, - 872, - -782, - 628, - -450, - 280, - -138, - 32, - 34, - -67, - 75, - -66, - 50, - -33, - 19, - -9, - 3, - 0, - 0, - 0, - -1, - 4, - -11, - 20, - -33, - 46, - -54, - 52, - -32, - -14, - 92, - -201, - 337, - -483, - 615, - -700, - 696, - -556, - 226, - 363, - -1324, - 2927, - -6165, - 19788, - 21300, - -5932, - 2594, - -1006, - 93, - 437, - -706, - 790, - -747, - 627, - -471, - 312, - -172, - 63, - 10, - -50, - 64, - -61, - 48, - -33, - 20, - -10, - 4, - -1, - 0, - 0, - -1, - 4, - -10, - 20, - -33, - 48, - -61, - 64, - -50, - 10, - 63, - -172, - 312, - -471, - 627, - -747, - 790, - -706, - 437, - 93, - -1006, - 2594, - -5932, - 21300, - 19788, - -6165, - 2927, - -1324, - 363, - 226, - -556, - 696, - -700, - 615, - -483, - 337, - -201, - 92, - -14, - -32, - 52, - -54, - 46, - -33, - 20, - -11, - 4, - -1, - 0, - 0, - 0, - 3, - -9, - 19, - -33, - 50, - -66, - 75, - -67, - 34, - 32, - -138, - 280, - -450, - 628, - -782, - 872, - -846, - 644, - -186, - -660, - 2198, - -5573, - 22722, - 18202, - -6275, - 3196, - -1609, - 619, - 16, - -400, - 592, - -641, - 592, - -486, - 355, - -227, - 118, - -37, - -14, - 40, - -47, - 42, - -32, - 20, - -11, - 5, - -2, - 0, - -1, - 0, - 2, - -7, - 17, - -32, - 51, - -71, - 84, - -84, - 59, - 0, - -100, - 243, - -421, - 617, - -803, - 939, - -974, - 845, - -469, - -290, - 1745, - -5085, - 24038, - 16557, - -6268, - 3397, - -1856, - 858, - -189, - -240, - 479, - -572, - 559, - -480, - 367, - -248, - 142, - -59, - 3, - 28, - -39, - 38, - -30, - 20, - -12, - 5, - -2, - 0, - -1, - 1, - 1, - -6, - 16, - -31, - 51, - -74, - 93, - -99, - 83, - -32, - -60, - 200, - -383, - 595, - -810, - 991, - -1087, - 1035, - -751, - 97, - 1240, - -4465, - 25235, - 14870, - -6153, - 3531, - -2063, - 1075, - -385, - -79, - 360, - -494, - 517, - -466, - 372, - -264, - 162, - -79, - 20, - 15, - -31, - 34, - -28, - 20, - -12, - 6, - -2, - 0, - -1, - 2, - 0, - -4, - 13, - -29, - 51, - -76, - 99, - -113, - 106, - -66, - -18, - 153, - -337, - 561, - -802, - 1026, - -1183, - 1211, - -1027, - 495, - 690, - -3715, - 26300, - 13160, - -5935, - 3596, - -2227, - 1268, - -571, - 80, - 237, - -409, - 467, - -443, - 370, - -275, - 179, - -97, - 36, - 3, - -23, - 28, - -26, - 19, - -12, - 6, - -2, - 1, - -2, - 2, - -2, - -2, - 11, - -26, - 49, - -76, - 105, - -125, - 128, - -98, - 25, - 102, - -284, - 517, - -780, - 1043, - -1259, - 1369, - -1292, - 898, - 102, - -2836, - 27221, - 11441, - -5626, - 3596, - -2346, - 1433, - -742, - 233, - 113, - -318, - 409, - -414, - 362, - -281, - 193, - -113, - 51, - -9, - -14, - 23, - -23, - 18, - -11, - 6, - -3, - 1, - -2, - 3, - -3, - 0, - 8, - -23, - 46, - -76, - 108, - -136, - 148, - -130, - 69, - 47, - -225, - 462, - -743, - 1041, - -1314, - 1506, - -1541, - 1297, - -515, - -1832, - 27989, - 9732, - -5235, - 3532, - -2421, - 1568, - -895, - 380, - -11, - -224, - 345, - -377, - 347, - -281, - 202, - -127, - 65, - -21, - -5, - 17, - -20, - 16, - -11, - 6, - -3, - 1, - -2, - 3, - -4, - 2, - 5, - -19, - 42, - -73, - 110, - -144, - 166, - -160, - 113, - -9, - -160, - 397, - -691, - 1020, - -1346, - 1619, - -1768, - 1686, - -1152, - -709, - 28594, - 8048, - -4773, - 3408, - -2450, - 1672, - -1030, - 516, - -132, - -128, - 276, - -335, - 326, - -277, - 208, - -138, - 77, - -32, - 3, - 12, - -16, - 14, - -10, - 6, - -3, - 1, - -2, - 4, - -5, - 4, - 2, - -15, - 38, - -70, - 109, - -150, - 181, - -188, - 155, - -66, - -91, - 324, - -626, - 980, - -1355, - 1705, - -1969, - 2058, - -1798, - 527, - 29032, - 6405, - -4251, - 3227, - -2434, - 1744, - -1142, - 640, - -248, - -31, - 204, - -287, - 300, - -267, - 210, - -146, - 87, - -42, - 11, - 6, - -13, - 13, - -9, - 6, - -3, - 1, - -2, - 5, - -6, - 6, - -2, - -10, - 32, - -65, - 107, - -153, - 193, - -213, - 196, - -124, - -19, - 243, - -547, - 921, - -1339, - 1762, - -2140, - 2405, - -2442, - 1867, - 29296, - 4818, - -3680, - 2996, - -2376, - 1783, - -1232, - 750, - -357, - 64, - 130, - -235, - 270, - -253, - 208, - -151, - 96, - -51, - 19, - 0, - -9, - 11, - -9, - 5, - -3, - 1, - -3, - 5, - -8, - 8, - -5, - -5, - 26, - -58, - 102, - -153, - 202, - -235, - 235, - -181, - 55, - 156, - -457, - 844, - -1298, - 1788, - -2277, - 2720, - -3073, - 3302, - 29385, - 3302, - -3073, - 2720, - -2277, - 1788, - -1298, - 844, - -457, - 156, - 55, - -181, - 235, - -235, - 202, - -153, - 102, - -58, - 26, - -5, - -5, - 8, - -8, - 5, - -3, - 0 - -}; -struct src_stage src_int16_21_20_4020_5000 = { - 19, 20, 21, 50, 1050, 20, 21, 0, 0, - src_int16_21_20_4020_5000_fir}; diff --git a/src/include/reef/audio/coefficients/src/src_int16_3_1_4375_5000.h b/src/include/reef/audio/coefficients/src/src_int16_3_1_4375_5000.h deleted file mode 100644 index a8d5813..0000000 --- a/src/include/reef/audio/coefficients/src/src_int16_3_1_4375_5000.h +++ /dev/null @@ -1,252 +0,0 @@ -const int16_t src_int16_3_1_4375_5000_fir[246] = { - 0, - -1, - 2, - -3, - 4, - -7, - 9, - -11, - 13, - -15, - 14, - -12, - 7, - 2, - -15, - 33, - -55, - 82, - -112, - 143, - -175, - 204, - -226, - 239, - -237, - 218, - -176, - 108, - -11, - -118, - 281, - -478, - 711, - -979, - 1286, - -1636, - 2044, - -2544, - 3231, - -4424, - 8001, - 29412, - -2495, - 372, - 409, - -786, - 974, - -1051, - 1053, - -1004, - 919, - -810, - 688, - -560, - 434, - -316, - 209, - -117, - 41, - 18, - -61, - 90, - -106, - 111, - -107, - 98, - -85, - 70, - -55, - 41, - -28, - 18, - -10, - 4, - 0, - -2, - 3, - -3, - 3, - -2, - 2, - -1, - 0, - 0, - 0, - -1, - 2, - -4, - 7, - -11, - 16, - -22, - 29, - -35, - 41, - -44, - 45, - -40, - 30, - -13, - -12, - 46, - -89, - 140, - -198, - 260, - -323, - 384, - -436, - 473, - -489, - 477, - -428, - 333, - -183, - -36, - 339, - -755, - 1332, - -2180, - 3582, - -6592, - 20737, - 20737, - -6592, - 3582, - -2180, - 1332, - -755, - 339, - -36, - -183, - 333, - -428, - 477, - -489, - 473, - -436, - 384, - -323, - 260, - -198, - 140, - -89, - 46, - -12, - -13, - 30, - -40, - 45, - -44, - 41, - -35, - 29, - -22, - 16, - -11, - 7, - -4, - 2, - -1, - 0, - 0, - 0, - -1, - 2, - -2, - 3, - -3, - 3, - -2, - 0, - 4, - -10, - 18, - -28, - 41, - -55, - 70, - -85, - 98, - -107, - 111, - -106, - 90, - -61, - 18, - 41, - -117, - 209, - -316, - 434, - -560, - 688, - -810, - 919, - -1004, - 1053, - -1051, - 974, - -786, - 409, - 372, - -2495, - 29412, - 8001, - -4424, - 3231, - -2544, - 2044, - -1636, - 1286, - -979, - 711, - -478, - 281, - -118, - -11, - 108, - -176, - 218, - -237, - 239, - -226, - 204, - -175, - 143, - -112, - 82, - -55, - 33, - -15, - 2, - 7, - -12, - 14, - -15, - 13, - -11, - 9, - -7, - 4, - -3, - 2, - -1, - 0 - -}; -struct src_stage src_int16_3_1_4375_5000 = { - 0, 1, 3, 82, 246, 1, 3, 0, 0, - src_int16_3_1_4375_5000_fir}; diff --git a/src/include/reef/audio/coefficients/src/src_int16_7_8_4375_5000.h b/src/include/reef/audio/coefficients/src/src_int16_7_8_4375_5000.h deleted file mode 100644 index 4b0eb73..0000000 --- a/src/include/reef/audio/coefficients/src/src_int16_7_8_4375_5000.h +++ /dev/null @@ -1,657 +0,0 @@ -const int16_t src_int16_7_8_4375_5000_fir[651] = { - 0, - 0, - 0, - -2, - 4, - -5, - 4, - 0, - -7, - 14, - -19, - 16, - -5, - -14, - 36, - -50, - 49, - -25, - -17, - 68, - -108, - 117, - -81, - 0, - 106, - -200, - 242, - -199, - 66, - 130, - -329, - 452, - -431, - 235, - 106, - -502, - 816, - -902, - 656, - -61, - -786, - 1673, - -2295, - 2280, - -1124, - -2459, - 23097, - 16168, - -5503, - 1769, - 321, - -1397, - 1681, - -1391, - 780, - -103, - -434, - 711, - -708, - 489, - -168, - -135, - 332, - -384, - 307, - -151, - -18, - 144, - -198, - 178, - -108, - 20, - 52, - -91, - 91, - -63, - 23, - 13, - -35, - 39, - -30, - 15, - 0, - -10, - 13, - -11, - 6, - -1, - -2, - 3, - -2, - 1, - 0, - -1, - 1, - 0, - -1, - 3, - -5, - 6, - -3, - -3, - 12, - -19, - 22, - -15, - -2, - 26, - -48, - 59, - -48, - 13, - 41, - -96, - 130, - -121, - 61, - 43, - -160, - 247, - -260, - 174, - 4, - -229, - 425, - -508, - 414, - -132, - -282, - 706, - -980, - 952, - -531, - -271, - 1315, - -2341, - 2983, - -2730, - 328, - 25336, - 12012, - -5744, - 2742, - -665, - -691, - 1357, - -1419, - 1047, - -464, - -112, - 517, - -672, - 587, - -340, - 42, - 205, - -337, - 336, - -231, - 78, - 66, - -157, - 179, - -141, - 67, - 9, - -64, - 85, - -74, - 43, - -8, - -20, - 33, - -32, - 21, - -7, - -4, - 10, - -11, - 8, - -3, - 0, - 2, - -2, - 1, - -1, - -1, - 1, - -1, - 0, - 3, - -6, - 7, - -6, - 1, - 8, - -18, - 25, - -24, - 11, - 12, - -40, - 62, - -65, - 42, - 7, - -70, - 125, - -147, - 116, - -28, - -97, - 219, - -288, - 263, - -128, - -95, - 341, - -520, - 544, - -361, - -15, - 496, - -929, - 1132, - -951, - 308, - 756, - -2069, - 3342, - -4177, - 3814, - 26503, - 7795, - -5248, - 3273, - -1492, - 59, - 876, - -1263, - 1168, - -751, - 212, - 263, - -550, - 605, - -462, - 208, - 56, - -247, - 320, - -279, - 160, - -18, - -98, - 157, - -154, - 104, - -34, - -30, - 67, - -74, - 56, - -26, - -4, - 24, - -30, - 25, - -14, - 2, - 6, - -9, - 8, - -5, - 1, - 1, - -2, - 1, - -1, - -1, - 1, - -2, - 1, - 1, - -5, - 8, - -9, - 6, - 2, - -14, - 25, - -30, - 24, - -4, - -26, - 56, - -74, - 67, - -30, - -34, - 104, - -154, - 157, - -98, - -18, - 160, - -279, - 320, - -247, - 56, - 208, - -462, - 605, - -550, - 263, - 212, - -751, - 1168, - -1263, - 876, - 59, - -1492, - 3273, - -5248, - 7795, - 26503, - 3814, - -4177, - 3342, - -2069, - 756, - 308, - -951, - 1132, - -929, - 496, - -15, - -361, - 544, - -520, - 341, - -95, - -128, - 263, - -288, - 219, - -97, - -28, - 116, - -147, - 125, - -70, - 7, - 42, - -65, - 62, - -40, - 12, - 11, - -24, - 25, - -18, - 8, - 1, - -6, - 7, - -6, - 3, - 0, - -1, - 1, - -1, - -1, - 1, - -2, - 2, - 0, - -3, - 8, - -11, - 10, - -4, - -7, - 21, - -32, - 33, - -20, - -8, - 43, - -74, - 85, - -64, - 9, - 67, - -141, - 179, - -157, - 66, - 78, - -231, - 336, - -337, - 205, - 42, - -340, - 587, - -672, - 517, - -112, - -464, - 1047, - -1419, - 1357, - -691, - -665, - 2742, - -5744, - 12012, - 25336, - 328, - -2730, - 2983, - -2341, - 1315, - -271, - -531, - 952, - -980, - 706, - -282, - -132, - 414, - -508, - 425, - -229, - 4, - 174, - -260, - 247, - -160, - 43, - 61, - -121, - 130, - -96, - 41, - 13, - -48, - 59, - -48, - 26, - -2, - -15, - 22, - -19, - 12, - -3, - -3, - 6, - -5, - 3, - -1, - 0, - 1, - -1, - 0, - 1, - -2, - 3, - -2, - -1, - 6, - -11, - 13, - -10, - 0, - 15, - -30, - 39, - -35, - 13, - 23, - -63, - 91, - -91, - 52, - 20, - -108, - 178, - -198, - 144, - -18, - -151, - 307, - -384, - 332, - -135, - -168, - 489, - -708, - 711, - -434, - -103, - 780, - -1391, - 1681, - -1397, - 321, - 1769, - -5503, - 16168, - 23097, - -2459, - -1124, - 2280, - -2295, - 1673, - -786, - -61, - 656, - -902, - 816, - -502, - 106, - 235, - -431, - 452, - -329, - 130, - 66, - -199, - 242, - -200, - 106, - 0, - -81, - 117, - -108, - 68, - -17, - -25, - 49, - -50, - 36, - -14, - -5, - 16, - -19, - 14, - -7, - 0, - 4, - -5, - 4, - -2, - 0, - 0, - 0, - 0, - 1, - -2, - 4, - -3, - 1, - 4, - -10, - 15, - -15, - 9, - 6, - -24, - 40, - -45, - 32, - -1, - -44, - 86, - -106, - 90, - -31, - -59, - 153, - -213, - 206, - -114, - -48, - 236, - -382, - 418, - -300, - 32, - 322, - -650, - 816, - -710, - 288, - 395, - -1173, - 1796, - -1960, - 1348, - 436, - -4418, - 19959, - 19959, - -4418, - 436, - 1348, - -1960, - 1796, - -1173, - 395, - 288, - -710, - 816, - -650, - 322, - 32, - -300, - 418, - -382, - 236, - -48, - -114, - 206, - -213, - 153, - -59, - -31, - 90, - -106, - 86, - -44, - -1, - 32, - -45, - 40, - -24, - 6, - 9, - -15, - 15, - -10, - 4, - 1, - -3, - 4, - -2, - 1, - 0, - 0 - -}; -struct src_stage src_int16_7_8_4375_5000 = { - 1, 1, 7, 93, 651, 8, 7, 0, 0, - src_int16_7_8_4375_5000_fir}; diff --git a/src/include/reef/audio/coefficients/src/src_int16_8_7_4375_5000.h b/src/include/reef/audio/coefficients/src/src_int16_8_7_4375_5000.h deleted file mode 100644 index 1ad7797..0000000 --- a/src/include/reef/audio/coefficients/src/src_int16_8_7_4375_5000.h +++ /dev/null @@ -1,662 +0,0 @@ -const int16_t src_int16_8_7_4375_5000_fir[656] = { - 0, - 0, - 1, - -2, - 4, - -7, - 10, - -13, - 17, - -21, - 23, - -23, - 21, - -14, - 3, - 14, - -37, - 65, - -99, - 136, - -174, - 211, - -242, - 263, - -269, - 256, - -219, - 152, - -53, - -81, - 251, - -458, - 702, - -979, - 1290, - -1635, - 2021, - -2471, - 3050, - -3986, - 6580, - 29785, - -1328, - -372, - 958, - -1207, - 1295, - -1286, - 1212, - -1095, - 951, - -792, - 628, - -469, - 322, - -190, - 79, - 10, - -77, - 123, - -150, - 161, - -159, - 146, - -128, - 105, - -82, - 60, - -40, - 23, - -10, - 1, - 5, - -9, - 10, - -9, - 8, - -6, - 5, - -3, - 2, - -1, - 0, - 0, - 0, - -1, - 3, - -5, - 9, - -13, - 18, - -23, - 28, - -32, - 34, - -33, - 27, - -15, - -3, - 29, - -62, - 102, - -147, - 195, - -243, - 287, - -322, - 342, - -341, - 314, - -253, - 155, - -14, - -175, - 414, - -709, - 1065, - -1493, - 2018, - -2695, - 3672, - -5455, - 11305, - 27819, - -4054, - 1304, - -212, - -361, - 684, - -859, - 934, - -938, - 889, - -804, - 696, - -574, - 449, - -327, - 215, - -117, - 36, - 28, - -74, - 104, - -119, - 123, - -117, - 105, - -89, - 71, - -53, - 37, - -23, - 12, - -4, - -1, - 4, - -6, - 6, - -5, - 4, - -3, - 2, - -1, - -1, - 1, - -1, - 0, - 1, - -3, - 6, - -11, - 16, - -23, - 30, - -38, - 44, - -48, - 49, - -44, - 33, - -13, - -15, - 52, - -99, - 153, - -212, - 274, - -333, - 385, - -422, - 438, - -426, - 378, - -287, - 143, - 60, - -332, - 686, - -1143, - 1741, - -2566, - 3846, - -6377, - 16134, - 24716, - -5794, - 2637, - -1264, - 480, - 17, - -342, - 547, - -665, - 715, - -712, - 670, - -600, - 513, - -417, - 319, - -225, - 140, - -68, - 9, - 35, - -66, - 84, - -92, - 91, - -83, - 72, - -59, - 46, - -33, - 22, - -13, - 6, - -1, - -2, - 3, - -3, - 3, - -2, - 2, - -1, - -1, - 1, - -2, - 2, - -1, - 0, - 3, - -7, - 12, - -19, - 28, - -38, - 48, - -57, - 64, - -68, - 65, - -55, - 36, - -6, - -35, - 88, - -151, - 223, - -300, - 377, - -449, - 509, - -548, - 559, - -531, - 454, - -316, - 106, - 197, - -619, - 1209, - -2077, - 3504, - -6542, - 20718, - 20718, - -6542, - 3504, - -2077, - 1209, - -619, - 197, - 106, - -316, - 454, - -531, - 559, - -548, - 509, - -449, - 377, - -300, - 223, - -151, - 88, - -35, - -6, - 36, - -55, - 65, - -68, - 64, - -57, - 48, - -38, - 28, - -19, - 12, - -7, - 3, - 0, - -1, - 2, - -2, - 1, - -1, - -1, - 2, - -2, - 3, - -3, - 3, - -2, - -1, - 6, - -13, - 22, - -33, - 46, - -59, - 72, - -83, - 91, - -92, - 84, - -66, - 35, - 9, - -68, - 140, - -225, - 319, - -417, - 513, - -600, - 670, - -712, - 715, - -665, - 547, - -342, - 17, - 480, - -1264, - 2637, - -5794, - 24716, - 16134, - -6377, - 3846, - -2566, - 1741, - -1143, - 686, - -332, - 60, - 143, - -287, - 378, - -426, - 438, - -422, - 385, - -333, - 274, - -212, - 153, - -99, - 52, - -15, - -13, - 33, - -44, - 49, - -48, - 44, - -38, - 30, - -23, - 16, - -11, - 6, - -3, - 1, - 0, - -1, - 1, - -1, - -1, - 2, - -3, - 4, - -5, - 6, - -6, - 4, - -1, - -4, - 12, - -23, - 37, - -53, - 71, - -89, - 105, - -117, - 123, - -119, - 104, - -74, - 28, - 36, - -117, - 215, - -327, - 449, - -574, - 696, - -804, - 889, - -938, - 934, - -859, - 684, - -361, - -212, - 1304, - -4054, - 27819, - 11305, - -5455, - 3672, - -2695, - 2018, - -1493, - 1065, - -709, - 414, - -175, - -14, - 155, - -253, - 314, - -341, - 342, - -322, - 287, - -243, - 195, - -147, - 102, - -62, - 29, - -3, - -15, - 27, - -33, - 34, - -32, - 28, - -23, - 18, - -13, - 9, - -5, - 3, - -1, - 0, - 0, - 0, - -1, - 2, - -3, - 5, - -6, - 8, - -9, - 10, - -9, - 5, - 1, - -10, - 23, - -40, - 60, - -82, - 105, - -128, - 146, - -159, - 161, - -150, - 123, - -77, - 10, - 79, - -190, - 322, - -469, - 628, - -792, - 951, - -1095, - 1212, - -1286, - 1295, - -1207, - 958, - -372, - -1328, - 29785, - 6580, - -3986, - 3050, - -2471, - 2021, - -1635, - 1290, - -979, - 702, - -458, - 251, - -81, - -53, - 152, - -219, - 256, - -269, - 263, - -242, - 211, - -174, - 136, - -99, - 65, - -37, - 14, - 3, - -14, - 21, - -23, - 23, - -21, - 17, - -13, - 10, - -7, - 4, - -2, - 1, - 0, - 0, - -1, - 2, - -3, - 5, - -7, - 10, - -12, - 14, - -16, - 15, - -12, - 5, - 5, - -20, - 40, - -64, - 92, - -122, - 151, - -178, - 199, - -209, - 205, - -184, - 140, - -72, - -24, - 147, - -298, - 474, - -673, - 887, - -1112, - 1339, - -1559, - 1765, - -1947, - 2097, - -2210, - 2280, - 30458, - 2280, - -2210, - 2097, - -1947, - 1765, - -1559, - 1339, - -1112, - 887, - -673, - 474, - -298, - 147, - -24, - -72, - 140, - -184, - 205, - -209, - 199, - -178, - 151, - -122, - 92, - -64, - 40, - -20, - 5, - 5, - -12, - 15, - -16, - 14, - -12, - 10, - -7, - 5, - -3, - 2, - -1, - 0 - -}; -struct src_stage src_int16_8_7_4375_5000 = { - 6, 7, 8, 82, 656, 7, 8, 0, 0, - src_int16_8_7_4375_5000_fir}; diff --git a/src/include/reef/audio/coefficients/src/src_int16_define.h b/src/include/reef/audio/coefficients/src/src_int16_define.h deleted file mode 100644 index 65954b0..0000000 --- a/src/include/reef/audio/coefficients/src/src_int16_define.h +++ /dev/null @@ -1,11 +0,0 @@ -/* SRC constants */ -#define MAX_FIR_DELAY_SIZE 450 -#define MAX_OUT_DELAY_SIZE 401 -#define MAX_BLK_IN 21 -#define MAX_BLK_OUT 21 -#define NUM_IN_FS 3 -#define NUM_OUT_FS 3 -#define STAGE1_TIMES_MAX 21 -#define STAGE2_TIMES_MAX 21 -#define STAGE_BUF_SIZE 168 -#define NUM_ALL_COEFFICIENTS 3908 diff --git a/src/include/reef/audio/coefficients/src/src_int16_table.h b/src/include/reef/audio/coefficients/src/src_int16_table.h deleted file mode 100644 index e37dfae..0000000 --- a/src/include/reef/audio/coefficients/src/src_int16_table.h +++ /dev/null @@ -1,32 +0,0 @@ -/* SRC conversions */ -#include <reef/audio/coefficients/src/src_int16_1_3_4375_5000.h> -#include <reef/audio/coefficients/src/src_int16_3_1_4375_5000.h> -#include <reef/audio/coefficients/src/src_int16_7_8_4375_5000.h> -#include <reef/audio/coefficients/src/src_int16_8_7_4375_5000.h> -#include <reef/audio/coefficients/src/src_int16_20_21_4020_5000.h> -#include <reef/audio/coefficients/src/src_int16_21_20_4020_5000.h> - -/* SRC table */ -int16_t fir_one = 16384; -struct src_stage src_int16_1_1_0_0 = { 0, 0, 1, 1, 1, 1, 1, 0, -1, &fir_one }; -struct src_stage src_int16_0_0_0_0 = { 0, 0, 0, 0, 0, 0, 0, 0, 0, &fir_one }; -int src_in_fs[3] = { 16000, 44100, 48000}; -int src_out_fs[3] = { 16000, 44100, 48000}; -struct src_stage *src_table1[3][3] = { - { &src_int16_1_1_0_0, &src_int16_0_0_0_0, - &src_int16_1_3_4375_5000}, - { &src_int16_0_0_0_0, - &src_int16_1_1_0_0, &src_int16_21_20_4020_5000 - }, - { &src_int16_3_1_4375_5000, &src_int16_8_7_4375_5000, - &src_int16_1_1_0_0} -}; -struct src_stage *src_table2[3][3] = { - { &src_int16_1_1_0_0, &src_int16_0_0_0_0, - &src_int16_1_1_0_0}, - { &src_int16_0_0_0_0, - &src_int16_1_1_0_0, &src_int16_7_8_4375_5000 - }, - { &src_int16_1_1_0_0, &src_int16_20_21_4020_5000, - &src_int16_1_1_0_0} -}; -- 2.11.0

2 4

[Sound-open-firmware] [PATCH 1/4] interrupt-map: add cpu param for IRQ
by Keyon Jie 20 Sep '17

20 Sep '17

Signed-off-by: Keyon Jie <yang.jie(a)linux.intel.com> --- src/include/reef/interrupt-map.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/include/reef/interrupt-map.h b/src/include/reef/interrupt-map.h index a292279..1856e95 100644 --- a/src/include/reef/interrupt-map.h +++ b/src/include/reef/interrupt-map.h @@ -43,6 +43,7 @@ #define REEF_IRQ(_bit, _level, _cpu, _number) \ ((_bit << REEF_IRQ_BIT_SHIFT) \ | (_level << REEF_IRQ_LEVEL_SHIFT)\ + | (_cpu << REEF_IRQ_CPU_SHIFT)\ | (_number << REEF_IRQ_NUM_SHIFT)) #ifdef CONFIG_IRQ_MAP -- 2.11.0

3 14

[Sound-open-firmware] [PATCH] timer: Add support for 64 bit timers.
by Liam Girdwood 20 Sep '17

20 Sep '17

This patch changes the time and timeouts used by timers from a uint32_t to a uint64_t. This means clocks can run for years before overflow. This patch also provides a virtual high 32 bits for HW that only has 32bit timer support. i.e. the high 32 is incremented at every HW timer overflow. Finally the patch updates all timer users to use uint64_t timeouts. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/arch/xtensa/include/arch/timer.h | 25 +++- src/arch/xtensa/timer.c | 163 ++++++++++++++++++++++++- src/include/reef/timer.h | 13 +- src/include/reef/work.h | 8 +- src/lib/work.c | 18 +-- src/platform/baytrail/include/platform/timer.h | 5 +- src/platform/baytrail/platform.c | 6 +- src/platform/baytrail/timer.c | 137 +++++++++++++++++++-- 8 files changed, 334 insertions(+), 41 deletions(-) diff --git a/src/arch/xtensa/include/arch/timer.h b/src/arch/xtensa/include/arch/timer.h index 3262ac0..e36df6b 100644 --- a/src/arch/xtensa/include/arch/timer.h +++ b/src/arch/xtensa/include/arch/timer.h @@ -39,12 +39,28 @@ struct timer { uint32_t id; uint32_t irq; + void *timer_data; /* used by core */ + uint32_t hitime; /* high end of 64bit timer */ + uint32_t hitimeout; + uint32_t lowtimeout; }; +/* internal API calls */ +int timer64_register(struct timer *timer, void(*handler)(void *arg), void *arg); +void timer_64_handler(void *arg); + static inline int arch_timer_register(struct timer *timer, void(*handler)(void *arg), void *arg) { - return arch_interrupt_register(timer->id, handler, arg); + uint32_t flags; + int ret; + + flags = arch_interrupt_global_disable(); + timer64_register(timer, handler, arg); + ret = arch_interrupt_register(timer->id, timer_64_handler, timer); + arch_interrupt_global_enable(flags); + + return ret; } static inline void arch_timer_unregister(struct timer *timer) @@ -62,12 +78,9 @@ static inline void arch_timer_disable(struct timer *timer) arch_interrupt_disable_mask(1 << timer->irq); } -static inline uint32_t arch_timer_get_system(struct timer *timer) -{ - return xthal_get_ccount(); -} +uint64_t arch_timer_get_system(struct timer *timer); -void arch_timer_set(struct timer *timer, unsigned int ticks); +int arch_timer_set(struct timer *timer, uint64_t ticks); static inline void arch_timer_clear(struct timer *timer) { diff --git a/src/arch/xtensa/timer.c b/src/arch/xtensa/timer.c index 9395ca9..82c2481 100644 --- a/src/arch/xtensa/timer.c +++ b/src/arch/xtensa/timer.c @@ -41,19 +41,174 @@ #include <stdint.h> #include <errno.h> -void arch_timer_set(struct timer *timer, unsigned int ticks) +struct timer_data { + void (*handler2)(void *arg); + void *arg2; +}; + +static struct timer_data xtimer[3] = {}; + +void timer_64_handler(void *arg) +{ + struct timer *timer = arg; + struct timer_data *tdata = timer->timer_data; + uint32_t ccompare; + + /* get comparator value - will tell us timeout reason */ + switch (timer->id) { + case TIMER0: + ccompare = xthal_get_ccompare(0); + break; + case TIMER1: + ccompare = xthal_get_ccompare(1); + break; + case TIMER2: + ccompare = xthal_get_ccompare(2); + break; + default: + return; + } + + /* is this a 32 bit rollover ? */ + if (ccompare == 1) { + /* roll over the timer */ + timer->hitime++; + arch_timer_clear(timer); + } else { + /* no roll over, run the handler */ + tdata->handler2(tdata->arg2); + } + + /* get next timeout value */ + if (timer->hitimeout > 0 && timer->hitimeout == timer->hitime) { + /* timeout is in this 32 bit period */ + ccompare = timer->lowtimeout; + } else { + /* timeout is in another 32 bit period */ + ccompare = 1; + } + + switch (timer->id) { + case TIMER0: + xthal_set_ccompare(0, ccompare); + break; + case TIMER1: + xthal_set_ccompare(1, ccompare); + break; + case TIMER2: + xthal_set_ccompare(2, ccompare); + break; + default: + return; + } +} + +int timer64_register(struct timer *timer, void(*handler)(void *arg), void *arg) +{ + struct timer_data *tdata; + + switch (timer->id) { + case TIMER0: + tdata = &xtimer[0]; + break; + case TIMER1: + tdata = &xtimer[1]; + break; + case TIMER2: + tdata = &xtimer[2]; + break; + default: + return -EINVAL; + } + + tdata->handler2 = handler; + tdata->arg2 = arg; + timer->timer_data = tdata; + timer->hitime = 0; + timer->hitimeout = 0; + return 0; +} + +uint64_t arch_timer_get_system(struct timer *timer) { + uint64_t time; + uint32_t flags, low, high, ccompare; + switch (timer->id) { case TIMER0: - xthal_set_ccompare(0, ticks); + ccompare = xthal_get_ccompare(0); break; case TIMER1: - xthal_set_ccompare(1, ticks); + ccompare = xthal_get_ccompare(1); break; case TIMER2: - xthal_set_ccompare(2, ticks); + ccompare = xthal_get_ccompare(2); break; default: + return 0; + } + + flags = arch_interrupt_global_disable(); + + /* read low 32 bits */ + low = xthal_get_ccount(); + + /* check and see whether 32bit IRQ is pending for timer */ + if (arch_interrupt_get_status() & (1 << timer->irq) && ccompare == 1) { + /* yes, overflow has occured but handler has not run */ + high = timer->hitime + 1; + } else { + /* no overflow */ + high = timer->hitime; + } + + time = ((uint64_t)high << 32) | low; + + arch_interrupt_global_enable(flags); + + return time; +} + +int arch_timer_set(struct timer *timer, uint64_t ticks) +{ + uint32_t time = 1, hitimeout = ticks >> 32, flags; + + /* value of 1 represents rollover */ + if ((ticks & 0xffffffff) == 0x1) + ticks++; + + flags = arch_interrupt_global_disable(); + + /* same hi 64 bit context as ticks ? */ + if (hitimeout == timer->hitime) { + /* yes, then set the value for next timeout */ + time = ticks; + timer->lowtimeout = 0; + timer->hitimeout = 0; + } else if (hitimeout < timer->hitime) { + /* cant be in the past */ + arch_interrupt_global_enable(flags); + return -EINVAL; + } else { + /* set for checking at next timeout */ + timer->hitimeout = hitimeout; + timer->lowtimeout = ticks; + } + + switch (timer->id) { + case TIMER0: + xthal_set_ccompare(0, time); + break; + case TIMER1: + xthal_set_ccompare(1, time); break; + case TIMER2: + xthal_set_ccompare(2, time); + break; + default: + return -EINVAL; } + + arch_interrupt_global_enable(flags); + return 0; } diff --git a/src/include/reef/timer.h b/src/include/reef/timer.h index d10d5e2..613cb8b 100644 --- a/src/include/reef/timer.h +++ b/src/include/reef/timer.h @@ -34,11 +34,8 @@ #include <arch/timer.h> #include <stdint.h> -static inline int timer_register(struct timer *timer, - void(*handler)(void *arg), void *arg) -{ - return arch_timer_register(timer, handler, arg); -} +int timer_register(struct timer *timer, + void(*handler)(void *arg), void *arg); static inline void timer_unregister(struct timer *timer) { @@ -55,9 +52,9 @@ static inline void timer_disable(struct timer *timer) arch_timer_disable(timer); } -static inline void timer_set(struct timer *timer, unsigned int ticks) +static inline int timer_set(struct timer *timer, uint64_t ticks) { - arch_timer_set(timer, ticks); + return arch_timer_set(timer, ticks); } void timer_set_ms(struct timer *timer, unsigned int ms); @@ -71,7 +68,7 @@ unsigned int timer_get_count(struct timer *timer); unsigned int timer_get_count_delta(struct timer *timer); -static inline uint32_t timer_get_system(struct timer *timer) +static inline uint64_t timer_get_system(struct timer *timer) { return arch_timer_get_system(timer); } diff --git a/src/include/reef/work.h b/src/include/reef/work.h index 6428301..199e46c 100644 --- a/src/include/reef/work.h +++ b/src/include/reef/work.h @@ -57,9 +57,9 @@ struct work_queue_timesource { struct timer timer; int clk; int notifier; - void (*timer_set)(struct timer *, uint32_t ticks); + int (*timer_set)(struct timer *, uint64_t ticks); void (*timer_clear)(struct timer *); - uint32_t (*timer_get)(struct timer *); + uint64_t (*timer_get)(struct timer *); }; /* initialise our work */ @@ -69,11 +69,11 @@ struct work_queue_timesource { (w)->flags = xflags; /* schedule/cancel work on work queue */ -void work_schedule(struct work_queue *queue, struct work *w, uint32_t timeout); +void work_schedule(struct work_queue *queue, struct work *w, uint64_t timeout); void work_cancel(struct work_queue *queue, struct work *work); /* schedule/cancel work on default system work queue */ -void work_schedule_default(struct work *work, uint32_t timeout); +void work_schedule_default(struct work *work, uint64_t timeout); void work_cancel_default(struct work *work); /* create new work queue */ diff --git a/src/lib/work.c b/src/lib/work.c index 3172710..cac3deb 100644 --- a/src/lib/work.c +++ b/src/lib/work.c @@ -60,22 +60,26 @@ struct work_queue { struct list_item work; /* list of work */ - uint32_t timeout; /* timeout for next queue run */ + uint64_t timeout; /* timeout for next queue run */ uint32_t window_size; /* window size for pending work */ spinlock_t lock; struct notifier notifier; /* notify CPU freq changes */ struct work_queue_timesource *ts; /* time source for work queue */ uint32_t ticks_per_usec; /* ticks per msec */ - uint32_t run_ticks; /* ticks when last run */ + uint64_t run_ticks; /* ticks when last run */ }; /* generic system work queue */ static struct work_queue *queue_; -static inline void work_set_timer(struct work_queue *queue, uint32_t ticks) +static inline int work_set_timer(struct work_queue *queue, uint64_t ticks) { - queue->ts->timer_set(&queue->ts->timer, ticks); + int ret; + + ret = queue->ts->timer_set(&queue->ts->timer, ticks); timer_enable(&queue->ts->timer); + + return ret; } static inline void work_clear_timer(struct work_queue *queue) @@ -84,7 +88,7 @@ static inline void work_clear_timer(struct work_queue *queue) timer_disable(&queue->ts->timer); } -static inline uint32_t work_get_timer(struct work_queue *queue) +static inline uint64_t work_get_timer(struct work_queue *queue) { return queue->ts->timer_get(&queue->ts->timer); } @@ -317,7 +321,7 @@ static void work_notify(int message, void *data, void *event_data) spin_unlock_irq(&queue->lock, flags); } -void work_schedule(struct work_queue *queue, struct work *w, uint32_t timeout) +void work_schedule(struct work_queue *queue, struct work *w, uint64_t timeout) { struct work *work; struct list_item *wlist; @@ -362,7 +366,7 @@ void work_cancel(struct work_queue *queue, struct work *w) spin_unlock_irq(&queue->lock, flags); } -void work_schedule_default(struct work *w, uint32_t timeout) +void work_schedule_default(struct work *w, uint64_t timeout) { struct work *work; struct list_item *wlist; diff --git a/src/platform/baytrail/include/platform/timer.h b/src/platform/baytrail/include/platform/timer.h index a7d2fc8..8f0aea4 100644 --- a/src/platform/baytrail/include/platform/timer.h +++ b/src/platform/baytrail/include/platform/timer.h @@ -50,9 +50,10 @@ struct comp_dev; struct sof_ipc_stream_posn; extern struct timer *platform_timer; -void platform_timer_set(struct timer *timer, uint32_t ticks); + +int platform_timer_set(struct timer *timer, uint64_t ticks); void platform_timer_clear(struct timer *timer); -uint32_t platform_timer_get(struct timer *timer); +uint64_t platform_timer_get(struct timer *timer); void platform_timer_start(struct timer *timer); void platform_timer_stop(struct timer *timer); diff --git a/src/platform/baytrail/platform.c b/src/platform/baytrail/platform.c index f97971a..ce8a689 100644 --- a/src/platform/baytrail/platform.c +++ b/src/platform/baytrail/platform.c @@ -172,15 +172,15 @@ int platform_init(struct reef *reef) platform_ipc_pmc_init(); /* init work queues and clocks */ + trace_point(TRACE_BOOT_SYS_WORK); + init_system_workq(&platform_generic_queue); + trace_point(TRACE_BOOT_PLATFORM_TIMER); platform_timer_start(platform_timer); trace_point(TRACE_BOOT_PLATFORM_CLOCK); init_platform_clocks(); - trace_point(TRACE_BOOT_SYS_WORK); - init_system_workq(&platform_generic_queue); - /* Set CPU to default frequency for booting */ trace_point(TRACE_BOOT_SYS_CPU_FREQ); clock_set_freq(CLK_CPU, CLK_MAX_CPU_HZ); diff --git a/src/platform/baytrail/timer.c b/src/platform/baytrail/timer.c index 3d08f6f..17c1f0b 100644 --- a/src/platform/baytrail/timer.c +++ b/src/platform/baytrail/timer.c @@ -32,15 +32,58 @@ #include <platform/timer.h> #include <platform/shim.h> +#include <platform/interrupt.h> #include <reef/debug.h> #include <reef/audio/component.h> #include <stdint.h> +struct timer_data { + void (*handler2)(void *arg); + void *arg2; +}; + +static struct timer_data xtimer[1] = {}; + +void platform_timer_64_handler(void *arg) +{ + struct timer *timer = arg; + struct timer_data *tdata = timer->timer_data; + uint32_t timeout; + + /* get timeout value - will tell us timeout reason */ + timeout = shim_read(SHIM_EXT_TIMER_CNTLL); + + /* we dont use the timer clear bit as we only need to clear the ISR */ + shim_write(SHIM_PISR, SHIM_PISR_EXT_TIMER); + + /* is this a 32 bit rollover ? */ + if (timeout == 1) { + /* roll over the timer */ + timer->hitime++; + } else { + /* no roll over, run the handler */ + tdata->handler2(tdata->arg2); + } + + /* get next timeout value */ + if (timer->hitimeout > 0 && timer->hitimeout == timer->hitime) { + /* timeout is in this 32 bit period */ + timeout = timer->lowtimeout; + } else { + /* timeout is in another 32 bit period */ + timeout = 1; + } + + /* set new value and run */ + shim_write(SHIM_EXT_TIMER_CNTLH, SHIM_EXT_TIMER_RUN); + shim_write(SHIM_EXT_TIMER_CNTLL, timeout); +} + void platform_timer_start(struct timer *timer) { /* run timer */ shim_write(SHIM_EXT_TIMER_CNTLH, SHIM_EXT_TIMER_RUN); - shim_write(SHIM_EXT_TIMER_CNTLL, 0); + shim_write(SHIM_EXT_TIMER_CNTLL, 1); } /* this seems to stop rebooting with RTD3 ???? */ @@ -51,15 +94,40 @@ void platform_timer_stop(struct timer *timer) shim_write(SHIM_EXT_TIMER_CNTLH, SHIM_EXT_TIMER_CLEAR); } -void platform_timer_set(struct timer *timer, uint32_t ticks) +int platform_timer_set(struct timer *timer, uint64_t ticks) { + uint32_t time = 1, hitimeout = ticks >> 32, flags; + /* a tick value of 0 will not generate an IRQ */ - if (ticks == 0) - ticks = 1; + /* value of 1 represents rollover */ + if ((ticks & 0xffffffff) < 0x2) + ticks += 2; + + flags = arch_interrupt_global_disable(); + + /* same hi 64 bit context as ticks ? */ + if (hitimeout == timer->hitime) { + /* yes, then set the value for next timeout */ + time = ticks; + timer->lowtimeout = 0; + timer->hitimeout = 0; + } else if (hitimeout < timer->hitime) { + /* cant be in the past */ + arch_interrupt_global_enable(flags); + return -EINVAL; + } else { + /* set for checking at next timeout */ + timer->hitimeout = hitimeout; + timer->lowtimeout = ticks; + } /* set new value and run */ shim_write(SHIM_EXT_TIMER_CNTLH, SHIM_EXT_TIMER_RUN); - shim_write(SHIM_EXT_TIMER_CNTLL, ticks); + shim_write(SHIM_EXT_TIMER_CNTLL, time); + + arch_interrupt_global_enable(flags); + + return 0; } void platform_timer_clear(struct timer *timer) @@ -68,9 +136,31 @@ void platform_timer_clear(struct timer *timer) shim_write(SHIM_PISR, SHIM_PISR_EXT_TIMER); } -uint32_t platform_timer_get(struct timer *timer) +uint64_t platform_timer_get(struct timer *timer) { - return shim_read(SHIM_EXT_TIMER_STAT); + uint64_t time; + uint32_t flags, low, high; + + flags = arch_interrupt_global_disable(); + + /* read low 32 bits */ + low = shim_read(SHIM_EXT_TIMER_STAT); + + /* check and see whether 32bit IRQ is pending for timer */ + if (arch_interrupt_get_status() & IRQ_MASK_EXT_TIMER && + shim_read(SHIM_EXT_TIMER_CNTLL) == 1) { + /* yes, overflow has occured but handler has not run */ + high = timer->hitime + 1; + } else { + /* no overflow */ + high = timer->hitime; + } + + time = ((uint64_t)high << 32) | low; + + arch_interrupt_global_enable(flags); + + return time; } /* get timestamp for host stream DMA position */ @@ -107,3 +197,36 @@ void platform_dai_wallclock(struct comp_dev *dai, uint64_t *wallclock) /* only 1 wallclock on BYT */ *wallclock = shim_read(SHIM_EXT_TIMER_STAT); } + +static int platform_timer_register(struct timer *timer, + void(*handler)(void *arg), void *arg) +{ + struct timer_data *tdata = &xtimer[0]; + uint32_t flags; + int ret; + + flags = arch_interrupt_global_disable(); + tdata->handler2 = handler; + tdata->arg2 = arg; + timer->timer_data = tdata; + timer->hitime = 0; + timer->hitimeout = 0; + ret = arch_interrupt_register(timer->id, platform_timer_64_handler, timer); + arch_interrupt_global_enable(flags); + + return ret; +} + +int timer_register(struct timer *timer, void(*handler)(void *arg), void *arg) +{ + switch (timer->id) { + case TIMER0: + case TIMER1: + case TIMER2: + return arch_timer_register(timer, handler, arg); + case TIMER3: + return platform_timer_register(timer, handler, arg); + default: + return -EINVAL; + } +} -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] timer: pass platform timer structure in to all platform timer calls.
by Liam Girdwood 20 Sep '17

20 Sep '17

Make sure we pass in our timer structure. In preparation for 64bit timers. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/ipc/intel-ipc.c | 2 +- src/lib/schedule.c | 4 ++-- src/lib/trace.c | 2 +- src/platform/baytrail/clk.c | 3 +-- src/platform/baytrail/include/platform/timer.h | 1 + src/platform/baytrail/platform.c | 9 +++------ 6 files changed, 9 insertions(+), 12 deletions(-) diff --git a/src/ipc/intel-ipc.c b/src/ipc/intel-ipc.c index 01c83b6..0c1b10a 100644 --- a/src/ipc/intel-ipc.c +++ b/src/ipc/intel-ipc.c @@ -505,7 +505,7 @@ static int ipc_pm_context_save(uint32_t header) /* TODO: clear any outstanding platform IRQs - TODO refine */ /* TODO: stop ALL timers */ - platform_timer_stop(0); + platform_timer_stop(platform_timer); /* TODO: disable SSP and DMA HW */ diff --git a/src/lib/schedule.c b/src/lib/schedule.c index b10bb98..147bfff 100644 --- a/src/lib/schedule.c +++ b/src/lib/schedule.c @@ -84,7 +84,7 @@ static inline struct task *edf_get_next(void) return NULL; /* get the current time */ - current = platform_timer_get(NULL); + current = platform_timer_get(platform_timer); /* check every queued or running task in list */ list_for_item(clist, &sch->list) { @@ -174,7 +174,7 @@ void schedule_task(struct task *task, uint32_t deadline, uint16_t priority, } /* get the current time */ - current = platform_timer_get(NULL); + current = platform_timer_get(platform_timer); /* calculate deadline - TODO: include MIPS */ ticks = clock_us_to_ticks(sch->clock, deadline); diff --git a/src/lib/trace.c b/src/lib/trace.c index 5da7c95..33e1466 100644 --- a/src/lib/trace.c +++ b/src/lib/trace.c @@ -56,7 +56,7 @@ void _trace_event(uint32_t event) /* write timestamp and event to trace buffer */ t =(volatile uint32_t*)(MAILBOX_TRACE_BASE + trace.pos); - t[0] = platform_timer_get(0); + t[0] = platform_timer_get(platform_timer); t[1] = event; /* writeback trace data */ diff --git a/src/platform/baytrail/clk.c b/src/platform/baytrail/clk.c index 5d8a73a..fdffcd5 100644 --- a/src/platform/baytrail/clk.c +++ b/src/platform/baytrail/clk.c @@ -240,8 +240,7 @@ uint32_t clock_time_elapsed(int clock, uint32_t previous, uint32_t *current) _current = arch_timer_get_system(NULL); break; case CLK_SSP: - // TODO: fix timer ID - _current = platform_timer_get(NULL); + _current = platform_timer_get(platform_timer); break; default: return 0; diff --git a/src/platform/baytrail/include/platform/timer.h b/src/platform/baytrail/include/platform/timer.h index 309828c..a7d2fc8 100644 --- a/src/platform/baytrail/include/platform/timer.h +++ b/src/platform/baytrail/include/platform/timer.h @@ -49,6 +49,7 @@ struct comp_dev; struct sof_ipc_stream_posn; +extern struct timer *platform_timer; void platform_timer_set(struct timer *timer, uint32_t ticks); void platform_timer_clear(struct timer *timer); uint32_t platform_timer_get(struct timer *timer); diff --git a/src/platform/baytrail/platform.c b/src/platform/baytrail/platform.c index b8c3e49..f97971a 100644 --- a/src/platform/baytrail/platform.c +++ b/src/platform/baytrail/platform.c @@ -83,6 +83,8 @@ static struct work_queue_timesource platform_generic_queue = { .timer_get = platform_timer_get, }; +struct timer *platform_timer = &platform_generic_queue.timer; + int platform_boot_complete(uint32_t boot_message) { uint64_t outbox = MAILBOX_HOST_OFFSET >> 3; @@ -138,11 +140,6 @@ void platform_interrupt_unmask(uint32_t irq, uint32_t mask) } -static struct timer platform_ext_timer = { - .id = TIMER3, - .irq = IRQ_NUM_EXT_TIMER, -}; - int platform_init(struct reef *reef) { #if defined CONFIG_BAYTRAIL @@ -176,7 +173,7 @@ int platform_init(struct reef *reef) /* init work queues and clocks */ trace_point(TRACE_BOOT_PLATFORM_TIMER); - platform_timer_start(&platform_ext_timer); + platform_timer_start(platform_timer); trace_point(TRACE_BOOT_PLATFORM_CLOCK); init_platform_clocks(); -- 2.11.0

1 0

[Sound-open-firmware] [PATCH 4/4] Add IPC processing code for DMA tracing.
by yan.wang＠linux.intel.com 18 Sep '17

18 Sep '17

From: Yan Wang <yan.wang(a)linux.intel.com> 1. Add processing case branch of SOF_IPC_GLB_TRACE_MSG. 2. Add processing functions for SOF_IPC_TRACE_DMA_INIT and SOF_IPC_TRACE_DMA_PARAMS for initlizing DMA for Trace and reply host. 3. Modify page table parsing fucntion for using in both PCM streaming and DMA tracing case. Signed-off-by: Yan Wang <yan.wang(a)linux.intel.com> --- src/include/reef/ipc.h | 4 ++ src/ipc/intel-ipc.c | 115 ++++++++++++++++++++++++++++++++++++++++++++++--- 2 files changed, 114 insertions(+), 5 deletions(-) diff --git a/src/include/reef/ipc.h b/src/include/reef/ipc.h index 3eb94d8..84a1dc1 100644 --- a/src/include/reef/ipc.h +++ b/src/include/reef/ipc.h @@ -40,6 +40,7 @@ #include <uapi/ipc.h> #include <reef/audio/pipeline.h> #include <reef/audio/component.h> +#include <reef/audio/dma-trace.h> struct reef; struct dai_config; @@ -99,6 +100,9 @@ struct ipc { /* pipelines, components and buffers */ struct list_item comp_list; /* list of component devices */ + /* DMA for Trace*/ + struct dma_trace_data dmat; + void *private; }; diff --git a/src/ipc/intel-ipc.c b/src/ipc/intel-ipc.c index 01c83b6..dbd9ec7 100644 --- a/src/ipc/intel-ipc.c +++ b/src/ipc/intel-ipc.c @@ -155,14 +155,22 @@ out: * page table entry and adding each elem to a list in struct dma_sg_config. */ static int parse_page_descriptors(struct intel_ipc_data *iipc, - struct sof_ipc_host_buffer *ring, struct comp_dev *cd) + struct sof_ipc_host_buffer *ring, void *data, uint32_t is_trace) { - struct sof_ipc_comp_host *host = (struct sof_ipc_comp_host *)&cd->comp; + struct comp_dev* cd = NULL; + struct sof_ipc_comp_host *host = NULL; + struct dma_trace_data *d = NULL; struct dma_sg_elem elem; int i, err; uint32_t idx, phy_addr; elem.size = HOST_PAGE_SIZE; + if (is_trace) + d = (struct dma_trace_data *)data; + else { + cd = (struct comp_dev *)data; + host = (struct sof_ipc_comp_host *)&cd->comp; + } for (i = 0; i < ring->pages; i++) { @@ -176,12 +184,15 @@ static int parse_page_descriptors(struct intel_ipc_data *iipc, phy_addr <<= 12; phy_addr &= 0xfffff000; - if (host->direction == SOF_IPC_STREAM_PLAYBACK) + if (!is_trace && host->direction == SOF_IPC_STREAM_PLAYBACK) elem.src = phy_addr; else elem.dest = phy_addr; - err = comp_host_buffer(cd, &elem, ring->size); + if (is_trace) + err = dma_trace_host_buffer(d, &elem, ring->size); + else + err = comp_host_buffer(cd, &elem, ring->size); if (err < 0) { trace_ipc_error("ePb"); return err; @@ -235,7 +246,7 @@ static int ipc_stream_pcm_params(uint32_t stream) /* Parse host tables */ err = parse_page_descriptors(iipc, &pcm_params->params.buffer, - pcm_dev->cd); + pcm_dev->cd, 0); if (err < 0) { trace_ipc_error("eAP"); goto error; @@ -551,6 +562,98 @@ static int ipc_glb_pm_message(uint32_t header) } /* + * Debug IPC Operations. + */ + +static int ipc_dma_trace_init(uint32_t header) +{ + struct sof_ipc_reply reply; + int err; + + trace_ipc("Dti"); + + /* Initialize DMA for Trace*/ + err = dma_trace_init(&_ipc->dmat); + if (err < 0) { + trace_ipc_error("eIP"); + goto error; + } + + /* write component values to the outbox */ + reply.hdr.size = sizeof(reply); + reply.hdr.cmd = header; + reply.error = 0; + mailbox_hostbox_write(0, &reply, sizeof(reply)); + return 0; + +error: + if (err < 0) + trace_ipc_error("eA!"); + return -EINVAL; +} + +static int ipc_dma_trace_config(uint32_t header) +{ + struct intel_ipc_data *iipc = ipc_get_drvdata(_ipc); + struct sof_ipc_dma_trace_params *params = _ipc->comp_data; + struct sof_ipc_reply reply; + int err; + + trace_ipc("DAl"); + + /* use DMA to read in compressed page table ringbuffer from host */ + err = get_page_descriptors(iipc, &params->buffer); + if (err < 0) { + trace_ipc_error("eCp"); + goto error; + } + + trace_ipc("DAg"); + + /* Parse host tables */ + err = parse_page_descriptors(iipc, &params->buffer, + &_ipc->dmat, 1); + if (err < 0) { + trace_ipc_error("ePP"); + goto error; + } + + trace_ipc("DAp"); + + dma_trace_config_ready(&_ipc->dmat); + + /* write component values to the outbox */ + reply.hdr.size = sizeof(reply); + reply.hdr.cmd = header; + reply.error = 0; + mailbox_hostbox_write(0, &reply, sizeof(reply)); + return 0; + +error: + if (err < 0) + trace_ipc_error("eA!"); + return -EINVAL; +} + +static int ipc_glb_debug_message(uint32_t header) +{ + uint32_t cmd = (header & SOF_CMD_TYPE_MASK) >> SOF_CMD_TYPE_SHIFT; + + trace_ipc("Idn"); + + switch (cmd) { + case iCS(SOF_IPC_TRACE_DMA_INIT): + return ipc_dma_trace_init(header); + case iCS(SOF_IPC_TRACE_DMA_PARAMS): + return ipc_dma_trace_config(header); + default: + trace_ipc_error("eDc"); + trace_value(header); + return -EINVAL; + } +} + +/* * Topology IPC Operations. */ @@ -766,6 +869,8 @@ int ipc_cmd(void) return ipc_glb_stream_message(hdr->cmd); case iGS(SOF_IPC_GLB_DAI_MSG): return ipc_glb_dai_message(hdr->cmd); + case iGS(SOF_IPC_GLB_TRACE_MSG): + return ipc_glb_debug_message(hdr->cmd); default: trace_ipc_error("eGc"); trace_value(type); -- 2.7.4

1 0

[Sound-open-firmware] [PATCH 3/4] Add the implementation for DMA tracing.
by yan.wang＠linux.intel.com 18 Sep '17

18 Sep '17

From: Yan Wang <yan.wang(a)linux.intel.com> 1. Initialize the data structure. a) Create local DMA buffer for saving trace data. b) Initialize the tracing work handler for syatem work queue. 2. Implement local circle buffer. a) When the local buffer is full, empty it and reset reading/writing pointer. 3. Save the host buffer PHY addr which is parsed from IPC message. After this config, start trace work in work queue. 4. Provide dtrace_event() for recroding trace string into local buffer. 5. Add rstrlen() utility function for getting the trace string length because DSP side hasn't strlen(). 6. Enbale trace DMA copying once every 500ms or some special cases. a) Schedule the tracing sending work once every 500ms. b) If the local buffer is half full, call trace sending immediately. c) When the wrting pointer will arrive iat the end of local buffer, call trace sending immediately. 7. Use dma_copy_to_host() function to do trace sending. Signed-off-by: Yan Wang <yan.wang(a)linux.intel.com> --- src/audio/Makefile.am | 1 + src/audio/dma-trace.c | 194 ++++++++++++++++++++++ src/include/reef/alloc.h | 1 + src/include/reef/audio/dma-trace.h | 69 ++++++++ src/lib/lib.c | 9 + src/platform/baytrail/include/platform/platform.h | 6 + 6 files changed, 280 insertions(+) create mode 100644 src/audio/dma-trace.c create mode 100644 src/include/reef/audio/dma-trace.h diff --git a/src/audio/Makefile.am b/src/audio/Makefile.am index 285422e..7ffe01f 100644 --- a/src/audio/Makefile.am +++ b/src/audio/Makefile.am @@ -17,6 +17,7 @@ libaudio_a_SOURCES = \ pipeline.c \ pipeline_static.c \ component.c \ + dma-trace.c \ buffer.c libaudio_a_CFLAGS = \ diff --git a/src/audio/dma-trace.c b/src/audio/dma-trace.c new file mode 100644 index 0000000..8fc220e --- /dev/null +++ b/src/audio/dma-trace.c @@ -0,0 +1,194 @@ +/* + * Copyright (c) 2016, Intel Corporation + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * * Neither the name of the Intel Corporation nor the + * names of its contributors may be used to endorse or promote products + * derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + * Author: Yan Wang <yan.wang(a)linux.intel.com> + */ + +#include <reef/trace.h> +#include <reef/audio/dma-trace.h> +#include <reef/ipc.h> +#include <reef/reef.h> +#include <reef/alloc.h> +#include <arch/cache.h> +#include <platform/timer.h> +#include <platform/dma.h> +#include <reef/lock.h> +#include <stdint.h> + +static struct dma_trace_data *trace_data = NULL; + +static int dma_trace_new_buffer(struct dma_trace_data *d, uint32_t buffer_size) +{ + struct dma_trace_buf *buffer = &d->dmatb; + + trace_buffer("nlb"); + + /* validate request */ + if (buffer_size == 0 || buffer_size > HEAP_BUFFER_SIZE) { + trace_buffer_error("ebg"); + trace_value(buffer_size); + return -ENOMEM; + } + + /* allocate new buffer */ + buffer->addr = rballoc(RZONE_RUNTIME, RFLAGS_NONE, buffer_size); + if (buffer->addr == NULL) { + trace_buffer_error("ebm"); + return -ENOMEM; + } + + bzero(buffer->addr, buffer_size); + + buffer->size = buffer_size; + buffer->w_ptr = buffer->r_ptr = buffer->addr; + buffer->end_addr = buffer->addr + buffer->size; + + return 0; +} + +static void trace_send(struct dma_trace_data *d) +{ + struct dma_trace_buf *buffer = &d->dmatb; + struct dma_sg_config *config = &d->config; + uint32_t size = 0; + int32_t offset = 0; + + if (buffer->w_ptr == buffer->r_ptr) + return; + + size = buffer->w_ptr - buffer->r_ptr; + if (d->host_offset + size > d->host_size) + d->host_offset = 0; + + offset = dma_copy_to_host(config, d->host_offset, + buffer->r_ptr, size); + if (offset < 0) { + trace_buffer_error("ebb"); + return; + } + + d->host_offset += size; + buffer->r_ptr += size; + + trace_buffer("dts"); +} + +static uint32_t trace_work(void *data, uint32_t delay) +{ + struct dma_trace_data *d = (struct dma_trace_data *)data; + + trace_send(d); + + /* reschedule the trace copying work */ + return DMA_TRACE_US; +} + +int dma_trace_init(struct dma_trace_data *d) +{ + int err; + + trace_buffer("dtn"); + + /* init buffer elems */ + list_init(&d->config.elem_list); + + /* allocate local DMA buffer */ + err = dma_trace_new_buffer(d, DMA_TRACE_LOCAL_SIZE); + if (err < 0) { + trace_buffer_error("ePb"); + return err; + } + + d->host_offset = 0; + trace_data = d; + + work_init(&d->dmat_work, trace_work, d, WORK_ASYNC); + return 0; +} + +int dma_trace_host_buffer(struct dma_trace_data *d, struct dma_sg_elem *elem, + uint32_t host_size) +{ + struct dma_sg_elem *e; + + /* allocate new host DMA elem and add it to our list */ + e = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, sizeof(*e)); + if (e == NULL) + return -ENOMEM; + + *e = *elem; + d->host_size = host_size; + + list_item_append(&e->list, &d->config.elem_list); + return 0; +} + +void dma_trace_config_ready(struct dma_trace_data *d) +{ + work_schedule_default(&d->dmat_work, DMA_TRACE_US); +} + +void dtrace_event(char *e) +{ + struct dma_trace_buf *buffer = NULL; + int length = rstrlen(e); + int margin = 0; + + if (trace_data == NULL || length < 1) { + trace_buffer_error("ele"); + return; + } + + buffer = &trace_data->dmatb; + if (buffer == NULL) { + trace_buffer_error("ele"); + return; + } + + margin = buffer->end_addr - buffer->w_ptr; + + if (margin > length) { + memcpy(buffer->w_ptr, e, length); + buffer->w_ptr += length; + } else { + memcpy(buffer->w_ptr, e, margin); + buffer->w_ptr += margin; + + trace_send(trace_data); + buffer->w_ptr = buffer->r_ptr = buffer->addr; + bzero(buffer->addr, buffer->size); + + memcpy(buffer->w_ptr, e + margin, length - margin); + buffer->w_ptr += length -margin; + + trace_buffer("ebs"); + } + + length = buffer->w_ptr - buffer->r_ptr; + if (length >= (DMA_TRACE_LOCAL_SIZE / 2)) + trace_send(trace_data); +} diff --git a/src/include/reef/alloc.h b/src/include/reef/alloc.h index d263052..a589959 100644 --- a/src/include/reef/alloc.h +++ b/src/include/reef/alloc.h @@ -82,6 +82,7 @@ void rbfree(void *ptr); /* utility */ void bzero(void *s, size_t n); void *memset(void *s, int c, size_t n); +int rstrlen(char *s); /* Heap save/restore contents and context for PM D0/D3 events */ uint32_t mm_pm_context_size(void); diff --git a/src/include/reef/audio/dma-trace.h b/src/include/reef/audio/dma-trace.h new file mode 100644 index 0000000..9ee88a0 --- /dev/null +++ b/src/include/reef/audio/dma-trace.h @@ -0,0 +1,69 @@ +/* + * Copyright (c) 2016, Intel Corporation + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * * Neither the name of the Intel Corporation nor the + * names of its contributors may be used to endorse or promote products + * derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + * Author: Yan Wang <yan.wang(a)linux.intel.com> + */ + +#ifndef __INCLUDE_DMA_TRACE__ +#define __INCLUDE_DMA_TRACE__ + +#include <stdint.h> +#include <stdlib.h> +#include <reef/reef.h> +#include <reef/list.h> +#include <reef/mailbox.h> +#include <reef/debug.h> +#include <reef/timer.h> +#include <reef/dma.h> +#include <reef/work.h> +#include <platform/platform.h> +#include <platform/timer.h> + +struct dma_trace_buf { + void *w_ptr; /* buffer write pointer */ + void *r_ptr; /* buffer read position */ + void *addr; /* buffer base address */ + void *end_addr; /* buffer end address */ + uint32_t size; /* size of buffer in bytes */ +}; + +struct dma_trace_data { + struct dma_sg_config config; + struct dma_trace_buf dmatb; + int32_t host_offset; + uint32_t host_size; + struct work dmat_work; +}; + +int dma_trace_init(struct dma_trace_data *d); +int dma_trace_host_buffer(struct dma_trace_data *d, struct dma_sg_elem *elem, + uint32_t host_size); +void dma_trace_config_ready(struct dma_trace_data *d); + +void dtrace_event(char *e); + +#endif diff --git a/src/lib/lib.c b/src/lib/lib.c index d018f5e..764e53b 100644 --- a/src/lib/lib.c +++ b/src/lib/lib.c @@ -89,3 +89,12 @@ void *memset(void *s, int c, size_t n) return s; } + +/* generic strlen - TODO: can be optimsed for ARCH ? */ +int rstrlen(char *s) +{ + char *p = s; + + while(*p++ != 0); + return (p - s) - 1; +} diff --git a/src/platform/baytrail/include/platform/platform.h b/src/platform/baytrail/include/platform/platform.h index 1ad0a22..ff3a117 100644 --- a/src/platform/baytrail/include/platform/platform.h +++ b/src/platform/baytrail/include/platform/platform.h @@ -76,6 +76,12 @@ struct reef; /* WorkQ window size in microseconds */ #define PLATFORM_WORKQ_WINDOW 2000 +/* local buffer size of DMA tracing */ +#define DMA_TRACE_LOCAL_SIZE HOST_PAGE_SIZE + +/* the interval of DMA trace copying */ +#define DMA_TRACE_US 500000 + /* Platform defined panic code */ #define platform_panic(__x) \ shim_write(SHIM_IPCXL, ((shim_read(SHIM_IPCXL) & 0xc0000000) |\ -- 2.7.4

1 0

[Sound-open-firmware] [PATCH 2/4] Add IPC message definition for DMA tracing.
by yan.wang＠linux.intel.com 18 Sep '17

18 Sep '17

From: Yan Wang <yan.wang(a)linux.intel.com> 1. Add SOF_IPC_GLB_TRACE_MSG class of IPC communication. 2. Add two IPC commands for DMA tracing. a) SOF_IPC_TRACE_DMA_INIT is used to initilize local buffer on DSP side. b) SOF_IPC_TRACE_DMA_PARAMS is used to receive host DMA buffer PHY. 3. Define DMA for Trace params IPC info structure. Signed-off-by: Yan Wang <yan.wang(a)linux.intel.com> --- src/include/uapi/ipc.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/include/uapi/ipc.h b/src/include/uapi/ipc.h index cbccb55..acfa05e 100644 --- a/src/include/uapi/ipc.h +++ b/src/include/uapi/ipc.h @@ -63,6 +63,7 @@ #define SOF_IPC_GLB_STREAM_MSG SOF_GLB_TYPE(0x6U) #define SOF_IPC_FW_READY SOF_GLB_TYPE(0x7U) #define SOF_IPC_GLB_DAI_MSG SOF_GLB_TYPE(0x8U) +#define SOF_IPC_GLB_TRACE_MSG SOF_GLB_TYPE(0x9U) /* * DSP Command Message Types @@ -113,6 +114,9 @@ #define SOF_IPC_STREAM_VORBIS_PARAMS SOF_CMD_TYPE(0x010) #define SOF_IPC_STREAM_VORBIS_FREE SOF_CMD_TYPE(0x011) +/* trace and debug */ +#define SOF_IPC_TRACE_DMA_INIT SOF_CMD_TYPE(0x001) +#define SOF_IPC_TRACE_DMA_PARAMS SOF_CMD_TYPE(0x002) /* Get message component id */ #define SOF_IPC_MESSAGE_ID(x) (x & 0xffff) @@ -796,4 +800,14 @@ struct sof_ipc_window { struct sof_ipc_window_elem window[]; } __attribute__((packed)); +/* + * DMA for Trace + */ + +/* DMA for Trace params info - SOF_IPC_DEBUG_DMA_PARAMS */ +struct sof_ipc_dma_trace_params { + struct sof_ipc_hdr hdr; + struct sof_ipc_host_buffer buffer; +} __attribute__((packed)); + #endif -- 2.7.4

1 0

[Sound-open-firmware] [PATCH 0/3] soft: make .m4 topology files more readable
by Pierre-Louis Bossart 14 Sep '17

14 Sep '17

Existing topology files are hard to look at, nothing is aligned, fits in 80 columns and comparisons between streams aren't straighforward. Re-indent files to make things more self-explanatory This also exposed a mistake in one of the passthrough test files (missing format). Pierre-Louis Bossart (3): topology: build: fix PIPELINE/DAI_ADD comments topology: test: fix passthrough 24bit-48k-ssp2 topology: indent reef-*.m4 files, fix typos topology/m4/build.m4 | 19 +++++++++++----- topology/reef-apl-nocodec.m4 | 34 +++++++++++++++++++++-------- topology/reef-bdw-rt286.m4 | 34 +++++++++++++++++++++-------- topology/reef-bdw-rt5640.m4 | 34 +++++++++++++++++++++-------- topology/reef-bxt-nocodec.m4 | 34 +++++++++++++++++++++-------- topology/reef-byt-nocodec.m4 | 30 ++++++++++++++++++------- topology/reef-byt-rt5640.m4 | 30 ++++++++++++++++++------- topology/reef-byt-rt5651.m4 | 30 ++++++++++++++++++------- topology/reef-cht-nocodec.m4 | 30 ++++++++++++++++++------- topology/reef-hsw-rt5640.m4 | 34 +++++++++++++++++++++-------- topology/test-passthrough-24bit-48k-ssp2.m4 | 2 +- 11 files changed, 228 insertions(+), 83 deletions(-) -- 2.11.0

2 4

[Sound-open-firmware] [PATCH v2 1/2] MUX component added
by Ranjani Sridharan 13 Sep '17

13 Sep '17

This patch adds a 1:N or N:1 MUX/DEMUX component. Only one source and one sink buffer can be active at run-time. The MUX component is configured using the COMP_CMD_MUX_SWITCH command passed along with the chosen source and sink buffer configuration. It performs no processing on the input samples, but simply copies the input frames from the source to the sink buffer. Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- src/audio/mux.c | 293 +++++++++++++++++++++++++++++++++++-- src/include/reef/audio/Makefile.am | 3 +- src/include/reef/audio/component.h | 1 - src/include/reef/audio/mux.h | 50 +++++++ src/include/uapi/ipc.h | 1 - 5 files changed, 335 insertions(+), 13 deletions(-) create mode 100644 src/include/reef/audio/mux.h diff --git a/src/audio/mux.c b/src/audio/mux.c index f420bd3..e010104 100644 --- a/src/audio/mux.c +++ b/src/audio/mux.c @@ -26,61 +26,333 @@ * POSSIBILITY OF SUCH DAMAGE. * * Author: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> + * Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> */ +#include <stdio.h> #include <stdint.h> #include <stddef.h> #include <reef/lock.h> +#include <reef/alloc.h> #include <reef/list.h> #include <reef/stream.h> +#include <reef/trace.h> #include <reef/audio/component.h> +#include <reef/audio/mux.h> +#include <reef/audio/pipeline.h> +#include <uapi/ipc.h> /* tracing */ -#define trace_mux(__e) trace_event(TRACE_CLASS_MUX, __e) +#define trace_mux(__e) trace_event(TRACE_CLASS_MUX, __e) #define trace_mux_error(__e) trace_error(TRACE_CLASS_MUX, __e) #define tracev_mux(__e) tracev_event(TRACE_CLASS_MUX, __e) +/* + * mux_comp_data structure + * num_src_buffer - number of source buffers + * num_sink_buffer - number of sink buffers + * config - current configuration of the MUX component + * mux_func - function that performs the routing of input buffer to + * the output buffer based on config + */ +struct mux_comp_data { + uint32_t num_src_buffer, num_sink_buffer; + struct mux_config *config; + int (*mux_func)(struct comp_dev *dev, struct comp_buffer *sink, + struct comp_buffer *source, uint32_t frames); + +}; + +/* mux function to copy data from source to sink buffer */ +static int mux_function(struct comp_dev *dev, struct comp_buffer *sink_buffer, + struct comp_buffer *source_buffer, uint32_t frames) +{ + int32_t *src = (int32_t *) source_buffer->r_ptr; + int32_t *dest = (int32_t *) sink_buffer->w_ptr; + int nch = dev->params.channels; + struct sof_ipc_comp_config *config = COMP_GET_CONFIG(dev); + int ret = 0; + + /* copy frames from source to destination */ + switch (config->frame_fmt) { + case SOF_IPC_FRAME_S16_LE: + memcpy(dest, src, frames * nch * sizeof(int16_t)); + break; + case SOF_IPC_FRAME_S32_LE: + case SOF_IPC_FRAME_S24_4LE: + case SOF_IPC_FRAME_FLOAT: + memcpy(dest, src, frames * nch * sizeof(int32_t)); + break; + default: + trace_mux_error("MUf"); + ret = -EINVAL; + break; + } + + return ret; +} + static struct comp_dev *mux_new(struct sof_ipc_comp *comp) { - trace_mux("new"); + struct comp_dev *dev; + struct mux_comp_data *cd; + + trace_mux("MUn"); + dev = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, + COMP_SIZE(struct sof_ipc_comp_mux)); + if (dev == NULL) + return NULL; + + memcpy(&dev->comp, comp, sizeof(struct sof_ipc_comp_mux)); + + cd = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, sizeof(*cd)); + if (cd == NULL) { + rfree(dev); + return NULL; + } + + cd->config = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, + sizeof(struct mux_config)); + if (cd == NULL) { + rfree(dev); + rfree(cd); + return NULL; + } + + cd->config->source_buffer_id = -1; + cd->config->sink_buffer_id = -1; + + comp_set_drvdata(dev, cd); + cd->mux_func = mux_function; - return NULL; + return dev; } static void mux_free(struct comp_dev *dev) { + struct mux_comp_data *cd = comp_get_drvdata(dev); + rfree(cd->config); + rfree(cd); + rfree(dev); } -/* set component audio stream paramters */ +/* set component audio stream parameters */ static int mux_params(struct comp_dev *dev) { + return 0; +} + +/* set new mux component configuration + * updates the connection status of sink/source buffers + */ +static int mux_route(struct comp_dev *dev, + int32_t source_buffer_index, int sink_buffer_index) +{ + struct mux_comp_data *cd = comp_get_drvdata(dev); + struct comp_buffer *source_buffer, *sink_buffer; + struct list_item *clist; + int i = 0; + + if ((source_buffer_index > (cd->num_src_buffer - 1)) || + (sink_buffer_index > (cd->num_sink_buffer - 1))) { + trace_mux_error("MUb"); + return -EINVAL; + } + + /* switch source buffer if needed */ + if (source_buffer_index != cd->config->source_buffer_id) { + cd->config->source_buffer_id = source_buffer_index; + /* connect new MUX source buffer and disconnect the rest */ + list_for_item_prev(clist, &dev->bsource_list) { + source_buffer = container_of(clist, struct comp_buffer, + sink_list); + if (i == cd->config->source_buffer_id) { + source_buffer->connected = 1; + cd->config->source_buffer = source_buffer; + } else + source_buffer->connected = 0; + i++; + } + } + + /* switch sink buffer if needed */ + i = 0; + if (sink_buffer_index != cd->config->sink_buffer_id) { + cd->config->sink_buffer_id = sink_buffer_index; + /* connect new MUX sink buffer and disconnect the rest */ + list_for_item_prev(clist, &dev->bsink_list) { + sink_buffer = container_of(clist, struct comp_buffer, + source_list); + if (i == cd->config->sink_buffer_id) { + sink_buffer->connected = 1; + cd->config->sink_buffer = sink_buffer; + } else + sink_buffer->connected = 0; + i++; + } + } + + return 0; +} + +/* set the number of input and output buffers connected at pipeline setup */ +static int set_buffer_count(struct comp_dev *dev) +{ + struct list_item *clist; + struct mux_comp_data *cd = comp_get_drvdata(dev); + int count = 0; + + if (list_is_empty(&dev->bsource_list) || + list_is_empty(&dev->bsink_list)) { + trace_mux_error("Mbc"); + return -EINVAL; + } + + list_for_item(clist, &dev->bsource_list) + count++; + cd->num_src_buffer = count; + + count = 0; + list_for_item(clist, &dev->bsink_list) + count++; + cd->num_sink_buffer = count; return 0; } +static int mux_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) +{ + struct mux_comp_data *cd = comp_get_drvdata(dev); + int source_buffer_index = -1, sink_buffer_index = -1, ret = 0; + + switch (cdata->cmd) { + case SOF_CTRL_CMD_ROUTE: + /* check if the ctrl cmd is for this component */ + if (cdata->comp_id != dev->comp.id) + break; + + if (cdata->num_elems < 1) { + trace_mux_error("Mcd"); + ret = -EINVAL; + } + + if (cdata->compv[0].index == 0) { + /* new source buffer index */ + source_buffer_index = cdata->compv[0].uvalue; + /* sink buffer index is unchanged */ + sink_buffer_index = cd->config->sink_buffer_id; + } else { + /* new sink buffer index */ + sink_buffer_index = cdata->compv[0].uvalue; + /* source buffer index is unchanged */ + source_buffer_index = cd->config->source_buffer_id; + } + /* switch to the new source/sink buffer(s)*/ + ret = mux_route(dev, source_buffer_index, + sink_buffer_index); + break; + default: + break; + } + + if (ret < 0) + trace_mux_error("Mct"); + return ret; + +} + /* used to pass standard and bespoke commands (with data) to component */ static int mux_cmd(struct comp_dev *dev, int cmd, void *data) { - /* mux will use buffer "connected" status */ - return 0; + struct sof_ipc_ctrl_data *cdata = data; + int ret = 0; + + switch (cmd) { + case COMP_CMD_SET_VALUE: + ret = mux_ctrl_cmd(dev, cdata); + break; + case COMP_CMD_START: + case COMP_CMD_STOP: + case COMP_CMD_PAUSE: + case COMP_CMD_RELEASE: + default: + ret = comp_set_state(dev, cmd); + break; + } + + return ret; } -/* copy and process stream data from source to sink buffers */ +/* copy and process stream data from source to sink buffers + * returns the number of frames copied + */ static int mux_copy(struct comp_dev *dev) { + struct mux_comp_data *cd = comp_get_drvdata(dev); + struct comp_buffer *source_buffer = NULL, *sink_buffer = NULL; + uint32_t copy_bytes; - return 0; + /* get the connected source and sink buffers */ + source_buffer = cd->config->source_buffer; + sink_buffer = cd->config->sink_buffer; + + if (!source_buffer || !sink_buffer) { + trace_mux_error("Mbn"); + return -EINVAL; + } + + /* check that source has enough frames available and sink enough + * frames free. + */ + copy_bytes = comp_buffer_get_copy_bytes(dev, source_buffer, + sink_buffer); + + if (copy_bytes < dev->params.host_period_bytes) { + trace_mux_error("Mcb"); + return -EINVAL; + } + + /* Run passthrough if buffers have enough room */ + cd->mux_func(dev, sink_buffer, source_buffer, dev->frames); + + comp_update_buffer_consume(source_buffer, + dev->params.host_period_bytes); + comp_update_buffer_produce(sink_buffer, dev->params.host_period_bytes); + + return dev->frames; +} + +static int mux_preload(struct comp_dev *dev) +{ + return mux_copy(dev); +} + +static int mux_default_config(struct comp_dev *dev) +{ + int ret = 0; + + ret = set_buffer_count(dev); + if (ret < 0) + return -EINVAL; + + ret = mux_route(dev, 0, 0); + + return ret; } static int mux_reset(struct comp_dev *dev) { - return 0; + trace_mux("MUr"); + dev->state = COMP_STATE_INIT; + return mux_default_config(dev); } static int mux_prepare(struct comp_dev *dev) { - return 0; + trace_mux("MUp"); + dev->state = COMP_STATE_PREPARE; + return mux_default_config(dev); } struct comp_driver comp_mux = { @@ -93,6 +365,7 @@ struct comp_driver comp_mux = { .copy = mux_copy, .prepare = mux_prepare, .reset = mux_reset, + .preload = mux_preload, }, }; diff --git a/src/include/reef/audio/Makefile.am b/src/include/reef/audio/Makefile.am index b02684c..509a34a 100644 --- a/src/include/reef/audio/Makefile.am +++ b/src/include/reef/audio/Makefile.am @@ -1,4 +1,5 @@ noinst_HEADERS = \ component.h \ pipeline.h \ - buffer.h + buffer.h \ + mux.h diff --git a/src/include/reef/audio/component.h b/src/include/reef/audio/component.h index e20ffed..ed29da4 100644 --- a/src/include/reef/audio/component.h +++ b/src/include/reef/audio/component.h @@ -80,7 +80,6 @@ #define COMP_CMD_SET_DATA 102 #define COMP_CMD_GET_DATA 103 - /* MMAP IPC status */ #define COMP_CMD_IPC_MMAP_RPOS 200 /* host read position */ #define COMP_CMD_IPC_MMAP_PPOS 201 /* DAI presentation position */ diff --git a/src/include/reef/audio/mux.h b/src/include/reef/audio/mux.h new file mode 100644 index 0000000..6c6b6af --- /dev/null +++ b/src/include/reef/audio/mux.h @@ -0,0 +1,50 @@ +/* + * Copyright (c) 2017, Intel Corporation + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * * Neither the name of the Intel Corporation nor the + * names of its contributors may be used to endorse or promote products + * derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + * Author: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> + */ + +#ifndef SOF_COMP_MUX_H +#define SOF_COMP_MUX_H + +#include <reef/audio/component.h> +/* + * mux_config data structure + * in_buffer_id - ID of input buffer connected to the MUX component + * out_buffer_id - ID of output buffer connected to the MUX component + * in_buffer - pointer to the connected source buffer + * out_buffer - pointer to the connected sink buffer + */ + +struct mux_config { + uint32_t source_buffer_id, sink_buffer_id; + struct comp_buffer *source_buffer, *sink_buffer; +}; + + + +#endif diff --git a/src/include/uapi/ipc.h b/src/include/uapi/ipc.h index c8cdedb..be4c9f2 100644 --- a/src/include/uapi/ipc.h +++ b/src/include/uapi/ipc.h @@ -641,7 +641,6 @@ struct sof_ipc_comp_eq_iir { struct sof_ipc_comp_config config; } __attribute__((packed)); - /* frees components, buffers and pipelines * SOF_IPC_TPLG_COMP_FREE, SOF_IPC_TPLG_PIPE_FREE, SOF_IPC_TPLG_BUFFER_FREE */ -- 2.9.3

3 3

[Sound-open-firmware] [PATCH] SRC: Sink and source buffers handling bug fixes
by Seppo Ingalsuo 12 Sep '17

12 Sep '17

This patch improves robustness to various buffering settings by adding more check for sufficient buffers sizes vs. internal block processing length of SRC. The resize of sink buffer is changed to allow at least internal output block length plus one period to the buffer. The bug in rejecting disabled SRC modes is fixed in SRC core module. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo(a)linux.intel.com> --- src/audio/src.c | 34 ++++++++++++++++++++++++++++------ src/audio/src_core.c | 23 +++++++++++------------ 2 files changed, 39 insertions(+), 18 deletions(-) diff --git a/src/audio/src.c b/src/audio/src.c index 54c798e..2ecf025 100644 --- a/src/audio/src.c +++ b/src/audio/src.c @@ -60,7 +60,7 @@ struct comp_data { int scratch_length; uint32_t sink_rate; uint32_t source_rate; - uint32_t period_bytes; /* sink period */ + uint32_t period_bytes; /* sink period */ void (*src_func)(struct comp_dev *dev, struct comp_buffer *source, struct comp_buffer *sink, @@ -308,12 +308,12 @@ static int src_params(struct comp_dev *dev) struct sof_ipc_comp_src *src = COMP_GET_IPC(dev, sof_ipc_comp_src); struct sof_ipc_comp_config *config = COMP_GET_CONFIG(dev); struct comp_data *cd = comp_get_drvdata(dev); - struct comp_buffer *sink; + struct comp_buffer *sink, *source; struct src_alloc need; size_t delay_lines_size; uint32_t source_rate, sink_rate; int32_t *buffer_start; - int n = 0, i, err, frames_is_for_source; + int n = 0, i, err, frames_is_for_source, q; trace_src("par"); @@ -405,9 +405,22 @@ static int src_params(struct comp_dev *dev) dev->params.sample_container_bytes * dev->params.channels; cd->period_bytes = dev->frames * dev->frame_bytes; - /* configure downstream buffer */ - sink = list_first_item(&dev->bsink_list, struct comp_buffer, source_list); - err = buffer_set_size(sink, cd->period_bytes * config->periods_sink); + /* The downstream buffer must be at least length of blk_out plus + * dev->frames and an integer multiple of dev->frames. The + * buffer_set_size will return an error if the required length would + * be too long. + */ + q = need.blk_out / dev->frames; + if (q * dev->frames < need.blk_out) + ++q; + + if (q * dev->frames < need.blk_out + dev->frames) + ++q; + + /* Configure downstream buffer */ + sink = list_first_item(&dev->bsink_list, struct comp_buffer, + source_list); + err = buffer_set_size(sink, q * dev->frames * dev->frame_bytes); if (err < 0) { trace_src_error("eSz"); return err; @@ -415,6 +428,15 @@ static int src_params(struct comp_dev *dev) buffer_reset_pos(sink); + /* Check that source buffer has sufficient size */ + source = list_first_item(&dev->bsource_list, struct comp_buffer, + sink_list); + if (source->size < need.blk_in * dev->frame_bytes) { + trace_src_error("eSy"); + return -EINVAL; + } + + return 0; } diff --git a/src/audio/src_core.c b/src/audio/src_core.c index cc44734..a9331a0 100644 --- a/src/audio/src_core.c +++ b/src/audio/src_core.c @@ -151,10 +151,12 @@ int src_buffer_lengths(struct src_alloc *a, int fs_in, int fs_out, int nch, k = max_frames / blk_out; } - /* Return with error if max_frames is too small even for smallest - possible SRC block length. */ + /* Mininum k is 1, when 0 max_frames is less than block length. In + * that case need to check in src.c that sink/source size is large + * enough for at least one block. + */ if (k < 1) - return -EINVAL; + k = 1; a->blk_mult = k; a->blk_in = blk_in * k; @@ -209,9 +211,6 @@ static int init_stages( if (stage1->blk_out == 0) return -EINVAL; } else { - if ((stage1->blk_out == 0) || (stage1->blk_in == 0)) - return -EINVAL; - src->stage1_times = res->stage1_times; src->stage2_times = res->stage2_times; src->blk_in = res->blk_in; @@ -219,14 +218,14 @@ static int init_stages( } /* Delay line sizes */ - src->state1.fir_delay_size = res->fir_s1; //src_fir_delay_length(stage1); - src->state1.out_delay_size = res->out_s1; //src_out_delay_length(stage1); + src->state1.fir_delay_size = res->fir_s1; + src->state1.out_delay_size = res->out_s1; src->state1.fir_delay = delay_lines_start; src->state1.out_delay = src->state1.fir_delay + src->state1.fir_delay_size; if (n > 1) { - src->state2.fir_delay_size = res->fir_s2; // src_fir_delay_length(stage2); - src->state2.out_delay_size = res->out_s2; // src_out_delay_length(stage2); + src->state2.fir_delay_size = res->fir_s2; + src->state2.out_delay_size = res->out_s2; src->state2.fir_delay = src->state1.out_delay + src->state1.out_delay_size; src->state2.out_delay = @@ -289,7 +288,7 @@ int src_polyphase_init(struct polyphase_src *src, int fs1, int fs2, return -EINVAL; /* Get number of stages used for optimize opportunity. 2nd - * stage lenth is one if conversion needs only one stage. + * stage length is one if conversion needs only one stage. */ n_stages = (src->stage2->filter_length == 1) ? 1 : 2; @@ -297,7 +296,7 @@ int src_polyphase_init(struct polyphase_src *src, int fs1, int fs2, * mode from in/out matrix. Computing of such SRC mode needs * to be prevented. */ - if (src->stage2->filter_length == 0) + if (src->stage1->filter_length == 0) return -EINVAL; return n_stages; -- 2.11.0

2 1

[Sound-open-firmware] [PATCH v2 1/2] volume: check if ctrl cmd is for volume component
by Ranjani Sridharan 12 Sep '17

12 Sep '17

This patch adds a fix to check if the ctrl cmd is meant for the volume component and if so, the data is valid. Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- src/audio/volume.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/audio/volume.c b/src/audio/volume.c index 5808bed..363055d 100644 --- a/src/audio/volume.c +++ b/src/audio/volume.c @@ -385,6 +385,11 @@ static int volume_ctrl_set_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *c struct comp_data *cd = comp_get_drvdata(dev); int i, j; + if (cdata == NULL) { + trace_volume_error("Sws"); + return -EINVAL; + } + /* validate */ if (cdata->num_elems == 0 || cdata->num_elems >= SOF_IPC_MAX_CHANNELS) { trace_volume_error("gs0"); @@ -436,6 +441,11 @@ static int volume_ctrl_get_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *c struct comp_data *cd = comp_get_drvdata(dev); int i, j; + if (cdata == NULL) { + trace_volume_error("Swg"); + return -EINVAL; + } + /* validate */ if (cdata->num_elems == 0 || cdata->num_elems >= SOF_IPC_MAX_CHANNELS) { trace_volume_error("gc0"); @@ -469,6 +479,10 @@ static int volume_cmd(struct comp_dev *dev, int cmd, void *data) trace_volume("cmd"); + /* check if the ctrl cmd is for this component */ + if ((cdata != NULL) && (cdata->comp_id != dev->comp.id)) + return 0; + switch (cmd) { case COMP_CMD_SET_VALUE: return volume_ctrl_set_cmd(dev, cdata); -- 2.11.0

2 2

[Sound-open-firmware] [PATCH] volume: ctrl cmd id check and prepare fix
by Ranjani Sridharan 12 Sep '17

12 Sep '17

This patch fixes the following: a. source_period_bytes/sink_period_bytes calculation fix with the correct frame_bytes b. check if the ctrl cmd is for the volume before processing it Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- src/audio/volume.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/audio/volume.c b/src/audio/volume.c index 5808bed..82b8848 100644 --- a/src/audio/volume.c +++ b/src/audio/volume.c @@ -471,9 +471,17 @@ static int volume_cmd(struct comp_dev *dev, int cmd, void *data) switch (cmd) { case COMP_CMD_SET_VALUE: - return volume_ctrl_set_cmd(dev, cdata); + /* check if the ctrl cmd is for this component */ + if ((cdata != NULL) && (cdata->comp_id != dev->comp.id)) + return 0; + else + return volume_ctrl_set_cmd(dev, cdata); case COMP_CMD_GET_VALUE: - return volume_ctrl_get_cmd(dev, cdata); + /* check if the ctrl cmd is for this component */ + if ((cdata != NULL) && (cdata->comp_id != dev->comp.id)) + return 0; + else + return volume_ctrl_get_cmd(dev, cdata); case COMP_CMD_START: case COMP_CMD_STOP: case COMP_CMD_PAUSE: @@ -555,7 +563,7 @@ static int volume_prepare(struct comp_dev *dev) sconfig = COMP_GET_CONFIG(sourceb->source); cd->source_format = sconfig->frame_fmt; cd->source_period_bytes = dev->frames * - sourceb->source->frame_bytes; + comp_frame_bytes(sourceb->source); break; } @@ -575,7 +583,7 @@ static int volume_prepare(struct comp_dev *dev) sconfig = COMP_GET_CONFIG(sinkb->sink); cd->sink_format = sconfig->frame_fmt; cd->sink_period_bytes = dev->frames * - sinkb->sink->frame_bytes; + comp_frame_bytes(sinkb->sink); break; } -- 2.11.0

2 2

[Sound-open-firmware] [PATCH v2 1/2] Switch component added
by Ranjani Sridharan 12 Sep '17

12 Sep '17

This patch adds a new switch component that mutes the pipeline when the when the switch is OFF. Stream data flows through the pipeline normally when it is ON. Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- src/audio/switch.c | 178 +++++++++++++++++++++++++++++++++++++++++++++++-- src/include/uapi/ipc.h | 6 ++ 2 files changed, 178 insertions(+), 6 deletions(-) diff --git a/src/audio/switch.c b/src/audio/switch.c index 7149b61..67f723c 100644 --- a/src/audio/switch.c +++ b/src/audio/switch.c @@ -26,6 +26,7 @@ * POSSIBILITY OF SUCH DAMAGE. * * Author: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> + * Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> */ #include <stdint.h> @@ -40,46 +41,211 @@ #define trace_switch_error(__e) trace_error(TRACE_CLASS_SWITCH, __e) #define tracev_switch(__e) tracev_event(TRACE_CLASS_SWITCH, __e) +/* Simple switch component + * This component copies stream data from source buffer to the sink buffer + * if the switch is ON. Otherwise it discards the source buffer data and + * writes 0's to the sink buffer. + */ + +/* + * switch_comp_data structure + * on_switch - indicates if the switch is ON/OFF + * switch_func - function that performs the routing of input buffer to + * the output buffer based on on_switch + */ +struct switch_comp_data { + int on_switch; + int (*switch_func)(struct comp_dev *dev, struct comp_buffer *sink, + struct comp_buffer *source, uint32_t frames); + +}; + +/* switch function to copy data from source to sink buffer */ +static int switch_function(struct comp_dev *dev, + struct comp_buffer *sink_buffer, + struct comp_buffer *source_buffer, uint32_t frames) +{ + struct sof_ipc_comp_config *config = COMP_GET_CONFIG(dev); + struct switch_comp_data *cd = comp_get_drvdata(dev); + int32_t *src = (int32_t *) source_buffer->r_ptr; + int32_t *dest = (int32_t *) sink_buffer->w_ptr; + int nch = dev->params.channels; + + /* copy source buffer to sink buffer if switch is on */ + if (cd->on_switch == 1) { + /* copy frames from source to destination */ + switch (config->frame_fmt) { + case SOF_IPC_FRAME_S16_LE: + memcpy(dest, src, frames * nch * sizeof(int16_t)); + break; + case SOF_IPC_FRAME_S32_LE: + case SOF_IPC_FRAME_S24_4LE: + case SOF_IPC_FRAME_FLOAT: + memcpy(dest, src, frames * nch * sizeof(int32_t)); + break; + default: + trace_switch_error("SWf"); + return -EINVAL; + } + + return frames; + } + + /* discard source data and copy 0's if switch is off */ + memset(dest, 0, frames * nch * sizeof(int32_t)); + + return frames; +} + static struct comp_dev *switch_new(struct sof_ipc_comp *comp) { - trace_switch("new"); + struct comp_dev *dev; + struct switch_comp_data *cd; + + trace_switch("Swn"); + dev = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, + COMP_SIZE(struct sof_ipc_comp_switch)); + if (dev == NULL) + return NULL; + + memcpy(&dev->comp, comp, sizeof(struct sof_ipc_comp_switch)); - return NULL; + cd = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, sizeof(*cd)); + if (cd == NULL) { + rfree(dev); + return NULL; + } + + /* switch is on by default */ + cd->on_switch = 1; + + comp_set_drvdata(dev, cd); + cd->switch_func = switch_function; + + return dev; } static void switch_free(struct comp_dev *dev) { + struct switch_comp_data *cd = comp_get_drvdata(dev); + rfree(cd); + rfree(dev); } /* set component audio stream paramters */ static int switch_params(struct comp_dev *dev) { - return 0; } +static int switch_ctrl_cmd(struct comp_dev *dev, + struct sof_ipc_ctrl_data *cdata) +{ + struct switch_comp_data *cd = comp_get_drvdata(dev); + int ret = 0; + + if (cdata == NULL) { + trace_switch_error("swe"); + return -EINVAL; + } + + switch (cdata->cmd) { + case SOF_CTRL_CMD_ROUTE: + /* check if the ctrl cmd is for this component */ + if (cdata->comp_id != dev->comp.id) + break; + + if (cdata->num_elems < 1) { + trace_switch_error("Swd"); + ret = -EINVAL; + } + + cd->on_switch = cdata->compv[0].uvalue; + break; + default: + break; + } + + return ret; +} + /* used to pass standard and bespoke commands (with data) to component */ static int switch_cmd(struct comp_dev *dev, int cmd, void *data) { - /* switch will use buffer "connected" status */ - return 0; + struct sof_ipc_ctrl_data *cdata = data; + int ret = 0; + + switch (cmd) { + case COMP_CMD_SET_VALUE: + ret = switch_ctrl_cmd(dev, cdata); + break; + case COMP_CMD_START: + case COMP_CMD_STOP: + case COMP_CMD_PAUSE: + case COMP_CMD_RELEASE: + default: + ret = comp_set_state(dev, cmd); + break; + } + + return ret; } /* copy and process stream data from source to sink buffers */ static int switch_copy(struct comp_dev *dev) { + struct switch_comp_data *cd = comp_get_drvdata(dev); + struct comp_buffer *source_buffer = NULL, *sink_buffer = NULL; + uint32_t copy_bytes; - return 0; + /* get source and sink buffers */ + source_buffer = list_first_item(&dev->bsource_list, struct comp_buffer, + sink_list); + sink_buffer = list_first_item(&dev->bsink_list, struct comp_buffer, + source_list); + + if (!source_buffer || !sink_buffer) { + trace_switch_error("Scp"); + return -EINVAL; + } + + /* check that source has enough frames available and sink enough + * frames free. + */ + copy_bytes = comp_buffer_get_copy_bytes(dev, source_buffer, + sink_buffer); + + if (copy_bytes < dev->params.host_period_bytes) { + trace_switch_error("Scb"); + return -EINVAL; + } + + /* Run passthrough if buffers have enough room */ + cd->switch_func(dev, sink_buffer, source_buffer, dev->frames); + + comp_update_buffer_consume(source_buffer, + dev->params.host_period_bytes); + comp_update_buffer_produce(sink_buffer, dev->params.host_period_bytes); + + return dev->frames; } static int switch_reset(struct comp_dev *dev) { + struct switch_comp_data *cd = comp_get_drvdata(dev); + + /* reset switch to on status */ + cd->on_switch = 1; + dev->state = COMP_STATE_INIT; + return 0; } static int switch_prepare(struct comp_dev *dev) { + dev->state = COMP_STATE_PREPARE; + return 0; } diff --git a/src/include/uapi/ipc.h b/src/include/uapi/ipc.h index 2c2f415..cbef325 100644 --- a/src/include/uapi/ipc.h +++ b/src/include/uapi/ipc.h @@ -616,6 +616,12 @@ struct sof_ipc_comp_mux { struct sof_ipc_comp_config config; } __attribute__((packed)); +/* generic switch component */ +struct sof_ipc_comp_switch { + struct sof_ipc_comp comp; + struct sof_ipc_comp_config config; +} __attribute__((packed)); + /* generic passthrough component */ struct sof_ipc_comp_passthrough { struct sof_ipc_comp comp; -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] topology: SRC: Use 4ms for topology scheduling and increase buffers
by Liam Girdwood 11 Sep '17

11 Sep '17

SRC should be scheduled on at least 4ms tick. Increase buffers to deal with 2 times output rate. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- topology/reef-bxt-nocodec.m4 | 10 +++++----- topology/reef-byt-nocodec.m4 | 4 ++-- topology/reef-byt-rt5640.m4 | 4 ++-- topology/reef-byt-rt5651.m4 | 4 ++-- topology/reef-cht-nocodec.m4 | 8 ++++---- topology/reef-hsw-rt5640.m4 | 10 +++++----- topology/sof/pipe-pcm-media.m4 | 10 ++++++---- 7 files changed, 26 insertions(+), 24 deletions(-) diff --git a/topology/reef-bxt-nocodec.m4 b/topology/reef-bxt-nocodec.m4 index 2028323..486d4ea 100644 --- a/topology/reef-bxt-nocodec.m4 +++ b/topology/reef-bxt-nocodec.m4 @@ -40,14 +40,14 @@ PIPELINE_PCM_ADD(sof/pipe-low-latency-playback.m4, 1, 0, 2, s32le, 48, 1000, 0, PIPELINE_PCM_ADD(sof/pipe-low-latency-capture.m4, 2, 1, 2, s32le, 48, 1000, 0, 0, 0, 2) # PCM Media Playback pipeline 3 on PCM 2 using max 2 channels of s32le. -# Schedule 96 frames per 2000us deadline on core 0 with priority 1 +# Schedule 192 frames per 4000us deadline on core 0 with priority 1 # Use DMAC 0 channel 3 for PCM audio playback data -PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 3, 2, 2, s32le, 96, 2000, 1, 0, 0, 3) +PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 3, 2, 2, s32le, 192, 4000, 1, 0, 0, 3) # PCM Media Playback pipeline 4 on PCM 3 using max 2 channels of s32le. -# Schedule 96 frames per 2000us deadline on core 0 with priority 1 -# Use DMAC 0 channel 4 for PCM audio playback data -PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 4, 3, 2, s32le, 96, 2000, 1, 0, 0, 4) +# Schedule 192 frames per 4000us deadline on core 0 with priority 1 +# Use DMAC 0 channel 3 for PCM audio playback data +PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 3, 2, 2, s32le, 192, 4000, 1, 0, 0, 4) # Tone Playback pipeline 5 using max 2 channels of s32le. # Schedule 192 frames per 4000us deadline on core 0 with priority 2 diff --git a/topology/reef-byt-nocodec.m4 b/topology/reef-byt-nocodec.m4 index 1c3cf5f..938666d 100644 --- a/topology/reef-byt-nocodec.m4 +++ b/topology/reef-byt-nocodec.m4 @@ -38,9 +38,9 @@ PIPELINE_PCM_ADD(sof/pipe-low-latency-playback.m4, 1, 0, 2, s32le, 48, 1000, 0, PIPELINE_PCM_ADD(sof/pipe-low-latency-capture.m4, 2, 1, 2, s32le, 48, 1000, 0, 0, 0, 2) # PCM Media Playback pipeline 3 on PCM 2 using max 2 channels of s32le. -# Schedule 96 frames per 2000us deadline on core 0 with priority 1 +# Schedule 192 frames per 4000us deadline on core 0 with priority 1 # Use DMAC 0 channel 3 for PCM audio playback data -PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 3, 2, 2, s32le, 96, 2000, 1, 0, 0, 3) +PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 3, 2, 2, s32le, 192, 4000, 1, 0, 0, 3) # Tone Playback pipeline 5 using max 2 channels of s32le. # Schedule 192 frames per 4000us deadline on core 0 with priority 2 diff --git a/topology/reef-byt-rt5640.m4 b/topology/reef-byt-rt5640.m4 index 9855f1a..05743e2 100644 --- a/topology/reef-byt-rt5640.m4 +++ b/topology/reef-byt-rt5640.m4 @@ -38,9 +38,9 @@ PIPELINE_PCM_ADD(sof/pipe-low-latency-playback.m4, 1, 0, 2, s32le, 48, 1000, 0, PIPELINE_PCM_ADD(sof/pipe-low-latency-capture.m4, 2, 1, 2, s32le, 48, 1000, 0, 0, 0, 2) # PCM Media Playback pipeline 3 on PCM 2 using max 2 channels of s32le. -# Schedule 96 frames per 2000us deadline on core 0 with priority 1 +# Schedule 192 frames per 4000us deadline on core 0 with priority 1 # Use DMAC 0 channel 3 for PCM audio playback data -PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 3, 2, 2, s32le, 96, 2000, 1, 0, 0, 3) +PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 3, 2, 2, s32le, 192, 4000, 1, 0, 0, 3) # Tone Playback pipeline 5 using max 2 channels of s32le. # Schedule 192 frames per 4000us deadline on core 0 with priority 2 diff --git a/topology/reef-byt-rt5651.m4 b/topology/reef-byt-rt5651.m4 index 1b492b7..cb9dcc2 100644 --- a/topology/reef-byt-rt5651.m4 +++ b/topology/reef-byt-rt5651.m4 @@ -38,9 +38,9 @@ PIPELINE_PCM_ADD(sof/pipe-low-latency-playback.m4, 1, 0, 2, s32le, 48, 1000, 0, PIPELINE_PCM_ADD(sof/pipe-low-latency-capture.m4, 2, 1, 2, s32le, 48, 1000, 0, 0, 0, 2) # PCM Media Playback pipeline 3 on PCM 2 using max 2 channels of s32le. -# Schedule 96 frames per 2000us deadline on core 0 with priority 1 +# Schedule 192 frames per 4000us deadline on core 0 with priority 1 # Use DMAC 0 channel 3 for PCM audio playback data -PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 3, 2, 2, s32le, 96, 2000, 1, 0, 0, 3) +PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 3, 2, 2, s32le, 192, 4000, 1, 0, 0, 3) # Tone Playback pipeline 5 using max 2 channels of s32le. # Schedule 192 frames per 4000us deadline on core 0 with priority 2 diff --git a/topology/reef-cht-nocodec.m4 b/topology/reef-cht-nocodec.m4 index ead0f75..52e8d50 100644 --- a/topology/reef-cht-nocodec.m4 +++ b/topology/reef-cht-nocodec.m4 @@ -37,10 +37,10 @@ PIPELINE_PCM_ADD(sof/pipe-low-latency-playback.m4, 1, 0, 2, s32le, 48, 1000, 0, # Use DMAC 0 channel 2 for PCM audio capture data PIPELINE_PCM_ADD(sof/pipe-low-latency-capture.m4, 2, 1, 2, s32le, 48, 1000, 0, 0, 0, 2) -# PCM Media Playback pipeline 4 on PCM 3 using max 2 channels of s32le. -# Schedule 96 frames per 2000us deadline on core 0 with priority 1 -# Use DMAC 0 channel 4 for PCM audio playback data -PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 4, 3, 2, s32le, 96, 2000, 1, 0, 0, 4) +# PCM Media Playback pipeline 3 on PCM 2 using max 2 channels of s32le. +# Schedule 192 frames per 4000us deadline on core 0 with priority 1 +# Use DMAC 0 channel 3 for PCM audio playback data +PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 3, 2, 2, s32le, 192, 4000, 1, 0, 0, 3) # Tone Playback pipeline 5 using max 2 channels of s32le. # Schedule 192 frames per 4000us deadline on core 0 with priority 2 diff --git a/topology/reef-hsw-rt5640.m4 b/topology/reef-hsw-rt5640.m4 index e4d9392..af18633 100644 --- a/topology/reef-hsw-rt5640.m4 +++ b/topology/reef-hsw-rt5640.m4 @@ -40,14 +40,14 @@ PIPELINE_PCM_ADD(sof/pipe-low-latency-playback.m4, 1, 0, 2, s32le, 48, 1000, 0, PIPELINE_PCM_ADD(sof/pipe-low-latency-capture.m4, 2, 1, 2, s32le, 48, 1000, 0, 0, 0, 2) # PCM Media Playback pipeline 3 on PCM 2 using max 2 channels of s32le. -# Schedule 96 frames per 2000us deadline on core 0 with priority 1 +# Schedule 192 frames per 4000us deadline on core 0 with priority 1 # Use DMAC 0 channel 3 for PCM audio playback data -PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 3, 2, 2, s32le, 96, 2000, 1, 0, 0, 3) +PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 3, 2, 2, s32le, 192, 4000, 1, 0, 0, 3) # PCM Media Playback pipeline 4 on PCM 3 using max 2 channels of s32le. -# Schedule 96 frames per 2000us deadline on core 0 with priority 1 -# Use DMAC 0 channel 4 for PCM audio playback data -PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 4, 3, 2, s32le, 96, 2000, 1, 0, 0, 4) +# Schedule 192 frames per 4000us deadline on core 0 with priority 1 +# Use DMAC 0 channel 3 for PCM audio playback data +PIPELINE_PCM_ADD(sof/pipe-pcm-media.m4, 3, 2, 2, s32le, 192, 4000, 1, 0, 0, 4) # Tone Playback pipeline 5 using max 2 channels of s32le. # Schedule 192 frames per 4000us deadline on core 0 with priority 2 diff --git a/topology/sof/pipe-pcm-media.m4 b/topology/sof/pipe-pcm-media.m4 index bde9dd2..97958cd 100644 --- a/topology/sof/pipe-pcm-media.m4 +++ b/topology/sof/pipe-pcm-media.m4 @@ -73,12 +73,14 @@ W_PGA(0, PCM PCM_ID Playback Volume, PIPELINE_FORMAT, 2, 2, 2) # "SRC 0" has 2 sink and source periods. W_SRC(0, PIPELINE_FORMAT, 2, 2, media_src_conf, 2) -# Media Buffers -W_BUFFER(0, COMP_BUFFER_SIZE(2, +# Media Source Buffers to SRC, make them big enough to deal with 2 * rate. +W_BUFFER(0, COMP_BUFFER_SIZE(4, COMP_SAMPLE_SIZE(PIPELINE_FORMAT), PIPELINE_CHANNELS, SCHEDULE_FRAMES)) -W_BUFFER(1,COMP_BUFFER_SIZE(2, +W_BUFFER(1,COMP_BUFFER_SIZE(4, COMP_SAMPLE_SIZE(PIPELINE_FORMAT), PIPELINE_CHANNELS, SCHEDULE_FRAMES)) -W_BUFFER(2, COMP_BUFFER_SIZE(2, + +# Buffer B2 is on fixed rate sink side of SRC. Set it 1.5 * rate. +W_BUFFER(2, COMP_BUFFER_SIZE(3, COMP_SAMPLE_SIZE(PIPELINE_FORMAT), PIPELINE_CHANNELS, SCHEDULE_FRAMES)) # -- 2.11.0

3 7

[Sound-open-firmware] [PATCH] topology: SRC testing passthrough pipeline.
by Liam Girdwood 11 Sep '17

11 Sep '17

The testing pipline for 24 bit SRC 48kHz output. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- topology/sof/pipe-passthrough-src-playback.m4 | 109 ++++++++++++++++++++++++++ 1 file changed, 109 insertions(+) create mode 100644 topology/sof/pipe-passthrough-src-playback.m4 diff --git a/topology/sof/pipe-passthrough-src-playback.m4 b/topology/sof/pipe-passthrough-src-playback.m4 new file mode 100644 index 0000000..0ffc2a4 --- /dev/null +++ b/topology/sof/pipe-passthrough-src-playback.m4 @@ -0,0 +1,109 @@ +# Low Latency Passthrough with volume Pipeline and PCM +# +# Pipeline Endpoints for connection are :- +# +# host PCM_P --> SRC --> sink DAI0 + +# Include topology builder +include(`local.m4') + + +# +# Components and Buffers +# + +# Host "Passthrough Playback" PCM uses pipeline DMAC and channel +# with 4 sink and 0 source periods +W_PCM_PLAYBACK(Passthrough Playback, PIPELINE_DMAC, PIPELINE_DMAC_CHAN, 4, 0, 2) + +# +# SRC Configuration +# + +SectionVendorTuples."media_src_tokens" { + tokens "sof_src_tokens" + + tuples."word" { + SOF_TKN_SRC_RATE_OUT "48000" + } +} + +SectionData."media_src_conf" { + tuples "media_src_tokens" +} + +# "SRC" has 4 source and 4 sink periods +W_SRC(0, PIPELINE_FORMAT, 4, 4, media_src_conf, 2) + +# Playback Buffers +W_BUFFER(0, COMP_BUFFER_SIZE(4, + COMP_SAMPLE_SIZE(PIPELINE_FORMAT), PIPELINE_CHANNELS, SCHEDULE_FRAMES)) +W_BUFFER(1, COMP_BUFFER_SIZE(4, + COMP_SAMPLE_SIZE(PIPELINE_FORMAT), PIPELINE_CHANNELS, SCHEDULE_FRAMES)) + +# +# DAI definitions +# +W_DAI_OUT(DAI_SNAME, DAI_TYPE, DAI_INDEX, DAI_FORMAT, 0, DAI_PERIODS, + DAI_PERIODS, dai0p_plat_conf) + +# +# DAI pipeline +# +W_PIPELINE(N_DAI_OUT, SCHEDULE_DEADLINE, SCHEDULE_PRIORITY, SCHEDULE_FRAMES, + SCHEDULE_CORE, 0, pipe_dai_schedule_plat) + +# +# Pipeline Graph +# +# host PCM_P --> B0 --> SRC 0 --> B1 --> sink DAI0 + +SectionGraph."pipe-pass-src-playback-PIPELINE_ID" { + index STR(PIPELINE_ID) + + lines [ + dapm(N_PCM, Passthrough Playback PCM_ID) + dapm(N_BUFFER(0), N_PCM) + dapm(N_SRC(0), N_BUFFER(0)) + dapm(N_BUFFER(1), N_SRC(0)) + dapm(N_DAI_OUT, N_BUFFER(1)) + ] +} + + +# +# PCM Configuration +# + +SectionPCMCapabilities.STR(Passthrough Playback PCM_ID) { + + formats "S32_LE,S24_LE,S16_LE" + rate_min "8000" + rate_max "96000" + channels_min "2" + channels_max "4" + periods_min "2" + periods_max "16" + period_size_min "192" + period_size_max "16384" + buffer_size_min "65536" + buffer_size_max "65536" +} + +# PCM Passthrough Playback +SectionPCM.STR(PCM PCM_ID) { + + index STR(PIPELINE_ID) + + # used for binding to the PCM + id STR(PCM_ID) + + dai.STR(Passthrough Playback PCM_ID) { + id STR(PCM_ID) + } + + pcm."playback" { + + capabilities STR(Passthrough Playback PCM_ID) + } +} -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] topology: Add support for DAI pipeline ID config
by Liam Girdwood 11 Sep '17

11 Sep '17

Allow topology to configure the pipeline ID of any DAI specific pipeline instead of using 0. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- topology/m4/build.m4 | 26 +++++++++++++------------- topology/reef-apl-nocodec.m4 | 4 ++-- topology/reef-bdw-rt286.m4 | 4 ++-- topology/reef-bdw-rt5640.m4 | 4 ++-- topology/reef-bxt-nocodec.m4 | 4 ++-- topology/reef-byt-nocodec.m4 | 4 ++-- topology/reef-byt-rt5640.m4 | 4 ++-- topology/reef-byt-rt5651.m4 | 4 ++-- topology/reef-cht-nocodec.m4 | 4 ++-- topology/reef-hsw-rt5640.m4 | 4 ++-- 10 files changed, 31 insertions(+), 31 deletions(-) diff --git a/topology/m4/build.m4 b/topology/m4/build.m4 index 7d248da..273e6b4 100644 --- a/topology/m4/build.m4 +++ b/topology/m4/build.m4 @@ -81,7 +81,7 @@ define(`PIPELINE_ADD', `include($1)' ) -dnl DAI_ADD(pipeline, dai type, dai_index, stream_name, buffer, periods, format, frames, deadline, priority, core) +dnl DAI_ADD(pipeline, pipeline id, dai type, dai_index, stream_name, buffer, periods, format, frames, deadline, priority, core) define(`DAI_ADD', `undefine(`PIPELINE_ID')' `undefine(`DAI_TYPE')' @@ -94,18 +94,18 @@ define(`DAI_ADD', `undefine(`SCHEDULE_DEADLINE')' `undefine(`SCHEDULE_PRIORITY')' `undefine(`SCHEDULE_CORE')' -`define(`PIPELINE_ID', 0)' -`define(`DAI_TYPE', STR($2))' -`define(`DAI_INDEX', STR($3))' -`define(`DAI_SNAME', $4)' -`define(`DAI_BUF', $5)' -`define(`DAI_NAME', $2$3)' -`define(`DAI_PERIODS', $6)' -`define(`DAI_FORMAT', $7)' -`define(`SCHEDULE_FRAMES', $8)' -`define(`SCHEDULE_DEADLINE', $9)' -`define(`SCHEDULE_PRIORITY', $10)' -`define(`SCHEDULE_CORE', $11)' +`define(`PIPELINE_ID', $2)' +`define(`DAI_TYPE', STR($3))' +`define(`DAI_INDEX', STR($4))' +`define(`DAI_SNAME', $5)' +`define(`DAI_BUF', $6)' +`define(`DAI_NAME', $3$4)' +`define(`DAI_PERIODS', $7)' +`define(`DAI_FORMAT', $8)' +`define(`SCHEDULE_FRAMES', $9)' +`define(`SCHEDULE_DEADLINE', $10)' +`define(`SCHEDULE_PRIORITY', $11)' +`define(`SCHEDULE_CORE', $12)' `include($1)' ) diff --git a/topology/reef-apl-nocodec.m4 b/topology/reef-apl-nocodec.m4 index ef80fd3..068c06b 100644 --- a/topology/reef-apl-nocodec.m4 +++ b/topology/reef-apl-nocodec.m4 @@ -75,11 +75,11 @@ SectionGraph."pipe-apl-nocodec" { # playback DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-playback.m4, SSP, 2, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-playback.m4, 1, SSP, 2, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) # capture DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-capture.m4, SSP, 2, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-capture.m4, 1, SSP, 2, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) # # BE configurations - overrides config in ACPI if present diff --git a/topology/reef-bdw-rt286.m4 b/topology/reef-bdw-rt286.m4 index e3f8dd9..1a6042a 100644 --- a/topology/reef-bdw-rt286.m4 +++ b/topology/reef-bdw-rt286.m4 @@ -75,11 +75,11 @@ SectionGraph."pipe-bdw-rt286" { # playback DAI is SSP0 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-playback.m4, SSP, 0, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-playback.m4, 1, SSP, 0, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) # capture DAI is SSP0 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-capture.m4, SSP, 0, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-capture.m4, 1, SSP, 0, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) # # BE configurations - overrides config in ACPI if present diff --git a/topology/reef-bdw-rt5640.m4 b/topology/reef-bdw-rt5640.m4 index 4344605..2453103 100644 --- a/topology/reef-bdw-rt5640.m4 +++ b/topology/reef-bdw-rt5640.m4 @@ -75,11 +75,11 @@ SectionGraph."pipe-bdw-rt5640" { # playback DAI is SSP0 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-playback.m4, SSP, 0, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-playback.m4, 1, SSP, 0, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) # capture DAI is SSP0 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-capture.m4, SSP, 0, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-capture.m4, 1, SSP, 0, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) # # BE configurations - overrides config in ACPI if present diff --git a/topology/reef-bxt-nocodec.m4 b/topology/reef-bxt-nocodec.m4 index 486d4ea..e86b30f 100644 --- a/topology/reef-bxt-nocodec.m4 +++ b/topology/reef-bxt-nocodec.m4 @@ -75,11 +75,11 @@ SectionGraph."pipe-bxt-nocodec" { # playback DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-playback.m4, SSP, 2, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-playback.m4, 1, SSP, 2, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) # capture DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-capture.m4, SSP, 2, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-capture.m4, 1, SSP, 2, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) # # BE configurations - overrides config in ACPI if present diff --git a/topology/reef-byt-nocodec.m4 b/topology/reef-byt-nocodec.m4 index 938666d..27e7468 100644 --- a/topology/reef-byt-nocodec.m4 +++ b/topology/reef-byt-nocodec.m4 @@ -66,11 +66,11 @@ SectionGraph."pipe-byt-nocodec" { # playback DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-playback.m4, SSP, 2, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-playback.m4, 1, SSP, 2, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) # capture DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-capture.m4, SSP, 2, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-capture.m4, 1, SSP, 2, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) # # BE configurations - overrides config in ACPI if present diff --git a/topology/reef-byt-rt5640.m4 b/topology/reef-byt-rt5640.m4 index 05743e2..8d70e52 100644 --- a/topology/reef-byt-rt5640.m4 +++ b/topology/reef-byt-rt5640.m4 @@ -66,11 +66,11 @@ SectionGraph."pipe-byt-rt5640" { # playback DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-playback.m4, SSP, 2, Audio, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-playback.m4, 1, SSP, 2, Audio, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) # capture DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-capture.m4, SSP, 2, Audio, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-capture.m4, 1, SSP, 2, Audio, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) # # BE configurations - overrides config in ACPI if present diff --git a/topology/reef-byt-rt5651.m4 b/topology/reef-byt-rt5651.m4 index cb9dcc2..b759137 100644 --- a/topology/reef-byt-rt5651.m4 +++ b/topology/reef-byt-rt5651.m4 @@ -66,11 +66,11 @@ SectionGraph."pipe-byt-rt5651" { # playback DAI is SSP2 using "Audio" DAPM stream name and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-playback.m4, SSP, 2, Audio, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-playback.m4, 1, SSP, 2, Audio, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) # capture DAI is SSP2 using "Audio" DAPM stream name and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-capture.m4, SSP, 2, Audio, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-capture.m4, 1, SSP, 2, Audio, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) # # BE configurations - overrides config in ACPI if present diff --git a/topology/reef-cht-nocodec.m4 b/topology/reef-cht-nocodec.m4 index 52e8d50..5f2be4c 100644 --- a/topology/reef-cht-nocodec.m4 +++ b/topology/reef-cht-nocodec.m4 @@ -66,11 +66,11 @@ SectionGraph."pipe-cht-nocodec" { # playback DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-playback.m4, SSP, 2, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-playback.m4, 1, SSP, 2, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) # capture DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-capture.m4, SSP, 2, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-capture.m4, 1, SSP, 2, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) # # BE configurations - overrides config in ACPI if present diff --git a/topology/reef-hsw-rt5640.m4 b/topology/reef-hsw-rt5640.m4 index af18633..f64d36b 100644 --- a/topology/reef-hsw-rt5640.m4 +++ b/topology/reef-hsw-rt5640.m4 @@ -75,11 +75,11 @@ SectionGraph."pipe-hsw-rt5640" { # playback DAI is SSP0 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-playback.m4, SSP, 0, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-playback.m4, 1, SSP, 0, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) # capture DAI is SSP0 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-capture.m4, SSP, 0, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-capture.m4, 1, SSP, 0, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) # # BE configurations - overrides config in ACPI if present -- 2.11.0

1 2

[Sound-open-firmware] [PATCH] core: make sure we emit trace errors for when returning error values.
by Liam Girdwood 08 Sep '17

08 Sep '17

Makes debug easier. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/audio/component.c | 1 + src/audio/pipeline.c | 21 ++++++++++++++------- src/ipc/intel-ipc.c | 1 + 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/src/audio/component.c b/src/audio/component.c index 232ef02..2a397d7 100644 --- a/src/audio/component.c +++ b/src/audio/component.c @@ -148,6 +148,7 @@ int comp_set_state(struct comp_dev *dev, int cmd) break; default: trace_comp_error("CEd"); + trace_value(cmd); ret = -EINVAL; break; } diff --git a/src/audio/pipeline.c b/src/audio/pipeline.c index 9aedc21..687efe9 100644 --- a/src/audio/pipeline.c +++ b/src/audio/pipeline.c @@ -465,7 +465,7 @@ static int preload_downstream(struct comp_dev *start, struct comp_dev *current) struct list_item *clist; int i, total = 0, count = 0; - trace_pipe("PR-"); + tracev_pipe("PR-"); tracev_value(current->comp.id); /* reached endpoint ? */ @@ -574,8 +574,11 @@ int pipeline_cmd(struct pipeline *p, struct comp_dev *host, int cmd, ret = component_op_upstream(&op_data, host, host, NULL); } - if (ret < 0) - trace_ipc_error("pae"); + if (ret < 0) { + trace_ipc_error("pc0"); + trace_value(host->comp.id); + trace_value(cmd); + } spin_unlock(&p->lock); return ret; @@ -617,8 +620,10 @@ int pipeline_params(struct pipeline *p, struct comp_dev *host, ret = component_op_upstream(&op_data, host, host, NULL); } - if (ret < 0) - trace_ipc_error("pae"); + if (ret < 0) { + trace_ipc_error("pp0"); + trace_value(host->comp.id); + } spin_unlock(&p->lock); return ret; @@ -645,8 +650,10 @@ int pipeline_reset(struct pipeline *p, struct comp_dev *host) ret = component_op_upstream(&op_data, host, host, NULL); } - if (ret < 0) - trace_ipc_error("pae"); + if (ret < 0) { + trace_ipc_error("pr0"); + trace_value(host->comp.id); + } spin_unlock(&p->lock); return ret; diff --git a/src/ipc/intel-ipc.c b/src/ipc/intel-ipc.c index 3912174..18d8732 100644 --- a/src/ipc/intel-ipc.c +++ b/src/ipc/intel-ipc.c @@ -567,6 +567,7 @@ static int ipc_comp_value(uint32_t header, uint32_t cmd) stream_dev = ipc_get_comp(_ipc, data->comp_id); if (stream_dev == NULL){ trace_ipc_error("eVg"); + trace_value(data->comp_id); return -ENODEV; } -- 2.11.0

1 2

[Sound-open-firmware] [PATCH] topology: Add support for 32bit data to playback and capture PCMs
by Liam Girdwood 08 Sep '17

08 Sep '17

Add S32_LE data support to the PCMs Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- topology/sof/pipe-low-latency-capture.m4 | 2 +- topology/sof/pipe-low-latency-playback.m4 | 2 +- topology/sof/pipe-passthrough-playback.m4 | 2 +- topology/sof/pipe-passthrough-vol-playback.m4 | 2 +- topology/sof/pipe-pcm-media.m4 | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/topology/sof/pipe-low-latency-capture.m4 b/topology/sof/pipe-low-latency-capture.m4 index 111aa86..d041dca 100644 --- a/topology/sof/pipe-low-latency-capture.m4 +++ b/topology/sof/pipe-low-latency-capture.m4 @@ -89,7 +89,7 @@ W_PIPELINE(N_PGA(0), SCHEDULE_DEADLINE, SCHEDULE_PRIORITY, SCHEDULE_FRAMES, SCHE SectionPCMCapabilities.STR(Low Latency Capture PCM_ID) { - formats "S24_LE,S16_LE" + formats "S32_LE,S24_LE,S16_LE" rate_min "48000" rate_max "48000" channels_min "2" diff --git a/topology/sof/pipe-low-latency-playback.m4 b/topology/sof/pipe-low-latency-playback.m4 index a860c82..3db55cf 100644 --- a/topology/sof/pipe-low-latency-playback.m4 +++ b/topology/sof/pipe-low-latency-playback.m4 @@ -155,7 +155,7 @@ W_PIPELINE(N_PGA(1), SCHEDULE_DEADLINE, SCHEDULE_PRIORITY, SCHEDULE_FRAMES, SCHE # PCM capabilities supported by FW SectionPCMCapabilities.STR(Low Latency Playback PCM_ID) { - formats "S24_LE,S16_LE" + formats "S32_LE,S24_LE,S16_LE" rate_min "48000" rate_max "48000" channels_min "2" diff --git a/topology/sof/pipe-passthrough-playback.m4 b/topology/sof/pipe-passthrough-playback.m4 index a6ecb32..732e173 100644 --- a/topology/sof/pipe-passthrough-playback.m4 +++ b/topology/sof/pipe-passthrough-playback.m4 @@ -52,7 +52,7 @@ SectionGraph."pipe-pass-playback-PIPELINE_ID" { SectionPCMCapabilities.STR(Passthrough Playback PCM_ID) { - formats "S24_LE,S16_LE" + formats "S32_LE,S24_LE,S16_LE" rate_min "48000" rate_max "48000" channels_min "2" diff --git a/topology/sof/pipe-passthrough-vol-playback.m4 b/topology/sof/pipe-passthrough-vol-playback.m4 index bf131c3..be3f9ec 100644 --- a/topology/sof/pipe-passthrough-vol-playback.m4 +++ b/topology/sof/pipe-passthrough-vol-playback.m4 @@ -91,7 +91,7 @@ SectionGraph."pipe-pass-vol-playback-PIPELINE_ID" { SectionPCMCapabilities.STR(Passthrough Playback PCM_ID) { - formats "S24_LE,S16_LE" + formats "S32_LE,S24_LE,S16_LE" rate_min "48000" rate_max "48000" channels_min "2" diff --git a/topology/sof/pipe-pcm-media.m4 b/topology/sof/pipe-pcm-media.m4 index 97958cd..b766e23 100644 --- a/topology/sof/pipe-pcm-media.m4 +++ b/topology/sof/pipe-pcm-media.m4 @@ -120,7 +120,7 @@ W_PIPELINE(N_SRC(0), SCHEDULE_DEADLINE, SCHEDULE_PRIORITY, SCHEDULE_FRAMES, SCHE # PCM capabilities supported by FW SectionPCMCapabilities.STR(Media Playback PCM_ID) { - formats "S24_LE,S16_LE" + formats "S32_LE,S24_LE,S16_LE" rate_min "8000" rate_max "192000" channels_min "2" -- 2.11.0

1 0

[Sound-open-firmware] [PATCH v4 1/5] Makefile and configure changes to add testbench
by Ranjani Sridharan 07 Sep '17

07 Sep '17

This patch adds the changes to configure.ac and Makefile to add the testbench directories Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- Makefile.am | 2 +- configure.ac | 5 +++++ tune/Makefile.am | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 tune/Makefile.am diff --git a/Makefile.am b/Makefile.am index ea01286..4f359ea 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1 +1 @@ -SUBDIRS = rimage rmbox topology +SUBDIRS = rimage rmbox topology tune diff --git a/configure.ac b/configure.ac index 87c7519..d5e4f48 100644 --- a/configure.ac +++ b/configure.ac @@ -17,6 +17,11 @@ AC_OUTPUT([ rimage/Makefile rmbox/Makefile topology/Makefile + tune/Makefile + tune/src/Makefile + tune/mux/Makefile + tune/passthrough/Makefile + tune/eq/Makefile ]) echo " diff --git a/tune/Makefile.am b/tune/Makefile.am new file mode 100644 index 0000000..b2dc2d9 --- /dev/null +++ b/tune/Makefile.am @@ -0,0 +1 @@ +SUBDIRS = src eq mux passthrough -- 2.9.3

1 4

[Sound-open-firmware] [PATCH 1/2] comp: buffer: reject buffer size 0 requests.
by Liam Girdwood 07 Sep '17

07 Sep '17

Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/include/reef/audio/buffer.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/include/reef/audio/buffer.h b/src/include/reef/audio/buffer.h index e708ee2..ea9bd9c 100644 --- a/src/include/reef/audio/buffer.h +++ b/src/include/reef/audio/buffer.h @@ -183,6 +183,8 @@ static inline int buffer_set_size(struct comp_buffer *buffer, uint32_t size) { if (size > buffer->alloc_size) return -ENOMEM; + if (size == 0) + return -EINVAL; buffer->end_addr = buffer->addr + size; buffer->size = size; -- 2.11.0

1 1

[Sound-open-firmware] [PATCH v4 1/3] comp: default function to set comp state
by Ranjani Sridharan 07 Sep '17

07 Sep '17

This patch adds a the comp_set_state() used for the mandatory pipeline commands, START, STOP, PAUSE and RELEASE. It also updates the cmd method in existing components to use comp_set_state(). Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- src/audio/component.c | 38 ++++++++++++++++++++++++++++++++++++++ src/audio/eq_fir.c | 23 +---------------------- src/audio/host.c | 16 ++++------------ src/audio/src.c | 25 +++---------------------- src/audio/tone.c | 28 +++++----------------------- src/audio/volume.c | 19 +++---------------- src/include/reef/audio/component.h | 3 +++ 7 files changed, 57 insertions(+), 95 deletions(-) diff --git a/src/audio/component.c b/src/audio/component.c index 6369e2e..232ef02 100644 --- a/src/audio/component.c +++ b/src/audio/component.c @@ -117,6 +117,44 @@ void comp_unregister(struct comp_driver *drv) spin_unlock(&cd->lock); } +int comp_set_state(struct comp_dev *dev, int cmd) +{ + int ret = 0; + + switch (cmd) { + case COMP_CMD_START: + case COMP_CMD_RELEASE: + dev->state = COMP_STATE_RUNNING; + break; + case COMP_CMD_STOP: + if (dev->state == COMP_STATE_RUNNING || + dev->state == COMP_STATE_DRAINING || + dev->state == COMP_STATE_PAUSED) { + comp_buffer_reset(dev); + dev->state = COMP_STATE_SETUP; + } else { + trace_comp_error("CEs"); + ret = -EINVAL; + } + break; + case COMP_CMD_PAUSE: + /* only support pausing for running */ + if (dev->state == COMP_STATE_RUNNING) + dev->state = COMP_STATE_PAUSED; + else { + trace_comp_error("CEp"); + ret = -EINVAL; + } + break; + default: + trace_comp_error("CEd"); + ret = -EINVAL; + break; + } + + return ret; +} + void sys_comp_init(void) { cd = rzalloc(RZONE_SYS, RFLAGS_NONE, sizeof(*cd)); diff --git a/src/audio/eq_fir.c b/src/audio/eq_fir.c index 540c68f..98cd43e 100644 --- a/src/audio/eq_fir.c +++ b/src/audio/eq_fir.c @@ -382,32 +382,11 @@ static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data) ret = fir_cmd(dev, cdata); break; case COMP_CMD_START: - trace_src("EFs"); - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - trace_src("ESp"); - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - trace_src("EPe"); - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - - break; case COMP_CMD_RELEASE: - trace_src("ERl"); - dev->state = COMP_STATE_RUNNING; - break; default: - trace_src("EDf"); - ret = -EINVAL; + ret = comp_set_state(dev, cmd); break; } diff --git a/src/audio/host.c b/src/audio/host.c index e71e95f..f81fd66 100644 --- a/src/audio/host.c +++ b/src/audio/host.c @@ -553,28 +553,20 @@ static int host_cmd(struct comp_dev *dev, int cmd, void *data) // TODO: align cmd macros. switch (cmd) { - case COMP_CMD_PAUSE: - /* only support pausing for running, channel is paused by DAI */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - break; case COMP_CMD_STOP: if (dev->state == COMP_STATE_RUNNING || dev->state == COMP_STATE_DRAINING || dev->state == COMP_STATE_PAUSED) ret = host_stop(dev); break; - case COMP_CMD_RELEASE: - /* channel is released by DAI */ - dev->state = COMP_STATE_RUNNING; - break; - case COMP_CMD_START: - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_SUSPEND: case COMP_CMD_RESUME: break; + case COMP_CMD_START: + case COMP_CMD_PAUSE: + case COMP_CMD_RELEASE: default: + ret = comp_set_state(dev, cmd); break; } diff --git a/src/audio/src.c b/src/audio/src.c index c11ef3f..34cab7a 100644 --- a/src/audio/src.c +++ b/src/audio/src.c @@ -431,6 +431,7 @@ static int src_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) static int src_cmd(struct comp_dev *dev, int cmd, void *data) { struct sof_ipc_ctrl_data *cdata = data; + int ret = 0; trace_src("SCm"); @@ -438,35 +439,15 @@ static int src_cmd(struct comp_dev *dev, int cmd, void *data) case COMP_CMD_SET_VALUE: return src_ctrl_cmd(dev, cdata); case COMP_CMD_START: - trace_src("SSt"); - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - trace_src("SSp"); - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - trace_src("SPe"); - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - - break; case COMP_CMD_RELEASE: - trace_src("SRl"); - dev->state = COMP_STATE_RUNNING; - break; default: - trace_src("SDf"); + ret = comp_set_state(dev, cmd); break; } - return 0; + return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/audio/tone.c b/src/audio/tone.c index 448c472..aec8a72 100644 --- a/src/audio/tone.c +++ b/src/audio/tone.c @@ -434,6 +434,8 @@ static int tone_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) { struct comp_data *cd = comp_get_drvdata(dev); + trace_tone("tri"); + switch (cdata->cmd) { case SOF_CTRL_CMD_MUTE: trace_tone("TMu"); @@ -468,6 +470,7 @@ static int tone_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) static int tone_cmd(struct comp_dev *dev, int cmd, void *data) { struct sof_ipc_ctrl_data *cdata = data; + int ret = 0; trace_tone("tri"); @@ -475,36 +478,15 @@ static int tone_cmd(struct comp_dev *dev, int cmd, void *data) case COMP_CMD_SET_VALUE: return tone_ctrl_cmd(dev, cdata); case COMP_CMD_START: - trace_tone("TSt"); - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - trace_tone("TSp"); - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - trace_tone("TPe"); - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - - break; case COMP_CMD_RELEASE: - trace_tone("TRl"); - dev->state = COMP_STATE_RUNNING; - break; default: - trace_tone("TDf"); - + ret = comp_set_state(dev, cmd); break; } - return 0; + return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/audio/volume.c b/src/audio/volume.c index c88f9d2..d642320 100644 --- a/src/audio/volume.c +++ b/src/audio/volume.c @@ -429,6 +429,7 @@ static int volume_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata static int volume_cmd(struct comp_dev *dev, int cmd, void *data) { struct sof_ipc_ctrl_data *cdata = data; + int ret = 0; trace_volume("cmd"); @@ -436,29 +437,15 @@ static int volume_cmd(struct comp_dev *dev, int cmd, void *data) case COMP_CMD_SET_VALUE: return volume_ctrl_cmd(dev, cdata); case COMP_CMD_START: - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - break; case COMP_CMD_RELEASE: - dev->state = COMP_STATE_RUNNING; - break; default: + ret = comp_set_state(dev, cmd); break; } - return 0; + return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/include/reef/audio/component.h b/src/include/reef/audio/component.h index 9793c36..d7ea29a 100644 --- a/src/include/reef/audio/component.h +++ b/src/include/reef/audio/component.h @@ -214,6 +214,9 @@ static inline void comp_free(struct comp_dev *dev) dev->drv->ops.free(dev); } +/* component state set */ +int comp_set_state(struct comp_dev *dev, int cmd); + /* component parameter init - mandatory */ static inline int comp_params(struct comp_dev *dev) { -- 2.9.3

2 1

[Sound-open-firmware] [PATCH] comp: dai: drain and stop notifications come from host.
by Liam Girdwood 07 Sep '17

07 Sep '17

Make sure all stop/drain notification come from host and not DAI component. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/audio/dai.c | 29 ----------------------------- 1 file changed, 29 deletions(-) diff --git a/src/audio/dai.c b/src/audio/dai.c index e085096..30d3ae9 100644 --- a/src/audio/dai.c +++ b/src/audio/dai.c @@ -121,38 +121,9 @@ static void dai_dma_cb(void *data, uint32_t type, struct dma_sg_elem *next) } } - if (dev->params.direction == SOF_IPC_STREAM_PLAYBACK && - dma_buffer->avail < dd->period_bytes) { - /* end of stream, finish */ - if (dma_buffer->avail == 0) { - dai_cmd(dev, COMP_CMD_STOP, NULL); - - /* stop dma immediately */ - next->size = DMA_RELOAD_END; - - /* let any waiters know we have completed */ - //wait_completed(&dev->pipeline->complete); - - return; - } else { - /* drain the last bytes */ - next->src = (uint32_t)dma_buffer->r_ptr; - next->dest = dai_fifo(dd->dai, SOF_IPC_STREAM_PLAYBACK); - next->size = dma_buffer->avail; - - dd->last_bytes = next->size; - - goto next_copy; - - } - - } - /* notify pipeline that DAI needs it's buffer processed */ pipeline_schedule_copy(dev->pipeline, dev); -next_copy: - return; } -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] comp: buffer: add support for non period aligned buffers
by Liam Girdwood 07 Sep '17

07 Sep '17

Add support for non period aligned buffers to the buffer free/avail calculation. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/include/reef/audio/buffer.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/include/reef/audio/buffer.h b/src/include/reef/audio/buffer.h index 54978a8..83fcd57 100644 --- a/src/include/reef/audio/buffer.h +++ b/src/include/reef/audio/buffer.h @@ -93,7 +93,7 @@ static inline void comp_update_buffer_produce(struct comp_buffer *buffer, /* check for pointer wrap */ if (buffer->w_ptr >= buffer->end_addr) - buffer->w_ptr = buffer->addr; + buffer->w_ptr = buffer->addr + (buffer->w_ptr - buffer->end_addr); /* calculate available bytes */ if (buffer->r_ptr < buffer->w_ptr) @@ -127,7 +127,7 @@ static inline void comp_update_buffer_consume(struct comp_buffer *buffer, /* check for pointer wrap */ if (buffer->r_ptr >= buffer->end_addr) - buffer->r_ptr = buffer->addr; + buffer->r_ptr = buffer->addr + (buffer->r_ptr - buffer->end_addr); /* calculate available bytes */ if (buffer->r_ptr < buffer->w_ptr) -- 2.11.0

1 3

[Sound-open-firmware] [PATCH v3 1/3] comp: default function to set comp state
by Ranjani Sridharan 06 Sep '17

06 Sep '17

This patch adds a the comp_set_state() used for the mandatory pipeline commands, START, STOP, PAUSE and RELEASE. It also updates the cmd method in existing components to use comp_set_state(). Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- src/audio/component.c | 38 ++++++++++++++++++++++++++++++++++++++ src/audio/eq_fir.c | 23 +---------------------- src/audio/host.c | 16 ++++------------ src/audio/src.c | 25 +++---------------------- src/audio/tone.c | 28 +++++----------------------- src/audio/volume.c | 19 +++---------------- src/include/reef/audio/component.h | 3 +++ 7 files changed, 57 insertions(+), 95 deletions(-) diff --git a/src/audio/component.c b/src/audio/component.c index 6369e2e..232ef02 100644 --- a/src/audio/component.c +++ b/src/audio/component.c @@ -117,6 +117,44 @@ void comp_unregister(struct comp_driver *drv) spin_unlock(&cd->lock); } +int comp_set_state(struct comp_dev *dev, int cmd) +{ + int ret = 0; + + switch (cmd) { + case COMP_CMD_START: + case COMP_CMD_RELEASE: + dev->state = COMP_STATE_RUNNING; + break; + case COMP_CMD_STOP: + if (dev->state == COMP_STATE_RUNNING || + dev->state == COMP_STATE_DRAINING || + dev->state == COMP_STATE_PAUSED) { + comp_buffer_reset(dev); + dev->state = COMP_STATE_SETUP; + } else { + trace_comp_error("CEs"); + ret = -EINVAL; + } + break; + case COMP_CMD_PAUSE: + /* only support pausing for running */ + if (dev->state == COMP_STATE_RUNNING) + dev->state = COMP_STATE_PAUSED; + else { + trace_comp_error("CEp"); + ret = -EINVAL; + } + break; + default: + trace_comp_error("CEd"); + ret = -EINVAL; + break; + } + + return ret; +} + void sys_comp_init(void) { cd = rzalloc(RZONE_SYS, RFLAGS_NONE, sizeof(*cd)); diff --git a/src/audio/eq_fir.c b/src/audio/eq_fir.c index 540c68f..98cd43e 100644 --- a/src/audio/eq_fir.c +++ b/src/audio/eq_fir.c @@ -382,32 +382,11 @@ static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data) ret = fir_cmd(dev, cdata); break; case COMP_CMD_START: - trace_src("EFs"); - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - trace_src("ESp"); - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - trace_src("EPe"); - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - - break; case COMP_CMD_RELEASE: - trace_src("ERl"); - dev->state = COMP_STATE_RUNNING; - break; default: - trace_src("EDf"); - ret = -EINVAL; + ret = comp_set_state(dev, cmd); break; } diff --git a/src/audio/host.c b/src/audio/host.c index e71e95f..f81fd66 100644 --- a/src/audio/host.c +++ b/src/audio/host.c @@ -553,28 +553,20 @@ static int host_cmd(struct comp_dev *dev, int cmd, void *data) // TODO: align cmd macros. switch (cmd) { - case COMP_CMD_PAUSE: - /* only support pausing for running, channel is paused by DAI */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - break; case COMP_CMD_STOP: if (dev->state == COMP_STATE_RUNNING || dev->state == COMP_STATE_DRAINING || dev->state == COMP_STATE_PAUSED) ret = host_stop(dev); break; - case COMP_CMD_RELEASE: - /* channel is released by DAI */ - dev->state = COMP_STATE_RUNNING; - break; - case COMP_CMD_START: - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_SUSPEND: case COMP_CMD_RESUME: break; + case COMP_CMD_START: + case COMP_CMD_PAUSE: + case COMP_CMD_RELEASE: default: + ret = comp_set_state(dev, cmd); break; } diff --git a/src/audio/src.c b/src/audio/src.c index c11ef3f..34cab7a 100644 --- a/src/audio/src.c +++ b/src/audio/src.c @@ -431,6 +431,7 @@ static int src_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) static int src_cmd(struct comp_dev *dev, int cmd, void *data) { struct sof_ipc_ctrl_data *cdata = data; + int ret = 0; trace_src("SCm"); @@ -438,35 +439,15 @@ static int src_cmd(struct comp_dev *dev, int cmd, void *data) case COMP_CMD_SET_VALUE: return src_ctrl_cmd(dev, cdata); case COMP_CMD_START: - trace_src("SSt"); - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - trace_src("SSp"); - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - trace_src("SPe"); - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - - break; case COMP_CMD_RELEASE: - trace_src("SRl"); - dev->state = COMP_STATE_RUNNING; - break; default: - trace_src("SDf"); + ret = comp_set_state(dev, cmd); break; } - return 0; + return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/audio/tone.c b/src/audio/tone.c index 448c472..aec8a72 100644 --- a/src/audio/tone.c +++ b/src/audio/tone.c @@ -434,6 +434,8 @@ static int tone_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) { struct comp_data *cd = comp_get_drvdata(dev); + trace_tone("tri"); + switch (cdata->cmd) { case SOF_CTRL_CMD_MUTE: trace_tone("TMu"); @@ -468,6 +470,7 @@ static int tone_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) static int tone_cmd(struct comp_dev *dev, int cmd, void *data) { struct sof_ipc_ctrl_data *cdata = data; + int ret = 0; trace_tone("tri"); @@ -475,36 +478,15 @@ static int tone_cmd(struct comp_dev *dev, int cmd, void *data) case COMP_CMD_SET_VALUE: return tone_ctrl_cmd(dev, cdata); case COMP_CMD_START: - trace_tone("TSt"); - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - trace_tone("TSp"); - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - trace_tone("TPe"); - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - - break; case COMP_CMD_RELEASE: - trace_tone("TRl"); - dev->state = COMP_STATE_RUNNING; - break; default: - trace_tone("TDf"); - + ret = comp_set_state(dev, cmd); break; } - return 0; + return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/audio/volume.c b/src/audio/volume.c index 6cbd6ff..6fa36c4 100644 --- a/src/audio/volume.c +++ b/src/audio/volume.c @@ -429,6 +429,7 @@ static int volume_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata static int volume_cmd(struct comp_dev *dev, int cmd, void *data) { struct sof_ipc_ctrl_data *cdata = data; + int ret = 0; trace_volume("cmd"); @@ -436,29 +437,15 @@ static int volume_cmd(struct comp_dev *dev, int cmd, void *data) case COMP_CMD_SET_VALUE: return volume_ctrl_cmd(dev, cdata); case COMP_CMD_START: - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - break; case COMP_CMD_RELEASE: - dev->state = COMP_STATE_RUNNING; - break; default: + ret = comp_set_state(dev, cmd); break; } - return 0; + return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/include/reef/audio/component.h b/src/include/reef/audio/component.h index 35c80de..e20ffed 100644 --- a/src/include/reef/audio/component.h +++ b/src/include/reef/audio/component.h @@ -214,6 +214,9 @@ static inline void comp_free(struct comp_dev *dev) dev->drv->ops.free(dev); } +/* component state set */ +int comp_set_state(struct comp_dev *dev, int cmd); + /* component parameter init - mandatory */ static inline int comp_params(struct comp_dev *dev) { -- 2.9.3

2 1

[Sound-open-firmware] [PATCH] SRC: Bug fix for copy period length and some init code cleanup
by Seppo Ingalsuo 06 Sep '17

06 Sep '17

The error in computing block length in copy() function is fixed. It caused SRC to use unnecessarily long blocks with some rates and fail to execute within available buffer size. The input and output block length is now computed in initization. Sample rates support mask bit for 7350 Hz is removed also. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo(a)linux.intel.com> --- src/audio/src.c | 26 +++++---- src/audio/src_core.c | 153 +++++++++++++++++++++++++++------------------------ src/audio/src_core.h | 12 +++- 3 files changed, 104 insertions(+), 87 deletions(-) diff --git a/src/audio/src.c b/src/audio/src.c index c11ef3f..d741aeb 100644 --- a/src/audio/src.c +++ b/src/audio/src.c @@ -311,7 +311,7 @@ static int src_params(struct comp_dev *dev) size_t delay_lines_size; uint32_t source_rate, sink_rate; int32_t *buffer_start; - int n = 0, i, err; + int n = 0, i, err, frames_is_for_source; trace_src("par"); @@ -329,21 +329,25 @@ static int src_params(struct comp_dev *dev) sink_rate = src->sink_rate; /* re-write our params with output rate for next component */ params->rate = sink_rate; + frames_is_for_source = 0; } else { /* params rate is sink rate */ source_rate = src->source_rate; sink_rate = params->rate; /* re-write our params with output rate for next component */ params->rate = source_rate; + frames_is_for_source = 1; } /* Allocate needed memory for delay lines */ - err = src_buffer_lengths(&need, source_rate, sink_rate, params->channels); + err = src_buffer_lengths(&need, source_rate, sink_rate, + params->channels, dev->frames, frames_is_for_source); if (err < 0) { trace_src_error("sr1"); trace_value(source_rate); trace_value(sink_rate); trace_value(params->channels); + trace_value(dev->frames); return err; } @@ -371,8 +375,8 @@ static int src_params(struct comp_dev *dev) /* Initize SRC for actual sample rate */ for (i = 0; i < params->channels; i++) { - n = src_polyphase_init(&cd->src[i], source_rate, - sink_rate, buffer_start); + n = src_polyphase_init(&cd->src[i], source_rate, sink_rate, + &need, buffer_start); buffer_start += need.single_src; } @@ -474,7 +478,7 @@ static int src_copy(struct comp_dev *dev) { struct comp_data *cd = comp_get_drvdata(dev); struct comp_buffer *source, *sink; - int need_source, need_sink, blk_in, blk_out, frames_source, frames_sink; + int need_source, need_sink, blk_in, blk_out; trace_comp("SRC"); @@ -484,20 +488,18 @@ static int src_copy(struct comp_dev *dev) sink = list_first_item(&dev->bsink_list, struct comp_buffer, source_list); - /* Check that source has enough frames available and sink enough - * frames free. + /* Calculate needed amount of source buffer and sink buffer + * for one SRC run. */ blk_in = src_polyphase_get_blk_in(&cd->src[0]); blk_out = src_polyphase_get_blk_out(&cd->src[0]); - frames_source = dev->frames * blk_in / blk_out; - frames_sink = frames_source * blk_out / blk_in; - need_source = frames_source * dev->frame_bytes; - need_sink = frames_sink * dev->frame_bytes; + need_source = blk_in * dev->frame_bytes; + need_sink = blk_out * dev->frame_bytes; /* Run as many times as buffers allow */ while ((source->avail >= need_source) && (sink->free >= need_sink)) { /* Run src */ - cd->src_func(dev, source, sink, frames_source, frames_sink); + cd->src_func(dev, source, sink, blk_in, blk_out); /* calc new free and available */ comp_update_buffer_consume(source, 0); diff --git a/src/audio/src_core.c b/src/audio/src_core.c index 55f7062..cc44734 100644 --- a/src/audio/src_core.c +++ b/src/audio/src_core.c @@ -52,8 +52,8 @@ #endif /* TODO: These should be defined somewhere else. */ -#define SOF_RATES_LENGTH 16 -int sof_rates[SOF_RATES_LENGTH] = {7350, 8000, 11025, 12000, 16000, 18900, +#define SOF_RATES_LENGTH 15 +int sof_rates[SOF_RATES_LENGTH] = {8000, 11025, 12000, 16000, 18900, 22050, 24000, 32000, 44100, 48000, 64000, 88200, 96000, 176400, 192000}; @@ -71,20 +71,6 @@ int src_out_delay_length(struct src_stage *s) return (s->num_of_subfilters - 1) * s->odm + 1; } -/* Calculates the buffer length needed between two SRC stages */ -int src_stage_buf_length(struct src_stage *s1, struct src_stage *s2) -{ - int k, s1_times; - - if ((s1->blk_out == 0) || (s2->blk_in == 0)) - return 0; - - k = gcd(s1->blk_out, s2->blk_in); - s1_times = s2->blk_in / k; - - return s1->blk_out * s1_times; -} - /* Returns index of a matching sample rate */ int src_find_fs(int fs_list[], int list_length, int fs) { @@ -126,31 +112,65 @@ int32_t src_output_rates(void) } /* Calculates buffers to allocate for a SRC mode */ -int src_buffer_lengths(struct src_alloc *a, int fs_in, int fs_out, int nch) +int src_buffer_lengths(struct src_alloc *a, int fs_in, int fs_out, int nch, + int max_frames, int max_frames_is_for_source) { - int idx_in, idx_out; + int blk_in, blk_out, k, s1_times, s2_times; struct src_stage *stage1, *stage2; - idx_in = src_find_fs(src_in_fs, NUM_IN_FS, fs_in); - idx_out = src_find_fs(src_out_fs, NUM_OUT_FS, fs_out); + a->idx_in = src_find_fs(src_in_fs, NUM_IN_FS, fs_in); + a->idx_out = src_find_fs(src_out_fs, NUM_OUT_FS, fs_out); - /* Return an error if no in and out match was found. */ - if ((idx_in < 0) || (idx_out < 0)) + /* Set blk_in, blk_out so that the muted fallback SRC keeps + * just source & sink in sync in pipeline without drift. + */ + if ((a->idx_in < 0) || (a->idx_out < 0)) { + k = gcd(fs_in, fs_out); + a->blk_in = fs_in / k; + a->blk_out = fs_out / k; return -EINVAL; + } - stage1 = src_table1[idx_out][idx_in]; - stage2 = src_table2[idx_out][idx_in]; + stage1 = src_table1[a->idx_out][a->idx_in]; + stage2 = src_table2[a->idx_out][a->idx_in]; a->fir_s1 = src_fir_delay_length(stage1); a->out_s1 = src_out_delay_length(stage1); + k = gcd(stage1->blk_out, stage2->blk_in); + s1_times = stage2->blk_in / k; + s2_times = s1_times * stage1->blk_out / stage2->blk_in; + blk_in = s1_times * stage1->blk_in; + blk_out = s2_times * stage2->blk_out; + + /* Find out how many additional times the SRC can be executed + while having block size less or equal to max_frames. + */ + if (max_frames_is_for_source) { + k = max_frames / blk_in; + } else { + k = max_frames / blk_out; + } + + /* Return with error if max_frames is too small even for smallest + possible SRC block length. */ + if (k < 1) + return -EINVAL; + + a->blk_mult = k; + a->blk_in = blk_in * k; + a->blk_out = blk_out * k; + a->stage1_times = s1_times * k; + a->stage2_times = s2_times * k; + if (stage2->filter_length == 1) { a->fir_s2 = 0; a->out_s2 = 0; a->scratch = 0; + a->stage2_times = 0; } else { a->fir_s2 = src_fir_delay_length(stage2); a->out_s2 = src_out_delay_length(stage2); - a->scratch = src_stage_buf_length(stage1, stage2); + a->scratch = stage1->blk_out * s1_times * k; } a->single_src = a->fir_s1 + a->fir_s2 + a->out_s1 + a->out_s2; a->total = a->scratch + nch * a->single_src; @@ -171,10 +191,9 @@ static void src_state_reset(struct src_state *state) static int init_stages( struct src_stage *stage1, struct src_stage *stage2, - struct polyphase_src *src, int n, int32_t *delay_lines_start) + struct polyphase_src *src, struct src_alloc *res, + int n, int32_t *delay_lines_start) { - int k; - /* Clear FIR state */ src_state_reset(&src->state1); src_state_reset(&src->state2); @@ -183,9 +202,9 @@ static int init_stages( src->stage1 = stage1; src->stage2 = stage2; if (n == 1) { - src->blk_in = stage1->blk_in; - src->blk_out = stage1->blk_out; - src->stage1_times = 1; + src->blk_in = stage1->blk_in * res->blk_mult; + src->blk_out = stage1->blk_out * res->blk_mult; + src->stage1_times = res->stage1_times; src->stage2_times = 0; if (stage1->blk_out == 0) return -EINVAL; @@ -193,23 +212,21 @@ static int init_stages( if ((stage1->blk_out == 0) || (stage1->blk_in == 0)) return -EINVAL; - k = gcd(stage1->blk_out, stage2->blk_in); - src->stage1_times = stage2->blk_in / k; - src->stage2_times = - src->stage1_times * stage1->blk_out / stage2->blk_in; - src->blk_in = src->stage1_times * stage1->blk_in; - src->blk_out = src->stage2_times * stage2->blk_out; + src->stage1_times = res->stage1_times; + src->stage2_times = res->stage2_times; + src->blk_in = res->blk_in; + src->blk_out = res->blk_out; } /* Delay line sizes */ - src->state1.fir_delay_size = src_fir_delay_length(stage1); - src->state1.out_delay_size = src_out_delay_length(stage1); + src->state1.fir_delay_size = res->fir_s1; //src_fir_delay_length(stage1); + src->state1.out_delay_size = res->out_s1; //src_out_delay_length(stage1); src->state1.fir_delay = delay_lines_start; src->state1.out_delay = src->state1.fir_delay + src->state1.fir_delay_size; if (n > 1) { - src->state2.fir_delay_size = src_fir_delay_length(stage2); - src->state2.out_delay_size = src_out_delay_length(stage2); + src->state2.fir_delay_size = res->fir_s2; // src_fir_delay_length(stage2); + src->state2.out_delay_size = res->out_s2; // src_out_delay_length(stage2); src->state2.fir_delay = src->state1.out_delay + src->state1.out_delay_size; src->state2.out_delay = @@ -253,45 +270,35 @@ void src_polyphase_reset(struct polyphase_src *src) } int src_polyphase_init(struct polyphase_src *src, int fs1, int fs2, - int32_t *delay_lines_start) + struct src_alloc *res, int32_t *delay_lines_start) { - int f, idx_in, idx_out, n_stages, ret; + int n_stages, ret; struct src_stage *stage1, *stage2; - idx_in = src_find_fs(src_in_fs, NUM_IN_FS, fs1); - idx_out = src_find_fs(src_out_fs, NUM_OUT_FS, fs2); - - if ((idx_in < 0) || (idx_out < 0)) { - ret = -EINVAL; - } else { - /* Get setup for 2 stage conversion */ - stage1 = src_table1[idx_out][idx_in]; - stage2 = src_table2[idx_out][idx_in]; - ret = init_stages(stage1, stage2, src, 2, delay_lines_start); - - /* Get number of stages used for optimize opportunity. 2nd - * stage lenth is one if conversion needs only one stage. - */ - n_stages = (src->stage2->filter_length == 1) ? 1 : 2; - - /* If filter length for first stage is zero this is a deleted - * mode from in/out matrix. Computing of such SRC mode needs - * to be prevented. - */ - if (src->stage2->filter_length == 0) - ret = -EINVAL; + if ((res->idx_in < 0) || (res->idx_out < 0)) { + src->blk_in = res->blk_in; + src->blk_out = res->blk_out; + return -EINVAL; } - if (ret < 0) { - /* Set blk_in, blk_out so that the muted fallback SRC keeps - * just source & sink in sync in pipeline without drift. - */ - f = gcd(fs1, fs2); - src->blk_in = fs1 / f; - src->blk_out = fs2 / f; + /* Get setup for 2 stage conversion */ + stage1 = src_table1[res->idx_out][res->idx_in]; + stage2 = src_table2[res->idx_out][res->idx_in]; + ret = init_stages(stage1, stage2, src, res, 2, delay_lines_start); + if (ret < 0) + return -EINVAL; + + /* Get number of stages used for optimize opportunity. 2nd + * stage lenth is one if conversion needs only one stage. + */ + n_stages = (src->stage2->filter_length == 1) ? 1 : 2; + /* If filter length for first stage is zero this is a deleted + * mode from in/out matrix. Computing of such SRC mode needs + * to be prevented. + */ + if (src->stage2->filter_length == 0) return -EINVAL; - } return n_stages; } diff --git a/src/audio/src_core.h b/src/audio/src_core.h index dae5e53..ae1223a 100644 --- a/src/audio/src_core.h +++ b/src/audio/src_core.h @@ -52,6 +52,13 @@ struct src_alloc { int scratch; int single_src; int total; + int blk_mult; + int blk_in; + int blk_out; + int stage1_times; + int stage2_times; + int idx_in; + int idx_out; }; struct src_stage { @@ -137,14 +144,15 @@ static inline int src_polyphase_get_blk_out(struct polyphase_src *src) void src_polyphase_reset(struct polyphase_src *src); int src_polyphase_init(struct polyphase_src *src, int fs1, int fs2, - int32_t *delay_lines_start); + struct src_alloc *res, int32_t *delay_lines_start); int src_polyphase(struct polyphase_src *src, int32_t x[], int32_t y[], int n_in); void src_polyphase_stage_cir(struct src_stage_prm *s); -int src_buffer_lengths(struct src_alloc *a, int fs_in, int fs_out, int nch); +int src_buffer_lengths(struct src_alloc *a, int fs_in, int fs_out, int nch, + int max_frames, int max_frames_is_for_source); int32_t src_input_rates(void); -- 2.11.0

1 0

[Sound-open-firmware] [PATCH] comp: mixer: report any mixer XRUNs to pipeline.
by Liam Girdwood 06 Sep '17

06 Sep '17

Report any mixer underruns or overruns for each source and sink to pipeline. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/audio/mixer.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/audio/mixer.c b/src/audio/mixer.c index e82b5f0..932c3ad 100644 --- a/src/audio/mixer.c +++ b/src/audio/mixer.c @@ -203,7 +203,7 @@ static int mixer_copy(struct comp_dev *dev) struct mixer_data *md = comp_get_drvdata(dev); struct comp_buffer *sink, *sources[PLATFORM_MAX_STREAMS], *source; struct list_item *blist; - int32_t i = 0, num_mix_sources = 0; + int32_t i = 0, num_mix_sources = 0, xru = 0; tracev_mixer("cpy"); @@ -223,17 +223,19 @@ static int mixer_copy(struct comp_dev *dev) /* make sure no sources have underruns */ for (i = 0; i < num_mix_sources; i++) { if (sources[i]->avail < md->period_bytes) { - trace_mixer("xru"); - trace_value(source[i].source->comp.id); - return 0; + comp_underrun(dev, sources[i], sources[i]->avail, + md->period_bytes); + xru = 1; } } + /* underrun ? */ + if (xru) + return 0; /* make sure sink has no overuns */ sink = list_first_item(&dev->bsink_list, struct comp_buffer, source_list); if (sink->free < md->period_bytes) { - trace_mixer("xro"); - trace_value(sink[i].sink->comp.id); + comp_overrun(dev, sink, sink->free, md->period_bytes); return 0; } -- 2.11.0

1 7

[Sound-open-firmware] [PATCH v3] Passthrough component added
by Ranjani Sridharan 05 Sep '17

05 Sep '17

This patch adds a passthrough component that copies the input stream from the source buffer to the sink buffer. It is meant to serve as a template for creating new components. Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- src/audio/Makefile.am | 3 +- src/audio/passthrough.c | 238 +++++++++++++++++++++++++++++++++++++++++++++++ src/include/reef/trace.h | 1 + src/include/uapi/ipc.h | 7 ++ 4 files changed, 248 insertions(+), 1 deletion(-) create mode 100644 src/audio/passthrough.c diff --git a/src/audio/Makefile.am b/src/audio/Makefile.am index 285422e..c71430c 100644 --- a/src/audio/Makefile.am +++ b/src/audio/Makefile.am @@ -17,7 +17,8 @@ libaudio_a_SOURCES = \ pipeline.c \ pipeline_static.c \ component.c \ - buffer.c + buffer.c \ + passthrough.c libaudio_a_CFLAGS = \ $(ARCH_CFLAGS) \ diff --git a/src/audio/passthrough.c b/src/audio/passthrough.c new file mode 100644 index 0000000..420d502 --- /dev/null +++ b/src/audio/passthrough.c @@ -0,0 +1,238 @@ +/* + * Copyright (c) 2016, Intel Corporation + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * * Neither the name of the Intel Corporation nor the + * names of its contributors may be used to endorse or promote products + * derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + * Author: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> + */ + +#include <stdio.h> +#include <stdint.h> +#include <stddef.h> +#include <reef/lock.h> +#include <reef/alloc.h> +#include <reef/list.h> +#include <reef/stream.h> +#include <reef/trace.h> +#include <reef/audio/component.h> +#include <reef/audio/pipeline.h> +#include <uapi/ipc.h> + +/* tracing */ +#define trace_pass(__e) trace_event(TRACE_CLASS_PASS, __e) +#define trace_pass_error(__e) trace_error(TRACE_CLASS_PASS, __e) +#define tracev_pass(__e) tracev_event(TRACE_CLASS_PASS, __e) + +/* The passthrough component, as the name inplies, allows the source buffer + * to pass through the component, without any processing, to the sink buffer. + * It supports 16-bits and 32-bits data formats. + * This code is intended to be used as a template for creating new components. + */ + +/* + * passthrough_comp_data structure: This is private data that cannot be touched + * outside the component. It contains: + * passthrough_func - function that performs the buffer copy + */ +struct passthrough_comp_data { + int (*passthrough_func)(struct comp_dev *dev, struct comp_buffer *sink, + struct comp_buffer *source, uint32_t frames); + +}; + +/* This function performs memcpy of the stream data from the source buffer to + * the sink buffer. It returns the number of frames that were copied. + */ +static int passthrough_function(struct comp_dev *dev, + struct comp_buffer *sink_buffer, + struct comp_buffer *source_buffer, uint32_t frames) +{ + struct sof_ipc_comp_config *config = COMP_GET_CONFIG(dev); + int32_t *src = (int32_t *) source_buffer->r_ptr; + int32_t *dest = (int32_t *) sink_buffer->w_ptr; + int nch = dev->params.channels; + + /* copy frames from source to destination */ + switch (config->frame_fmt) { + case SOF_IPC_FRAME_S16_LE: + memcpy(dest, src, frames * nch * sizeof(int16_t)); + break; + case SOF_IPC_FRAME_S32_LE: + case SOF_IPC_FRAME_S24_4LE: + case SOF_IPC_FRAME_FLOAT: + memcpy(dest, src, frames * nch * sizeof(int32_t)); + break; + default: + trace_pass_error("PTp"); + return -EINVAL; + } + + return frames; +} + +/* passthrough_new create the new passthrough component and allocates + * memory for the component and its private data. + * It returns a pointer to struct comp_dev that was created. + */ +static struct comp_dev *passthrough_new(struct sof_ipc_comp *comp) +{ + struct comp_dev *dev; + struct passthrough_comp_data *cd; + + trace_pass("PTn"); + dev = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, + COMP_SIZE(struct sof_ipc_comp_passthrough)); + if (dev == NULL) + return NULL; + + memcpy(&dev->comp, comp, sizeof(struct sof_ipc_comp_passthrough)); + + cd = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, sizeof(*cd)); + if (cd == NULL) { + rfree(dev); + return NULL; + } + + comp_set_drvdata(dev, cd); + cd->passthrough_func = passthrough_function; + + return dev; +} + +/* passthrough_free performs the clean-up */ +static void passthrough_free(struct comp_dev *dev) +{ + struct passthrough_comp_data *cd = comp_get_drvdata(dev); + + rfree(cd); + rfree(dev); +} + +/* passthrough_params sets the component audio stream parameters */ +static int passthrough_params(struct comp_dev *dev) +{ + return 0; +} + +/* passthrough_cmd is used to pass standard and bespoke commands (with data) + * to the component + */ +static int passthrough_cmd(struct comp_dev *dev, int cmd, void *data) +{ + int ret = 0; + + switch (cmd) { + case COMP_CMD_START: + case COMP_CMD_STOP: + case COMP_CMD_PAUSE: + case COMP_CMD_RELEASE: + default: + ret = comp_set_state(dev, cmd); + break; + } + + return ret; +} + +/* passthrough_copy is called when stream data flows through the pipeline + * It calls passthrough_function to copy the source buffer to the sink buffer. + * It returns the number of frames that were copied. + */ +static int passthrough_copy(struct comp_dev *dev) +{ + struct passthrough_comp_data *cd = comp_get_drvdata(dev); + struct comp_buffer *source_buffer = NULL, *sink_buffer = NULL; + uint32_t copy_bytes; + + /* get source and sink buffers */ + source_buffer = list_first_item(&dev->bsource_list, struct comp_buffer, + sink_list); + sink_buffer = list_first_item(&dev->bsink_list, struct comp_buffer, + source_list); + + /* check that source has enough frames available and sink enough + * frames free + */ + copy_bytes = comp_buffer_get_copy_bytes(dev, source_buffer, + sink_buffer); + + if (copy_bytes < dev->params.host_period_bytes) { + trace_pass_error("PTc"); + return -EINVAL; + } + + /* Run passthrough if buffers have enough room */ + cd->passthrough_func(dev, sink_buffer, source_buffer, dev->frames); + + comp_update_buffer_consume(source_buffer, + dev->params.host_period_bytes); + comp_update_buffer_produce(sink_buffer, dev->params.host_period_bytes); + + return dev->frames; +} + +/* passthrough_preload is used for preloading the component buffers before + * pipeline start + */ +static int passthrough_preload(struct comp_dev *dev) +{ + return passthrough_copy(dev); +} + +/* passthrough_reset rests the component state */ +static int passthrough_reset(struct comp_dev *dev) +{ + trace_pass("PTe"); + dev->state = COMP_STATE_INIT; + return 0; +} + +/* passthrough_prepare prepares the component for receiving stream data */ +static int passthrough_prepare(struct comp_dev *dev) +{ + trace_pass("PTl"); + dev->state = COMP_STATE_PREPARE; + return 0; +} + +/* passthrough component driver ops */ +struct comp_driver comp_passthrough = { + .type = SOF_COMP_PASSTHROUGH, + .ops = { + .new = passthrough_new, + .free = passthrough_free, + .params = passthrough_params, + .cmd = passthrough_cmd, + .copy = passthrough_copy, + .prepare = passthrough_prepare, + .reset = passthrough_reset, + .preload = passthrough_preload, + }, +}; + +void sys_comp_passthrough_init(void) +{ + comp_register(&comp_passthrough); +} diff --git a/src/include/reef/trace.h b/src/include/reef/trace.h index 300e8d8..b7ec31a 100644 --- a/src/include/reef/trace.h +++ b/src/include/reef/trace.h @@ -87,6 +87,7 @@ #define TRACE_CLASS_TONE (18 << 24) #define TRACE_CLASS_EQ_FIR (19 << 24) #define TRACE_CLASS_EQ_IIR (20 << 24) +#define TRACE_CLASS_PASS (21 << 24) /* move to config.h */ #define TRACE 1 diff --git a/src/include/uapi/ipc.h b/src/include/uapi/ipc.h index be4c9f2..127ecf1 100644 --- a/src/include/uapi/ipc.h +++ b/src/include/uapi/ipc.h @@ -516,6 +516,7 @@ enum sof_comp_type { SOF_COMP_EQ_FIR, SOF_COMP_FILEREAD, /* host test based file IO */ SOF_COMP_FILEWRITE, /* host test based file IO */ + SOF_COMP_PASSTHROUGH, }; /* XRUN action for component */ @@ -615,6 +616,12 @@ struct sof_ipc_comp_mux { struct sof_ipc_comp_config config; } __attribute__((packed)); +/* generic passthrough component */ +struct sof_ipc_comp_passthrough { + struct sof_ipc_comp comp; + struct sof_ipc_comp_config config; +} __attribute__((packed)); + /* generic tone generator component */ struct sof_ipc_comp_tone { struct sof_ipc_comp comp; -- 2.9.3

1 0

[Sound-open-firmware] [PATCH] component: data: Make component get/set data host API generic
by Liam Girdwood 05 Sep '17

05 Sep '17

Make the host API and IPC to set and get component runtime data and values generic with no bespoke commands at the IPC level. Create a generic structure that descibes the type and size of data and whether that data is appended to the IPC message or is available to be DMAed from host. Update the components to use the new structure. Some components like SRC, tone and tone still require some work to export thier ABI. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/audio/eq_fir.c | 58 ++++++++++++++-------- src/audio/eq_iir.c | 53 +++++++++++++-------- src/audio/src.c | 31 ++++++++---- src/audio/tone.c | 49 +++++++++++++------ src/audio/volume.c | 71 +++++++++++++++------------ src/include/reef/audio/component.h | 25 +++++----- src/include/uapi/ipc.h | 98 +++++++++++++++++++++++--------------- src/ipc/intel-ipc.c | 53 ++++++--------------- 8 files changed, 254 insertions(+), 184 deletions(-) diff --git a/src/audio/eq_fir.c b/src/audio/eq_fir.c index 534a4a1..540c68f 100644 --- a/src/audio/eq_fir.c +++ b/src/audio/eq_fir.c @@ -299,26 +299,25 @@ static int eq_fir_params(struct comp_dev *dev) return 0; } -/* used to pass standard and bespoke commands (with data) to component */ -static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data) +static int fir_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) { struct comp_data *cd = comp_get_drvdata(dev); - struct sof_ipc_eq_fir_blob *blob; - struct sof_ipc_eq_fir_switch *assign; - struct eq_fir_update *fir_update; - int i; - int ret = 0; + struct eq_fir_update *fir_update; /* TODO: move this to IPC as it's ABI */ size_t bs; + int i, ret = 0; - trace_src("cmd"); + /* TODO: determine if data is DMAed or appended to cdata */ - switch (cmd) { - case COMP_CMD_EQ_FIR_SWITCH: + switch (cdata->cmd) { + case SOF_CTRL_CMD_EQ_SWITCH: trace_src("EFx"); - assign = (struct sof_ipc_eq_fir_switch *) data; - fir_update = (struct eq_fir_update *) assign->data; + fir_update = (struct eq_fir_update *)cdata->data; ret = eq_fir_switch_response(cd->fir, cd->config, fir_update, PLATFORM_MAX_CHANNELS); + if (ret < 0) { + trace_src_error("ec1"); + return ret; + } /* Print trace information */ tracev_value(fir_update->stream_max_channels); @@ -326,14 +325,13 @@ static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data) tracev_value(fir_update->assign_response[i]); break; - case COMP_CMD_EQ_FIR_CONFIG: + case SOF_CTRL_CMD_EQ_CONFIG: trace_src("EFc"); /* Check and free old config */ eq_fir_free_parameters(&cd->config); /* Copy new config, need to decode data to know the size */ - blob = (struct sof_ipc_eq_fir_blob *) data; - bs = blob->comp.hdr.size - sizeof(struct sof_ipc_hdr); + bs = cdata->num_elems; if (bs > EQ_FIR_MAX_BLOB_SIZE) return -EINVAL; @@ -341,7 +339,7 @@ static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data) if (cd->config == NULL) return -EINVAL; - memcpy(cd->config, blob->data, bs); + memcpy(cd->config, cdata->data, bs); ret = eq_fir_setup(cd->fir, cd->config, PLATFORM_MAX_CHANNELS); /* Print trace information */ @@ -349,20 +347,40 @@ static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data) tracev_value(cd->config->number_of_responses_defined); for (i = 0; i < cd->config->stream_max_channels; i++) tracev_value(cd->config->assign_response[i]); - break; - case COMP_CMD_MUTE: + case SOF_CTRL_CMD_MUTE: trace_src("EFm"); for (i = 0; i < PLATFORM_MAX_CHANNELS; i++) fir_mute(&cd->fir[i]); break; - case COMP_CMD_UNMUTE: + case SOF_CTRL_CMD_UNMUTE: trace_src("EFu"); for (i = 0; i < PLATFORM_MAX_CHANNELS; i++) fir_unmute(&cd->fir[i]); break; + default: + trace_src_error("ec1"); + ret = -EINVAL; + break; + } + + return ret; +} + +/* used to pass standard and bespoke commands (with data) to component */ +static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data) +{ + struct sof_ipc_ctrl_data *cdata = data; + int ret = 0; + + trace_src("cmd"); + + switch (cmd) { + case COMP_CMD_SET_DATA: + ret = fir_cmd(dev, cdata); + break; case COMP_CMD_START: trace_src("EFs"); dev->state = COMP_STATE_RUNNING; @@ -389,6 +407,8 @@ static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data) break; default: trace_src("EDf"); + ret = -EINVAL; + break; } return ret; diff --git a/src/audio/eq_iir.c b/src/audio/eq_iir.c index 0ac2ef9..f75be71 100644 --- a/src/audio/eq_iir.c +++ b/src/audio/eq_iir.c @@ -303,24 +303,17 @@ static int eq_iir_params(struct comp_dev *dev) return 0; } -/* used to pass standard and bespoke commands (with data) to component */ -static int eq_iir_cmd(struct comp_dev *dev, int cmd, void *data) +static int iir_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) { struct comp_data *cd = comp_get_drvdata(dev); - struct sof_ipc_eq_iir_switch *assign; - struct sof_ipc_eq_iir_blob *blob; - struct eq_iir_update *iir_update; - int i; - int ret = 0; + struct eq_iir_update *iir_update; /* TODO: move to IPC header as part of ABI */ + int i, ret = 0; size_t bs; - trace_eq_iir("cmd"); - - switch (cmd) { - case COMP_CMD_EQ_IIR_SWITCH: + switch (cdata->cmd) { + case SOF_CTRL_CMD_EQ_SWITCH: trace_eq_iir("EFx"); - assign = (struct sof_ipc_eq_iir_switch *) data; - iir_update = (struct eq_iir_update *) assign->data; + iir_update = (struct eq_iir_update *) cdata->data; ret = eq_iir_switch_response(cd->iir, cd->config, iir_update, PLATFORM_MAX_CHANNELS); @@ -330,15 +323,13 @@ static int eq_iir_cmd(struct comp_dev *dev, int cmd, void *data) tracev_value(iir_update->assign_response[i]); break; - case COMP_CMD_EQ_IIR_CONFIG: + case SOF_CTRL_CMD_EQ_CONFIG: trace_eq_iir("EFc"); /* Check and free old config */ eq_iir_free_parameters(&cd->config); /* Copy new config, need to decode data to know the size */ - blob = (struct sof_ipc_eq_iir_blob *) data; - bs = blob->comp.hdr.size - sizeof(struct sof_ipc_hdr) - - sizeof(struct sof_ipc_host_buffer); + bs = cdata->num_elems; if (bs > EQ_IIR_MAX_BLOB_SIZE) return -EINVAL; @@ -347,7 +338,7 @@ static int eq_iir_cmd(struct comp_dev *dev, int cmd, void *data) if (cd->config == NULL) return -EINVAL; - memcpy(cd->config, blob->data, bs); + memcpy(cd->config, cdata->data, bs); /* Initialize all channels, the actual number of channels may * not be set yet. */ @@ -360,18 +351,39 @@ static int eq_iir_cmd(struct comp_dev *dev, int cmd, void *data) tracev_value(cd->config->assign_response[i]); break; - case COMP_CMD_MUTE: + case SOF_CTRL_CMD_MUTE: trace_eq_iir("EFm"); for (i = 0; i < PLATFORM_MAX_CHANNELS; i++) iir_mute_df2t(&cd->iir[i]); break; - case COMP_CMD_UNMUTE: + case SOF_CTRL_CMD_UNMUTE: trace_eq_iir("EFu"); for (i = 0; i < PLATFORM_MAX_CHANNELS; i++) iir_unmute_df2t(&cd->iir[i]); break; + default: + trace_eq_iir_error("ec1"); + ret = -EINVAL; + break; + } + + return ret; +} + +/* used to pass standard and bespoke commands (with data) to component */ +static int eq_iir_cmd(struct comp_dev *dev, int cmd, void *data) +{ + struct sof_ipc_ctrl_data *cdata = data; + int ret = 0; + + trace_eq_iir("cmd"); + + switch (cmd) { + case COMP_CMD_SET_DATA: + ret = iir_cmd(dev, cdata); + break; case COMP_CMD_START: trace_eq_iir("EFs"); dev->state = COMP_STATE_RUNNING; @@ -398,6 +410,7 @@ static int eq_iir_cmd(struct comp_dev *dev, int cmd, void *data) break; default: trace_eq_iir("EDf"); + ret = -EINVAL; break; } diff --git a/src/audio/src.c b/src/audio/src.c index 0279841..5dd8345 100644 --- a/src/audio/src.c +++ b/src/audio/src.c @@ -376,29 +376,42 @@ static int src_params(struct comp_dev *dev) return 0; } -/* used to pass standard and bespoke commands (with data) to component */ -static int src_cmd(struct comp_dev *dev, int cmd, void *data) +static int src_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) { - trace_src("SCm"); struct comp_data *cd = comp_get_drvdata(dev); int i; - switch (cmd) { - case COMP_CMD_SRC: - trace_src("SMa"); - break; - case COMP_CMD_MUTE: + switch (cdata->cmd) { + case SOF_CTRL_CMD_MUTE: trace_src("SMu"); for (i = 0; i < PLATFORM_MAX_CHANNELS; i++) src_polyphase_mute(&cd->src[i]); break; - case COMP_CMD_UNMUTE: + case SOF_CTRL_CMD_UNMUTE: trace_src("SUm"); for (i = 0; i < PLATFORM_MAX_CHANNELS; i++) src_polyphase_unmute(&cd->src[i]); break; + default: + trace_src_error("ec1"); + return -EINVAL; + } + + return 0; +} + +/* used to pass standard and bespoke commands (with data) to component */ +static int src_cmd(struct comp_dev *dev, int cmd, void *data) +{ + struct sof_ipc_ctrl_data *cdata = data; + + trace_src("SCm"); + + switch (cmd) { + case COMP_CMD_SET_VALUE: + return src_ctrl_cmd(dev, cdata); case COMP_CMD_START: trace_src("SSt"); dev->state = COMP_STATE_RUNNING; diff --git a/src/audio/tone.c b/src/audio/tone.c index cbc50ac..448c472 100644 --- a/src/audio/tone.c +++ b/src/audio/tone.c @@ -229,6 +229,7 @@ static inline void tonegen_set_f(struct tone_state *sg, int32_t f) sg->f = f; } +#if 0 /* Tone sweep parameters description: * fc - Multiplication factor for frequency as Q2.30 for logarithmic change * ac - Multiplication factor for amplitude as Q2.30 for logarithmic change @@ -250,6 +251,7 @@ static void tonegen_set_sweep(struct tone_state *sg, int32_t fc, int32_t ac, sg->tone_length = (l > 0) ? l : INT32_MAXVALUE; /* Count rate 125 us */ sg->tone_period = (p > 0) ? p : INT32_MAXVALUE; /* Count rate 125 us */ } +#endif /* Tone ramp parameters: * step - Value that is added or subtracted to amplitude. A zero or negative @@ -428,16 +430,22 @@ static int tone_params(struct comp_dev *dev) return 0; } -/* used to pass standard and bespoke commands (with data) to component */ -static int tone_cmd(struct comp_dev *dev, int cmd, void *data) +static int tone_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) { struct comp_data *cd = comp_get_drvdata(dev); - struct sof_ipc_comp_tone *ct; - - trace_tone("tri"); - switch (cmd) { - case COMP_CMD_TONE: + switch (cdata->cmd) { + case SOF_CTRL_CMD_MUTE: + trace_tone("TMu"); + tonegen_mute(&cd->sg); + break; + case SOF_CTRL_CMD_UNMUTE: + trace_tone("TUm"); + tonegen_unmute(&cd->sg); + break; +/* TODO: use comp value list array to set this */ +#if 0 + case SOF_CTRL_TYPE_VALUE_COMP_SET: trace_tone("Tto"); ct = (struct sof_ipc_comp_tone *) data; /* Ignore channels while tone implementation is mono */ @@ -447,14 +455,25 @@ static int tone_cmd(struct comp_dev *dev, int cmd, void *data) ct->length, ct->period, ct->repeats); tonegen_set_linramp(&cd->sg, ct->ramp_step); break; - case COMP_CMD_MUTE: - trace_tone("TMu"); - tonegen_mute(&cd->sg); - break; - case COMP_CMD_UNMUTE: - trace_tone("TUm"); - tonegen_unmute(&cd->sg); - break; +#endif + default: + trace_tone_error("ec1"); + return -EINVAL; + } + + return 0; +} + +/* used to pass standard and bespoke commands (with data) to component */ +static int tone_cmd(struct comp_dev *dev, int cmd, void *data) +{ + struct sof_ipc_ctrl_data *cdata = data; + + trace_tone("tri"); + + switch (cmd) { + case COMP_CMD_SET_VALUE: + return tone_ctrl_cmd(dev, cdata); case COMP_CMD_START: trace_tone("TSt"); dev->state = COMP_STATE_RUNNING; diff --git a/src/audio/volume.c b/src/audio/volume.c index 93a3839..6cbd6ff 100644 --- a/src/audio/volume.c +++ b/src/audio/volume.c @@ -69,16 +69,16 @@ struct comp_data { uint32_t sink_period_bytes; enum sof_ipc_frame source_format; enum sof_ipc_frame sink_format; - uint32_t chan[PLATFORM_MAX_CHANNELS]; - uint32_t volume[PLATFORM_MAX_CHANNELS]; /* current volume */ - uint32_t tvolume[PLATFORM_MAX_CHANNELS]; /* target volume */ - uint32_t mvolume[PLATFORM_MAX_CHANNELS]; /* mute volume */ + uint32_t chan[SOF_IPC_MAX_CHANNELS]; + uint32_t volume[SOF_IPC_MAX_CHANNELS]; /* current volume */ + uint32_t tvolume[SOF_IPC_MAX_CHANNELS]; /* target volume */ + uint32_t mvolume[SOF_IPC_MAX_CHANNELS]; /* mute volume */ void (*scale_vol)(struct comp_dev *dev, struct comp_buffer *sink, struct comp_buffer *source, uint32_t frames); struct work volwork; /* host volume readback */ - struct sof_ipc_ctrl_values *hvol; + struct sof_ipc_ctrl_value_chan *hvol; }; struct comp_func_map { @@ -234,9 +234,9 @@ static void vol_sync_host(struct comp_data *cd, uint32_t chan) if (cd->hvol == NULL) return; - for (i = 0; i < cd->hvol->num_values; i++) { - if (cd->hvol->values[i].channel == cd->chan[chan]) - cd->hvol->values[i].value = cd->volume[chan]; + for (i = 0; i < SOF_IPC_MAX_CHANNELS; i++) { + if (cd->hvol[i].channel == cd->chan[chan]) + cd->hvol[i].value = cd->volume[chan]; } } @@ -380,50 +380,61 @@ static inline void volume_set_chan_unmute(struct comp_dev *dev, int chan) cd->tvolume[chan] = cd->mvolume[chan]; } -/* used to pass standard and bespoke commands (with data) to component */ -static int volume_cmd(struct comp_dev *dev, int cmd, void *data) +static int volume_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) { struct comp_data *cd = comp_get_drvdata(dev); - struct sof_ipc_ctrl_values *cv; int i, j; - trace_volume("cmd"); - - switch (cmd) { - case COMP_CMD_VOLUME: - cv = (struct sof_ipc_ctrl_values*)data; + switch (cdata->cmd) { + case SOF_CTRL_CMD_VOLUME: - for (i = 0; i < PLATFORM_MAX_CHANNELS; i++) { - for (j = 0; j < cv->num_values; j++) { - if (cv->values[j].channel == cd->chan[i]) - volume_set_chan(dev, i, cv->values[j].value); + for (i = 0; i < SOF_IPC_MAX_CHANNELS; i++) { + for (j = 0; j < cdata->num_elems; j++) { + if (cdata->chanv[j].value == cd->chan[i]) + volume_set_chan(dev, i, cdata->chanv[j].value); } } work_schedule_default(&cd->volwork, VOL_RAMP_US); break; - case COMP_CMD_MUTE: - cv = (struct sof_ipc_ctrl_values*)data; + case SOF_CTRL_CMD_MUTE: - for (i = 0; i < PLATFORM_MAX_CHANNELS; i++) { - for (j = 0; j < cv->num_values; j++) { - if (cv->values[j].channel == cd->chan[i]) + for (i = 0; i < SOF_IPC_MAX_CHANNELS; i++) { + for (j = 0; j < cdata->num_elems; j++) { + if (cdata->chanv[j].value == cd->chan[i]) volume_set_chan_mute(dev, i); } } work_schedule_default(&cd->volwork, VOL_RAMP_US); break; - case COMP_CMD_UNMUTE: - cv = (struct sof_ipc_ctrl_values*)data; + case SOF_CTRL_CMD_UNMUTE: - for (i = 0; i < PLATFORM_MAX_CHANNELS; i++) { - for (j = 0; j < cv->num_values; j++) { - if (cv->values[j].channel == cd->chan[i]) + for (i = 0; i < SOF_IPC_MAX_CHANNELS; i++) { + for (j = 0; j < cdata->num_elems; j++) { + if (cdata->chanv[j].value == cd->chan[i]) volume_set_chan_unmute(dev, i); } } work_schedule_default(&cd->volwork, VOL_RAMP_US); break; + default: + trace_volume_error("ec1"); + return -EINVAL; + } + + return 0; +} + +/* used to pass standard and bespoke commands (with data) to component */ +static int volume_cmd(struct comp_dev *dev, int cmd, void *data) +{ + struct sof_ipc_ctrl_data *cdata = data; + + trace_volume("cmd"); + + switch (cmd) { + case COMP_CMD_SET_VALUE: + return volume_ctrl_cmd(dev, cdata); case COMP_CMD_START: dev->state = COMP_STATE_RUNNING; break; diff --git a/src/include/reef/audio/component.h b/src/include/reef/audio/component.h index e73a22a..35c80de 100644 --- a/src/include/reef/audio/component.h +++ b/src/include/reef/audio/component.h @@ -59,7 +59,9 @@ #define COMP_STATE_PAUSED 5 /* component paused */ #define COMP_STATE_RUNNING 6 /* component active */ -/* standard component commands */ +/* + * standard component stream commands + */ #define COMP_CMD_STOP 0 /* stop component stream */ #define COMP_CMD_START 1 /* start component stream */ @@ -69,18 +71,15 @@ #define COMP_CMD_SUSPEND 5 /* suspend component */ #define COMP_CMD_RESUME 6 /* resume component */ -#define COMP_CMD_VOLUME 100 -#define COMP_CMD_MUTE 101 -#define COMP_CMD_UNMUTE 102 -#define COMP_CMD_ROUTE 103 -#define COMP_CMD_SRC 104 -#define COMP_CMD_LOOPBACK 105 - -#define COMP_CMD_TONE 106 /* Tone generator amplitude and frequency */ -#define COMP_CMD_EQ_FIR_CONFIG 107 /* Configuration data for FIR EQ */ -#define COMP_CMD_EQ_FIR_SWITCH 108 /* Update request for FIR EQ */ -#define COMP_CMD_EQ_IIR_CONFIG 109 /* Configuration data for IIR EQ */ -#define COMP_CMD_EQ_IIR_SWITCH 110 /* Response update request for IIR EQ */ +/* + * standard component control commands + */ + +#define COMP_CMD_SET_VALUE 100 +#define COMP_CMD_GET_VALUE 101 +#define COMP_CMD_SET_DATA 102 +#define COMP_CMD_GET_DATA 103 + /* MMAP IPC status */ #define COMP_CMD_IPC_MMAP_RPOS 200 /* host read position */ diff --git a/src/include/uapi/ipc.h b/src/include/uapi/ipc.h index 053390c..c8cdedb 100644 --- a/src/include/uapi/ipc.h +++ b/src/include/uapi/ipc.h @@ -88,15 +88,12 @@ #define SOF_IPC_PM_CLK_GET SOF_CMD_TYPE(0x005) #define SOF_IPC_PM_CLK_REQ SOF_CMD_TYPE(0x006) -/* component - multiple different types */ -#define SOF_IPC_COMP_SET_VOLUME SOF_CMD_TYPE(0x001) -#define SOF_IPC_COMP_GET_VOLUME SOF_CMD_TYPE(0x002) -#define SOF_IPC_COMP_SET_MIXER SOF_CMD_TYPE(0x003) -#define SOF_IPC_COMP_GET_MIXER SOF_CMD_TYPE(0x004) -#define SOF_IPC_COMP_SET_MUX SOF_CMD_TYPE(0x005) -#define SOF_IPC_COMP_GET_MUX SOF_CMD_TYPE(0x006) -#define SOF_IPC_COMP_SET_SRC SOF_CMD_TYPE(0x007) -#define SOF_IPC_COMP_GET_SRC SOF_CMD_TYPE(0x008) +/* component runtime config - multiple different types */ +#define SOF_IPC_COMP_SET_VALUE SOF_CMD_TYPE(0x001) +#define SOF_IPC_COMP_GET_VALUE SOF_CMD_TYPE(0x002) +#define SOF_IPC_COMP_SET_DATA SOF_CMD_TYPE(0x003) +#define SOF_IPC_COMP_GET_DATA SOF_CMD_TYPE(0x004) + /* DAI messages */ #define SOF_IPC_DAI_CONFIG SOF_CMD_TYPE(0x001) @@ -433,24 +430,69 @@ struct sof_ipc_stream_posn { * Component Mixers and Controls */ -struct sof_ipc_ctrl_chan { +/* control data type and direction */ +enum sof_ipc_ctrl_type { + SOF_CTRL_TYPE_VALUE_CHAN_GET = 0, + SOF_CTRL_TYPE_VALUE_CHAN_SET, + SOF_CTRL_TYPE_VALUE_COMP_GET, + SOF_CTRL_TYPE_VALUE_COMP_SET, + SOF_CTRL_TYPE_DATA_GET, + SOF_CTRL_TYPE_DATA_SET, +}; + +/* control command type */ +enum sof_ipc_ctrl_cmd { + SOF_CTRL_CMD_VOLUME = 0, + SOF_CTRL_CMD_ROUTE, + SOF_CTRL_CMD_SRC, + SOF_CTRL_CMD_LOOPBACK, + SOF_CTRL_CMD_EQ_SWITCH, + SOF_CTRL_CMD_EQ_CONFIG, + /* Mute is similar to volume, but maps better onto ALSA switch controls */ + SOF_CTRL_CMD_MUTE, + SOF_CTRL_CMD_UNMUTE, +}; + +/* generic channel mapped value data */ +struct sof_ipc_ctrl_value_chan { enum sof_ipc_chmap channel; uint32_t value; } __attribute__((packed)); -struct sof_ipc_ctrl_values { - struct sof_ipc_hdr hdr; - uint32_t comp_id; - uint32_t num_values; - struct sof_ipc_ctrl_chan values[SOF_IPC_MAX_CHANNELS]; +/* generic component mapped value data */ +struct sof_ipc_ctrl_value_comp { + uint32_t index; /* component source/sink/control index in control */ + union { + uint32_t uvalue; + int32_t svalue; + }; } __attribute__((packed)); -struct sof_ipc_ctrl_get_values { +/* generic control data */ +struct sof_ipc_ctrl_data { struct sof_ipc_hdr hdr; uint32_t comp_id; - uint32_t num_values; + + /* control access and data type */ + enum sof_ipc_ctrl_type type; + enum sof_ipc_ctrl_cmd cmd; + + /* control data - can either be appended or DMAed from host */ + struct sof_ipc_host_buffer buffer; + uint32_t num_elems; /* in array elems or bytes */ + + /* control data - add new types if needed */ + union { + /* channel values can be used by volume type controls */ + struct sof_ipc_ctrl_value_chan chanv[0]; + /* component values used by routing controls like mux, mixer */ + struct sof_ipc_ctrl_value_comp compv[0]; + /* data can be used by binary controls */ + char data[0]; + }; } __attribute__((packed)); + /* * Component */ @@ -599,28 +641,6 @@ struct sof_ipc_comp_eq_iir { struct sof_ipc_comp_config config; } __attribute__((packed)); -/* IPC to pass configuration blobs to equalizers and re-assign responses */ -struct sof_ipc_eq_fir_blob { - struct sof_ipc_comp comp; - struct sof_ipc_host_buffer buffer; - int32_t data[]; -} __attribute__((packed)); - -struct sof_ipc_eq_iir_blob { - struct sof_ipc_comp comp; - struct sof_ipc_host_buffer buffer; - int32_t data[]; -} __attribute__((packed)); - -struct sof_ipc_eq_fir_switch { - struct sof_ipc_comp comp; - int32_t data[]; -} __attribute__((packed)); - -struct sof_ipc_eq_iir_switch { - struct sof_ipc_comp comp; - int32_t data[]; -} __attribute__((packed)); /* frees components, buffers and pipelines * SOF_IPC_TPLG_COMP_FREE, SOF_IPC_TPLG_PIPE_FREE, SOF_IPC_TPLG_BUFFER_FREE diff --git a/src/ipc/intel-ipc.c b/src/ipc/intel-ipc.c index 60001c3..4f397c1 100644 --- a/src/ipc/intel-ipc.c +++ b/src/ipc/intel-ipc.c @@ -559,48 +559,31 @@ static int ipc_glb_pm_message(uint32_t header) * Topology IPC Operations. */ -static int ipc_comp_set_value(uint32_t header, uint32_t cmd) +/* get/set component values or runtime data */ +static int ipc_comp_value(uint32_t header, uint32_t cmd) { struct ipc_comp_dev *stream_dev; - struct sof_ipc_ctrl_values *values = _ipc->comp_data; - - trace_ipc("VoS"); - - /* get the component */ - stream_dev = ipc_get_comp(_ipc, values->comp_id); - if (stream_dev == NULL) { - trace_ipc_error("eVs"); - return -ENODEV; - } - - /* set component values */ - return comp_cmd(stream_dev->cd, cmd, values); -} - -static int ipc_comp_get_value(uint32_t header, uint32_t cmd) -{ - struct ipc_comp_dev *stream_dev; - struct sof_ipc_ctrl_values *values = _ipc->comp_data; + struct sof_ipc_ctrl_data *data = _ipc->comp_data; int ret; trace_ipc("VoG"); /* get the component */ - stream_dev = ipc_get_comp(_ipc, values->comp_id); + stream_dev = ipc_get_comp(_ipc, data->comp_id); if (stream_dev == NULL){ trace_ipc_error("eVg"); return -ENODEV; } /* get component values */ - ret = comp_cmd(stream_dev->cd, COMP_CMD_VOLUME, values); + ret = comp_cmd(stream_dev->cd, cmd, data); if (ret < 0) { trace_ipc_error("eVG"); return ret; } /* write component values to the outbox */ - mailbox_outbox_write(values, 0, sizeof(*values)); + mailbox_outbox_write(0, data, data->hdr.size); return 0; } @@ -610,22 +593,14 @@ static int ipc_glb_comp_message(uint32_t header) uint32_t cmd = (header & SOF_CMD_TYPE_MASK) >> SOF_CMD_TYPE_SHIFT; switch (cmd) { - case iCS(SOF_IPC_COMP_SET_VOLUME): - return ipc_comp_set_value(header, COMP_CMD_VOLUME); - case iCS(SOF_IPC_COMP_GET_VOLUME): - return ipc_comp_get_value(header, COMP_CMD_VOLUME); - case iCS(SOF_IPC_COMP_SET_MIXER): - return ipc_comp_set_value(header, COMP_CMD_ROUTE); - case iCS(SOF_IPC_COMP_GET_MIXER): - return ipc_comp_get_value(header, COMP_CMD_ROUTE); - case iCS(SOF_IPC_COMP_SET_MUX): - return ipc_comp_set_value(header, COMP_CMD_ROUTE); - case iCS(SOF_IPC_COMP_GET_MUX): - return ipc_comp_get_value(header, COMP_CMD_ROUTE); - case iCS(SOF_IPC_COMP_SET_SRC): - return ipc_comp_set_value(header, COMP_CMD_SRC); - case iCS(SOF_IPC_COMP_GET_SRC): - return ipc_comp_get_value(header, COMP_CMD_SRC); + case iCS(SOF_IPC_COMP_SET_VALUE): + return ipc_comp_value(header, COMP_CMD_SET_VALUE); + case iCS(SOF_IPC_COMP_GET_VALUE): + return ipc_comp_value(header, COMP_CMD_GET_VALUE); + case iCS(SOF_IPC_COMP_SET_DATA): + return ipc_comp_value(header, COMP_CMD_SET_DATA); + case iCS(SOF_IPC_COMP_GET_DATA): + return ipc_comp_value(header, COMP_CMD_GET_DATA); default: trace_ipc_error("eCc"); trace_value(header); -- 2.11.0

2 1

[Sound-open-firmware] [PATCH v2 2/2] Passthrough component added
by Ranjani Sridharan 05 Sep '17

05 Sep '17

This patch adds a passthrough component that copies the input stream from the source buffer to the sink buffer. It is meant to serve as a template for creating new components. Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- src/audio/Makefile.am | 3 +- src/audio/passthrough.c | 238 +++++++++++++++++++++++++++++++++++++++++++++++ src/include/reef/trace.h | 1 + src/include/uapi/ipc.h | 7 ++ 4 files changed, 248 insertions(+), 1 deletion(-) create mode 100644 src/audio/passthrough.c diff --git a/src/audio/Makefile.am b/src/audio/Makefile.am index 285422e..c71430c 100644 --- a/src/audio/Makefile.am +++ b/src/audio/Makefile.am @@ -17,7 +17,8 @@ libaudio_a_SOURCES = \ pipeline.c \ pipeline_static.c \ component.c \ - buffer.c + buffer.c \ + passthrough.c libaudio_a_CFLAGS = \ $(ARCH_CFLAGS) \ diff --git a/src/audio/passthrough.c b/src/audio/passthrough.c new file mode 100644 index 0000000..4163db9 --- /dev/null +++ b/src/audio/passthrough.c @@ -0,0 +1,238 @@ +/* + * Copyright (c) 2016, Intel Corporation + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * * Neither the name of the Intel Corporation nor the + * names of its contributors may be used to endorse or promote products + * derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + * Author: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> + */ + +#include <stdio.h> +#include <stdint.h> +#include <stddef.h> +#include <reef/lock.h> +#include <reef/alloc.h> +#include <reef/list.h> +#include <reef/stream.h> +#include <reef/trace.h> +#include <reef/audio/component.h> +#include <reef/audio/pipeline.h> +#include <uapi/ipc.h> + +/* tracing */ +#define trace_pass(__e) trace_event(TRACE_CLASS_PASS, __e) +#define trace_pass_error(__e) trace_error(TRACE_CLASS_PASS, __e) +#define tracev_pass(__e) tracev_event(TRACE_CLASS_PASS, __e) + +/* The passthrough component, as the name inplies, allows the source buffer + * to pass through the component, without any processing, to the sink buffer. + * It supports 16-bits and 32-bits data formats. + * This code is intended to be used as a template for creating new components. + */ + +/* + * passthrough_comp_data structure: This is private data that cannot be touched + * outside the component. It contains: + * passthrough_func - function that performs the buffer copy + */ +struct passthrough_comp_data { + int (*passthrough_func)(struct comp_dev *dev, struct comp_buffer *sink, + struct comp_buffer *source, uint32_t frames); + +}; + +/* This function performs memcpy of the stream data from the source buffer to + * the sink buffer. It returns the number of frames that were copied. + */ +static int passthrough_function(struct comp_dev *dev, + struct comp_buffer *sink_buffer, + struct comp_buffer *source_buffer, uint32_t frames) +{ + struct sof_ipc_comp_config *config = COMP_GET_CONFIG(dev); + int32_t *src = (int32_t *) source_buffer->r_ptr; + int32_t *dest = (int32_t *) sink_buffer->w_ptr; + int nch = dev->params.channels; + + /* copy frames from source to destination */ + switch (config->frame_fmt) { + case SOF_IPC_FRAME_S16_LE: + memcpy(dest, src, frames * nch * sizeof(int16_t)); + break; + case SOF_IPC_FRAME_S32_LE: + case SOF_IPC_FRAME_S24_4LE: + case SOF_IPC_FRAME_FLOAT: + memcpy(dest, src, frames * nch * sizeof(int32_t)); + break; + default: + trace_pass_error("PTp"); + return -EINVAL; + } + + return frames; +} + +/* passthrough_new create the new passthrough component and allocates + * memory for the component and its private data. + * It returns a pointer to struct comp_dev that was created. + */ +static struct comp_dev *passthrough_new(struct sof_ipc_comp *comp) +{ + struct comp_dev *dev; + struct passthrough_comp_data *cd; + + trace_pass("PTn"); + dev = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, + COMP_SIZE(struct sof_ipc_comp_passthrough)); + if (dev == NULL) + return NULL; + + memcpy(&dev->comp, comp, sizeof(struct sof_ipc_comp_passthrough)); + + cd = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, sizeof(*cd)); + if (cd == NULL) { + rfree(dev); + return NULL; + } + + comp_set_drvdata(dev, cd); + cd->passthrough_func = passthrough_function; + + return dev; +} + +/* passthrough_free performs the clean-up */ +static void passthrough_free(struct comp_dev *dev) +{ + struct passthrough_comp_data *cd = comp_get_drvdata(dev); + + rfree(cd); + rfree(dev); +} + +/* passthrough_params sets the component audio stream parameters */ +static int passthrough_params(struct comp_dev *dev) +{ + return 0; +} + +/* passthrough_cmd is used to pass standard and bespoke commands (with data) + * to the component + */ +static int passthrough_cmd(struct comp_dev *dev, int cmd, void *data) +{ + int ret = 0; + + switch (cmd) { + case COMP_CMD_START: + case COMP_CMD_STOP: + case COMP_CMD_PAUSE: + case COMP_CMD_RELEASE: + default: + ret = comp_set_state(dev, cmd); + break; + } + + return ret; +} + +/* passthrough_copy is called when stream data flows through the pipeline + * It calls passthrough_function to copy the source buffer to the sink buffer. + * It returns the number of frames that were copied. + */ +static int passthrough_copy(struct comp_dev *dev) +{ + struct passthrough_comp_data *cd = comp_get_drvdata(dev); + struct comp_buffer *source_buffer = NULL, *sink_buffer = NULL; + uint32_t copy_bytes; + + /* get source and sink buffers */ + source_buffer = list_first_item(&dev->bsource_list, struct comp_buffer, + sink_list); + sink_buffer = list_first_item(&dev->bsink_list, struct comp_buffer, + source_list); + + /* check that source has enough frames available and sink enough + * frames free + */ + copy_bytes = comp_buffer_get_copy_bytes(dev, source_buffer, + sink_buffer); + + if (copy_bytes < dev->frames * dev->frame_bytes) { + trace_pass_error("PTc"); + return -EINVAL; + } + + /* Run passthrough if buffers have enough room */ + cd->passthrough_func(dev, sink_buffer, source_buffer, dev->frames); + + comp_update_buffer_consume(source_buffer, + dev->params.host_period_bytes); + comp_update_buffer_produce(sink_buffer, dev->params.host_period_bytes); + + return dev->frames; +} + +/* passthrough_preload is used for preloading the component buffers before + * pipeline start + */ +static int passthrough_preload(struct comp_dev *dev) +{ + return passthrough_copy(dev); +} + +/* passthrough_reset rests the component state */ +static int passthrough_reset(struct comp_dev *dev) +{ + trace_pass("PTe"); + dev->state = COMP_STATE_INIT; + return 0; +} + +/* passthrough_prepare prepares the component for receiving stream data */ +static int passthrough_prepare(struct comp_dev *dev) +{ + trace_pass("PTl"); + dev->state = COMP_STATE_PREPARE; + return 0; +} + +/* passthrough component driver ops */ +struct comp_driver comp_passthrough = { + .type = SOF_COMP_PASSTHROUGH, + .ops = { + .new = passthrough_new, + .free = passthrough_free, + .params = passthrough_params, + .cmd = passthrough_cmd, + .copy = passthrough_copy, + .prepare = passthrough_prepare, + .reset = passthrough_reset, + .preload = passthrough_preload, + }, +}; + +void sys_comp_passthrough_init(void) +{ + comp_register(&comp_passthrough); +} diff --git a/src/include/reef/trace.h b/src/include/reef/trace.h index 300e8d8..b7ec31a 100644 --- a/src/include/reef/trace.h +++ b/src/include/reef/trace.h @@ -87,6 +87,7 @@ #define TRACE_CLASS_TONE (18 << 24) #define TRACE_CLASS_EQ_FIR (19 << 24) #define TRACE_CLASS_EQ_IIR (20 << 24) +#define TRACE_CLASS_PASS (21 << 24) /* move to config.h */ #define TRACE 1 diff --git a/src/include/uapi/ipc.h b/src/include/uapi/ipc.h index be4c9f2..127ecf1 100644 --- a/src/include/uapi/ipc.h +++ b/src/include/uapi/ipc.h @@ -516,6 +516,7 @@ enum sof_comp_type { SOF_COMP_EQ_FIR, SOF_COMP_FILEREAD, /* host test based file IO */ SOF_COMP_FILEWRITE, /* host test based file IO */ + SOF_COMP_PASSTHROUGH, }; /* XRUN action for component */ @@ -615,6 +616,12 @@ struct sof_ipc_comp_mux { struct sof_ipc_comp_config config; } __attribute__((packed)); +/* generic passthrough component */ +struct sof_ipc_comp_passthrough { + struct sof_ipc_comp comp; + struct sof_ipc_comp_config config; +} __attribute__((packed)); + /* generic tone generator component */ struct sof_ipc_comp_tone { struct sof_ipc_comp comp; -- 2.9.3

1 0

[Sound-open-firmware] [PATCH] topology: byt-rt5640: Fix stream name for BE DAI link
by Liam Girdwood 04 Sep '17

04 Sep '17

Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- topology/reef-byt-rt5640.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/topology/reef-byt-rt5640.m4 b/topology/reef-byt-rt5640.m4 index 0629d43..9855f1a 100644 --- a/topology/reef-byt-rt5640.m4 +++ b/topology/reef-byt-rt5640.m4 @@ -66,11 +66,11 @@ SectionGraph."pipe-byt-rt5640" { # playback DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-playback.m4, SSP, 2, I2S, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-playback.m4, SSP, 2, Audio, PIPELINE_SOURCE_1, 2, s24le, 48, 1000, 0, 0) # capture DAI is SSP2 using I2S DAPM stream and 2 periods # Buffers use s24le format, with 48 frame per 1000us on core 0 with priorty 0 -DAI_ADD(sof/pipe-dai-capture.m4, SSP, 2, I2S, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) +DAI_ADD(sof/pipe-dai-capture.m4, SSP, 2, Audio, PIPELINE_SINK_2, 2, s24le, 48, 1000, 0, 0) # # BE configurations - overrides config in ACPI if present -- 2.11.0

1 0

[Sound-open-firmware] [PATCH v2 1/3] comp: default function to set comp state
by Ranjani Sridharan 04 Sep '17

04 Sep '17

This patch adds a the comp_set_state() used for the mandatory pipeline commands, START, STOP, PAUSE and RELEASE. It also updates the cmd method in existing components to use comp_set_state(). Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- src/audio/component.c | 38 ++++++++++++++++++++++++++++++++++++++ src/audio/eq_fir.c | 23 +---------------------- src/audio/host.c | 16 ++++------------ src/audio/src.c | 26 +++----------------------- src/audio/tone.c | 29 ++++++----------------------- src/audio/volume.c | 21 ++++----------------- src/include/reef/audio/component.h | 3 +++ 7 files changed, 59 insertions(+), 97 deletions(-) diff --git a/src/audio/component.c b/src/audio/component.c index 6369e2e..232ef02 100644 --- a/src/audio/component.c +++ b/src/audio/component.c @@ -117,6 +117,44 @@ void comp_unregister(struct comp_driver *drv) spin_unlock(&cd->lock); } +int comp_set_state(struct comp_dev *dev, int cmd) +{ + int ret = 0; + + switch (cmd) { + case COMP_CMD_START: + case COMP_CMD_RELEASE: + dev->state = COMP_STATE_RUNNING; + break; + case COMP_CMD_STOP: + if (dev->state == COMP_STATE_RUNNING || + dev->state == COMP_STATE_DRAINING || + dev->state == COMP_STATE_PAUSED) { + comp_buffer_reset(dev); + dev->state = COMP_STATE_SETUP; + } else { + trace_comp_error("CEs"); + ret = -EINVAL; + } + break; + case COMP_CMD_PAUSE: + /* only support pausing for running */ + if (dev->state == COMP_STATE_RUNNING) + dev->state = COMP_STATE_PAUSED; + else { + trace_comp_error("CEp"); + ret = -EINVAL; + } + break; + default: + trace_comp_error("CEd"); + ret = -EINVAL; + break; + } + + return ret; +} + void sys_comp_init(void) { cd = rzalloc(RZONE_SYS, RFLAGS_NONE, sizeof(*cd)); diff --git a/src/audio/eq_fir.c b/src/audio/eq_fir.c index 540c68f..98cd43e 100644 --- a/src/audio/eq_fir.c +++ b/src/audio/eq_fir.c @@ -382,32 +382,11 @@ static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data) ret = fir_cmd(dev, cdata); break; case COMP_CMD_START: - trace_src("EFs"); - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - trace_src("ESp"); - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - trace_src("EPe"); - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - - break; case COMP_CMD_RELEASE: - trace_src("ERl"); - dev->state = COMP_STATE_RUNNING; - break; default: - trace_src("EDf"); - ret = -EINVAL; + ret = comp_set_state(dev, cmd); break; } diff --git a/src/audio/host.c b/src/audio/host.c index e71e95f..f81fd66 100644 --- a/src/audio/host.c +++ b/src/audio/host.c @@ -553,28 +553,20 @@ static int host_cmd(struct comp_dev *dev, int cmd, void *data) // TODO: align cmd macros. switch (cmd) { - case COMP_CMD_PAUSE: - /* only support pausing for running, channel is paused by DAI */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - break; case COMP_CMD_STOP: if (dev->state == COMP_STATE_RUNNING || dev->state == COMP_STATE_DRAINING || dev->state == COMP_STATE_PAUSED) ret = host_stop(dev); break; - case COMP_CMD_RELEASE: - /* channel is released by DAI */ - dev->state = COMP_STATE_RUNNING; - break; - case COMP_CMD_START: - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_SUSPEND: case COMP_CMD_RESUME: break; + case COMP_CMD_START: + case COMP_CMD_PAUSE: + case COMP_CMD_RELEASE: default: + ret = comp_set_state(dev, cmd); break; } diff --git a/src/audio/src.c b/src/audio/src.c index c11ef3f..056822f 100644 --- a/src/audio/src.c +++ b/src/audio/src.c @@ -404,7 +404,7 @@ static int src_params(struct comp_dev *dev) static int src_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) { struct comp_data *cd = comp_get_drvdata(dev); - int i; + int i, ret = 0; switch (cdata->cmd) { case SOF_CTRL_CMD_MUTE: @@ -438,35 +438,15 @@ static int src_cmd(struct comp_dev *dev, int cmd, void *data) case COMP_CMD_SET_VALUE: return src_ctrl_cmd(dev, cdata); case COMP_CMD_START: - trace_src("SSt"); - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - trace_src("SSp"); - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - trace_src("SPe"); - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - - break; case COMP_CMD_RELEASE: - trace_src("SRl"); - dev->state = COMP_STATE_RUNNING; - break; default: - trace_src("SDf"); + ret = comp_set_state(dev, cmd); break; } - return 0; + return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/audio/tone.c b/src/audio/tone.c index 448c472..5d844b2 100644 --- a/src/audio/tone.c +++ b/src/audio/tone.c @@ -433,6 +433,10 @@ static int tone_params(struct comp_dev *dev) static int tone_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) { struct comp_data *cd = comp_get_drvdata(dev); + struct sof_ipc_comp_tone *ct; + int ret = 0; + + trace_tone("tri"); switch (cdata->cmd) { case SOF_CTRL_CMD_MUTE: @@ -475,36 +479,15 @@ static int tone_cmd(struct comp_dev *dev, int cmd, void *data) case COMP_CMD_SET_VALUE: return tone_ctrl_cmd(dev, cdata); case COMP_CMD_START: - trace_tone("TSt"); - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - trace_tone("TSp"); - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - trace_tone("TPe"); - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - - break; case COMP_CMD_RELEASE: - trace_tone("TRl"); - dev->state = COMP_STATE_RUNNING; - break; default: - trace_tone("TDf"); - + ret = comp_set_state(dev, cmd); break; } - return 0; + return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/audio/volume.c b/src/audio/volume.c index 6cbd6ff..cde117c 100644 --- a/src/audio/volume.c +++ b/src/audio/volume.c @@ -383,7 +383,8 @@ static inline void volume_set_chan_unmute(struct comp_dev *dev, int chan) static int volume_ctrl_cmd(struct comp_dev *dev, struct sof_ipc_ctrl_data *cdata) { struct comp_data *cd = comp_get_drvdata(dev); - int i, j; + struct sof_ipc_ctrl_values *cv; + int i, j, ret = 0; switch (cdata->cmd) { case SOF_CTRL_CMD_VOLUME: @@ -436,29 +437,15 @@ static int volume_cmd(struct comp_dev *dev, int cmd, void *data) case COMP_CMD_SET_VALUE: return volume_ctrl_cmd(dev, cdata); case COMP_CMD_START: - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - break; case COMP_CMD_RELEASE: - dev->state = COMP_STATE_RUNNING; - break; default: + ret = comp_set_state(dev, cmd); break; } - return 0; + return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/include/reef/audio/component.h b/src/include/reef/audio/component.h index 35c80de..e20ffed 100644 --- a/src/include/reef/audio/component.h +++ b/src/include/reef/audio/component.h @@ -214,6 +214,9 @@ static inline void comp_free(struct comp_dev *dev) dev->drv->ops.free(dev); } +/* component state set */ +int comp_set_state(struct comp_dev *dev, int cmd); + /* component parameter init - mandatory */ static inline int comp_params(struct comp_dev *dev) { -- 2.9.3

1 0

[Sound-open-firmware] [PATCH] pipeline: fixed return value from preload_downstream
by Ranjani Sridharan 04 Sep '17

04 Sep '17

This patch fixes the return value from the preload_downstream() call in pipeline_params() Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- src/audio/pipeline.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/audio/pipeline.c b/src/audio/pipeline.c index 4327254..49a0c51 100644 --- a/src/audio/pipeline.c +++ b/src/audio/pipeline.c @@ -505,7 +505,7 @@ static int preload_downstream(struct comp_dev *start, struct comp_dev *current) int pipeline_prepare(struct pipeline *p, struct comp_dev *dev) { struct op_data op_data; - int ret, count, i; + int ret, i; trace_pipe("pre"); @@ -527,10 +527,10 @@ int pipeline_prepare(struct pipeline *p, struct comp_dev *dev) * trigger start */ for (i = 0; i < MAX_PRELOAD_SIZE; i++) { - count = preload_downstream(dev, dev); + ret = preload_downstream(dev, dev); /* complete ? */ - if (count <= 0) + if (ret <= 0) goto out; } -- 2.9.3

2 1

[Sound-open-firmware] [PATCH] rmbox: check for non printable chars in trace.
by Liam Girdwood 04 Sep '17

04 Sep '17

Non printable means trace is a value. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- rmbox/rmbox.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/rmbox/rmbox.c b/rmbox/rmbox.c index 1f81e06..3ef6fb4 100644 --- a/rmbox/rmbox.c +++ b/rmbox/rmbox.c @@ -19,6 +19,7 @@ #include <stdint.h> #include <errno.h> #include <string.h> +#include <ctype.h> // TODO: include all this stuff @@ -135,6 +136,12 @@ static void show_trace(uint32_t val, uint32_t addr, uint32_t *timestamp, float c return; } + /* check for printable values - otherwise it's a value */ + if (!isprint((char)(val >> 16)) || !isprint((char)(val >> 8)) || !isprint((char)val)) { + printf("value 0x%8.8x\n", (uint32_t)val); + return; + } + class = val & 0xff000000; if (class == TRACE_CLASS_IRQ) trace = "irq"; -- 2.11.0

1 0

[Sound-open-firmware] [PATCH v1 1/3] comp: default function to set comp state
by Ranjani Sridharan 04 Sep '17

04 Sep '17

This patch adds a the comp_set_state() used for the mandatory pipeline commands, START, STOP, PAUSE and RELEASE. It also updates the cmd method in existing components to use comp_set_state(). Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- src/audio/component.c | 36 ++++++++++++++++++++++++++++++++++++ src/audio/eq_fir.c | 23 ++--------------------- src/audio/host.c | 16 ++++------------ src/audio/src.c | 26 +++----------------------- src/audio/tone.c | 26 +++----------------------- src/audio/volume.c | 20 +++----------------- src/include/reef/audio/component.h | 3 +++ 7 files changed, 54 insertions(+), 96 deletions(-) diff --git a/src/audio/component.c b/src/audio/component.c index 6369e2e..6f2e0c3 100644 --- a/src/audio/component.c +++ b/src/audio/component.c @@ -117,6 +117,42 @@ void comp_unregister(struct comp_driver *drv) spin_unlock(&cd->lock); } +int comp_set_state(struct comp_dev *dev, int cmd) +{ + int ret = 0; + + switch (cmd) { + case COMP_CMD_START: + case COMP_CMD_RELEASE: + dev->state = COMP_STATE_RUNNING; + break; + case COMP_CMD_STOP: + if (dev->state == COMP_STATE_RUNNING || + dev->state == COMP_STATE_DRAINING || + dev->state == COMP_STATE_PAUSED) { + comp_buffer_reset(dev); + dev->state = COMP_STATE_SETUP; + } else { + trace_comp_error("CEs"); + ret = -EINVAL; + } + break; + case COMP_CMD_PAUSE: + /* only support pausing for running */ + if (dev->state == COMP_STATE_RUNNING) + dev->state = COMP_STATE_PAUSED; + else { + trace_comp_error("CEp"); + ret = -EINVAL; + } + break; + default: + break; + } + + return ret; +} + void sys_comp_init(void) { cd = rzalloc(RZONE_SYS, RFLAGS_NONE, sizeof(*cd)); diff --git a/src/audio/eq_fir.c b/src/audio/eq_fir.c index 534a4a1..6380340 100644 --- a/src/audio/eq_fir.c +++ b/src/audio/eq_fir.c @@ -364,31 +364,12 @@ static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data) break; case COMP_CMD_START: - trace_src("EFs"); - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - trace_src("ESp"); - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - trace_src("EPe"); - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - - break; case COMP_CMD_RELEASE: - trace_src("ERl"); - dev->state = COMP_STATE_RUNNING; - break; default: - trace_src("EDf"); + ret = comp_set_state(dev, cmd); + break; } return ret; diff --git a/src/audio/host.c b/src/audio/host.c index e71e95f..f81fd66 100644 --- a/src/audio/host.c +++ b/src/audio/host.c @@ -553,28 +553,20 @@ static int host_cmd(struct comp_dev *dev, int cmd, void *data) // TODO: align cmd macros. switch (cmd) { - case COMP_CMD_PAUSE: - /* only support pausing for running, channel is paused by DAI */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - break; case COMP_CMD_STOP: if (dev->state == COMP_STATE_RUNNING || dev->state == COMP_STATE_DRAINING || dev->state == COMP_STATE_PAUSED) ret = host_stop(dev); break; - case COMP_CMD_RELEASE: - /* channel is released by DAI */ - dev->state = COMP_STATE_RUNNING; - break; - case COMP_CMD_START: - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_SUSPEND: case COMP_CMD_RESUME: break; + case COMP_CMD_START: + case COMP_CMD_PAUSE: + case COMP_CMD_RELEASE: default: + ret = comp_set_state(dev, cmd); break; } diff --git a/src/audio/src.c b/src/audio/src.c index 0279841..0ecb48c 100644 --- a/src/audio/src.c +++ b/src/audio/src.c @@ -381,7 +381,7 @@ static int src_cmd(struct comp_dev *dev, int cmd, void *data) { trace_src("SCm"); struct comp_data *cd = comp_get_drvdata(dev); - int i; + int i, ret = 0; switch (cmd) { case COMP_CMD_SRC: @@ -400,35 +400,15 @@ static int src_cmd(struct comp_dev *dev, int cmd, void *data) break; case COMP_CMD_START: - trace_src("SSt"); - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - trace_src("SSp"); - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - trace_src("SPe"); - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - - break; case COMP_CMD_RELEASE: - trace_src("SRl"); - dev->state = COMP_STATE_RUNNING; - break; default: - trace_src("SDf"); + ret = comp_set_state(dev, cmd); break; } - return 0; + return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/audio/tone.c b/src/audio/tone.c index cbc50ac..305563e 100644 --- a/src/audio/tone.c +++ b/src/audio/tone.c @@ -433,6 +433,7 @@ static int tone_cmd(struct comp_dev *dev, int cmd, void *data) { struct comp_data *cd = comp_get_drvdata(dev); struct sof_ipc_comp_tone *ct; + int ret = 0; trace_tone("tri"); @@ -456,36 +457,15 @@ static int tone_cmd(struct comp_dev *dev, int cmd, void *data) tonegen_unmute(&cd->sg); break; case COMP_CMD_START: - trace_tone("TSt"); - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - trace_tone("TSp"); - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - trace_tone("TPe"); - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - - break; case COMP_CMD_RELEASE: - trace_tone("TRl"); - dev->state = COMP_STATE_RUNNING; - break; default: - trace_tone("TDf"); - + ret = comp_set_state(dev, cmd); break; } - return 0; + return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/audio/volume.c b/src/audio/volume.c index 93a3839..2e097d5 100644 --- a/src/audio/volume.c +++ b/src/audio/volume.c @@ -385,7 +385,7 @@ static int volume_cmd(struct comp_dev *dev, int cmd, void *data) { struct comp_data *cd = comp_get_drvdata(dev); struct sof_ipc_ctrl_values *cv; - int i, j; + int i, j, ret = 0; trace_volume("cmd"); @@ -425,29 +425,15 @@ static int volume_cmd(struct comp_dev *dev, int cmd, void *data) work_schedule_default(&cd->volwork, VOL_RAMP_US); break; case COMP_CMD_START: - dev->state = COMP_STATE_RUNNING; - break; case COMP_CMD_STOP: - if (dev->state == COMP_STATE_RUNNING || - dev->state == COMP_STATE_DRAINING || - dev->state == COMP_STATE_PAUSED) { - comp_buffer_reset(dev); - dev->state = COMP_STATE_SETUP; - } - break; case COMP_CMD_PAUSE: - /* only support pausing for running */ - if (dev->state == COMP_STATE_RUNNING) - dev->state = COMP_STATE_PAUSED; - break; case COMP_CMD_RELEASE: - dev->state = COMP_STATE_RUNNING; - break; default: + ret = comp_set_state(dev, cmd); break; } - return 0; + return ret; } /* copy and process stream data from source to sink buffers */ diff --git a/src/include/reef/audio/component.h b/src/include/reef/audio/component.h index e73a22a..cbd2356 100644 --- a/src/include/reef/audio/component.h +++ b/src/include/reef/audio/component.h @@ -215,6 +215,9 @@ static inline void comp_free(struct comp_dev *dev) dev->drv->ops.free(dev); } +/* component state set */ +int comp_set_state(struct comp_dev *dev, int cmd); + /* component parameter init - mandatory */ static inline int comp_params(struct comp_dev *dev) { -- 2.9.3

2 5

[Sound-open-firmware] [PATCH] alloc: Add support for allocating different types of memory from the heap
by Keyon Jie 04 Sep '17

04 Sep '17

To add support for different types of heap memory, here it will: 1. add handle for RFLAGS_DMA which will allocate DMA buffer blocks if exist; 2. refine free_block, which will free blocks of runtime heap, general buffer heap, or dma buffer heap. Signed-off-by: Keyon Jie <yang.jie(a)linux.intel.com> Tested-by: Zhang Keqiao <keqiao.zhang(a)intel.com> --- src/lib/alloc.c | 82 +++++++++++++++++++++++++++++++++++++++------------------ 1 file changed, 56 insertions(+), 26 deletions(-) diff --git a/src/lib/alloc.c b/src/lib/alloc.c index 86c2bc7..e28817b 100644 --- a/src/lib/alloc.c +++ b/src/lib/alloc.c @@ -334,20 +334,38 @@ found: /* free block(s) */ static void free_block(struct mm_heap *heap, void *ptr) { - struct block_map *map; + struct mm_heap * mm_heap; + struct block_map * block_map; struct block_hdr *hdr; - int i, block; + int i, block, array_size; /* sanity check */ if (ptr == NULL) return; + /* find mm_heap that ptr belongs to */ + if ((uint32_t)ptr >= memmap.runtime.heap && + (uint32_t)ptr < memmap.runtime.heap + memmap.runtime.size) { + mm_heap = &memmap.runtime; + array_size = ARRAY_SIZE(rt_heap_map); + } else if ((uint32_t)ptr >= memmap.buffer.heap && + (uint32_t)ptr < memmap.buffer.heap + memmap.buffer.size) { + mm_heap = &memmap.buffer; + array_size = ARRAY_SIZE(buf_heap_map); +#if (HEAP_DMA_BUFFER_SIZE > 0) + } else if ((uint32_t)ptr >= memmap.dma.heap && + (uint32_t)ptr < memmap.dma.heap + memmap.dma.size) { + mm_heap = &memmap.dma; + array_size = ARRAY_SIZE(dma_buf_heap_map); +#endif + } else + return; + /* find block that ptr belongs to */ - for (i = 0; i < ARRAY_SIZE(rt_heap_map) - 1; i ++) { + for (i = 0; i < array_size - 1; i ++) { /* is ptr in this block */ - if ((uint32_t)ptr >= rt_heap_map[i].base && - (uint32_t)ptr < rt_heap_map[i + 1].base) + if ((uint32_t)ptr < mm_heap->map[i + 1].base) goto found; } @@ -356,27 +374,29 @@ static void free_block(struct mm_heap *heap, void *ptr) return; found: + /* the block i is it */ + block_map = &mm_heap->map[i]; + /* calculate block header */ - map = &rt_heap_map[i]; - block = ((uint32_t)ptr - map->base) / map->block_size; - hdr = &map->block[block]; + block = ((uint32_t)ptr - block_map->base) / block_map->block_size; + hdr = &block_map->block[block]; /* free block header and continious blocks */ for (i = block; i < block + hdr->size; i++) { - hdr = &map->block[i]; + hdr = &block_map->block[i]; hdr->size = 0; hdr->flags = 0; - map->free_count++; - heap->info.used -= map->block_size; - heap->info.free += map->block_size; + block_map->free_count++; + heap->info.used -= block_map->block_size; + heap->info.free += block_map->block_size; } /* set first free */ - if (block < map->first_free) - map->first_free = block; + if (block < block_map->first_free) + block_map->first_free = block; #if DEBUG_BLOCK_FREE - alloc_memset_region(ptr, map->block_size * (i - 1), DEBUG_BLOCK_FREE_VALUE); + alloc_memset_region(ptr, block_map->block_size * (i - 1), DEBUG_BLOCK_FREE_VALUE); #endif } @@ -443,47 +463,57 @@ void *rzalloc(int zone, int bflags, size_t bytes) /* allocates continuous buffer on 1k boundary */ void *rballoc(int zone, int bflags, size_t bytes) { + struct block_map * block_map = buf_heap_map; + struct mm_heap * mm_heap = &memmap.buffer; + int i, array_size = ARRAY_SIZE(buf_heap_map); uint32_t flags; void *ptr = NULL; - int i; +#if (HEAP_DMA_BUFFER_SIZE > 0) + if (bflags & RFLAGS_DMA) { + mm_heap = &memmap.dma; + block_map = dma_buf_heap_map; + array_size = ARRAY_SIZE(dma_buf_heap_map); + } +#endif spin_lock_irq(&memmap.lock, flags); /* will request fit in single block */ - for (i = 0; i < ARRAY_SIZE(buf_heap_map); i++) { + for (i = 0; i < array_size; i++) { + trace_value(block_map[i].block_size); /* is block big enough */ - if (buf_heap_map[i].block_size < bytes) + if (block_map[i].block_size < bytes) continue; /* does block have free space */ - if (buf_heap_map[i].free_count == 0) + if (block_map[i].free_count == 0) continue; /* allocate block */ - ptr = alloc_block(&memmap.buffer, i, bflags); + ptr = alloc_block(mm_heap, i, bflags); goto out; } /* request spans > 1 block */ /* only 1 choice for block size */ - if (ARRAY_SIZE(buf_heap_map) == 1) { - ptr = alloc_cont_blocks(&memmap.buffer, 0, bflags, bytes); + if (array_size == 1) { + ptr = alloc_cont_blocks(mm_heap, 0, bflags, bytes); goto out; } else { /* find best block size for request */ - for (i = 0; i < ARRAY_SIZE(buf_heap_map); i++) { + for (i = 0; i < array_size; i++) { /* allocate is block size smaller than request */ - if (buf_heap_map[i].block_size < bytes) - alloc_cont_blocks(&memmap.buffer, i, bflags, + if (block_map[i].block_size < bytes) + alloc_cont_blocks(mm_heap, i, bflags, bytes); } } - ptr = alloc_cont_blocks(&memmap.buffer, ARRAY_SIZE(buf_heap_map) - 1, + ptr = alloc_cont_blocks(mm_heap, array_size - 1, bflags, bytes); out: -- 2.11.0

2 1

[Sound-open-firmware] [PATCH] sof: abi: Add component ABI header for host configuration
by Liam Girdwood 04 Sep '17

04 Sep '17

Add an ABI header to be pre-pended to all binary blobs or bespoke component data structures that will be passed from host to DSP component or vice versa (i.e via binary kcontrols). Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/include/uapi/Makefile.am | 3 ++- src/include/uapi/abi.h | 50 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+), 1 deletion(-) create mode 100644 src/include/uapi/abi.h diff --git a/src/include/uapi/Makefile.am b/src/include/uapi/Makefile.am index b49560c..c4c2fe6 100644 --- a/src/include/uapi/Makefile.am +++ b/src/include/uapi/Makefile.am @@ -1,2 +1,3 @@ include_HEADERS = \ - ipc.h + ipc.h \ + abi.h diff --git a/src/include/uapi/abi.h b/src/include/uapi/abi.h new file mode 100644 index 0000000..66ec16a --- /dev/null +++ b/src/include/uapi/abi.h @@ -0,0 +1,50 @@ +/* + * Copyright (c) 2016, Intel Corporation + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * * Neither the name of the Intel Corporation nor the + * names of its contributors may be used to endorse or promote products + * derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + * Author: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> + */ + +#ifndef __INCLUDE_UAPI_ABI_H__ +#define __INCLUDE_UAPI_ABI_H__ + +#define SOF_ABI_VERSION 1 + +/* + * Header for all non IPC ABI data. Identifies data type, size and ABI. + * Used by any bespoke component data structures or binary blobs. + */ + +struct sof_abi_hdr { + char magic[4]; /* 'S', 'O', 'F', '\0' */ + uint32_t type; /* component specific type */ + uint32_t size; /* size in bytes of data excluding this struct */ + uint32_t abi; /* SOF ABI version */ + uint32_t comp_abi; /* component specific ABI version */ +} __attribute__((packed)); + +#endif + -- 2.11.0

1 0

[Sound-open-firmware] [PATCH 1/4] SRC: Bug fixes, add support for int16 coefficients, comments cleanup
by Seppo Ingalsuo 04 Sep '17

04 Sep '17

This patch fixes bugs in sink and source buffers handling and adds support for short coefficient type to save RAM in platforms with less space such as BYT. The patch introduces also a RAM saving minimum conversions set between 16, 44.1, and 48 kHz. A new possible rate 18.9 kHz was added to supported rates indication bits. SRC filters quality is also adjusted for lower default performance. The higher performance will need >16bit coefficients usage. The larger conversion set and 32 bit filter coefficients can be easily restored with the SRC tools in rimage. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo(a)linux.intel.com> --- src/audio/src.c | 62 +- src/audio/src_core.c | 67 +- src/audio/src_core.h | 11 + .../coefficients/src/src_int16_1_3_4375_5000.h | 251 +++++ .../coefficients/src/src_int16_20_21_4020_5000.h | 1066 ++++++++++++++++++++ .../coefficients/src/src_int16_21_20_4020_5000.h | 1056 +++++++++++++++++++ .../coefficients/src/src_int16_3_1_4375_5000.h | 252 +++++ .../coefficients/src/src_int16_7_8_4375_5000.h | 657 ++++++++++++ .../coefficients/src/src_int16_8_7_4375_5000.h | 662 ++++++++++++ .../reef/audio/coefficients/src/src_int16_define.h | 11 + .../reef/audio/coefficients/src/src_int16_table.h | 32 + 11 files changed, 4076 insertions(+), 51 deletions(-) create mode 100644 src/include/reef/audio/coefficients/src/src_int16_1_3_4375_5000.h create mode 100644 src/include/reef/audio/coefficients/src/src_int16_20_21_4020_5000.h create mode 100644 src/include/reef/audio/coefficients/src/src_int16_21_20_4020_5000.h create mode 100644 src/include/reef/audio/coefficients/src/src_int16_3_1_4375_5000.h create mode 100644 src/include/reef/audio/coefficients/src/src_int16_7_8_4375_5000.h create mode 100644 src/include/reef/audio/coefficients/src/src_int16_8_7_4375_5000.h create mode 100644 src/include/reef/audio/coefficients/src/src_int16_define.h create mode 100644 src/include/reef/audio/coefficients/src/src_int16_table.h diff --git a/src/audio/src.c b/src/audio/src.c index 074c041..0279841 100644 --- a/src/audio/src.c +++ b/src/audio/src.c @@ -60,7 +60,6 @@ struct comp_data { int scratch_length; uint32_t sink_rate; uint32_t source_rate; - //int32_t z[STAGE_BUF_SIZE]; void (*src_func)(struct comp_dev *dev, struct comp_buffer *source, struct comp_buffer *sink, @@ -117,8 +116,6 @@ static void fallback_s32(struct comp_dev *dev, { struct comp_data *cd = comp_get_drvdata(dev); - //int32_t *src = (int32_t*) source->r_ptr; - //int32_t *dest = (int32_t*) sink->w_ptr; int nch = dev->params.channels; int blk_in = cd->src[0].blk_in; int blk_out = cd->src[0].blk_out; @@ -253,7 +250,7 @@ static struct comp_dev *src_new(struct sof_ipc_comp *comp) { struct comp_dev *dev; struct sof_ipc_comp_src *src; - struct sof_ipc_comp_src *ipc_src = (struct sof_ipc_comp_src *)comp; + struct sof_ipc_comp_src *ipc_src = (struct sof_ipc_comp_src *) comp; struct comp_data *cd; int i; @@ -264,7 +261,7 @@ static struct comp_dev *src_new(struct sof_ipc_comp *comp) if (dev == NULL) return NULL; - src = (struct sof_ipc_comp_src *)&dev->comp; + src = (struct sof_ipc_comp_src *) &dev->comp; memcpy(src, ipc_src, sizeof(struct sof_ipc_comp_src)); cd = rzalloc(RZONE_RUNTIME, RFLAGS_NONE, sizeof(*cd)); @@ -312,7 +309,7 @@ static int src_params(struct comp_dev *dev) trace_src("par"); - /* EQ supports only S32_LE PCM format */ + /* SRC supports only S32_LE PCM format */ if (config->frame_fmt != SOF_IPC_FRAME_S32_LE) return -EINVAL; @@ -372,14 +369,9 @@ static int src_params(struct comp_dev *dev) break; } - /* Check that src blk_in and blk_out are less than params.period_frames. - * Return an error if the period is too short. - */ - if (src_polyphase_get_blk_in(&cd->src[0]) > dev->frames) - return -EINVAL; - - if (src_polyphase_get_blk_out(&cd->src[0]) > dev->frames) - return -EINVAL; + /* Need to compute this */ + dev->frame_bytes = + dev->params.sample_container_bytes * dev->params.channels; return 0; } @@ -389,15 +381,11 @@ static int src_cmd(struct comp_dev *dev, int cmd, void *data) { trace_src("SCm"); struct comp_data *cd = comp_get_drvdata(dev); -// struct sof_ipc_comp_src *cv; int i; switch (cmd) { case COMP_CMD_SRC: trace_src("SMa"); -// cv = (struct sof_ipc_comp_src *) data; -// cv->in_mask = src_input_rates(); -// cv->out_mask = src_output_rates(); break; case COMP_CMD_MUTE: trace_src("SMu"); @@ -447,11 +435,8 @@ static int src_cmd(struct comp_dev *dev, int cmd, void *data) static int src_copy(struct comp_dev *dev) { struct comp_data *cd = comp_get_drvdata(dev); - struct comp_buffer *source; - struct comp_buffer *sink; - uint32_t frames_source; - uint32_t frames_sink; - int need_source, need_sink, min_frames; + struct comp_buffer *source, *sink; + int need_source, need_sink, blk_in, blk_out, frames_source, frames_sink; trace_comp("SRC"); @@ -464,36 +449,23 @@ static int src_copy(struct comp_dev *dev) /* Check that source has enough frames available and sink enough * frames free. */ - frames_source = dev->frames; - frames_sink = dev->frames; - - min_frames = src_polyphase_get_blk_in(&cd->src[0]); - if (frames_source > min_frames) - need_source = frames_source * dev->frame_bytes; - else { - frames_source = min_frames; - need_source = min_frames * dev->frame_bytes; - } - - min_frames = src_polyphase_get_blk_out(&cd->src[0]); - if (frames_sink > min_frames) - need_sink = frames_sink * dev->frame_bytes; - else { - frames_sink = min_frames; - need_sink = min_frames * dev->frame_bytes; - } + blk_in = src_polyphase_get_blk_in(&cd->src[0]); + blk_out = src_polyphase_get_blk_out(&cd->src[0]); + frames_source = dev->frames * blk_in / blk_out; + frames_sink = frames_source * blk_out / blk_in; + need_source = frames_source * dev->frame_bytes; + need_sink = frames_sink * dev->frame_bytes; /* Run as many times as buffers allow */ while ((source->avail >= need_source) && (sink->free >= need_sink)) { /* Run src */ cd->src_func(dev, source, sink, frames_source, frames_sink); + /* calc new free and available */ + comp_update_buffer_consume(source, 0); + comp_update_buffer_produce(sink, 0); } - /* calc new free and available - offset calc by conversion func */ - comp_update_buffer_consume(source, 0); - comp_update_buffer_produce(sink, 0); - return 0; } diff --git a/src/audio/src_core.c b/src/audio/src_core.c index 7deae14..55f7062 100644 --- a/src/audio/src_core.c +++ b/src/audio/src_core.c @@ -45,14 +45,17 @@ #include "src_core.h" /* Include conversion tables */ +#if SRC_SHORT == 1 +#include <reef/audio/coefficients/src/src_int16_table.h> +#else #include <reef/audio/coefficients/src/src_int24_table.h> +#endif -#if 1 /* TODO: These should be defined somewhere else. */ -#define SOF_RATES_LENGTH 15 -int sof_rates[SOF_RATES_LENGTH] = {7350, 8000, 11025, 12000, 16000, 22050, - 24000, 32000, 44100, 48000, 64000, 88200, 96000, 176400, 192000}; -#endif +#define SOF_RATES_LENGTH 16 +int sof_rates[SOF_RATES_LENGTH] = {7350, 8000, 11025, 12000, 16000, 18900, + 22050, 24000, 32000, 44100, 48000, 64000, 88200, 96000, 176400, + 192000}; /* Calculates the needed FIR delay line length */ int src_fir_delay_length(struct src_stage *s) @@ -293,6 +296,23 @@ int src_polyphase_init(struct polyphase_src *src, int fs1, int fs2, return n_stages; } +#if SRC_SHORT == 1 + +/* Calculate a FIR filter part that does not need circular modification */ +static inline void fir_part(int64_t *y, int ntaps, const int16_t c[], int *ic, + int32_t d[], int *id) +{ + int64_t p; + int n; + + /* Data is Q1.31, coef is Q1.15, product is Q2.46 */ + for (n = 0; n < ntaps; n++) { + p = (int64_t) c[(*ic)++] * d[(*id)--]; + *y += p; + } +} +#else + /* Calculate a FIR filter part that does not need circular modification */ static inline void fir_part(int64_t *y, int ntaps, const int32_t c[], int *ic, int32_t d[], int *id) @@ -307,6 +327,40 @@ static inline void fir_part(int64_t *y, int ntaps, const int32_t c[], int *ic, *y += p; } } +#endif + +#if SRC_SHORT == 1 + +static inline int32_t fir_filter( + struct src_state *fir, const int16_t coefs[], + int *coefi, int filter_length, int shift) +{ + int64_t y = 0; + int n1; + int n2; + + n1 = fir->fir_ri + 1; + if (n1 > filter_length) { + /* No need to un-wrap fir read index, make sure fir_fi + * is ge 0 after FIR computation. + */ + fir_part(&y, filter_length, coefs, coefi, fir->fir_delay, + &fir->fir_ri); + } else { + n2 = filter_length - n1; + /* Part 1, loop n1 times, fir_ri becomes -1 */ + fir_part(&y, n1, coefs, coefi, fir->fir_delay, &fir->fir_ri); + + /* Part 2, unwrap fir_ri, continue rest of filter */ + fir->fir_ri = fir->fir_delay_size - 1; + fir_part(&y, n2, coefs, coefi, fir->fir_delay, &fir->fir_ri); + } + /* Q2.46 -> Q2.31, saturate to Q1.31 */ + y = y >> (15 + shift); + + return (int32_t) sat_int32(y); +} +#else static inline int32_t fir_filter( struct src_state *fir, const int32_t coefs[], @@ -335,8 +389,9 @@ static inline int32_t fir_filter( /* Q9.47 -> Q9.24, saturate to Q8.24 */ y = y >> (23 + shift); - return (int32_t)sat_int32(y); + return (int32_t) sat_int32(y); } +#endif void src_polyphase_stage_cir(struct src_stage_prm *s) { diff --git a/src/audio/src_core.h b/src/audio/src_core.h index 0444215..dae5e53 100644 --- a/src/audio/src_core.h +++ b/src/audio/src_core.h @@ -32,10 +32,17 @@ #ifndef SRC_CORE_H #define SRC_CORE_H +/* TODO: This should be made per platform configurable */ +#define SRC_SHORT 1 + #define MAX(a, b) (((a) > (b)) ? (a) : (b)) /* Include SRC min/max constants etc. */ +#if SRC_SHORT == 1 +#include <reef/audio/coefficients/src/src_int16_define.h> +#else #include <reef/audio/coefficients/src/src_int24_define.h> +#endif struct src_alloc { int fir_s1; @@ -57,7 +64,11 @@ struct src_stage { const int blk_out; const int halfband; const int shift; +#if SRC_SHORT == 1 + const int16_t *coefs; +#else const int32_t *coefs; +#endif }; struct src_state { diff --git a/src/include/reef/audio/coefficients/src/src_int16_1_3_4375_5000.h b/src/include/reef/audio/coefficients/src/src_int16_1_3_4375_5000.h new file mode 100644 index 0000000..34e177c --- /dev/null +++ b/src/include/reef/audio/coefficients/src/src_int16_1_3_4375_5000.h @@ -0,0 +1,251 @@ +const int16_t src_int16_1_3_4375_5000_fir[245] = { + 0, + 0, + -1, + 0, + 1, + 1, + 1, + -1, + -2, + -1, + 1, + 3, + 2, + 0, + -4, + -4, + 0, + 4, + 6, + 2, + -5, + -8, + -4, + 5, + 11, + 7, + -4, + -13, + -12, + 1, + 16, + 17, + 2, + -17, + -23, + -8, + 17, + 30, + 16, + -15, + -37, + -26, + 10, + 42, + 39, + -2, + -46, + -52, + -10, + 47, + 67, + 26, + -44, + -82, + -47, + 36, + 95, + 72, + -21, + -104, + -100, + -1, + 109, + 129, + 31, + -106, + -159, + -69, + 94, + 187, + 115, + -71, + -210, + -167, + 35, + 225, + 225, + 16, + -228, + -284, + -82, + 216, + 342, + 163, + -184, + -395, + -259, + 130, + 437, + 368, + -49, + -463, + -489, + -62, + 467, + 616, + 208, + -439, + -748, + -393, + 372, + 880, + 624, + -252, + -1007, + -914, + 60, + 1125, + 1285, + 240, + -1228, + -1791, + -720, + 1313, + 2565, + 1582, + -1377, + -4078, + -3627, + 1416, + 9650, + 17303, + 20414, + 17303, + 9650, + 1416, + -3627, + -4078, + -1377, + 1582, + 2565, + 1313, + -720, + -1791, + -1228, + 240, + 1285, + 1125, + 60, + -914, + -1007, + -252, + 624, + 880, + 372, + -393, + -748, + -439, + 208, + 616, + 467, + -62, + -489, + -463, + -49, + 368, + 437, + 130, + -259, + -395, + -184, + 163, + 342, + 216, + -82, + -284, + -228, + 16, + 225, + 225, + 35, + -167, + -210, + -71, + 115, + 187, + 94, + -69, + -159, + -106, + 31, + 129, + 109, + -1, + -100, + -104, + -21, + 72, + 95, + 36, + -47, + -82, + -44, + 26, + 67, + 47, + -10, + -52, + -46, + -2, + 39, + 42, + 10, + -26, + -37, + -15, + 16, + 30, + 17, + -8, + -23, + -17, + 2, + 17, + 16, + 1, + -12, + -13, + -4, + 7, + 11, + 5, + -4, + -8, + -5, + 2, + 6, + 4, + 0, + -4, + -4, + 0, + 2, + 3, + 1, + -1, + -2, + -1, + 1, + 1, + 1, + 0, + -1, + 0, + 0 + +}; +struct src_stage src_int16_1_3_4375_5000 = { + 1, 0, 1, 245, 245, 3, 1, 0, 1, + src_int16_1_3_4375_5000_fir}; diff --git a/src/include/reef/audio/coefficients/src/src_int16_20_21_4020_5000.h b/src/include/reef/audio/coefficients/src/src_int16_20_21_4020_5000.h new file mode 100644 index 0000000..51aade7 --- /dev/null +++ b/src/include/reef/audio/coefficients/src/src_int16_20_21_4020_5000.h @@ -0,0 +1,1066 @@ +const int16_t src_int16_20_21_4020_5000_fir[1060] = { + 1, + -2, + 2, + 1, + -8, + 19, + -34, + 46, + -47, + 28, + 20, + -96, + 188, + -274, + 316, + -277, + 125, + 150, + -525, + 939, + -1288, + 1439, + -1233, + 472, + 1182, + -4843, + 21640, + 18847, + -5651, + 2095, + -277, + -717, + 1157, + -1205, + 997, + -663, + 311, + -18, + -175, + 261, + -260, + 203, + -125, + 51, + 3, + -31, + 38, + -32, + 21, + -10, + 3, + 0, + -1, + 1, + -2, + 2, + 0, + -6, + 18, + -34, + 49, + -54, + 40, + 3, + -78, + 175, + -273, + 336, + -323, + 197, + 61, + -439, + 882, + -1296, + 1547, + -1470, + 856, + 658, + -4253, + 22894, + 17336, + -5873, + 2472, + -629, + -447, + 989, + -1132, + 999, + -713, + 382, + -88, + -120, + 228, + -247, + 205, + -135, + 64, + -9, + -23, + 34, + -31, + 21, + -11, + 4, + 0, + -1, + 1, + -2, + 3, + -2, + -4, + 16, + -33, + 51, + -61, + 52, + -14, + -58, + 159, + -268, + 351, + -364, + 266, + -30, + -343, + 808, + -1280, + 1629, + -1687, + 1237, + 97, + -3539, + 24033, + 15769, + -5978, + 2790, + -960, + -177, + 807, + -1040, + 983, + -749, + 444, + -155, + -64, + 191, + -229, + 203, + -143, + 76, + -21, + -14, + 29, + -29, + 21, + -12, + 5, + -1, + -1, + 1, + -3, + 4, + -3, + -2, + 14, + -32, + 52, + -66, + 63, + -32, + -37, + 139, + -257, + 359, + -400, + 333, + -123, + -238, + 718, + -1241, + 1683, + -1879, + 1608, + -491, + -2701, + 25047, + 14163, + -5972, + 3046, + -1263, + 89, + 616, + -932, + 950, + -771, + 497, + -217, + -9, + 151, + -208, + 198, + -148, + 86, + -32, + -5, + 23, + -26, + 20, + -12, + 5, + -1, + 0, + 1, + -3, + 4, + -4, + 0, + 11, + -29, + 52, + -70, + 74, + -49, + -14, + 115, + -241, + 361, + -428, + 394, + -215, + -127, + 613, + -1178, + 1708, + -2042, + 1962, + -1097, + -1745, + 25925, + 12534, + -5861, + 3238, + -1534, + 347, + 417, + -810, + 900, + -778, + 540, + -274, + 46, + 109, + -183, + 189, + -151, + 95, + -41, + 3, + 18, + -23, + 19, + -12, + 6, + -2, + 0, + 1, + -3, + 5, + -6, + 2, + 8, + -27, + 51, + -74, + 83, + -66, + 10, + 90, + -221, + 356, + -450, + 450, + -306, + -11, + 494, + -1092, + 1703, + -2173, + 2293, + -1713, + -675, + 26656, + 10897, + -5655, + 3365, + -1770, + 591, + 216, + -676, + 836, + -771, + 573, + -326, + 98, + 67, + -156, + 177, + -150, + 101, + -50, + 11, + 12, + -20, + 18, + -12, + 6, + -2, + 0, + 1, + -3, + 5, + -7, + 4, + 5, + -23, + 49, + -76, + 92, + -82, + 33, + 62, + -196, + 344, + -464, + 498, + -393, + 108, + 364, + -984, + 1666, + -2267, + 2593, + -2327, + 502, + 27233, + 9269, + -5360, + 3428, + -1968, + 819, + 16, + -532, + 757, + -751, + 594, + -370, + 148, + 24, + -127, + 162, + -147, + 106, + -58, + 19, + 6, + -16, + 17, + -12, + 6, + -2, + 0, + 1, + -3, + 6, + -8, + 6, + 2, + -20, + 46, + -76, + 98, + -97, + 57, + 32, + -167, + 326, + -469, + 539, + -475, + 228, + 224, + -856, + 1597, + -2323, + 2856, + -2928, + 1779, + 27649, + 7665, + -4988, + 3428, + -2124, + 1027, + -180, + -383, + 667, + -718, + 604, + -406, + 194, + -18, + -96, + 145, + -142, + 108, + -64, + 26, + 0, + -13, + 15, + -12, + 7, + -3, + 1, + 1, + -3, + 6, + -9, + 9, + -2, + -15, + 42, + -75, + 104, + -111, + 81, + 0, + -134, + 302, + -466, + 570, + -550, + 345, + 76, + -709, + 1498, + -2337, + 3076, + -3506, + 3145, + 27901, + 6101, + -4547, + 3367, + -2238, + 1211, + -368, + -230, + 567, + -672, + 604, + -435, + 235, + -59, + -64, + 125, + -134, + 109, + -70, + 32, + -5, + -9, + 13, + -11, + 7, + -3, + 1, + 1, + -3, + 6, + -10, + 11, + -5, + -10, + 38, + -73, + 107, + -123, + 104, + -32, + -98, + 271, + -455, + 592, + -616, + 459, + -76, + -546, + 1368, + -2309, + 3248, + -4050, + 4589, + 27985, + 4589, + -4050, + 3248, + -2309, + 1368, + -546, + -76, + 459, + -616, + 592, + -455, + 271, + -98, + -32, + 104, + -123, + 107, + -73, + 38, + -10, + -5, + 11, + -10, + 6, + -3, + 1, + 1, + -3, + 7, + -11, + 13, + -9, + -5, + 32, + -70, + 109, + -134, + 125, + -64, + -59, + 235, + -435, + 604, + -672, + 567, + -230, + -368, + 1211, + -2238, + 3367, + -4547, + 6101, + 27901, + 3145, + -3506, + 3076, + -2337, + 1498, + -709, + 76, + 345, + -550, + 570, + -466, + 302, + -134, + 0, + 81, + -111, + 104, + -75, + 42, + -15, + -2, + 9, + -9, + 6, + -3, + 1, + 1, + -3, + 7, + -12, + 15, + -13, + 0, + 26, + -64, + 108, + -142, + 145, + -96, + -18, + 194, + -406, + 604, + -718, + 667, + -383, + -180, + 1027, + -2124, + 3428, + -4988, + 7665, + 27649, + 1779, + -2928, + 2856, + -2323, + 1597, + -856, + 224, + 228, + -475, + 539, + -469, + 326, + -167, + 32, + 57, + -97, + 98, + -76, + 46, + -20, + 2, + 6, + -8, + 6, + -3, + 1, + 0, + -2, + 6, + -12, + 17, + -16, + 6, + 19, + -58, + 106, + -147, + 162, + -127, + 24, + 148, + -370, + 594, + -751, + 757, + -532, + 16, + 819, + -1968, + 3428, + -5360, + 9269, + 27233, + 502, + -2327, + 2593, + -2267, + 1666, + -984, + 364, + 108, + -393, + 498, + -464, + 344, + -196, + 62, + 33, + -82, + 92, + -76, + 49, + -23, + 5, + 4, + -7, + 5, + -3, + 1, + 0, + -2, + 6, + -12, + 18, + -20, + 12, + 11, + -50, + 101, + -150, + 177, + -156, + 67, + 98, + -326, + 573, + -771, + 836, + -676, + 216, + 591, + -1770, + 3365, + -5655, + 10897, + 26656, + -675, + -1713, + 2293, + -2173, + 1703, + -1092, + 494, + -11, + -306, + 450, + -450, + 356, + -221, + 90, + 10, + -66, + 83, + -74, + 51, + -27, + 8, + 2, + -6, + 5, + -3, + 1, + 0, + -2, + 6, + -12, + 19, + -23, + 18, + 3, + -41, + 95, + -151, + 189, + -183, + 109, + 46, + -274, + 540, + -778, + 900, + -810, + 417, + 347, + -1534, + 3238, + -5861, + 12534, + 25925, + -1745, + -1097, + 1962, + -2042, + 1708, + -1178, + 613, + -127, + -215, + 394, + -428, + 361, + -241, + 115, + -14, + -49, + 74, + -70, + 52, + -29, + 11, + 0, + -4, + 4, + -3, + 1, + 0, + -1, + 5, + -12, + 20, + -26, + 23, + -5, + -32, + 86, + -148, + 198, + -208, + 151, + -9, + -217, + 497, + -771, + 950, + -932, + 616, + 89, + -1263, + 3046, + -5972, + 14163, + 25047, + -2701, + -491, + 1608, + -1879, + 1683, + -1241, + 718, + -238, + -123, + 333, + -400, + 359, + -257, + 139, + -37, + -32, + 63, + -66, + 52, + -32, + 14, + -2, + -3, + 4, + -3, + 1, + -1, + -1, + 5, + -12, + 21, + -29, + 29, + -14, + -21, + 76, + -143, + 203, + -229, + 191, + -64, + -155, + 444, + -749, + 983, + -1040, + 807, + -177, + -960, + 2790, + -5978, + 15769, + 24033, + -3539, + 97, + 1237, + -1687, + 1629, + -1280, + 808, + -343, + -30, + 266, + -364, + 351, + -268, + 159, + -58, + -14, + 52, + -61, + 51, + -33, + 16, + -4, + -2, + 3, + -2, + 1, + -1, + 0, + 4, + -11, + 21, + -31, + 34, + -23, + -9, + 64, + -135, + 205, + -247, + 228, + -120, + -88, + 382, + -713, + 999, + -1132, + 989, + -447, + -629, + 2472, + -5873, + 17336, + 22894, + -4253, + 658, + 856, + -1470, + 1547, + -1296, + 882, + -439, + 61, + 197, + -323, + 336, + -273, + 175, + -78, + 3, + 40, + -54, + 49, + -34, + 18, + -6, + 0, + 2, + -2, + 1, + -1, + 0, + 3, + -10, + 21, + -32, + 38, + -31, + 3, + 51, + -125, + 203, + -260, + 261, + -175, + -18, + 311, + -663, + 997, + -1205, + 1157, + -717, + -277, + 2095, + -5651, + 18847, + 21640, + -4843, + 1182, + 472, + -1233, + 1439, + -1288, + 939, + -525, + 150, + 125, + -277, + 316, + -274, + 188, + -96, + 20, + 28, + -47, + 46, + -34, + 19, + -8, + 1, + 2, + -2, + 1, + -1, + 1, + 2, + -9, + 20, + -33, + 43, + -39, + 15, + 36, + -111, + 198, + -269, + 291, + -228, + 53, + 233, + -600, + 977, + -1257, + 1308, + -980, + 93, + 1663, + -5309, + 20286, + 20286, + -5309, + 1663, + 93, + -980, + 1308, + -1257, + 977, + -600, + 233, + 53, + -228, + 291, + -269, + 198, + -111, + 36, + 15, + -39, + 43, + -33, + 20, + -9, + 2, + 1, + -1, + 0 + +}; +struct src_stage src_int16_20_21_4020_5000 = { + 1, 1, 20, 53, 1060, 21, 20, 0, 0, + src_int16_20_21_4020_5000_fir}; diff --git a/src/include/reef/audio/coefficients/src/src_int16_21_20_4020_5000.h b/src/include/reef/audio/coefficients/src/src_int16_21_20_4020_5000.h new file mode 100644 index 0000000..678ed4f --- /dev/null +++ b/src/include/reef/audio/coefficients/src/src_int16_21_20_4020_5000.h @@ -0,0 +1,1056 @@ +const int16_t src_int16_21_20_4020_5000_fir[1050] = { + 1, + -3, + 5, + -9, + 11, + -9, + 0, + 19, + -51, + 96, + -151, + 208, + -253, + 270, + -235, + 130, + 64, + -357, + 750, + -1232, + 1783, + -2376, + 2996, + -3680, + 4818, + 29296, + 1867, + -2442, + 2405, + -2140, + 1762, + -1339, + 921, + -547, + 243, + -19, + -124, + 196, + -213, + 193, + -153, + 107, + -65, + 32, + -10, + -2, + 6, + -6, + 5, + -2, + 1, + -3, + 6, + -9, + 13, + -13, + 6, + 11, + -42, + 87, + -146, + 210, + -267, + 300, + -287, + 204, + -31, + -248, + 640, + -1142, + 1744, + -2434, + 3227, + -4251, + 6405, + 29032, + 527, + -1798, + 2058, + -1969, + 1705, + -1355, + 980, + -626, + 324, + -91, + -66, + 155, + -188, + 181, + -150, + 109, + -70, + 38, + -15, + 2, + 4, + -5, + 4, + -2, + 1, + -3, + 6, + -10, + 14, + -16, + 12, + 3, + -32, + 77, + -138, + 208, + -277, + 326, + -335, + 276, + -128, + -132, + 516, + -1030, + 1672, + -2450, + 3408, + -4773, + 8048, + 28594, + -709, + -1152, + 1686, + -1768, + 1619, + -1346, + 1020, + -691, + 397, + -160, + -9, + 113, + -160, + 166, + -144, + 110, + -73, + 42, + -19, + 5, + 2, + -4, + 3, + -2, + 1, + -3, + 6, + -11, + 16, + -20, + 17, + -5, + -21, + 65, + -127, + 202, + -281, + 347, + -377, + 345, + -224, + -11, + 380, + -895, + 1568, + -2421, + 3532, + -5235, + 9732, + 27989, + -1832, + -515, + 1297, + -1541, + 1506, + -1314, + 1041, + -743, + 462, + -225, + 47, + 69, + -130, + 148, + -136, + 108, + -76, + 46, + -23, + 8, + 0, + -3, + 3, + -2, + 1, + -3, + 6, + -11, + 18, + -23, + 23, + -14, + -9, + 51, + -113, + 193, + -281, + 362, + -414, + 409, + -318, + 113, + 233, + -742, + 1433, + -2346, + 3596, + -5626, + 11441, + 27221, + -2836, + 102, + 898, + -1292, + 1369, + -1259, + 1043, + -780, + 517, + -284, + 102, + 25, + -98, + 128, + -125, + 105, + -76, + 49, + -26, + 11, + -2, + -2, + 2, + -2, + 1, + -2, + 6, + -12, + 19, + -26, + 28, + -23, + 3, + 36, + -97, + 179, + -275, + 370, + -443, + 467, + -409, + 237, + 80, + -571, + 1268, + -2227, + 3596, + -5935, + 13160, + 26300, + -3715, + 690, + 495, + -1027, + 1211, + -1183, + 1026, + -802, + 561, + -337, + 153, + -18, + -66, + 106, + -113, + 99, + -76, + 51, + -29, + 13, + -4, + 0, + 2, + -1, + 0, + -2, + 6, + -12, + 20, + -28, + 34, + -31, + 15, + 20, + -79, + 162, + -264, + 372, + -466, + 517, + -494, + 360, + -79, + -385, + 1075, + -2063, + 3531, + -6153, + 14870, + 25235, + -4465, + 1240, + 97, + -751, + 1035, + -1087, + 991, + -810, + 595, + -383, + 200, + -60, + -32, + 83, + -99, + 93, + -74, + 51, + -31, + 16, + -6, + 1, + 1, + -1, + 0, + -2, + 5, + -12, + 20, + -30, + 38, + -39, + 28, + 3, + -59, + 142, + -248, + 367, + -480, + 559, + -572, + 479, + -240, + -189, + 858, + -1856, + 3397, + -6268, + 16557, + 24038, + -5085, + 1745, + -290, + -469, + 845, + -974, + 939, + -803, + 617, + -421, + 243, + -100, + 0, + 59, + -84, + 84, + -71, + 51, + -32, + 17, + -7, + 2, + 0, + -1, + 0, + -2, + 5, + -11, + 20, + -32, + 42, + -47, + 40, + -14, + -37, + 118, + -227, + 355, + -486, + 592, + -641, + 592, + -400, + 16, + 619, + -1609, + 3196, + -6275, + 18202, + 22722, + -5573, + 2198, + -660, + -186, + 644, + -846, + 872, + -782, + 628, + -450, + 280, + -138, + 32, + 34, + -67, + 75, + -66, + 50, + -33, + 19, + -9, + 3, + 0, + 0, + 0, + -1, + 4, + -11, + 20, + -33, + 46, + -54, + 52, + -32, + -14, + 92, + -201, + 337, + -483, + 615, + -700, + 696, + -556, + 226, + 363, + -1324, + 2927, + -6165, + 19788, + 21300, + -5932, + 2594, + -1006, + 93, + 437, + -706, + 790, + -747, + 627, + -471, + 312, + -172, + 63, + 10, + -50, + 64, + -61, + 48, + -33, + 20, + -10, + 4, + -1, + 0, + 0, + -1, + 4, + -10, + 20, + -33, + 48, + -61, + 64, + -50, + 10, + 63, + -172, + 312, + -471, + 627, + -747, + 790, + -706, + 437, + 93, + -1006, + 2594, + -5932, + 21300, + 19788, + -6165, + 2927, + -1324, + 363, + 226, + -556, + 696, + -700, + 615, + -483, + 337, + -201, + 92, + -14, + -32, + 52, + -54, + 46, + -33, + 20, + -11, + 4, + -1, + 0, + 0, + 0, + 3, + -9, + 19, + -33, + 50, + -66, + 75, + -67, + 34, + 32, + -138, + 280, + -450, + 628, + -782, + 872, + -846, + 644, + -186, + -660, + 2198, + -5573, + 22722, + 18202, + -6275, + 3196, + -1609, + 619, + 16, + -400, + 592, + -641, + 592, + -486, + 355, + -227, + 118, + -37, + -14, + 40, + -47, + 42, + -32, + 20, + -11, + 5, + -2, + 0, + -1, + 0, + 2, + -7, + 17, + -32, + 51, + -71, + 84, + -84, + 59, + 0, + -100, + 243, + -421, + 617, + -803, + 939, + -974, + 845, + -469, + -290, + 1745, + -5085, + 24038, + 16557, + -6268, + 3397, + -1856, + 858, + -189, + -240, + 479, + -572, + 559, + -480, + 367, + -248, + 142, + -59, + 3, + 28, + -39, + 38, + -30, + 20, + -12, + 5, + -2, + 0, + -1, + 1, + 1, + -6, + 16, + -31, + 51, + -74, + 93, + -99, + 83, + -32, + -60, + 200, + -383, + 595, + -810, + 991, + -1087, + 1035, + -751, + 97, + 1240, + -4465, + 25235, + 14870, + -6153, + 3531, + -2063, + 1075, + -385, + -79, + 360, + -494, + 517, + -466, + 372, + -264, + 162, + -79, + 20, + 15, + -31, + 34, + -28, + 20, + -12, + 6, + -2, + 0, + -1, + 2, + 0, + -4, + 13, + -29, + 51, + -76, + 99, + -113, + 106, + -66, + -18, + 153, + -337, + 561, + -802, + 1026, + -1183, + 1211, + -1027, + 495, + 690, + -3715, + 26300, + 13160, + -5935, + 3596, + -2227, + 1268, + -571, + 80, + 237, + -409, + 467, + -443, + 370, + -275, + 179, + -97, + 36, + 3, + -23, + 28, + -26, + 19, + -12, + 6, + -2, + 1, + -2, + 2, + -2, + -2, + 11, + -26, + 49, + -76, + 105, + -125, + 128, + -98, + 25, + 102, + -284, + 517, + -780, + 1043, + -1259, + 1369, + -1292, + 898, + 102, + -2836, + 27221, + 11441, + -5626, + 3596, + -2346, + 1433, + -742, + 233, + 113, + -318, + 409, + -414, + 362, + -281, + 193, + -113, + 51, + -9, + -14, + 23, + -23, + 18, + -11, + 6, + -3, + 1, + -2, + 3, + -3, + 0, + 8, + -23, + 46, + -76, + 108, + -136, + 148, + -130, + 69, + 47, + -225, + 462, + -743, + 1041, + -1314, + 1506, + -1541, + 1297, + -515, + -1832, + 27989, + 9732, + -5235, + 3532, + -2421, + 1568, + -895, + 380, + -11, + -224, + 345, + -377, + 347, + -281, + 202, + -127, + 65, + -21, + -5, + 17, + -20, + 16, + -11, + 6, + -3, + 1, + -2, + 3, + -4, + 2, + 5, + -19, + 42, + -73, + 110, + -144, + 166, + -160, + 113, + -9, + -160, + 397, + -691, + 1020, + -1346, + 1619, + -1768, + 1686, + -1152, + -709, + 28594, + 8048, + -4773, + 3408, + -2450, + 1672, + -1030, + 516, + -132, + -128, + 276, + -335, + 326, + -277, + 208, + -138, + 77, + -32, + 3, + 12, + -16, + 14, + -10, + 6, + -3, + 1, + -2, + 4, + -5, + 4, + 2, + -15, + 38, + -70, + 109, + -150, + 181, + -188, + 155, + -66, + -91, + 324, + -626, + 980, + -1355, + 1705, + -1969, + 2058, + -1798, + 527, + 29032, + 6405, + -4251, + 3227, + -2434, + 1744, + -1142, + 640, + -248, + -31, + 204, + -287, + 300, + -267, + 210, + -146, + 87, + -42, + 11, + 6, + -13, + 13, + -9, + 6, + -3, + 1, + -2, + 5, + -6, + 6, + -2, + -10, + 32, + -65, + 107, + -153, + 193, + -213, + 196, + -124, + -19, + 243, + -547, + 921, + -1339, + 1762, + -2140, + 2405, + -2442, + 1867, + 29296, + 4818, + -3680, + 2996, + -2376, + 1783, + -1232, + 750, + -357, + 64, + 130, + -235, + 270, + -253, + 208, + -151, + 96, + -51, + 19, + 0, + -9, + 11, + -9, + 5, + -3, + 1, + -3, + 5, + -8, + 8, + -5, + -5, + 26, + -58, + 102, + -153, + 202, + -235, + 235, + -181, + 55, + 156, + -457, + 844, + -1298, + 1788, + -2277, + 2720, + -3073, + 3302, + 29385, + 3302, + -3073, + 2720, + -2277, + 1788, + -1298, + 844, + -457, + 156, + 55, + -181, + 235, + -235, + 202, + -153, + 102, + -58, + 26, + -5, + -5, + 8, + -8, + 5, + -3, + 0 + +}; +struct src_stage src_int16_21_20_4020_5000 = { + 19, 20, 21, 50, 1050, 20, 21, 0, 0, + src_int16_21_20_4020_5000_fir}; diff --git a/src/include/reef/audio/coefficients/src/src_int16_3_1_4375_5000.h b/src/include/reef/audio/coefficients/src/src_int16_3_1_4375_5000.h new file mode 100644 index 0000000..a8d5813 --- /dev/null +++ b/src/include/reef/audio/coefficients/src/src_int16_3_1_4375_5000.h @@ -0,0 +1,252 @@ +const int16_t src_int16_3_1_4375_5000_fir[246] = { + 0, + -1, + 2, + -3, + 4, + -7, + 9, + -11, + 13, + -15, + 14, + -12, + 7, + 2, + -15, + 33, + -55, + 82, + -112, + 143, + -175, + 204, + -226, + 239, + -237, + 218, + -176, + 108, + -11, + -118, + 281, + -478, + 711, + -979, + 1286, + -1636, + 2044, + -2544, + 3231, + -4424, + 8001, + 29412, + -2495, + 372, + 409, + -786, + 974, + -1051, + 1053, + -1004, + 919, + -810, + 688, + -560, + 434, + -316, + 209, + -117, + 41, + 18, + -61, + 90, + -106, + 111, + -107, + 98, + -85, + 70, + -55, + 41, + -28, + 18, + -10, + 4, + 0, + -2, + 3, + -3, + 3, + -2, + 2, + -1, + 0, + 0, + 0, + -1, + 2, + -4, + 7, + -11, + 16, + -22, + 29, + -35, + 41, + -44, + 45, + -40, + 30, + -13, + -12, + 46, + -89, + 140, + -198, + 260, + -323, + 384, + -436, + 473, + -489, + 477, + -428, + 333, + -183, + -36, + 339, + -755, + 1332, + -2180, + 3582, + -6592, + 20737, + 20737, + -6592, + 3582, + -2180, + 1332, + -755, + 339, + -36, + -183, + 333, + -428, + 477, + -489, + 473, + -436, + 384, + -323, + 260, + -198, + 140, + -89, + 46, + -12, + -13, + 30, + -40, + 45, + -44, + 41, + -35, + 29, + -22, + 16, + -11, + 7, + -4, + 2, + -1, + 0, + 0, + 0, + -1, + 2, + -2, + 3, + -3, + 3, + -2, + 0, + 4, + -10, + 18, + -28, + 41, + -55, + 70, + -85, + 98, + -107, + 111, + -106, + 90, + -61, + 18, + 41, + -117, + 209, + -316, + 434, + -560, + 688, + -810, + 919, + -1004, + 1053, + -1051, + 974, + -786, + 409, + 372, + -2495, + 29412, + 8001, + -4424, + 3231, + -2544, + 2044, + -1636, + 1286, + -979, + 711, + -478, + 281, + -118, + -11, + 108, + -176, + 218, + -237, + 239, + -226, + 204, + -175, + 143, + -112, + 82, + -55, + 33, + -15, + 2, + 7, + -12, + 14, + -15, + 13, + -11, + 9, + -7, + 4, + -3, + 2, + -1, + 0 + +}; +struct src_stage src_int16_3_1_4375_5000 = { + 0, 1, 3, 82, 246, 1, 3, 0, 0, + src_int16_3_1_4375_5000_fir}; diff --git a/src/include/reef/audio/coefficients/src/src_int16_7_8_4375_5000.h b/src/include/reef/audio/coefficients/src/src_int16_7_8_4375_5000.h new file mode 100644 index 0000000..4b0eb73 --- /dev/null +++ b/src/include/reef/audio/coefficients/src/src_int16_7_8_4375_5000.h @@ -0,0 +1,657 @@ +const int16_t src_int16_7_8_4375_5000_fir[651] = { + 0, + 0, + 0, + -2, + 4, + -5, + 4, + 0, + -7, + 14, + -19, + 16, + -5, + -14, + 36, + -50, + 49, + -25, + -17, + 68, + -108, + 117, + -81, + 0, + 106, + -200, + 242, + -199, + 66, + 130, + -329, + 452, + -431, + 235, + 106, + -502, + 816, + -902, + 656, + -61, + -786, + 1673, + -2295, + 2280, + -1124, + -2459, + 23097, + 16168, + -5503, + 1769, + 321, + -1397, + 1681, + -1391, + 780, + -103, + -434, + 711, + -708, + 489, + -168, + -135, + 332, + -384, + 307, + -151, + -18, + 144, + -198, + 178, + -108, + 20, + 52, + -91, + 91, + -63, + 23, + 13, + -35, + 39, + -30, + 15, + 0, + -10, + 13, + -11, + 6, + -1, + -2, + 3, + -2, + 1, + 0, + -1, + 1, + 0, + -1, + 3, + -5, + 6, + -3, + -3, + 12, + -19, + 22, + -15, + -2, + 26, + -48, + 59, + -48, + 13, + 41, + -96, + 130, + -121, + 61, + 43, + -160, + 247, + -260, + 174, + 4, + -229, + 425, + -508, + 414, + -132, + -282, + 706, + -980, + 952, + -531, + -271, + 1315, + -2341, + 2983, + -2730, + 328, + 25336, + 12012, + -5744, + 2742, + -665, + -691, + 1357, + -1419, + 1047, + -464, + -112, + 517, + -672, + 587, + -340, + 42, + 205, + -337, + 336, + -231, + 78, + 66, + -157, + 179, + -141, + 67, + 9, + -64, + 85, + -74, + 43, + -8, + -20, + 33, + -32, + 21, + -7, + -4, + 10, + -11, + 8, + -3, + 0, + 2, + -2, + 1, + -1, + -1, + 1, + -1, + 0, + 3, + -6, + 7, + -6, + 1, + 8, + -18, + 25, + -24, + 11, + 12, + -40, + 62, + -65, + 42, + 7, + -70, + 125, + -147, + 116, + -28, + -97, + 219, + -288, + 263, + -128, + -95, + 341, + -520, + 544, + -361, + -15, + 496, + -929, + 1132, + -951, + 308, + 756, + -2069, + 3342, + -4177, + 3814, + 26503, + 7795, + -5248, + 3273, + -1492, + 59, + 876, + -1263, + 1168, + -751, + 212, + 263, + -550, + 605, + -462, + 208, + 56, + -247, + 320, + -279, + 160, + -18, + -98, + 157, + -154, + 104, + -34, + -30, + 67, + -74, + 56, + -26, + -4, + 24, + -30, + 25, + -14, + 2, + 6, + -9, + 8, + -5, + 1, + 1, + -2, + 1, + -1, + -1, + 1, + -2, + 1, + 1, + -5, + 8, + -9, + 6, + 2, + -14, + 25, + -30, + 24, + -4, + -26, + 56, + -74, + 67, + -30, + -34, + 104, + -154, + 157, + -98, + -18, + 160, + -279, + 320, + -247, + 56, + 208, + -462, + 605, + -550, + 263, + 212, + -751, + 1168, + -1263, + 876, + 59, + -1492, + 3273, + -5248, + 7795, + 26503, + 3814, + -4177, + 3342, + -2069, + 756, + 308, + -951, + 1132, + -929, + 496, + -15, + -361, + 544, + -520, + 341, + -95, + -128, + 263, + -288, + 219, + -97, + -28, + 116, + -147, + 125, + -70, + 7, + 42, + -65, + 62, + -40, + 12, + 11, + -24, + 25, + -18, + 8, + 1, + -6, + 7, + -6, + 3, + 0, + -1, + 1, + -1, + -1, + 1, + -2, + 2, + 0, + -3, + 8, + -11, + 10, + -4, + -7, + 21, + -32, + 33, + -20, + -8, + 43, + -74, + 85, + -64, + 9, + 67, + -141, + 179, + -157, + 66, + 78, + -231, + 336, + -337, + 205, + 42, + -340, + 587, + -672, + 517, + -112, + -464, + 1047, + -1419, + 1357, + -691, + -665, + 2742, + -5744, + 12012, + 25336, + 328, + -2730, + 2983, + -2341, + 1315, + -271, + -531, + 952, + -980, + 706, + -282, + -132, + 414, + -508, + 425, + -229, + 4, + 174, + -260, + 247, + -160, + 43, + 61, + -121, + 130, + -96, + 41, + 13, + -48, + 59, + -48, + 26, + -2, + -15, + 22, + -19, + 12, + -3, + -3, + 6, + -5, + 3, + -1, + 0, + 1, + -1, + 0, + 1, + -2, + 3, + -2, + -1, + 6, + -11, + 13, + -10, + 0, + 15, + -30, + 39, + -35, + 13, + 23, + -63, + 91, + -91, + 52, + 20, + -108, + 178, + -198, + 144, + -18, + -151, + 307, + -384, + 332, + -135, + -168, + 489, + -708, + 711, + -434, + -103, + 780, + -1391, + 1681, + -1397, + 321, + 1769, + -5503, + 16168, + 23097, + -2459, + -1124, + 2280, + -2295, + 1673, + -786, + -61, + 656, + -902, + 816, + -502, + 106, + 235, + -431, + 452, + -329, + 130, + 66, + -199, + 242, + -200, + 106, + 0, + -81, + 117, + -108, + 68, + -17, + -25, + 49, + -50, + 36, + -14, + -5, + 16, + -19, + 14, + -7, + 0, + 4, + -5, + 4, + -2, + 0, + 0, + 0, + 0, + 1, + -2, + 4, + -3, + 1, + 4, + -10, + 15, + -15, + 9, + 6, + -24, + 40, + -45, + 32, + -1, + -44, + 86, + -106, + 90, + -31, + -59, + 153, + -213, + 206, + -114, + -48, + 236, + -382, + 418, + -300, + 32, + 322, + -650, + 816, + -710, + 288, + 395, + -1173, + 1796, + -1960, + 1348, + 436, + -4418, + 19959, + 19959, + -4418, + 436, + 1348, + -1960, + 1796, + -1173, + 395, + 288, + -710, + 816, + -650, + 322, + 32, + -300, + 418, + -382, + 236, + -48, + -114, + 206, + -213, + 153, + -59, + -31, + 90, + -106, + 86, + -44, + -1, + 32, + -45, + 40, + -24, + 6, + 9, + -15, + 15, + -10, + 4, + 1, + -3, + 4, + -2, + 1, + 0, + 0 + +}; +struct src_stage src_int16_7_8_4375_5000 = { + 1, 1, 7, 93, 651, 8, 7, 0, 0, + src_int16_7_8_4375_5000_fir}; diff --git a/src/include/reef/audio/coefficients/src/src_int16_8_7_4375_5000.h b/src/include/reef/audio/coefficients/src/src_int16_8_7_4375_5000.h new file mode 100644 index 0000000..1ad7797 --- /dev/null +++ b/src/include/reef/audio/coefficients/src/src_int16_8_7_4375_5000.h @@ -0,0 +1,662 @@ +const int16_t src_int16_8_7_4375_5000_fir[656] = { + 0, + 0, + 1, + -2, + 4, + -7, + 10, + -13, + 17, + -21, + 23, + -23, + 21, + -14, + 3, + 14, + -37, + 65, + -99, + 136, + -174, + 211, + -242, + 263, + -269, + 256, + -219, + 152, + -53, + -81, + 251, + -458, + 702, + -979, + 1290, + -1635, + 2021, + -2471, + 3050, + -3986, + 6580, + 29785, + -1328, + -372, + 958, + -1207, + 1295, + -1286, + 1212, + -1095, + 951, + -792, + 628, + -469, + 322, + -190, + 79, + 10, + -77, + 123, + -150, + 161, + -159, + 146, + -128, + 105, + -82, + 60, + -40, + 23, + -10, + 1, + 5, + -9, + 10, + -9, + 8, + -6, + 5, + -3, + 2, + -1, + 0, + 0, + 0, + -1, + 3, + -5, + 9, + -13, + 18, + -23, + 28, + -32, + 34, + -33, + 27, + -15, + -3, + 29, + -62, + 102, + -147, + 195, + -243, + 287, + -322, + 342, + -341, + 314, + -253, + 155, + -14, + -175, + 414, + -709, + 1065, + -1493, + 2018, + -2695, + 3672, + -5455, + 11305, + 27819, + -4054, + 1304, + -212, + -361, + 684, + -859, + 934, + -938, + 889, + -804, + 696, + -574, + 449, + -327, + 215, + -117, + 36, + 28, + -74, + 104, + -119, + 123, + -117, + 105, + -89, + 71, + -53, + 37, + -23, + 12, + -4, + -1, + 4, + -6, + 6, + -5, + 4, + -3, + 2, + -1, + -1, + 1, + -1, + 0, + 1, + -3, + 6, + -11, + 16, + -23, + 30, + -38, + 44, + -48, + 49, + -44, + 33, + -13, + -15, + 52, + -99, + 153, + -212, + 274, + -333, + 385, + -422, + 438, + -426, + 378, + -287, + 143, + 60, + -332, + 686, + -1143, + 1741, + -2566, + 3846, + -6377, + 16134, + 24716, + -5794, + 2637, + -1264, + 480, + 17, + -342, + 547, + -665, + 715, + -712, + 670, + -600, + 513, + -417, + 319, + -225, + 140, + -68, + 9, + 35, + -66, + 84, + -92, + 91, + -83, + 72, + -59, + 46, + -33, + 22, + -13, + 6, + -1, + -2, + 3, + -3, + 3, + -2, + 2, + -1, + -1, + 1, + -2, + 2, + -1, + 0, + 3, + -7, + 12, + -19, + 28, + -38, + 48, + -57, + 64, + -68, + 65, + -55, + 36, + -6, + -35, + 88, + -151, + 223, + -300, + 377, + -449, + 509, + -548, + 559, + -531, + 454, + -316, + 106, + 197, + -619, + 1209, + -2077, + 3504, + -6542, + 20718, + 20718, + -6542, + 3504, + -2077, + 1209, + -619, + 197, + 106, + -316, + 454, + -531, + 559, + -548, + 509, + -449, + 377, + -300, + 223, + -151, + 88, + -35, + -6, + 36, + -55, + 65, + -68, + 64, + -57, + 48, + -38, + 28, + -19, + 12, + -7, + 3, + 0, + -1, + 2, + -2, + 1, + -1, + -1, + 2, + -2, + 3, + -3, + 3, + -2, + -1, + 6, + -13, + 22, + -33, + 46, + -59, + 72, + -83, + 91, + -92, + 84, + -66, + 35, + 9, + -68, + 140, + -225, + 319, + -417, + 513, + -600, + 670, + -712, + 715, + -665, + 547, + -342, + 17, + 480, + -1264, + 2637, + -5794, + 24716, + 16134, + -6377, + 3846, + -2566, + 1741, + -1143, + 686, + -332, + 60, + 143, + -287, + 378, + -426, + 438, + -422, + 385, + -333, + 274, + -212, + 153, + -99, + 52, + -15, + -13, + 33, + -44, + 49, + -48, + 44, + -38, + 30, + -23, + 16, + -11, + 6, + -3, + 1, + 0, + -1, + 1, + -1, + -1, + 2, + -3, + 4, + -5, + 6, + -6, + 4, + -1, + -4, + 12, + -23, + 37, + -53, + 71, + -89, + 105, + -117, + 123, + -119, + 104, + -74, + 28, + 36, + -117, + 215, + -327, + 449, + -574, + 696, + -804, + 889, + -938, + 934, + -859, + 684, + -361, + -212, + 1304, + -4054, + 27819, + 11305, + -5455, + 3672, + -2695, + 2018, + -1493, + 1065, + -709, + 414, + -175, + -14, + 155, + -253, + 314, + -341, + 342, + -322, + 287, + -243, + 195, + -147, + 102, + -62, + 29, + -3, + -15, + 27, + -33, + 34, + -32, + 28, + -23, + 18, + -13, + 9, + -5, + 3, + -1, + 0, + 0, + 0, + -1, + 2, + -3, + 5, + -6, + 8, + -9, + 10, + -9, + 5, + 1, + -10, + 23, + -40, + 60, + -82, + 105, + -128, + 146, + -159, + 161, + -150, + 123, + -77, + 10, + 79, + -190, + 322, + -469, + 628, + -792, + 951, + -1095, + 1212, + -1286, + 1295, + -1207, + 958, + -372, + -1328, + 29785, + 6580, + -3986, + 3050, + -2471, + 2021, + -1635, + 1290, + -979, + 702, + -458, + 251, + -81, + -53, + 152, + -219, + 256, + -269, + 263, + -242, + 211, + -174, + 136, + -99, + 65, + -37, + 14, + 3, + -14, + 21, + -23, + 23, + -21, + 17, + -13, + 10, + -7, + 4, + -2, + 1, + 0, + 0, + -1, + 2, + -3, + 5, + -7, + 10, + -12, + 14, + -16, + 15, + -12, + 5, + 5, + -20, + 40, + -64, + 92, + -122, + 151, + -178, + 199, + -209, + 205, + -184, + 140, + -72, + -24, + 147, + -298, + 474, + -673, + 887, + -1112, + 1339, + -1559, + 1765, + -1947, + 2097, + -2210, + 2280, + 30458, + 2280, + -2210, + 2097, + -1947, + 1765, + -1559, + 1339, + -1112, + 887, + -673, + 474, + -298, + 147, + -24, + -72, + 140, + -184, + 205, + -209, + 199, + -178, + 151, + -122, + 92, + -64, + 40, + -20, + 5, + 5, + -12, + 15, + -16, + 14, + -12, + 10, + -7, + 5, + -3, + 2, + -1, + 0 + +}; +struct src_stage src_int16_8_7_4375_5000 = { + 6, 7, 8, 82, 656, 7, 8, 0, 0, + src_int16_8_7_4375_5000_fir}; diff --git a/src/include/reef/audio/coefficients/src/src_int16_define.h b/src/include/reef/audio/coefficients/src/src_int16_define.h new file mode 100644 index 0000000..65954b0 --- /dev/null +++ b/src/include/reef/audio/coefficients/src/src_int16_define.h @@ -0,0 +1,11 @@ +/* SRC constants */ +#define MAX_FIR_DELAY_SIZE 450 +#define MAX_OUT_DELAY_SIZE 401 +#define MAX_BLK_IN 21 +#define MAX_BLK_OUT 21 +#define NUM_IN_FS 3 +#define NUM_OUT_FS 3 +#define STAGE1_TIMES_MAX 21 +#define STAGE2_TIMES_MAX 21 +#define STAGE_BUF_SIZE 168 +#define NUM_ALL_COEFFICIENTS 3908 diff --git a/src/include/reef/audio/coefficients/src/src_int16_table.h b/src/include/reef/audio/coefficients/src/src_int16_table.h new file mode 100644 index 0000000..e37dfae --- /dev/null +++ b/src/include/reef/audio/coefficients/src/src_int16_table.h @@ -0,0 +1,32 @@ +/* SRC conversions */ +#include <reef/audio/coefficients/src/src_int16_1_3_4375_5000.h> +#include <reef/audio/coefficients/src/src_int16_3_1_4375_5000.h> +#include <reef/audio/coefficients/src/src_int16_7_8_4375_5000.h> +#include <reef/audio/coefficients/src/src_int16_8_7_4375_5000.h> +#include <reef/audio/coefficients/src/src_int16_20_21_4020_5000.h> +#include <reef/audio/coefficients/src/src_int16_21_20_4020_5000.h> + +/* SRC table */ +int16_t fir_one = 16384; +struct src_stage src_int16_1_1_0_0 = { 0, 0, 1, 1, 1, 1, 1, 0, -1, &fir_one }; +struct src_stage src_int16_0_0_0_0 = { 0, 0, 0, 0, 0, 0, 0, 0, 0, &fir_one }; +int src_in_fs[3] = { 16000, 44100, 48000}; +int src_out_fs[3] = { 16000, 44100, 48000}; +struct src_stage *src_table1[3][3] = { + { &src_int16_1_1_0_0, &src_int16_0_0_0_0, + &src_int16_1_3_4375_5000}, + { &src_int16_0_0_0_0, + &src_int16_1_1_0_0, &src_int16_21_20_4020_5000 + }, + { &src_int16_3_1_4375_5000, &src_int16_8_7_4375_5000, + &src_int16_1_1_0_0} +}; +struct src_stage *src_table2[3][3] = { + { &src_int16_1_1_0_0, &src_int16_0_0_0_0, + &src_int16_1_1_0_0}, + { &src_int16_0_0_0_0, + &src_int16_1_1_0_0, &src_int16_7_8_4375_5000 + }, + { &src_int16_1_1_0_0, &src_int16_20_21_4020_5000, + &src_int16_1_1_0_0} +}; -- 2.11.0

2 4

[Sound-open-firmware] [PATCH 1/3] heap: byt: balance heap block size map
by Liam Girdwood 04 Sep '17

04 Sep '17

Balance the heap block map size out to better fit real world usage by reducing small blocks to create extra larger blocks. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- src/platform/baytrail/include/platform/memory.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/platform/baytrail/include/platform/memory.h b/src/platform/baytrail/include/platform/memory.h index 6bd0e78..c6a1301 100644 --- a/src/platform/baytrail/include/platform/memory.h +++ b/src/platform/baytrail/include/platform/memory.h @@ -100,11 +100,11 @@ /* Heap section sizes for module pool */ #define HEAP_RT_COUNT8 0 -#define HEAP_RT_COUNT16 256 -#define HEAP_RT_COUNT32 128 +#define HEAP_RT_COUNT16 64 +#define HEAP_RT_COUNT32 64 #define HEAP_RT_COUNT64 64 -#define HEAP_RT_COUNT128 32 -#define HEAP_RT_COUNT256 16 +#define HEAP_RT_COUNT128 64 +#define HEAP_RT_COUNT256 64 #define HEAP_RT_COUNT512 8 #define HEAP_RT_COUNT1024 4 -- 2.11.0

1 2

[Sound-open-firmware] [PATCH] topology: src: fix W_SRC widget argument list order
by Liam Girdwood 04 Sep '17

04 Sep '17

Put format and data in correct order. Signed-off-by: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> --- topology/m4/local.m4 | 4 ++-- topology/sof/pipe-pcm-media.m4 | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/topology/m4/local.m4 b/topology/m4/local.m4 index 5da77e2..5ff0a3d 100644 --- a/topology/m4/local.m4 +++ b/topology/m4/local.m4 @@ -17,7 +17,7 @@ define(`W_SRC', ` tuples."word" {' ` SOF_TKN_COMP_PERIOD_SINK_COUNT' STR($3) ` SOF_TKN_COMP_PERIOD_SOURCE_COUNT' STR($4) -` SOF_TKN_COMP_PRELOAD_COUNT' STR($5) +` SOF_TKN_COMP_PRELOAD_COUNT' STR($6) ` }' `}' `SectionData."'N_SRC($1)`_data_w" {' @@ -39,7 +39,7 @@ define(`W_SRC', ` data [' ` "'N_SRC($1)`_data_w"' ` "'N_SRC($1)`_data_str"' -` "'$2`"' +` "'$5`"' ` ]' `}') diff --git a/topology/sof/pipe-pcm-media.m4 b/topology/sof/pipe-pcm-media.m4 index 0ce6faa..4a68eb4 100644 --- a/topology/sof/pipe-pcm-media.m4 +++ b/topology/sof/pipe-pcm-media.m4 @@ -73,7 +73,7 @@ W_PCM_PLAYBACK(Media Playback, PIPELINE_DMAC, PIPELINE_DMAC_CHAN, 2, 0, 2) W_PGA(0, PCM PCM_ID Playback Volume, PIPELINE_FORMAT, 2, 2, 2) # "SRC 0" has 2 sink and source periods. -W_SRC(0, media_src_conf, PIPELINE_FORMAT, 2, 2, 2) +W_SRC(0, PIPELINE_FORMAT, 2, 2, media_src_conf, 2) # Media Buffers W_BUFFER(0, COMP_BUFFER_SIZE(2, -- 2.11.0

1 2