8 Oct
2019
8 Oct
'19
2:11 p.m.
On Fri, Sep 27, 2019 at 06:31:57PM +0800, Jiaxin Yu wrote:
- rstc = devm_reset_control_get(dev, "audiosys");
- if (IS_ERR(rstc)) {
ret = PTR_ERR(rstc);
dev_err(dev, "could not get audiosys reset:%d\n", ret);
return ret;
- }
- ret = reset_control_reset(rstc);
- if (ret) {
dev_err(dev, "failed to trigger audio reset:%d\n", ret);
return ret;
- }
This means that we're going to be incompatible with old DT bindings that don't specify a reset controller. I don't know how widely used these bindings are so we may be able to get away with this and I'll apply but we shouldn't be doing it, the code might need to be fixed to make this optional if people complain.