On Mon, Mar 07, 2022 at 11:10:38AM -0300, Alifer Moraes wrote:
From: Pierluigi Passaro pierluigi.p@variscite.com
The codec WM8904 can use internal FLL as PLL source. Whenever the PLL source is not an external MCLK, this source must be setup during hw_params callback otherwise the BCLK could be wrongly evaluated. The SND_SOC_BIAS_PREPARE event is raised after the hw_params callback, so there is no need to set again PLL and SYSCLK and actually there's no need at all the set_bias_level function. Also, when esai is used, a dedicated snd_soc_dai_set_tdm_slot
Signed-off by: Alifer Moraes alifer.m@variscite.com
Signed-off-by: Pierluigi Passaro pierluigi.p@variscite.com
When you're sending a mail your signoff should come at the end of the chain of signoffs - see submitting-patches.rst for details.
This breaks an arm64 defconfig build:
/mnt/kernel/sound/soc/fsl/fsl-asoc-card.c: In function 'fsl_asoc_card_hw_free': /mnt/kernel/sound/soc/fsl/fsl-asoc-card.c:265:37: error: 'struct snd_soc_pcm_runtime' has no member named 'cpu_dai' 265 | ret = snd_soc_dai_set_tdm_slot(rtd->cpu_dai, 0, 0, 2, | ^~ /mnt/kernel/sound/soc/fsl/fsl-asoc-card.c:266:35: error: 'params' undeclared (first use in this function); did you mean 'parameq'? 266 | params_physical_width(params)); | ^~~~~~ | parameq /mnt/kernel/sound/soc/fsl/fsl-asoc-card.c:266:35: note: each undeclared identifier is reported only once for each function it appears in