Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on broonie-sound/for-next] [also build test WARNING on linus/master v6.1-rc4 next-20221111] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/wangweidong-a-awinic-com/ASoC... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/1668165992-6493-7-git-send-email-wangweidong.a%40a... patch subject: [PATCH V3 6/6] ASoC:codecs:aw883xx corresponds to the modified Makefile and Kconfig config: sparc-allyesconfig compiler: sparc64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/b8778077cd1bc1375124d18df7afee... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review wangweidong-a-awinic-com/ASoC-codecs-Add-i2c-and-codec-registration-for/20221111-202637 git checkout b8778077cd1bc1375124d18df7afeec32dca1950 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash sound/soc/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
sound/soc/codecs/aw883xx/aw883xx.c: In function 'reg_store':
sound/soc/codecs/aw883xx/aw883xx.c:1095:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
1095 | if (sscanf(buf, "%x %x", &databuf[0], &databuf[1]) == 2) | ^~ sound/soc/codecs/aw883xx/aw883xx.c:1097:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 1097 | regmap_write(aw883xx->regmap, databuf[0], databuf[1]); | ^~~~~~~~~~~~ sound/soc/codecs/aw883xx/aw883xx.c: At top level: sound/soc/codecs/aw883xx/aw883xx.c:1799:19: error: initialization of 'void (*)(struct i2c_client *)' from incompatible pointer type 'int (*)(struct i2c_client *)' [-Werror=incompatible-pointer-types] 1799 | .remove = aw883xx_i2c_remove, | ^~~~~~~~~~~~~~~~~~ sound/soc/codecs/aw883xx/aw883xx.c:1799:19: note: (near initialization for 'aw883xx_i2c_driver.remove') In file included from sound/soc/codecs/aw883xx/aw883xx.c:30: sound/soc/codecs/aw883xx/aw883xx_pid_2049_reg.h:110:28: warning: 'aw_pid_2049_reg_access' defined but not used [-Wunused-const-variable=] 110 | static const unsigned char aw_pid_2049_reg_access[AW_PID_2049_REG_MAX] = { | ^~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors --
sound/soc/codecs/aw883xx/aw883xx_device.c:634:5: warning: no previous prototype for 'aw883xx_dev_get_int_status' [-Wmissing-prototypes]
634 | int aw883xx_dev_get_int_status(struct aw_device *aw_dev, uint16_t *int_status) | ^~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/aw883xx/aw883xx_device.c:650:6: warning: no previous prototype for 'aw883xx_dev_clear_int_status' [-Wmissing-prototypes]
650 | void aw883xx_dev_clear_int_status(struct aw_device *aw_dev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/aw883xx/aw883xx_device.c:1000:5: warning: no previous prototype for 'aw_dev_get_ra' [-Wmissing-prototypes]
1000 | int aw_dev_get_ra(struct aw_cali_desc *cali_desc) | ^~~~~~~~~~~~~
sound/soc/codecs/aw883xx/aw883xx_device.c:1062:5: warning: no previous prototype for 'aw_dev_dsp_fw_update' [-Wmissing-prototypes]
1062 | int aw_dev_dsp_fw_update(struct aw_device *aw_dev, | ^~~~~~~~~~~~~~~~~~~~
vim +/if +1095 sound/soc/codecs/aw883xx/aw883xx.c
00cbb9c2078dff Weidong Wang 2022-11-11 1087 00cbb9c2078dff Weidong Wang 2022-11-11 1088 static ssize_t reg_store(struct device *dev, 00cbb9c2078dff Weidong Wang 2022-11-11 1089 struct device_attribute *attr, const char *buf, 00cbb9c2078dff Weidong Wang 2022-11-11 1090 size_t count) 00cbb9c2078dff Weidong Wang 2022-11-11 1091 { 00cbb9c2078dff Weidong Wang 2022-11-11 1092 struct aw883xx *aw883xx = dev_get_drvdata(dev); 00cbb9c2078dff Weidong Wang 2022-11-11 1093 unsigned int databuf[2] = { 0 }; 00cbb9c2078dff Weidong Wang 2022-11-11 1094 00cbb9c2078dff Weidong Wang 2022-11-11 @1095 if (sscanf(buf, "%x %x", &databuf[0], &databuf[1]) == 2) 00cbb9c2078dff Weidong Wang 2022-11-11 1096 mutex_lock(&aw883xx->dsp_lock); 00cbb9c2078dff Weidong Wang 2022-11-11 1097 regmap_write(aw883xx->regmap, databuf[0], databuf[1]); 00cbb9c2078dff Weidong Wang 2022-11-11 1098 mutex_unlock(&aw883xx->dsp_lock); 00cbb9c2078dff Weidong Wang 2022-11-11 1099 00cbb9c2078dff Weidong Wang 2022-11-11 1100 return count; 00cbb9c2078dff Weidong Wang 2022-11-11 1101 } 00cbb9c2078dff Weidong Wang 2022-11-11 1102