Re: [alsa-devel] Macbook[Pro] 5 6ch support

At Sat, 30 May 2009 12:30:49 +0200, Kacper Szczesniak wrote:

Hi,

this is a patch against current snapshot that adds: 6 channels support for the MB5 model

Hm, this patch changes the channel mapping completely. Is it intentional?

static struct snd_kcontrol_new alc885_mb5_mixer[] = {

• HDA_CODEC_VOLUME("Front Playback Volume", 0x0d, 0x00, HDA_OUTPUT),
• HDA_BIND_MUTE ("Front Playback Switch", 0x0d, 0x02, HDA_INPUT),
• HDA_CODEC_VOLUME("Line-Out Playback Volume", 0x0c, 0x00, HDA_OUTPUT),
• HDA_BIND_MUTE ("Line-Out Playback Switch", 0x0c, 0x02, HDA_INPUT),

• HDA_CODEC_VOLUME("Front Playback Volume", 0x0c, 0x00, HDA_OUTPUT),
• HDA_BIND_MUTE ("Front Playback Switch", 0x0c, 0x02, HDA_INPUT),
• HDA_CODEC_VOLUME("Surround Playback Volume", 0x0d, 0x00, HDA_OUTPUT),
• HDA_BIND_MUTE ("Surround Playback Switch", 0x0d, 0x02, HDA_INPUT),
• HDA_CODEC_VOLUME("LFE Playback Volume", 0x0e, 0x00, HDA_OUTPUT),
• HDA_BIND_MUTE ("LFE Playback Switch", 0x0e, 0x02, HDA_INPUT),
• HDA_CODEC_VOLUME("HP Playback Volume", 0x0f, 0x00, HDA_OUTPUT),
• HDA_BIND_MUTE ("HP Playback Switch", 0x0f, 0x02, HDA_INPUT), HDA_CODEC_VOLUME("Line Playback Volume", 0x0b, 0x02, HDA_INPUT), HDA_CODEC_MUTE ("Line Playback Switch", 0x0b, 0x02, HDA_INPUT),

I'm wondering whether this breaks MB5, not MB5.1. If it's MB5.1 specific, please create another model instead of breaking the old one.

thanks,

Takashi