Re: [PATCH 2/2] ASoC: mediatek: mt8195: fix use-after-free in driver remove path

Hi,

On Tue, May 30, 2023 at 12:25 AM Trevor Wu trevor.wu@mediatek.com wrote:

diff --git a/sound/soc/mediatek/mt8195/mt8195-audsys-clk.c b/sound/soc/mediatek/mt8195/mt8195-audsys-clk.c index e0670e0dbd5b..09bd1a020421 100644 --- a/sound/soc/mediatek/mt8195/mt8195-audsys-clk.c +++ b/sound/soc/mediatek/mt8195/mt8195-audsys-clk.c @@ -148,6 +148,29 @@ static const struct afe_gate aud_clks[CLK_AUD_NR_CLK] = { GATE_AUD6(CLK_AUD_GASRC19, "aud_gasrc19", "top_asm_h", 19), };

+static void mt8195_audsys_clk_unregister(void *data) +{

•   struct mtk_base_afe *afe = (struct mtk_base_afe *)data;
  

Same as in patch #1, the above cast isn't necessary. Other than that:

Reviewed-by: Douglas Anderson dianders@chromium.org