Re: [alsa-devel] [PATCH 3/5] net: sched: pie: Use ULL suffix for 64-bit constant

On Tue, May 28, 2019 at 4:24 PM Geert Uytterhoeven geert@linux-m68k.org wrote:

With gcc 4.1, when compiling for a 32-bit platform:

net/sched/sch_pie.c: In function ‘drop_early’:
net/sched/sch_pie.c:116: warning: integer constant is too large for ‘long’ type
net/sched/sch_pie.c:138: warning: integer constant is too large for ‘long’ type
net/sched/sch_pie.c:144: warning: integer constant is too large for ‘long’ type
net/sched/sch_pie.c:147: warning: integer constant is too large for ‘long’ type
net/sched/sch_pie.c: In function ‘pie_qdisc_enqueue’:
net/sched/sch_pie.c:173: warning: integer constant is too large for ‘long’ type
net/sched/sch_pie.c: In function ‘calculate_probability’:
net/sched/sch_pie.c:371: warning: integer constant is too large for ‘long’ type
net/sched/sch_pie.c:372: warning: integer constant is too large for ‘long’ type
net/sched/sch_pie.c:377: warning: integer constant is too large for ‘long’ type
net/sched/sch_pie.c:382: warning: integer constant is too large for ‘long’ type
net/sched/sch_pie.c:397: warning: integer constant is too large for ‘long’ type
net/sched/sch_pie.c:398: warning: integer constant is too large for ‘long’ type
net/sched/sch_pie.c:399: warning: integer constant is too large for ‘long’ type
net/sched/sch_pie.c:407: warning: integer constant is too large for ‘long’ type
net/sched/sch_pie.c:414: warning: integer constant is too large for ‘long’ type

Fix this by adding the missing "ULL" suffix.

Fixes: 3f7ae5f3dc5295ac ("net: sched: pie: add more cases to auto-tune alpha and beta") Signed-off-by: Geert Uytterhoeven geert@linux-m68k.org

I created patches for all instances of this issue at some point in the past, but did not send those as we raised the minimum compiler version to one that handles this in the expected way without a warning.

Maybe you can just ignore these as well?

Arnd