Hi Fabio, Andy,
Thanks a lot for your comments. I will address them and send v2.
Few comments inline.
On Mi, 2018-01-31 at 18:12 +0200, Andy Shevchenko wrote:
On Wed, Jan 31, 2018 at 2:57 PM, Daniel Baluta daniel.baluta@nxp.com wrote:
AK5558 is a 32-bit, 768 kHZ sampling, differential input ADC for digital audio systems.
Signed-off-by: Junichi Wakasugi wakasugi.jb@om.asahi-kasei.co.jp Signed-off-by: Mihai Serban mihai.serban@nxp.com Signed-off-by: Shengjiu Wang shengjiu.wang@nxp.com Signed-off-by: Daniel Baluta daniel.baluta@nxp.com
4 authors of the code?!
The code has a very long history. I will add under each SoB the specific contribution.
Mihai got the code from Junichi and reworked it for 4.9. Then Shengjiu and me added various features and cleanups.
According to DCO [1] all SoB are valid and required.
+MODULE_AUTHOR("Junichi Wakasugi wakasugi.jb@om.asahi-kasei.co.jp"); +MODULE_AUTHOR("Mihai Serban mihai.serban@nxp.com");
4 SoBs, 2 Authors. Please, fix accordingly.
Here I would prefer to list Junichi and Mihai because they were the main contributors. Any other suggestion?
thanks, Daniel.