On Wed, Mar 28, 2018 at 11:56:52PM +0000, Kuninori Morimoto wrote:
Hi Charles
Thank you for your feedback
I think no-one is using snd_soc_codec, but please double-check it. I added [RFC] on this patch
Looks to me like there are still users in drivers/mfd/cwm8350-core.c:
wm8350_client_dev_register(wm8350, "wm8350-codec", &(wm8350->codec.pdev));
And arch/arm/mach-imx/mach-mx31ads.c:
wm8350->codec.platform_data = &imx32ads_wm8350_setup;
Also it should be simple enough to build test drivers for patches like this, you don't need to have the hardware to build the driver.
The relationships (and my removed) are
struct wm8350_codec { struct platform_device *pdev;
- struct snd_soc_codec *codec; struct wm8350_audio_platform_data *platform_data;
};
struct wm8350 { ... struct wm8350_codec codec; ... }
This means I think my removed was
wm8350->codec.codec
not
wm8350->codec
And I think no one is using wm8350->codec.codec. But can you double check ?
Apologies you are of course correct. Looks good from my side:
Acked-by: Charles Keepax ckeepax@opensource.cirrus.com
Thanks, Charles