[alsa-devel] [PATCH][RFC] ASoC: wm8350: remove snd_soc_codec
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
codec is replace to component. It seems no-one is using it, Let's remove it.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- Hi Mark, Liam
I think no-one is using snd_soc_codec, but please double-check it. I added [RFC] on this patch
include/linux/mfd/wm8350/audio.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/linux/mfd/wm8350/audio.h b/include/linux/mfd/wm8350/audio.h index bd581c6..0bc41c4c 100644 --- a/include/linux/mfd/wm8350/audio.h +++ b/include/linux/mfd/wm8350/audio.h @@ -617,11 +617,8 @@ struct wm8350_audio_platform_data { u32 codec_current_charge:2; /* codec current @ vmid charge */ };
-struct snd_soc_codec; - struct wm8350_codec { struct platform_device *pdev; - struct snd_soc_codec *codec; struct wm8350_audio_platform_data *platform_data; };
On Wed, Mar 28, 2018 at 02:22:07AM +0000, Kuninori Morimoto wrote:
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
codec is replace to component. It seems no-one is using it, Let's remove it.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Hi Mark, Liam
I think no-one is using snd_soc_codec, but please double-check it. I added [RFC] on this patch
Looks to me like there are still users in drivers/mfd/cwm8350-core.c:
wm8350_client_dev_register(wm8350, "wm8350-codec", &(wm8350->codec.pdev));
And arch/arm/mach-imx/mach-mx31ads.c:
wm8350->codec.platform_data = &imx32ads_wm8350_setup;
Also it should be simple enough to build test drivers for patches like this, you don't need to have the hardware to build the driver.
Thanks, Charles
Hi Charles
Thank you for your feedback
I think no-one is using snd_soc_codec, but please double-check it. I added [RFC] on this patch
Looks to me like there are still users in drivers/mfd/cwm8350-core.c:
wm8350_client_dev_register(wm8350, "wm8350-codec", &(wm8350->codec.pdev));
And arch/arm/mach-imx/mach-mx31ads.c:
wm8350->codec.platform_data = &imx32ads_wm8350_setup;
Also it should be simple enough to build test drivers for patches like this, you don't need to have the hardware to build the driver.
The relationships (and my removed) are
struct wm8350_codec { struct platform_device *pdev; - struct snd_soc_codec *codec; struct wm8350_audio_platform_data *platform_data; };
struct wm8350 { ... struct wm8350_codec codec; ... }
This means I think my removed was
wm8350->codec.codec
not
wm8350->codec
And I think no one is using wm8350->codec.codec. But can you double check ? Compile test in my side was OK
Best regards --- Kuninori Morimoto
On Wed, Mar 28, 2018 at 11:56:52PM +0000, Kuninori Morimoto wrote:
Hi Charles
Thank you for your feedback
I think no-one is using snd_soc_codec, but please double-check it. I added [RFC] on this patch
Looks to me like there are still users in drivers/mfd/cwm8350-core.c:
wm8350_client_dev_register(wm8350, "wm8350-codec", &(wm8350->codec.pdev));
And arch/arm/mach-imx/mach-mx31ads.c:
wm8350->codec.platform_data = &imx32ads_wm8350_setup;
Also it should be simple enough to build test drivers for patches like this, you don't need to have the hardware to build the driver.
The relationships (and my removed) are
struct wm8350_codec { struct platform_device *pdev;
- struct snd_soc_codec *codec; struct wm8350_audio_platform_data *platform_data;
};
struct wm8350 { ... struct wm8350_codec codec; ... }
This means I think my removed was
wm8350->codec.codec
not
wm8350->codec
And I think no one is using wm8350->codec.codec. But can you double check ?
Apologies you are of course correct. Looks good from my side:
Acked-by: Charles Keepax ckeepax@opensource.cirrus.com
Thanks, Charles
The patch
ASoC: wm8350: remove snd_soc_codec
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From d00ef703065abc8d1efe5e548daa923f5411b042 Mon Sep 17 00:00:00 2001
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com Date: Wed, 28 Mar 2018 02:22:07 +0000 Subject: [PATCH] ASoC: wm8350: remove snd_soc_codec
codec is replace to component. It seems no-one is using it, Let's remove it.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com Acked-by: Charles Keepax ckeepax@opensource.cirrus.com Signed-off-by: Mark Brown broonie@kernel.org --- include/linux/mfd/wm8350/audio.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/linux/mfd/wm8350/audio.h b/include/linux/mfd/wm8350/audio.h index bd581c6fa085..0bc41c4c0429 100644 --- a/include/linux/mfd/wm8350/audio.h +++ b/include/linux/mfd/wm8350/audio.h @@ -617,11 +617,8 @@ struct wm8350_audio_platform_data { u32 codec_current_charge:2; /* codec current @ vmid charge */ };
-struct snd_soc_codec; - struct wm8350_codec { struct platform_device *pdev; - struct snd_soc_codec *codec; struct wm8350_audio_platform_data *platform_data; };
The patch
ASoC: wm8350: remove snd_soc_codec
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From d00ef703065abc8d1efe5e548daa923f5411b042 Mon Sep 17 00:00:00 2001
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com Date: Wed, 28 Mar 2018 02:22:07 +0000 Subject: [PATCH] ASoC: wm8350: remove snd_soc_codec
codec is replace to component. It seems no-one is using it, Let's remove it.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com Acked-by: Charles Keepax ckeepax@opensource.cirrus.com Signed-off-by: Mark Brown broonie@kernel.org --- include/linux/mfd/wm8350/audio.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/linux/mfd/wm8350/audio.h b/include/linux/mfd/wm8350/audio.h index bd581c6fa085..0bc41c4c0429 100644 --- a/include/linux/mfd/wm8350/audio.h +++ b/include/linux/mfd/wm8350/audio.h @@ -617,11 +617,8 @@ struct wm8350_audio_platform_data { u32 codec_current_charge:2; /* codec current @ vmid charge */ };
-struct snd_soc_codec; - struct wm8350_codec { struct platform_device *pdev; - struct snd_soc_codec *codec; struct wm8350_audio_platform_data *platform_data; };
The patch
ASoC: wm8350: remove snd_soc_codec
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From d00ef703065abc8d1efe5e548daa923f5411b042 Mon Sep 17 00:00:00 2001
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com Date: Wed, 28 Mar 2018 02:22:07 +0000 Subject: [PATCH] ASoC: wm8350: remove snd_soc_codec
codec is replace to component. It seems no-one is using it, Let's remove it.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com Acked-by: Charles Keepax ckeepax@opensource.cirrus.com Signed-off-by: Mark Brown broonie@kernel.org --- include/linux/mfd/wm8350/audio.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/linux/mfd/wm8350/audio.h b/include/linux/mfd/wm8350/audio.h index bd581c6fa085..0bc41c4c0429 100644 --- a/include/linux/mfd/wm8350/audio.h +++ b/include/linux/mfd/wm8350/audio.h @@ -617,11 +617,8 @@ struct wm8350_audio_platform_data { u32 codec_current_charge:2; /* codec current @ vmid charge */ };
-struct snd_soc_codec; - struct wm8350_codec { struct platform_device *pdev; - struct snd_soc_codec *codec; struct wm8350_audio_platform_data *platform_data; };
participants (3)
-
Charles Keepax -
Kuninori Morimoto -
Mark Brown