6 Feb
2017
6 Feb
'17
11:28 a.m.
On Mon, Feb 06, 2017 at 09:50:20PM +0800, Baoyou Xie wrote:
+static void zx_i2s_set_clk(struct zx_i2s_info *i2s,
unsigned int ch_num, unsigned int sample_rate)+{
- unsigned long val = sample_rate * ch_num * CLK_RAT;
- clk_set_rate(i2s->dai_wclk, val);
- if (i2s->dai_pclk)
clk_set_rate(i2s->dai_pclk, val);+}
There's no error checking here, if we don't care if these calls succeed we could save some power and not enable the clocks. This function is also very small and has exactly one user so it's not clear why it's split out.
static const struct of_device_id zx_i2s_dt_ids[] = { { .compatible = "zte,zx296702-i2s", },
- { .compatible = "zte,zx296718-i2s", }, {}
}; MODULE_DEVICE_TABLE(of, zx_i2s_dt_ids);
This adds a new DT binding but does not update the binding document.