On 2020-03-09 17:48, Pierre-Louis Bossart wrote:
DRM is quite a tree, you got to be more specific. Tested with i915=m and DRM=m. I hope we mean the same thing when mentioning 'race'. There is an obvious initialization race between hda bus drv and i915 which requires one to follow a tight operation order in order to not lose i915 codec on hda link and thus be able to enumerate it properly.
I meant CONFIG_DRM=m, yes, thanks for the clarification.
With the DRM as module, it took more time to establish the communication. That's probably changed if we do all the inits in a workqueue now.
So, does the DRM=m & i915=m test satisfy you?
On top of that, as you mentioned (by the link) this series addresses missing DMIC configuration in conjunction with HDA +/- iDisp AND shields against no-NHLT configuration. On Dell XPS 9350 lack on of NHLT was the biggest problem - that's why I'd like that issue not to be forgotten about.
yes, but we don't want the driver to be auto-selected on SKL w/o DMICs, since it'd break existing devices who don't have a topology file installed.
My patch does not touch any of kconfig stuff. I'd prefer anything that goes into disable/enable kconfig bucket to be split into a separate patch. Don't believe SKL somehow gets automatically selected on these. On the machines I've tested fixes with, legacy HDaudio driver was the primary option/ drv.