16 Feb
2023
16 Feb
'23
4:15 p.m.
On Thu, Feb 16, 2023 at 10:32:53AM +0000, Lucas Tanure wrote:
Make use of 100 character limit and modify indentation so code is easier to read.
I'm having a hard time seeing this as a helpful
While at it:
- sort includes in alphabetical order
- sort variables declarations by line length
- use smaller variables names
- remove unnecessary "struct snd_soc_card *card" lines
- insert blank lines before return
- align defines
This isn't helping make things easier to review :/
-static int acp5x_8821_startup(struct snd_pcm_substream *substream) +static int acp5x_8821_startup(struct snd_pcm_substream *sub)
We do usually refer to substreams as such, I'm not sure this is really helping.
- snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
&constraints_channels);
- snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, &constraints_channels);
I'm having a *really* hard time seeing this as helping with legibility, it just makes things worse when viewed at 80 columns but it's hard to see what it helps. The 100 column limit is flexibility we can use to avoid contortions but this is fairly natural.