Re: [bug report] ALSA: usb-audio: Add new quirk FIXED_RATE for JBL Quantum810 Wireless

On 06. 01. 23 10:35, Dan Carpenter wrote:

Hello Jaroslav Kysela,

The patch fd28941cff1c: "ALSA: usb-audio: Add new quirk FIXED_RATE for JBL Quantum810 Wireless" from Dec 15, 2022, leads to the following Smatch static checker warning:

sound/usb/pcm.c:543 snd_usb_hw_params() error: uninitialized symbol 'sync_fixed_rate'.

...

 496         if (fmt->implicit_fb) {
 497                 sync_fmt = snd_usb_find_implicit_fb_sync_format(chip, fmt,
 498                                                                 hw_params,
 499                                                                 !substream->stream,
 500                                                                 &sync_fixed_rate);

"sync_fixed_rate" is uninitialized when we "Use the original audioformat as fallback for the shared altset" and find_matching_substream() returns NULL.

Thanks. The fix was sent:

https://lore.kernel.org/alsa-devel/20230109141133.335543-1-perex@perex.cz/

Jaroslav