Re: [PATCH v2 3/3] ALSA: hda/realtek: Delete cs35l41 component master during free

On Mon, 05 Jun 2023 17:28:55 +0200, Stefan Binding wrote:

This ensures that the driver is properly cleaned up when freed.

Signed-off-by: Stefan Binding sbinding@opensource.cirrus.com

sound/pci/hda/patch_realtek.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 7b5f194513c7b..e3774903918fe 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6757,6 +6757,8 @@ static void cs35l41_generic_fixup(struct hda_codec *cdc, int action, const char else spec->gen.pcm_playback_hook = comp_generic_playback_hook; break;

• case HDA_FIXUP_ACT_FREE:

• component_master_del(dev, &comp_master_ops);
  

  }

Don't forget to add break here.

thanks,

Takashi