[Sound-open-firmware] [PATCH] topology:scripts: fix tplg build script to compile last topology when using xargs

Liam Girdwood liam.r.girdwood at linux.intel.com
Sat May 26 11:34:15 CEST 2018


On Fri, 2018-05-25 at 15:36 -0700, Ranjani Sridharan wrote:
> When using xargs, the last topology file while batch processing alsatplg
> doesn't get compiled properly.
> 
> It also removes a stray ; in the script.
> 
> Signed-off-by: Ranjani Sridharan <ranjani.sridharan at linux.intel.com>
> ---
>  topology/test/tplg-build.sh | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/topology/test/tplg-build.sh b/topology/test/tplg-build.sh
> index 004e8b1..9efda10 100755
> --- a/topology/test/tplg-build.sh
> +++ b/topology/test/tplg-build.sh
> @@ -207,12 +207,14 @@ simple_test nocodec passthrough "DMIC0" s32le DMIC 0
> s32le 1 500000 4800000 40 6
>  if [ "$USE_XARGS" == "yes" ]
>  then
>  	echo "Batch processing m4 files..."
> -	M4_STRINGS=${M4_STRINGS%?};
> +	M4_STRINGS=${M4_STRINGS%?}
>  	#m4 processing
>  	echo $M4_STRINGS | tr " " "," | tr '\n' '\0' | xargs -P0 -d ',' -n13
> bash -c 'm4 "${@:1:${#}-1}" > ${13}.conf' m4
>  
>  	#execute alsatplg to create topology binary
>  	TEST_STRINGS=${TEST_STRINGS%?}
> -	echo $TEST_STRINGS | tr '\n' '\0' | xargs -d ',' -P0 -n1 -I string
> alsatplg -v 1 -c string".conf" -o string".tplg"
> +	echo $TEST_STRINGS | tr '\n' ',' |\
> +		xargs -d ',' -P0 -n1 -I string alsatplg -v 1 -c\
> +			string".conf" -o string".tplg"
>  fi
>  

Sorry, this one doesn't apply. Can you redo.

Thanks

Liam


More information about the Sound-open-firmware mailing list