[Sound-open-firmware] [PATCH] topology: dai: add link_id for dai_link matching in DAI_CONFIG

[Jie, Yang]

Thanks,
~Keyon


>-----Original Message-----
>From: sound-open-firmware-bounces at alsa-project.org [mailto:sound-open-
>firmware-bounces at alsa-project.org] On Behalf Of Liam Girdwood
>Sent: Thursday, May 24, 2018 6:28 PM
>To: Keyon Jie <yang.jie at linux.intel.com>; Ranjani Sridharan
><ranjani.sridharan at linux.intel.com>; sound-open-firmware at alsa-project.org
>Subject: Re: [Sound-open-firmware] [PATCH] topology: dai: add link_id for
>dai_link matching in DAI_CONFIG
>
>On Thu, 2018-05-24 at 10:35 +0800, Keyon Jie wrote:
>> it should be aligned with the definition in machine driver. it do be
>> consistent in machine driver, and they are also same with SSP port
>> number in machine driver(although they could be different, such as the
>> change in this same patch for byt...).
>>
>> another point is, I am planing to add PCMs for all 6 SSP ports soon,
>> after that, you will still see that the ids here are exactly same with
>> port number.
>
>Ok, we can upstream once this is working on a device with > 1 port e.g 1 SSP and
>1 DMIC Unless you have already tested ? Do we need driver patches too ?

Yes, I have tested with GPMRB sof-apl-tdf8532.m4, which enable SSP2 and SSP4 at the same time.

We need make sure this link_id should be same value with the .id of the corresponding BE dai_link(SSP) in machine driver.

e.g. for bxt_tdf8532.c, they are already same so no driver patches needed.

For nocodec machine driver, we have only one BE dai_link at the moment, we may need figure out how to add BE dai_link for it dynamically, during topology parsing. (maybe we can refer to add_dai_link which is used to add FE dai_link according to topology settings).

>
>You need to add more detail in the commit message too. What you are adding
>and why it will match Ids.

Similar to other section member, we can find that in topology ABI, SectionBE.id will be generated as BE dai_link.id, that is why it will match.

Thanks,
~Keyon

>
>Liam
>_______________________________________________
>Sound-open-firmware mailing list
>Sound-open-firmware at alsa-project.org
>http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware