[Sound-open-firmware] [RFC PATCH v2 00/29] Trace level control based on modules.

Yan Wang yan.wang at linux.intel.com
Sat May 12 02:05:28 CEST 2018



On 5/12/2018 6:00 AM, Ranjani Sridharan wrote:
> On Fri, 2018-05-11 at 14:35 +0800, sound-open-firmware-bounces at alsa-
> project.org wrote:
>> From: Yan Wang <yan.wang at linux.intel.com>
>>
>> Resend this series because previous mail list issue.
>> I have addressed Liam's comments in cover letter (00/29) and will
>> change it in the next version patch set.
>> I have addressed Ranjani's comments patch 05/29 and will change it
>> in the next version patch set.
>>
>> This patch set is only for review.
>> This patch set is tested on CNL no-codec only currently.
>>
>> User could check current trace level status like the following:
>> cat /sys/kernel/debug/sof/trace_level
>> irq >> 1
>> ipc >> 1
>> dma >> 1
>> ssp >> 1
>> wait >> 1
>> lock >> 1
>> mem >> 1
>> value >> 1
>> PIPELINE.2.SSP2.IN >> 1
>> SSP2.IN >> 1
>> BUF2.0 >> 1
>> PCM0C >> 0
>> PIPELINE.1.SSP2.OUT >> 1
>> SSP2.OUT >> 1
>> BUF1.0 >> 1
>> PCM0P >> 1
>>
>> It includes trace levels of global trace types and loaded widgets.
>>
>> When level = 0, only error trace will be enabled.
>> When level = 1, error and normal trace will be enabled.
>> When level = 2, all trace including verbose trace will be enabled.
> 
> What is the default trace level for all types?

the default level is 1.

> 
> Also, is there a universal setting for all types so I turn them all off
> in one go and then just turn one type on?

I can add the feature in the next version.
Thanks.

Yan Wang

>>
>> Set trace level like the following:
>> echo PCM0C 0 > /sys/kernel/debug/sof/trace_level
>> will disable the trace of capture host component of fw pipeline.
>>
>> In the future, more module information will bind with trace.
>>
>> Yan Wang (29):
>>    Define IPC message type and data structure for trace level.
>>    Add utility functions and variable for DMA trace level control.
>>    Add trace level variable and set function for SOF modules.
>>    Add trace level IPC message processing logic.
>>    Change trace macro definition and API for trace level checking.
>>    Change macro definition and trace calling for dma-trace.c
>>    Change macro definition and trace calling for dma-copy.c
>>    Change macro definition and trace calling for alloc.c
>>    Change macro definition and trace calling for agent.c
>>    Change macro definition and trace calling for schdule module.
>>    Change macro definition and trace calling for wait.h
>>    Change macro definition and trace calling for SSP.
>>    Change macro definition and trace calling for dw-dma.c
>>    Change macro definition and trace calling for hda-dma.c
>>    Change macro definition and trace calling for interrupt.h
>>    Change macro definition and trace calling for comp_dev.
>>    Change macro definition and trace calling for comp_buffer.
>>    Change macro definition and trace calling for pipeline.
>>    Change macro definition and trace calling for dai.
>>    Change macro definition and trace calling for volume.
>>    Change macro definition and trace calling for switch.
>>    Change macro definition and trace calling for tone.
>>    Change macro definition and trace calling for mixer.
>>    Change macro definition and trace calling for host.
>>    Change macro definition and trace calling for mux.
>>    Change macro definition and trace calling for eq_fir.
>>    Change macro definition and trace calling for eq_iir.
>>    Change macro definition and trace calling for src.
>>    Change macro definition and trace calling for IPC.
>>
>>   src/audio/buffer.c                |  13 +--
>>   src/audio/component.c             |  31 +++---
>>   src/audio/dai.c                   |  80 +++++++++-------
>>   src/audio/eq_fir.c                |  63 ++++++------
>>   src/audio/eq_iir.c                |  63 ++++++------
>>   src/audio/host.c                  |  71 ++++++++------
>>   src/audio/mixer.c                 |  39 +++++---
>>   src/audio/mux.c                   |  17 +++-
>>   src/audio/pipeline.c              | 191 +++++++++++++++++++---------
>> --------
>>   src/audio/pipeline_static.c       |   2 +-
>>   src/audio/src.c                   |  97 ++++++++++---------
>>   src/audio/src.h                   |   5 +-
>>   src/audio/switch.c                |  17 +++-
>>   src/audio/tone.c                  |  79 ++++++++-------
>>   src/audio/volume.c                | 121 ++++++++++++-----------
>>   src/drivers/apl-ssp.c             |  29 +++---
>>   src/drivers/byt-ssp.c             |   7 +-
>>   src/drivers/dw-dma.c              |  25 +++--
>>   src/drivers/hda-dma.c             |  44 +++++----
>>   src/include/sof/audio/buffer.h    |  41 +++++---
>>   src/include/sof/audio/component.h |  34 ++++---
>>   src/include/sof/audio/pipeline.h  |  18 +++-
>>   src/include/sof/dma-trace.h       |   7 ++
>>   src/include/sof/interrupt.h       |  12 ++-
>>   src/include/sof/ipc.h             |  18 +++-
>>   src/include/sof/schedule.h        |  10 ++
>>   src/include/sof/ssp.h             |  14 ++-
>>   src/include/sof/trace.h           | 197
>> +++++++++++++++++++++++++++++---------
>>   src/include/sof/wait.h            |  21 +++-
>>   src/include/uapi/ipc.h            |  25 +++++
>>   src/ipc/dma-copy.c                |  13 ++-
>>   src/ipc/handler.c                 |  54 ++++++++---
>>   src/ipc/ipc.c                     |  50 ++++++++--
>>   src/lib/agent.c                   |  12 ++-
>>   src/lib/alloc.c                   |  18 +++-
>>   src/lib/dma-trace.c               |  83 +++++++++++++++-
>>   src/lib/schedule.c                |  20 ++--
>>   src/lib/trace.c                   | 101 +++++++++++++++++++
>>   38 files changed, 1173 insertions(+), 569 deletions(-)
>>
> _______________________________________________
> Sound-open-firmware mailing list
> Sound-open-firmware at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
> 


More information about the Sound-open-firmware mailing list