[Sound-open-firmware] [PATCH 01/15] [RFC][v2]DMIC: Add PDM microphones (DMIC) support to DAI

Seppo Ingalsuo seppo.ingalsuo at linux.intel.com
Fri May 11 12:47:44 CEST 2018


On 07.05.2018 14:37, Liam Girdwood wrote:
>> +	if (direction != DAI_DIR_CAPTURE) {
>> +		trace_dmic_error("cap");
>> +		return -EINVAL;
>> +	}
> You need to do this here :-
>
> 	ret = comp_set_state(dev, cmd);
> 	if (ret < 0)
> 		return ret;
>
> This does all state checking/setting so no need to do it below.
>
I tried but I noticed it can't be done since struct comp_dev *dev and 
struct dmic_pdata *dmic are not the same.

Thanks,
Seppo



More information about the Sound-open-firmware mailing list