[Sound-open-firmware] [RFC PATCH 5/6] apl-ssp: fix SSCR0_ECS

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Wed Jul 18 04:24:30 CEST 2018


This bitfield controls the use of the external oscillator or PLL,
it has nothing to do with the bclk master settings.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
---
 src/drivers/apl-ssp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/drivers/apl-ssp.c b/src/drivers/apl-ssp.c
index e1e2ca1..fdd40bd 100644
--- a/src/drivers/apl-ssp.c
+++ b/src/drivers/apl-ssp.c
@@ -212,7 +212,6 @@ static inline int ssp_set_config(struct dai *dai,
 	trace_value(config->format);
 	switch (config->format & SOF_DAI_FMT_MASTER_MASK) {
 	case SOF_DAI_FMT_CBM_CFM:
-		sscr0 |= SSCR0_ECS; /* external clock used */
 		sscr1 |= SSCR1_SCLKDIR;
 		/*
 		 * FIXME: does SSRC1.SCFR need to be set
@@ -223,7 +222,6 @@ static inline int ssp_set_config(struct dai *dai,
 		ssioc |= SSIOC_SCOE;
 		break;
 	case SOF_DAI_FMT_CBM_CFS:
-		sscr0 |= SSCR0_ECS; /* external clock used */
 		sscr1 |= SSCR1_SCLKDIR;
 		/*
 		 * FIXME: does SSRC1.SCFR need to be set
-- 
2.14.1



More information about the Sound-open-firmware mailing list