[Sound-open-firmware] [RFC PATCH 4/6] apl-ssp: move SSCR0_ACS, MOD as default settings

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Wed Jul 18 04:24:29 CEST 2018


These settings are not conditionally set, move as init values

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
---
 src/drivers/apl-ssp.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/drivers/apl-ssp.c b/src/drivers/apl-ssp.c
index b706a20..e1e2ca1 100644
--- a/src/drivers/apl-ssp.c
+++ b/src/drivers/apl-ssp.c
@@ -165,12 +165,10 @@ static inline int ssp_set_config(struct dai *dai,
 	trace_value(config->format);
 
 	/* reset SSP settings */
+
 	/* sscr0 dynamic settings are DSS, EDSS, SCR, FRDC, ECS */
-	/*
-	 * FIXME: MOD, ACS, NCS are not set,
-	 * no support for network mode for now
-	 */
 	sscr0 = SSCR0_PSP | SSCR0_RIM | SSCR0_TIM;
+	sscr0 |= SSCR0_MOD | SSCR0_ACS;
 
 	/* sscr1 dynamic settings are SFRMDIR, SCLKDIR */
 	sscr1 = SSCR1_TTE | SSCR1_TTELP | SSCR1_TRAIL | SSCR1_RSRE | SSCR1_TSRE;
@@ -263,8 +261,6 @@ static inline int ssp_set_config(struct dai *dai,
 		goto out;
 	}
 
-	sscr0 |= SSCR0_MOD | SSCR0_ACS;
-
 	mdivc = 0x1;
 #ifdef CONFIG_CANNONLAKE
 	if (!config->ssp.mclk_rate || config->ssp.mclk_rate > F_24000_kHz) {
-- 
2.14.1



More information about the Sound-open-firmware mailing list