[Sound-open-firmware] [PATCH] Incorrect trace variable name

[Liam Girdwood]

On Mon, 2017-08-07 at 19:26 -0500, Pierre-Louis Bossart wrote:
> On 8/3/17 3:08 PM, Curtis Malainey wrote:
> > Minor debugging issue, when verbose trace is turned on it will not compile
> > because these variables are incorrect.
> 
> Thank you for the fix.
> 
> Small nitpick: I believe we have an undocumented expectation to follow 
> the kernel usages and ask for a Signed-off-by certificate of origin (see 
> Documentation/SubmittingPatches), so if you could resubmit with the 
> --signoff option it'd be great. It's overkill for this small fix I know 
> but let's do the right thing from day1.
> 
> Liam, is this something we can add to the public wiki?

Yes, will do. Sorry, apologies I've not had much time this week to
review patches with getting 1.0-rc1 ready...

Thanks

Liam 

> 
> > ---
> >  src/audio/eq_fir.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/audio/eq_fir.c b/src/audio/eq_fir.c
> > index ae87f92..41c6d38 100644
> > --- a/src/audio/eq_fir.c
> > +++ b/src/audio/eq_fir.c
> > @@ -323,9 +323,9 @@ static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data)
> >  			fir_update, PLATFORM_MAX_CHANNELS);
> >
> >  		/* Print trace information */
> > -		tracev_value(iir_update->stream_max_channels);
> > +		tracev_value(fir_update->stream_max_channels);
> >  		for (i = 0; i < fir_update->stream_max_channels; i++)
> > -			tracev_value(iir_update->assign_response[i]);
> > +			tracev_value(fir_update->assign_response[i]);
> >
> >  		break;
> >  	case COMP_CMD_EQ_FIR_CONFIG:
> >
> 
> _______________________________________________
> Sound-open-firmware mailing list
> Sound-open-firmware at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware