[Sound-open-firmware] [PATCH] Incorrect trace variable name
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Tue Aug 8 02:26:18 CEST 2017
On 8/3/17 3:08 PM, Curtis Malainey wrote:
> Minor debugging issue, when verbose trace is turned on it will not compile
> because these variables are incorrect.
Thank you for the fix.
Small nitpick: I believe we have an undocumented expectation to follow
the kernel usages and ask for a Signed-off-by certificate of origin (see
Documentation/SubmittingPatches), so if you could resubmit with the
--signoff option it'd be great. It's overkill for this small fix I know
but let's do the right thing from day1.
Liam, is this something we can add to the public wiki?
> ---
> src/audio/eq_fir.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/audio/eq_fir.c b/src/audio/eq_fir.c
> index ae87f92..41c6d38 100644
> --- a/src/audio/eq_fir.c
> +++ b/src/audio/eq_fir.c
> @@ -323,9 +323,9 @@ static int eq_fir_cmd(struct comp_dev *dev, int cmd, void *data)
> fir_update, PLATFORM_MAX_CHANNELS);
>
> /* Print trace information */
> - tracev_value(iir_update->stream_max_channels);
> + tracev_value(fir_update->stream_max_channels);
> for (i = 0; i < fir_update->stream_max_channels; i++)
> - tracev_value(iir_update->assign_response[i]);
> + tracev_value(fir_update->assign_response[i]);
>
> break;
> case COMP_CMD_EQ_FIR_CONFIG:
>
More information about the Sound-open-firmware
mailing list