[PATCH 8/8] ASoC: soc-pcm: tidyup dulicate handing at dpcm_fe_dai_startup()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Feb 27 01:04:31 CET 2020


Hi Pierre-Louis

> > diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> > index 1f7a86c4bc02..2fdd90437a6f 100644
> > --- a/sound/soc/soc-pcm.c
> > +++ b/sound/soc/soc-pcm.c
> > @@ -2165,11 +2165,9 @@ static int dpcm_fe_dai_startup(struct snd_pcm_substream *fe_substream)
> >   		goto unwind;
> >   	}
> 
> nit-pick: since the two lines below are removed, the 'goto unwind'
> above becomes unnecessary. I don't mind if you leave it for symmetry
> with the rest of the error handling flow.

Oops ? Indeed.
Thank you for your review
Will fixup it in v2

Thank you for your help !!
Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list