[alsa-devel] [PATCH] ASoC: rcar: ssi: don't set SSICR.CKDV = 000 with SSIWSR.CONT

Simon Horman horms at verge.net.au
Fri Mar 24 07:55:12 CET 2017


On Wed, Mar 22, 2017 at 08:56:07AM +0000, Kuninori Morimoto wrote:
> 
> Hi Sergei
> 
> > >  		/*
> > > +		 * It will set SSIWSR.CONT here, but SSICR.CKDV = 000
> > > +		 * with it is not allowed. (SSIWSR.WS_MODE with
> > > +		 * SSICR.CKDV = 000 is not allowed either).
> > > +		 * Skip it. See SSICR.CKDV
> > > +		 */
> > > +		if (j == 0)
> > > +			continue;
> > 
> >    Why not change the *for* statement itself to start with j = 1?
> 
> It can be one solution. Actually my local 1st patch was such style.
> But I thought that it is difficult to notice such magical operation from code.
> Thus, I used this style

FWIIW, I think if you have a comment, like the one above, then j = 1 should
be obvious enough.


More information about the Alsa-devel mailing list