[alsa-devel] [PATCH] ASoC: rcar: ssi: don't set SSICR.CKDV = 000 with SSIWSR.CONT

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Wed Mar 22 09:56:07 CET 2017


Hi Sergei

> >  		/*
> > +		 * It will set SSIWSR.CONT here, but SSICR.CKDV = 000
> > +		 * with it is not allowed. (SSIWSR.WS_MODE with
> > +		 * SSICR.CKDV = 000 is not allowed either).
> > +		 * Skip it. See SSICR.CKDV
> > +		 */
> > +		if (j == 0)
> > +			continue;
> 
>    Why not change the *for* statement itself to start with j = 1?

It can be one solution. Actually my local 1st patch was such style.
But I thought that it is difficult to notice such magical operation from code.
Thus, I used this style

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list