[alsa-devel] [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35]

Geert Uytterhoeven geert at linux-m68k.org
Wed Dec 13 13:34:40 CET 2017


Hi Mark,

On Wed, Dec 13, 2017 at 1:20 PM, Mark Brown <broonie at kernel.org> wrote:
> On Tue, Dec 12, 2017 at 06:09:15PM +0000, Biju Das wrote:
>> Document r8a774[35] specific compatible strings. The Renesas RZ/G1[ME]
>> (r8a774[35]) sound modules are identical to the R-Car Gen2 family.
>> No driver change is needed as the fallback compatible string
>> "renesas,rcar_sound-gen2" activates the right code in the driver.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem.  This makes it easier for people to identify relevant
> patches.  Look at what existing commits in the area you're changing are
> doing and make sure your subject lines visually resemble what they're
> doing.

The confusing part here is that for most[*] subsystems, patches touching
only DT bindings should have a "dt-bindings" prefix, while patches touching
both DT bindings and driver code should have the drivers' subsystem prefix.

[*] I think you're about the only maintainer who insists on patches touching
only DT bindings having the drivers' subsystem prefix, which people tend to
forget, if they're even aware of that rule...

Can we improve this?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds


More information about the Alsa-devel mailing list