[alsa-devel] [PATCH] ASoC: sgtl5000: fix devres handling

[Russell King - ARM Linux]

On Mon, Jun 30, 2014 at 03:44:17PM +0100, Mark Brown wrote:
> On Mon, Jun 30, 2014 at 10:58:18AM +0100, Russell King wrote:
> 
> > You may wish to give some consideration to whether ASoC core code should
> > be doing this instead, this is probably a very common source of brokenness
> > where two-stage driver initialisation exists.  These kinds of issues are
> > why I consider (as a general rule) that two-stage driver initialisation
> > is really bad.
> 
> What we've been doing here is getting everyone to move their resource
> allocation to the device level probe where it should be, leaving only
> things that genuinely need the card to be there (mainly controls and so
> on) in the ASoC level probe.  Is that possible for this device - now
> that it's been converted to regmap I'd expect so?

I have no idea, and I can't help beyond this patch.  Needless to say
that the driver as it stands right now oopses the kernel when you
try and remove it, so it really needs fixing.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.