[alsa-devel] [PATCH] ASoC: sgtl5000: fix devres handling

Mark Brown broonie at kernel.org
Mon Jun 30 16:44:17 CEST 2014


On Mon, Jun 30, 2014 at 10:58:18AM +0100, Russell King wrote:

> You may wish to give some consideration to whether ASoC core code should
> be doing this instead, this is probably a very common source of brokenness
> where two-stage driver initialisation exists.  These kinds of issues are
> why I consider (as a general rule) that two-stage driver initialisation
> is really bad.

What we've been doing here is getting everyone to move their resource
allocation to the device level probe where it should be, leaving only
things that genuinely need the card to be there (mainly controls and so
on) in the ASoC level probe.  Is that possible for this device - now
that it's been converted to regmap I'd expect so?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140630/f6999d69/attachment.sig>


More information about the Alsa-devel mailing list