[alsa-devel] [PATCH] ASoC: core: Use devm_kzalloc() instead kzalloc()

Li.Xiubo at freescale.com Li.Xiubo at freescale.com
Mon Jan 20 04:18:44 CET 2014

Hi Mar, Lars

> > I don't like this. I don't think it is a good design pattern to call
> > devm function from within (especial non-devm) library functions. It
> > creates an asymmetric API. The memory is allocated when
> > snd_dmaengine_pcm_register() is called, but it is not freed when
> > snd_dmaengine_pcm_unregister() is called. This goes against the
> > principle of least surprise.
> Yes, I tend to agree - unless we only support managed registration the
> API shouldn't do managed things internally.

Got it.


More information about the Alsa-devel mailing list