[alsa-devel] [PATCH] ASoC: core: Use devm_kzalloc() instead kzalloc()
broonie at kernel.org
Fri Jan 17 19:48:57 CET 2014
On Thu, Jan 16, 2014 at 10:52:35PM +0100, Lars-Peter Clausen wrote:
> On 01/16/2014 09:44 AM, Xiubo Li wrote:
> >Makes the code slightly shorter
> >Signed-off-by: Xiubo Li <Li.Xiubo at freescale.com>
> I don't like this. I don't think it is a good design pattern to call
> devm function from within (especial non-devm) library functions. It
> creates an asymmetric API. The memory is allocated when
> snd_dmaengine_pcm_register() is called, but it is not freed when
> snd_dmaengine_pcm_unregister() is called. This goes against the
> principle of least surprise.
Yes, I tend to agree - unless we only support managed registration the
API shouldn't do managed things internally.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Alsa-devel