[alsa-devel] [PATCH 1/9] ASoC: wm5100: Replace BUG() with WARN()

Takashi Iwai tiwai at suse.de
Wed Nov 6 11:07:11 CET 2013


BUG() used in the driver is just to spit the stack trace on buggy
points, not really needed to stop the whole operation.  For that
purpose, it'd be more convenient to use WARN() instead with more
error information.

Cc: patches at opensource.wolfsonmicro.com
Signed-off-by: Takashi Iwai <tiwai at suse.de>
---
 sound/soc/codecs/wm5100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c
index 4cf91deabc02..288e0ff33a2b 100644
--- a/sound/soc/codecs/wm5100.c
+++ b/sound/soc/codecs/wm5100.c
@@ -1621,7 +1621,7 @@ static int wm5100_set_sysclk(struct snd_soc_codec *codec, int clk_id,
 		break;
 
 	default:
-		BUG();
+		WARN(1, "Invalid freq %d\n", freq);
 		audio_rate = 0;
 		break;
 	}
-- 
1.8.4.2



More information about the Alsa-devel mailing list