[alsa-devel] [PATCH 3/9] ASoC: wm8900: Replace BUG() with WARN()

Takashi Iwai tiwai at suse.de
Wed Nov 6 11:07:13 CET 2013

BUG() used in the driver is just to spit the stack trace on buggy
points, not really needed to stop the whole operation.  For that
purpose, it'd be more convenient to use WARN() instead with more
error information.

Cc: patches at opensource.wolfsonmicro.com
Signed-off-by: Takashi Iwai <tiwai at suse.de>
 sound/soc/codecs/wm8900.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wm8900.c b/sound/soc/codecs/wm8900.c
index de67e74dca0c..734209e252c3 100644
--- a/sound/soc/codecs/wm8900.c
+++ b/sound/soc/codecs/wm8900.c
@@ -279,7 +279,8 @@ static int wm8900_hp_event(struct snd_soc_dapm_widget *w,
-		BUG();
+		WARN(1, "Invalid event %d\n", event);
+		break;
 	return 0;

More information about the Alsa-devel mailing list