[alsa-devel] [PATCH 30/31] ASoC: Replace BUG() with snd_BUG()

Takashi Iwai tiwai at suse.de
Wed Nov 6 11:04:14 CET 2013

At Wed, 6 Nov 2013 09:39:47 +0000,
Mark Brown wrote:
> [1  <text/plain; us-ascii (7bit)>]
> On Tue, Nov 05, 2013 at 06:40:17PM +0100, Takashi Iwai wrote:
> > BUG() used in the driver is just to spit the stack trace on buggy
> > points, not really needed to stop the whole operation.  For that
> > purpose, it'd be more convenient to use snd_BUG() instead.
> snd_BUG() doesn't look like it's quite doing what was desired here -
> it's conditional on SND_DEBUG but these are all for really bad problems
> which should never happen and will generally cause serious problems if
> they don't happen.  It seems better to replace them (or at least most of
> them) with the direct WARN() instead.

OK, I don't mind either case, so I'll resend the patches fixing BUG()
(although I myself prefer a possibility to remove such debug things for
the production systems...)


More information about the Alsa-devel mailing list