[alsa-devel] [PATCH 30/31] ASoC: Replace BUG() with snd_BUG()

Mark Brown broonie at kernel.org
Wed Nov 6 10:39:47 CET 2013


On Tue, Nov 05, 2013 at 06:40:17PM +0100, Takashi Iwai wrote:
> BUG() used in the driver is just to spit the stack trace on buggy
> points, not really needed to stop the whole operation.  For that
> purpose, it'd be more convenient to use snd_BUG() instead.

snd_BUG() doesn't look like it's quite doing what was desired here -
it's conditional on SND_DEBUG but these are all for really bad problems
which should never happen and will generally cause serious problems if
they don't happen.  It seems better to replace them (or at least most of
them) with the direct WARN() instead.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20131106/98416bf2/attachment-0001.sig>


More information about the Alsa-devel mailing list