[alsa-devel] [PATCH 19/54 v2] ASoC: switch over to use snd_soc_register_component() on mpc5200 i2s

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Mon Mar 25 01:24:07 CET 2013


Hi Stephen

Thank you for your checking

> > arch/powerpc/boot/dts/lite5200.dts seems the user of this driver,
> > but, it was comment-outed.
> > And it is using DT, not name matching ?
(snip)
> Anyway, as far as I can tell from any of the in-kernel device trees,
> this particular mpc5200-psc-i2s device isn't actually instantiated
> anywhere. I guess the only users are removed or out-of-tree.
> 
> Equally, of those 4 files, the compatible value they're instantiated
> from doesn't exist in any in-kernel DT files, except for imx-sgtl5000.c,
> and in that case the CPU phandle points at something the definitely
> isn't the MPC5200 PSC device.
> 
> So, I guess this if probably fine...

In my understanding,
there are some concerns, but basically it is OK in general?

I can send v4 of migor patch which description has been updated
(the difference of cpu_dai_name between dai() and dais())

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list