[alsa-devel] [PATCH 19/54 v2] ASoC: switch over to use snd_soc_register_component() on mpc5200 i2s

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Mar 22 11:26:16 CET 2013


On Thu, Mar 21, 2013 at 11:04:05PM -0600, Stephen Warren wrote:
> On 03/21/2013 07:19 PM, Kuninori Morimoto wrote:

> However, I do see:

> > ./mpc8610_hpcd.c:213:	machine_data->dai[0].cpu_dai_name = dev_name(&ssi_pdev->dev);
> > ./p1022_ds.c:223:	mdata->dai[0].cpu_dai_name = dev_name(&ssi_pdev->dev);
> > ./p1022_rdk.c:226:	mdata->dai[0].cpu_dai_name = dev_name(&ssi_pdev->dev);
> > ./imx-sgtl5000.c:151:	data->dai.cpu_dai_name = dev_name(&ssi_pdev->dev);

> That's a bit icky; DT-based systems should use .cpu_of_node, not
> .cpu_dai_name...

With the exception of the SGTL5000 one those are all very old school
ASoC DT drivers that predate any framework involvement or review outside
of the driver.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130322/9d1e5a7e/attachment-0001.sig>


More information about the Alsa-devel mailing list