[alsa-devel] [RFC][PATCH 2/2] ASoC: simple-card: add DT support

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Nov 29 07:05:19 CET 2012


Hi Stephen

> This could benefit from a patch description.
> 
> A file in Documentation/devicetree/bindings is required to specify the
> format of the device tree.
> 
> Property name prefixes such as "cinfo," aren't very descriptive; what
> does that mean?
> 
> A property name prefix such as "asoc," sounds Linux- (ASoC-) specific;
> DT is supposed to represent HW, and hence shouldn't be influenced by OS
> naming, etc.
>
> Looking at the code, I think the machine driver is binding to the other
> components by string name. With DT, it should be using phandles to point
> at them instead.

I see. I fix it up.
Thank you for your description.

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list