[alsa-devel] [RFC][PATCH 2/2] ASoC: simple-card: add DT support

Stephen Warren swarren at wwwdotorg.org
Thu Nov 29 06:20:14 CET 2012

On 11/28/2012 09:32 PM, Kuninori Morimoto wrote:

This could benefit from a patch description.

A file in Documentation/devicetree/bindings is required to specify the
format of the device tree.

Property name prefixes such as "cinfo," aren't very descriptive; what
does that mean?

A property name prefix such as "asoc," sounds Linux- (ASoC-) specific;
DT is supposed to represent HW, and hence shouldn't be influenced by OS
naming, etc.

Looking at the code, I think the machine driver is binding to the other
components by string name. With DT, it should be using phandles to point
at them instead.

The sysclk value that's parsed from DT doesn't appear to be used. How
does clocking work with this driver; what about when the sample-rate
changes, etc.?

More information about the Alsa-devel mailing list