[alsa-devel] [PATCH 2/2] ASoC: DAPM - Make sure DAPM widget IO ops hold the component mutex.

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Mar 7 11:54:27 CET 2012

On Wed, Mar 07, 2012 at 10:11:01AM +0000, Liam Girdwood wrote:
> On Tue, 2012-03-06 at 20:03 +0000, Mark Brown wrote:

> > Actually for CODECs we don't need to hold the CODEC mutex for I/O if
> > we've pushed the cache down into regmap - regmap does all the locking
> > for us.  I'll send a followup patch.

> I know, but this patch did check for regmap usage in
> soc_widget_update_bits_locked(). With your fix we are doing the regmap
> test twice.

Yes, we are but it's a simple comparison with integer so not the end of
the world.  I'd much rather have the check in the locking code so it's
clear what's expected instead of split between one of the call sites and
the locking function where it might easily get missed if someone adds a
new user.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120307/504bde91/attachment.sig 

More information about the Alsa-devel mailing list