[alsa-devel] [PATCH 2/2] ASoC: DAPM - Make sure DAPM widget IO ops hold the component mutex.

Liam Girdwood lrg at ti.com
Wed Mar 7 11:11:01 CET 2012


On Tue, 2012-03-06 at 20:03 +0000, Mark Brown wrote:
> On Tue, Mar 06, 2012 at 06:16:19PM +0000, Liam Girdwood wrote:
> 
> > +	if (w->codec)
> > +		mutex_lock(&w->codec->mutex);
> 
> Actually for CODECs we don't need to hold the CODEC mutex for I/O if
> we've pushed the cache down into regmap - regmap does all the locking
> for us.  I'll send a followup patch.

I know, but this patch did check for regmap usage in
soc_widget_update_bits_locked(). With your fix we are doing the regmap
test twice.

Liam



More information about the Alsa-devel mailing list