[alsa-devel] [PATCH] ASoC: tlv320aic3x: add missing registers and bits

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Jun 26 18:33:44 CEST 2012

On Tue, Jun 26, 2012 at 04:56:27PM +0200, Roberto Nibali wrote:
> On Tue, Jun 26, 2012 at 3:21 PM, Mark Brown

> > This is essentially impossible to review as you've not said what's being
> > fixed and have completely reformatted the table so the diff doesn't
> > highlight the changes at all.  What's wrong and what is the change
> > fixing?

> This is merely a match to the data sheet of various TLV320AIC310x
> codecs. I've planned on submitting almost the same patch a couple of
> months ago. The reformatting to my avail adds to readability, no
> values are changed. Only a couple of 0x00 are added for the missing

This is irrelevant, you shouldn't be putting several unrelated changes
into a single patch.  It's bad for review and it's bad for reading the
history  Mixing minor style changes with bug fixes is especially bad,
whatever actual changes you've made are essentially invisible in all the

To be perfectly honest I personally find your new version less readable,
having more numbers per line means more counting is needed to figure out
which register is which.

You've still also not clearly described what the actual changes are...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20120626/8239a4a2/attachment-0001.sig 

More information about the Alsa-devel mailing list