[alsa-devel] [PATCH] ASoC: tlv320aic3x: add missing registers and bits

Roberto Nibali rnibali at gmail.com
Tue Jun 26 16:56:27 CEST 2012


My two cents on this:

On Tue, Jun 26, 2012 at 3:21 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Tue, Jun 26, 2012 at 02:38:55PM +0200, Prchal Jiří wrote:
>> This patch adds missing registers and bits for TLV320AIC3106.
>>  static const u8 aic3x_reg[AIC3X_CACHEREGNUM] = {
>> -     0x00, 0x00, 0x00, 0x10, /* 0 */
>> +     0x00, 0x00, 0x00, 0x10, 0x04, 0x00, 0x00, 0x00, /* 0 */
> This is essentially impossible to review as you've not said what's being
> fixed and have completely reformatted the table so the diff doesn't
> highlight the changes at all.  What's wrong and what is the change
> fixing?

This is merely a match to the data sheet of various TLV320AIC310x
codecs. I've planned on submitting almost the same patch a couple of
months ago. The reformatting to my avail adds to readability, no
values are changed. Only a couple of 0x00 are added for the missing
additional registers and at least the TLV320AIC3101 and the
TLV320AIC3106, which essentially were not initialized before.

On the other hand there is nothing for page 1 in this driver, since
most probably there are no users of registers > 102 or page 1.


More information about the Alsa-devel mailing list