[alsa-devel] [PATCH v6] media: Add stk1160 new driver

Ezequiel Garcia elezegarcia at gmail.com
Fri Jul 27 18:50:33 CEST 2012

Hi Takashi,

On Fri, Jul 27, 2012 at 5:03 AM, Takashi Iwai <tiwai at suse.de> wrote:
>> This is achieved through snd_ac97_codec/ac97_bus drivers.
>> Mauro suggested that this ac97 handling should be put
>> inside -alsa tree, but I'm still not sure about it.
>> This approach is working well in practice, but I'm not 100%
>> confident so feedback is welcome (in particular from you alsa guys).
> Well, it's a pretty small stuff and ac97 isn't developed so much any
> longer, so I'm fine to put your code in the video tree.

Yes, I also feel the same way: it's very small code to be splitted.
Let's wait Mauro to hear his opinion.

> Looking through your patch, a remaining problem is that the dependency
> on the sound core is missing.  The "select" in Kconfig doesn't fulfill
> the dependencies automatically but forcibly sets the value.
> Selecting CONFIG_SND_AC97_CODEC will select most of other components
> but CONFIG_SND itself must be enabled beforehand.  Thus, you need to
> wrap CONFIG_VIDEO_STK1160 with "depends on SND".
> Or split the ac97 codec part and makes it depending on SND, and
> define dummy functions if not defined, e.g.
> #ifdef CONFIG_VIDEO_STK1160_AC97
> int stk1160_ac97_register(struct stk1160 *dev);
> int stk1160_ac97_unregister(struct stk1160 *dev);
> #else
> static inline int stk1160_ac97_register(struct stk1160 *dev) { return 0; }
> static inline int stk1160_ac97_unregister(struct stk1160 *dev) { return 0; }
> #endif

This looks nice.

Thanks a lot for the review,

More information about the Alsa-devel mailing list