[alsa-devel] [PATCH v5] ASoC: Apply msbits constraint for sample size bigger than the msbits

Peter Ujfalusi peter.ujfalusi at ti.com
Wed Jan 18 17:43:28 CET 2012

On 01/18/2012 04:29 PM, Mark Brown wrote:
> I'm not sure this is actually a legibility improvement, if anything it's
> probably less clear than the original as now the setup of the loop is
> spread even further around the function.

Would it make it clearer if I set i to 0 right before the while?

>> Most of the drivers require 24/32 configuration, so not point of looping
>> for smaller sample sizes.
> Performance isn't really a concern in this path unless we do something
> totally insane.  Thinking time on the part of the reader needs to be
> considered too...

Sure it is not a concern. These small 'Performance isn't really a
concern in this path' at the end ads up that we need faster CPUs to have
the same perceived perfomrance.


More information about the Alsa-devel mailing list