[alsa-devel] [PATCH v5] ASoC: Apply msbits constraint for sample size bigger than the msbits

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Jan 18 16:29:05 CET 2012

On Wed, Jan 18, 2012 at 04:05:14PM +0100, Peter Ujfalusi wrote:

> Converted to use while loop.
> We run the loop as long as the sample size is bigger than the requested
> msbits.

I'm not sure this is actually a legibility improvement, if anything it's
probably less clear than the original as now the setup of the loop is
spread even further around the function.

> Most of the drivers require 24/32 configuration, so not point of looping
> for smaller sample sizes.

Performance isn't really a concern in this path unless we do something
totally insane.  Thinking time on the part of the reader needs to be
considered too...

More information about the Alsa-devel mailing list