[alsa-devel] [PATCH v2 2/3] ASoC: Tegra+WM903 machine: Set the new fully_routed flag

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Nov 23 23:06:50 CET 2011

On Wed, Nov 23, 2011 at 01:56:14PM -0800, Stephen Warren wrote:

> * Documents the review process in git, potentially giving some insight
>   into reasoning behind parts of the patch.

If this is an issue write better changelogs (with similar reasoning to
why we don't merge incremental versions of the code either; besides
without knowing what the old versions were it's generally not so useful).
The lkml-reference: stuff looks a lot more useful if you really do want
to do that as it'll show the older versions and discussions.

> * Allows confirmation that the correct version was checked in.
>   (rarely an issue, but occasionally, albeit I haven't seen it in ASoC)

Diff is useful for that (especially if people do what I do when I notice
this stuff and manually strip the noise).

> It's been mentioned a couple of times briefly on various lists before,
> and while I'm sure it's not standard practice or anything, at least
> there are some people supporting it. However, if you prefer, I'll try
> to remember to move the changelog for ASoC patches.

I've genuinely never seen this before except where it looked like an
error on the part of the sender.

More information about the Alsa-devel mailing list