[alsa-devel] [PATCH v2 2/3] ASoC: Tegra+WM903 machine: Set the new fully_routed flag

Stephen Warren swarren at nvidia.com
Wed Nov 23 22:56:14 CET 2011

Mark Brown wrote at Wednesday, November 23, 2011 2:32 PM:
> On Wed, Nov 23, 2011 at 12:42:05PM -0700, Stephen Warren wrote:
> > v2: Rename flag from auto_nc_pins to fully_routed. Adjust description.
> >
> > Signed-off-by: Stephen Warren <swarren at nvidia.com>
> > ---
> >  sound/soc/tegra/tegra_wm8903.c |   22 +---------------------
> >  1 files changed, 1 insertions(+), 21 deletions(-)
> Things like your above "v2" line really ought to go here below the ---
> so they're automatically cut from the changelog by the tools.

That was deliberate; some advantages:
* Documents the review process in git, potentially giving some insight
  into reasoning behind parts of the patch.
* Allows confirmation that the correct version was checked in.
  (rarely an issue, but occasionally, albeit I haven't seen it in ASoC)

It's been mentioned a couple of times briefly on various lists before,
and while I'm sure it's not standard practice or anything, at least
there are some people supporting it. However, if you prefer, I'll try
to remember to move the changelog for ASoC patches.


More information about the Alsa-devel mailing list