[alsa-devel] [PATCH 01/19] ASoC: upd9976: Add Renesas uPD9976 codec driver

[Lu Guanqun]

On Wed, May 04, 2011 at 11:07:24PM +0800, Takashi Iwai wrote:
> At Wed, 4 May 2011 15:34:51 +0100,
> Mark Brown wrote:
> > 
> > On Wed, May 04, 2011 at 09:44:58PM +0800, Lu Guanqun wrote:
> > 
> > > +static const struct snd_kcontrol_new upd9976_snd_controls[] = {
> > > +	SOC_DOUBLE_R_TLV("Headphone & Speaker Volume",
> > 
> > Master Volume would be a better name.
> 
> Yes, also in general, try to avoid special letters like "&".

I once used letter "/", but then it failed to create the corresponding
debugfs directory... :)

Oh, btw: There are another register that's related to volume control,
it's before DAC (not added in this patchset yet, for simplicity, will
add it later). so the connection looks something like this:

[volume gain A] --> [DAC] --> [Mixer Volume] -> [Output Pins]

Which volume control should be the master volume? I'm a bit unclear on
this one.

-- 
guanqun